asker-tool 2.6.0 → 2.7.0

data/lib/asker/ai/code/ruby_code_ai.rb

@@ -16,29 +16,29 @@ class RubyCodeAI < BaseCodeAI
     questions = []
     # error_lines = []
     @lines.each_with_index do |line, index|
-      if line.strip.start_with?('#')
+      if line.strip.start_with?("#")
         lines = clone_array @lines
-        lines[index].sub!('#','').strip!
+        lines[index].sub!("#", "").strip!
 
         q = Question.new(:short)
         q.name = "#{name}-#{num}-uncomment"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << (index+1)
-        q.feedback = 'Comment symbol removed'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << (index + 1)
+        q.feedback = "Comment symbol removed"
         questions << q
-      elsif line.strip.size>0
+      elsif line.strip.size > 0
         lines = clone_array @lines
-        lines[index]='# ' + lines[index]
+        lines[index] = "# " + lines[index]
 
         q = Question.new(:short)
         q.name = "#{name}-#{num}-comment"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << (index+1)
-        q.feedback = 'Comment symbol added'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << (index + 1)
+        q.feedback = "Comment symbol added"
         questions << q
       end
     end
-    questions.shuffle[0,@lines.size/@reduce]
+    questions.shuffle[0, @lines.size / @reduce]
   end
 
   ##
@@ -47,7 +47,7 @@ class RubyCodeAI < BaseCodeAI
     questions = []
     empty_lines = []
     used_lines = []
-    @lines.each_with_index do |line,index|
+    @lines.each_with_index do |line, index|
       if line.strip.size.zero?
         empty_lines << index
       else
@@ -57,28 +57,28 @@ class RubyCodeAI < BaseCodeAI
 
     used_lines.each do |index|
       lines = clone_array(@lines)
-      lines.insert(index, ' ' * (rand(4).to_i + 1))
+      lines.insert(index, " " * (rand(4).to_i + 1))
       if @lines.size < 4 || rand(2) == 0
         q = Question.new(:short)
         q.name = "#{name}-#{num}-codeok"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << '0'
-        q.feedback = 'Code is OK'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << "0"
+        q.feedback = "Code is OK"
         questions << q
       else
         q = Question.new(:choice)
         q.name = "#{name}-#{num}-codeok"
-        q.text = @lang.text_for(:code2,lines_to_html(lines))
+        q.text = @lang.text_for(:code2, lines_to_html(lines))
         others = (1..@lines.size).to_a.shuffle!
-        q.good = '0'
+        q.good = "0"
         q.bads << others[0].to_s
         q.bads << others[1].to_s
         q.bads << others[2].to_s
-        q.feedback = 'Code is OK'
+        q.feedback = "Code is OK"
       end
     end
 
-    questions.shuffle[0,@lines.size/@reduce]
+    questions.shuffle[0, @lines.size / @reduce]
   end
 
   ##
@@ -86,13 +86,13 @@ class RubyCodeAI < BaseCodeAI
   def make_syntax_error
     questions = []
 
-    @lang.mistakes.each_pair do |key,values|
+    @lang.mistakes.each_pair do |key, values|
       error_lines = []
-      @lines.each_with_index do |line,index|
+      @lines.each_with_index do |line, index|
         error_lines << index if line.include?(key.to_s)
       end
 
-      v = values.split(',')
+      v = values.split(",")
       v.each do |value|
         error_lines.each do |index|
           lines = clone_array(@lines)
@@ -100,15 +100,15 @@ class RubyCodeAI < BaseCodeAI
           if @lines.size < 4 || rand(2) == 0
             q = Question.new(:short)
             q.name = "#{name}-#{num}-syntaxerror"
-            q.text = @lang.text_for(:code1,lines_to_html(lines))
-            q.shorts << (index+1)
+            q.text = @lang.text_for(:code1, lines_to_html(lines))
+            q.shorts << (index + 1)
             q.feedback = "Syntax error: '#{value}' must be '#{key}'"
           else
             q = Question.new(:choice)
             q.name = "#{name}-#{num}-syntaxerror"
-            q.text = @lang.text_for(:code2,lines_to_html(lines))
+            q.text = @lang.text_for(:code2, lines_to_html(lines))
             others = (1..@lines.size).to_a.shuffle!
-            others.delete(index+1)
+            others.delete(index + 1)
             q.good = (index + 1).to_s
             q.bads << others[0].to_s
             q.bads << others[1].to_s
@@ -119,7 +119,7 @@ class RubyCodeAI < BaseCodeAI
         end
       end
     end
-    questions.shuffle[0,@lines.size/@reduce]
+    questions.shuffle[0, @lines.size / @reduce]
   end
 
   ##
@@ -129,7 +129,7 @@ class RubyCodeAI < BaseCodeAI
     # error_lines = []
     @lines.each_with_index do |line, index|
       # Search Variable assignment
-      m = /\s*(\w*)\s*\=\w*/.match(line)
+      m = /\s*(\w*)\s*=\w*/.match(line)
       i = []
       unless m.nil?
         varname = (m.values_at 1)[0]
@@ -152,22 +152,22 @@ class RubyCodeAI < BaseCodeAI
           q.name = "#{name}-#{num}-variable"
           q.text = @lang.text_for(:code1, lines_to_html(lines))
           q.shorts << (index + 1)
-          q.feedback = "Variable error! Swapped lines #{(index+1)} with #{(k+1)}"
+          q.feedback = "Variable error! Swapped lines #{index + 1} with #{k + 1}"
         else
           q = Question.new(:choice)
           q.name = "#{name}-#{num}-variable"
           q.text = @lang.text_for(:code2, lines_to_html(lines))
           others = (1..@lines.size).to_a.shuffle!
-          others.delete(index+1)
+          others.delete(index + 1)
           q.good = (index + 1).to_s
           q.bads << others[0].to_s
           q.bads << others[1].to_s
           q.bads << others[2].to_s
-          q.feedback = "Variable error! Swapped lines #{(index+1)} with #{(k+1)}"
+          q.feedback = "Variable error! Swapped lines #{index + 1} with #{k + 1}"
         end
         questions << q
       end
     end
-    questions.shuffle[0,@lines.size/@reduce]
+    questions.shuffle[0, @lines.size / @reduce]
   end
 end

data/lib/asker/ai/code/sql_code_ai.rb

@@ -1,36 +1,35 @@
-
-require_relative '../../lang/lang_factory'
-require_relative '../../ai/question'
-require_relative 'base_code_ai'
+require_relative "../../lang/lang_factory"
+require_relative "../../ai/question"
+require_relative "base_code_ai"
 
 class SQLCodeAI < BaseCodeAI
   def initialize(code)
-    @lang = LangFactory.instance.get('sql')
+    @lang = LangFactory.instance.get("sql")
     super code
   end
 
   def make_comment_error
     questions = []
-    @lines.each_with_index do |line,index|
-      if line.include?('//')
+    @lines.each_with_index do |line, index|
+      if line.include?("//")
         lines = clone_array @lines
-        lines[index].sub!('//','').strip!
+        lines[index].sub!("//", "").strip!
 
         q = Question.new(:short)
         q.name = "#{name}-#{num}-code1uncomment"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << (index+1)
-        q.feedback = 'Comment symbol removed'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << (index + 1)
+        q.feedback = "Comment symbol removed"
         questions << q
-      elsif line.strip.size>0
+      elsif line.strip.size > 0
         lines = clone_array @lines
-        lines[index]='// ' + lines[index]
+        lines[index] = "// " + lines[index]
 
         q = Question.new(:short)
         q.name = "#{name}-#{num}-code1comment"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << (index+1)
-        q.feedback = 'Comment symbol added'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << (index + 1)
+        q.feedback = "Comment symbol added"
         questions << q
       end
     end
@@ -41,10 +40,10 @@ class SQLCodeAI < BaseCodeAI
     error_lines = []
     questions = []
 
-    @lang.mistakes.each_pair do |key,values|
-      v = values.split(',')
+    @lang.mistakes.each_pair do |key, values|
+      v = values.split(",")
       v.each do |value|
-        @lines.each_with_index do |line,index|
+        @lines.each_with_index do |line, index|
           error_lines << index if line.include?(key.to_s)
         end
 
@@ -53,8 +52,8 @@ class SQLCodeAI < BaseCodeAI
           lines[index].sub!(key.to_s, value)
           q = Question.new(:short)
           q.name = "#{name}-#{num}-code1keyword"
-          q.text = @lang.text_for(:code1,lines_to_html(lines))
-          q.shorts << (index+1)
+          q.text = @lang.text_for(:code1, lines_to_html(lines))
+          q.shorts << (index + 1)
           q.feedback = "Keyword error: '#{value}' must be '#{key}'"
           questions << q
         end

data/lib/asker/ai/concept_ai.rb

@@ -1,15 +1,11 @@
 # frozen_string_literal: true
 
-require_relative '../lang/lang'
-require_relative 'ai'
-require_relative 'question'
-
-# ConceptAI: Add more info to every Concept instance.
-#            Encapsulating AI data => questions
-# * concept
-# * questions
-# * num
-# * random_image_for
+require_relative "../lang/lang"
+require_relative "ai"
+require_relative "question"
+
+# Add more info to every Concept instance.
+# Encapsulating AI data => questions
 class ConceptAI
   include AI
 
@@ -17,22 +13,17 @@ class ConceptAI
   attr_reader :questions
   attr_reader :excluded_questions
 
-  ##
-  # Initialize ConcepAI
-  # @param concept (Concept)
-  # @param world (World)
   def initialize(concept, world)
     @concept = concept
     @world = world
-    @questions = { d: [], b: [], f: [], i: [], s: [], t: [] }
-    @excluded_questions = { d: [], b: [], f: [], i: [], s: [], t: [] }
+    @questions = {d: [], b: [], f: [], i: [], s: [], t: []}
+    @excluded_questions = {d: [], b: [], f: [], i: [], s: [], t: []}
     @num = 0 # Add a unique number to every question
     make_questions
   end
 
-  ##
-  # Generates and return new "num" value
   def num
+    # Generates and return new "num" value
     @num += 1
     @num.to_s
   end
@@ -43,15 +34,14 @@ class ConceptAI
     @concept.send(method, *args, &block)
   end
 
-  ##
-  # Generates random image URL
   def random_image_for(_conceptname)
-    return '' if rand <= ProjectData.instance.get(:threshold)
+    # Generates random image URL
+    return "" if rand <= ProjectData.instance.get(:threshold)
 
     keys = @world.image_urls.keys
     keys.shuffle!
     values = @world.image_urls[keys[0]] # keys[0] could be conceptname
-    return '' if values.nil?
+    return "" if values.nil?
 
     values.shuffle!
     "<img src=\"#{values[0]}\" alt=\"image\"><br/>"

data/lib/asker/ai/problem/problem_ai.rb

@@ -0,0 +1,226 @@
+require_relative "../../lang/lang_factory"
+require_relative "../question"
+
+class ProblemAI
+  attr_accessor :problem
+
+  def call(problem)
+    @problem = problem
+    make_questions
+    @problem
+  end
+
+  def make_questions
+    @counter = 0
+    @questions = []
+    @customs = get_customs(@problem)
+    make_questions_with_aswers
+    make_questions_with_steps
+    @problem.questions = @questions
+  end
+
+  private
+
+  def counter
+    @counter += 1
+  end
+
+  def customize(text:, custom:)
+    output = text.clone
+    custom.each_pair { |oldvalue, newvalue| output.gsub!(oldvalue, newvalue) }
+    output
+  end
+
+  def get_customs(problem)
+    customs = []
+    vars = problem.varnames
+    problem.cases.each do |acase|
+      custom = {}
+      vars.each_with_index { |varname, index| custom[varname] = acase[index] }
+      customs << custom
+    end
+    customs
+  end
+
+  def lines_to_s(lines)
+    output = ""
+    lines.each_with_index do |line, index|
+      output << "%2d: #{line}\n" % (index + 1)
+    end
+    output
+  end
+
+  def make_questions_with_aswers
+    name = @problem.name
+    lang = @problem.lang
+
+    @customs.each do |custom|
+      desc = customize(text: @problem.desc, custom: custom)
+
+      @problem.asks.each do |ask|
+        next if ask[:text].nil?
+        asktext = customize(text: ask[:text], custom: custom)
+        next if ask[:answer].nil?
+        correct_answer = customize(text: ask[:answer], custom: custom)
+
+        # Question boolean => true
+        q = Question.new(:boolean)
+        q.name = "#{name}-#{counter}-pa1true1"
+        q.text = lang.text_for(:pa1, desc, asktext, correct_answer)
+        q.good = "TRUE"
+        @questions << q
+
+        # Locate incorrect answers
+        incorrect_answers = []
+        @customs.each do |aux|
+          next if aux == custom
+          incorrect = customize(text: ask[:answer], custom: aux)
+          incorrect_answers << incorrect if incorrect != correct_answer
+        end
+
+        # Question boolean => true
+        if incorrect_answers.size > 0
+          q = Question.new(:boolean)
+          q.name = "#{name}-#{counter}-pa2false2"
+          q.text = lang.text_for(:pa1, desc, asktext, incorrect_answers.first)
+          q.good = "FALSE"
+          @questions << q
+        end
+
+        # Question choice NONE
+        if incorrect_answers.size > 2
+          q = Question.new(:choice)
+          q.name = "#{name}-#{counter}-pa2-choice-none3"
+          q.text = lang.text_for(:pa2, desc, asktext)
+          q.good = lang.text_for(:none)
+          incorrect_answers.shuffle!
+          q.bads << incorrect_answers[0]
+          q.bads << incorrect_answers[1]
+          q.bads << incorrect_answers[2]
+          q.feedback = "Correct answer is #{correct_answer}."
+          @questions << q
+        end
+
+        # Question choice OK
+        if incorrect_answers.size > 2
+          q = Question.new(:choice)
+          q.name = "#{name}-#{counter}-pa2choice4"
+          q.text = lang.text_for(:pa2, desc, asktext)
+          q.good = correct_answer
+          incorrect_answers.shuffle!
+          q.bads << incorrect_answers[0]
+          q.bads << incorrect_answers[1]
+          q.bads << incorrect_answers[2]
+          q.feedback = "Correct answer is #{correct_answer}."
+          @questions << q
+        end
+
+        if incorrect_answers.size > 1
+          q = Question.new(:choice)
+          q.name = "#{name}-#{counter}-pa2choice5"
+          q.text = lang.text_for(:pa2, desc, asktext)
+          q.good = correct_answer
+          incorrect_answers.shuffle!
+          q.bads << incorrect_answers[0]
+          q.bads << incorrect_answers[1]
+          q.bads << lang.text_for(:none)
+          q.feedback = "Correct answer is #{correct_answer}."
+          @questions << q
+        end
+
+        # Question short
+        q = Question.new(:short)
+        q.name = "#{name}-#{counter}-pa2short6"
+        q.text = lang.text_for(:pa2, desc, asktext)
+        q.shorts << correct_answer
+        q.feedback = "Correct answer is #{correct_answer}."
+        @questions << q
+      end
+    end
+
+    def make_questions_with_steps
+      name = @problem.name
+      lang = @problem.lang
+
+      @customs.each do |custom|
+        desc = customize(text: @problem.desc, custom: custom)
+
+        @problem.asks.each do |ask|
+          next if ask[:text].nil?
+          asktext = customize(text: ask[:text], custom: custom)
+          next if ask[:steps].nil? || ask[:steps].empty?
+          steps = ask[:steps].map { |step| customize(text: step, custom: custom) }
+
+          # Question steps ok
+          q = Question.new(:short)
+          q.name = "#{name}-#{counter}-ps3short7"
+          q.text = lang.text_for(:ps3, desc, asktext, lines_to_s(steps))
+          q.shorts << 0
+          @questions << q
+
+          if steps.size > 3
+            q = Question.new(:ordering)
+            q.name = "#{name}-#{counter}-ps6ordering8"
+            q.text = lang.text_for(:ps6, desc, asktext, lines_to_s(steps))
+            steps.each { |step| q.ordering << step }
+            @questions << q
+          end
+
+          # Using diferents wrong steps sequences
+          max = steps.size - 1
+          (0..max).each do |index|
+            change = rand(max + 1)
+            bads = steps.clone
+
+            minor = index
+            major = change
+            if minor > major
+              minor, major = major, minor
+            elsif minor == major
+              next
+            end
+            bads[minor], bads[major] = bads[major], bads[minor]
+
+            # Question steps error
+            q = Question.new(:short)
+            q.name = "#{name}-#{counter}-ps3short-error9"
+            q.text = lang.text_for(:ps3, desc, asktext, lines_to_s(bads))
+            q.shorts << minor + 1
+            q.feedback = lang.text_for(:ps4, minor + 1, major + 1)
+            @questions << q
+          end
+
+          # Match questions
+          indexes = (0..(steps.size - 1)).to_a.shuffle
+          (0..(steps.size - 4)).each do |first|
+            incomplete_steps = steps.clone
+            incomplete_steps[indexes[first]] = "?"
+            incomplete_steps[indexes[first + 1]] = "?"
+            incomplete_steps[indexes[first + 2]] = "?"
+            incomplete_steps[indexes[first + 3]] = "?"
+
+            q = Question.new(:match)
+            q.name = "#{name}-#{counter}-ps5match10"
+            q.text = lang.text_for(:ps5, desc,  asktext, lines_to_s(incomplete_steps))
+            q.matching << [steps[indexes[first]], (indexes[first] + 1).to_s]
+            q.matching << [steps[indexes[first + 1]], (indexes[first + 1] + 1).to_s]
+            q.matching << [steps[indexes[first + 2]], (indexes[first + 2] + 1).to_s]
+            q.matching << [steps[indexes[first + 3]], (indexes[first + 3] + 1).to_s]
+            q.matching << ["", lang.text_for(:error)]
+            @questions << q
+
+            q = Question.new(:ddmatch)
+            q.name = "#{name}-#{counter}-ps5ddmatch11"
+            q.text = lang.text_for(:ps5, desc,  asktext, lines_to_s(incomplete_steps))
+            q.matching << [(indexes[first] + 1).to_s, steps[indexes[first]]]
+            q.matching << [(indexes[first + 1] + 1).to_s, steps[indexes[first + 1]]]
+            q.matching << [(indexes[first + 2] + 1).to_s, steps[indexes[first + 2]]]
+            q.matching << [(indexes[first + 3] + 1).to_s, steps[indexes[first + 3]]]
+            q.matching << ["", lang.text_for(:error)]
+            @questions << q
+          end
+        end
+      end
+    end
+  end
+end

data/lib/asker/ai/question.rb

@@ -1,80 +1,69 @@
 # frozen_string_literal: true
 
-require 'set'
+require "set"
 
-# Define Question class
 class Question
+  TYPES = %i[boolean choice ddmatch match ordering short]
+
   attr_accessor :name     # Question name used as identification
   attr_accessor :comment  # Comments asociated
-  attr_accessor :text     # The real text of the question
-  attr_accessor :good     # The correct answer
-  attr_accessor :bads     # Bads answers used by choice type question
-  attr_accessor :matching # Matching answers used by match type question
-  attr_accessor :shorts   # Short answers used by short type question
-  attr_accessor :feedback # Question feedbak
-  attr_reader   :type     # Question type: :choice, :match, :boolean, :short
   attr_accessor :tags
   attr_accessor :lang     # Info used when export (YAML)
   attr_accessor :encode   # image base64 content used when export Moodle xml
 
-  # Initialize object
-  # @param type (Symbol) Question type: choice, match, boolean, short
+  attr_accessor :text     # The real text of the question
+  attr_accessor :feedback # Question feedbak
+  attr_reader :type       # Question type: ;boolean, :choice, :match, :short
+
+  attr_accessor :good     # The correct answer (types: boolean, choice)
+  attr_accessor :bads     # Bads answers (type: choice)
+  attr_accessor :matching # Matching answers (type: match)
+  attr_accessor :ordering # Steps answer (type: ordering)
+  attr_accessor :shorts   # Short answers (type: short)
+
   def initialize(type = :choice)
     reset(type)
   end
 
-  # Reset attributes
   # @param type (Symbol) Question type: choice, match, boolean, short
-  # rubocop:disable Metrics/MethodLength
   def reset(type = :choice)
-    @name = ''
-    @comment = ''
-    @text = ''
+    validate type
     @type = type
-    @good = ''
-    @bads = []
-    @matching = []
-    @shorts = []
-    @feedback = nil
-    shuffle_on
+
+    @name = ""
+    @comment = ""
     @tags = Set.new
     @lang = nil
     @encode = :none
-  end
-  # rubocop:enable Metrics/MethodLength
 
-  # Set choice type
-  def set_choice
-    @type = :choice
-  end
-
-  # Set match type
-  def set_match
-    @type = :match
-  end
-
-  # Set boolean type
-  def set_boolean
-    @type = :boolean
-  end
-
-  # Set short type
-  def set_short
-    @type = :short
+    @text = ""
+    @feedback = nil
+    @good = ""
+    @bads = []
+    @matching = []
+    @ordering = []
+    @shorts = []
+    shuffle_on
   end
 
-  # Set shuffle off
   def shuffle_off
     @shuffle = false
   end
 
-  # Set shuffle on
   def shuffle_on
     @shuffle = true
   end
 
-  # Return shuffle value
   def shuffle?
     @shuffle
   end
+
+  private
+
+  def validate(type)
+    unless TYPES.include? type
+      warn "[ERROR] Question type error (#{type})"
+      exit 1
+    end
+  end
 end