asker-tool 2.5.9 → 2.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 211d45e28562281dbadb99c156ae2e630d28bae27d4314f74771c7637de889b7
-  data.tar.gz: 16625618a4b4a26753727abbe6f1c59e51bd63eb99573fd929a3d98b06cdcd39
+  metadata.gz: 1baeb7aed03362eef9980d237bfa0fbd9b260c356fc11b96c88d870e970260ec
+  data.tar.gz: 67ed271bf5e6979643e7d63eed43fbb9659428b66a3f67522d8acc5bb4ea14ba
 SHA512:
-  metadata.gz: e2ac75d61319e1c833d72dc8224da00df81f57636fa5f1f61e887cc5ddff47a98bd6f2e389de58c142c77c224ea1dd87ad3971479c50b1024a691626bae13a8e
-  data.tar.gz: 34aa413ffac40f922b18ec07ecefec8fe7d2132bd2f20f3929ae87f7666958adefd75cc3bd6c67c12078f004a1ce61e743837a46e55c78c85a454e13d073e184
+  metadata.gz: 9bf4fd2e2ca703548c1a5fdeca6d12bf05549e76423d5ce82f094ca5aaea455499632ae5926ae8ac2e9072ff748a1c74f68908fce8e8cca0ba51220802c97d30
+  data.tar.gz: bd150d797993fd3708c254f03fb227e04dc33789854f71b548d3cf27663288ea61c5b62be2a5242f43f8ac449a571675c889cb106e072e0709603642f3ed8d51

data/README.md

@@ -21,11 +21,10 @@ gem install asker-tool
 
 # Usage
 
-| Step | Action                | Description |
-| ---: | --------------------- | ----------- |
-| 1    | Create your **input file** | Create input file with your contents (_conceptual map_). Here are some [examples](./docs/examples). And more examples at this [repository](https://github.com/dvarrui/asker-inputs).
-| 2    | **Run `asker`** | `asker PATH/TO/INPUT` |
-| 3    | Choose your **output files** | Output files saved into the `output` folder |
+| Step | Action                | Tool | Description |
+| ---: | --------------------- | ---- | ----------- |
+| 1    | Define your concepts | Text plain editor | Create input file with your contents (_conceptual map_). Here are some [examples](./docs/examples). And more examples at this [repository](https://github.com/dvarrui/asker-inputs).
+| 2    | Generate questions | `asker PATH/TO/INPUT` | **Run `asker`** to process input file. Output files are saved into the `output` folder |
 
 Let's see an example creating questions from ACDC input example file:
 
@@ -35,10 +34,10 @@ Let's see an example creating questions from ACDC input example file:
 +--------------------+-----------+---------+---------+---+---+----+---+---+----+
 | Concept            | Questions | Entries | xFactor | d | b | f  | i | s | t  |
 +--------------------+-----------+---------+---------+---+---+----+---+---+----+
-| AC/DC              | 45        | 18      | 2.5     | 7 | 0 | 15 | 0 | 3 | 20 |
+| AC/DC              | 46        | 18      | 2.5     | 7 | 0 | 15 | 0 | 4 | 20 |
 | Excluded questions | 0         | -       | -       | 0 | 0 | 0  | 0 | 0 | 0  |
 +--------------------+-----------+---------+---------+---+---+----+---+---+----+
-| 1 concept/s        | 45        | 18      | 2.5     | 7 | 0 | 15 | 0 | 3 | 20 |
+| 1 concept/s        | 46        | 18      | 2.5     | 7 | 0 | 15 | 0 | 4 | 20 |
 +--------------------+-----------+---------+---------+---+---+----+---+---+----+
 ```
 
@@ -46,6 +45,10 @@ Let's see an example creating questions from ACDC input example file:
 
 * [Free Software License](LICENSE).
 * Multiplatform.
+* Input files formats: XML, HAML.
+* Output formats: GIFT, Moodle XML, YAML.
+* Question types: true/false, multiple choice, short answer, matching and ordering.
+* Embeded files: mp3, ogg, wav, jpg, jpeg, png, mp4, ogv and plain text files.
 
 # Documentation
 

data/lib/asker/ai/ai.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
-require_relative 'stages/main'
-require_relative 'ai_calculate'
+require_relative "stages/main"
+require_relative "ai_calculate"
 
 # Description: Method to be included into every ConceptAI instance.
 # * make_questions: use AI to fill @questions Array
@@ -13,13 +13,13 @@ module AI
 
     make_questions_stages_di
     # Process every table of this concept
-    concept.tables.each do |tab|
-      list1, list2 = get_list1_and_list2_from(tab)
-      make_questions_stages_bsf(tab, list1, list2)
-      make_questions_stages_t(tab, list1, list2)
+    concept.tables.each do |table|
+      list1, list2 = get_list1_and_list2_from(table)
+      make_questions_stages_bsf(table, list1, list2)
+      make_questions_stages_t(table, list1, list2)
     end
     # -------------------------------------------------------
-    # Exclude questions as is defined into config.ini params
+    # Exclude questions as is defined into asker.ini params
     exclude_questions
   end
 
@@ -30,34 +30,31 @@ module AI
   end
 
   # Make questions for stages B, S and F
-  def make_questions_stages_bsf(tab, list1, list2)
+  def make_questions_stages_bsf(table, list1, list2)
     # Stage B: process table to make match questions
-    @questions[:b] += StageB.new(self).run(tab, list1, list2)
+    @questions[:b] += StageB.new(self).run(table, list1, list2)
     # Stage S: process tables with sequences
-    @questions[:s] += StageS.new(self).run(tab, list1, list2)
+    @questions[:s] += StageS.new(self).run(table, list1, list2)
     # Stage F: process tables with only 1 field
-    @questions[:f] += StageF.new(self).run(tab, list1, list2)
+    @questions[:f] += StageF.new(self).run(table, list1, list2)
   end
 
-  # Make questions for stage T
-  def make_questions_stages_t(tab, list1, list2)
+  def make_questions_stages_t(table, list1, list2)
     # Stage T: process_tableXfields
     list3 = list1 + list2
     list1.each do |row|
       reorder_list_with_row(list3, row)
-      @questions[:t] += StageT.new(self).run(tab, row, list3)
+      @questions[:t] += StageT.new(self).run(table, row, list3)
     end
   end
 
-  # rubocop:disable Metrics/AbcSize
-  # rubocop:disable Metrics/MethodLength
   def exclude_questions
-    param = Application.instance.config['questions']['exclude']
+    param = Application.instance.config["questions"]["exclude"]
     return if param.nil?
 
-    tags = param.split(',').each(&:strip!)
-    input = { d: [], b: [], f: [], i: [], s: [], t: [] }
-    output = { d: [], b: [], f: [], i: [], s: [], t: [] }
+    tags = param.split(",").each(&:strip!)
+    input = {d: [], b: [], f: [], i: [], s: [], t: []}
+    output = {d: [], b: [], f: [], i: [], s: [], t: []}
 
     @questions.each_pair do |key, qlist|
       output[key] = qlist.select { |q| string_has_this_tags?(q.name, tags) }
@@ -66,8 +63,6 @@ module AI
     @questions = input
     @excluded_questions = output
   end
-  # rubocop:enable Metrics/AbcSize
-  # rubocop:enable Metrics/MethodLength
 
   def string_has_this_tags?(input, tags)
     flag = false

data/lib/asker/ai/ai_calculate.rb

@@ -7,14 +7,12 @@ module AICalculate
   # * return list1 (Array) List with all the rows from the table
   # * return list2 (Array) List with similar rows (same table name) from the neighbours tables
   # @param p_table (Table)
-  # rubocop:disable Metrics/MethodLength
-  # rubocop:disable Metrics/AbcSize
   def get_list1_and_list2_from(p_table)
     # create <list1> with all the rows from the table
     list1 = []
     count = 1
     p_table.rows.each do |i|
-      list1 << { id: count, weight: 0, data: i }
+      list1 << {id: count, weight: 0, data: i}
       count += 1
     end
 
@@ -25,45 +23,40 @@ module AICalculate
         next if t2.name != p_table.name
 
         t2.rows.each do |i|
-          list2 << { id: count, weight: 0, data: i }
+          list2 << {id: count, weight: 0, data: i}
           count += 1
         end
       end
     end
     [list1, list2]
   end
-  # rubocop:enable Metrics/MethodLength
-  # rubocop:enable Metrics/AbcSize
 
   def calculate_nearness_between_texts(text1, text2)
     return 0.0 if text2.nil? || text2.empty?
 
-    words = text1.split(' ')
+    words = text1.split(" ")
     count = 0
     words.each { |w| count += 1 if text2.include?(w) }
     (count * 100 / words.count)
   end
 
-  # rubocop:disable Metrics/MethodLength
-  # rubocop:disable Metrics/AbcSize
   def reorder_list_with_row(list, row)
-    # evaluate every row of the list2
+    # evaluate every row of the list, and calculate weight
+    magic_number = -300
     list.each do |r|
       if r[:id] == row[:id]
-        r[:weight] = -300
+        r[:weight] = magic_number
       else
-        val = 0
+        value = 0
         s = row[:data].count
         s.times do |i|
-          val += calculate_nearness_between_texts(row[:data][i], r[:data][i])
+          value += calculate_nearness_between_texts(row[:data][i], r[:data][i])
         end
-        val /= s
-        r[:weight] = val
+        value /= s
+        r[:weight] = value
       end
     end
     list.sort! { |a, b| a[:weight] <=> b[:weight] }
     list.reverse!
   end
-  # rubocop:enable Metrics/MethodLength
-  # rubocop:enable Metrics/AbcSize
 end

data/lib/asker/ai/code/base_code_ai.rb

@@ -1,16 +1,13 @@
 # frozen_string_literal: false
 
-require_relative '../../lang/lang_factory'
-require_relative '../../ai/question'
+require_relative "../../lang/lang_factory"
+require_relative "../../ai/question"
 
 ##
 # BaseCodeAI class
 class BaseCodeAI
   attr_reader :questions
 
-  ##
-  # Create CodeAI object from Code data
-  # @param code (Code)
   def initialize(code)
     @code = code
     @lines = code.lines
@@ -19,9 +16,6 @@ class BaseCodeAI
     make_questions
   end
 
-  ##
-  # Return the name of code
-  # @return String
   def name
     File.basename(@code.filename)
   end
@@ -42,51 +36,32 @@ class BaseCodeAI
     @code.lines
   end
 
-  ##
-  # Counter
-  # @return count
   def num
     @num += 1
   end
 
-  ##
-  # Clone array
-  # @param array (Array)
-  # @return Array
   def clone_array(array)
     out = []
     array.each { |item| out << item.dup }
     out
   end
 
-  ##
-  # Convert an array of lines into one String
-  # @param lines (Array)
-  # @return String
-  # rubocop:disable Style/FormatString
   def lines_to_s(lines)
-    out = ''
+    out = ""
     lines.each_with_index do |line, index|
       out << "%2d: #{line}\n" % (index + 1)
     end
     out
   end
 
-  ##
-  # Convert an array of lines into one HTML String
-  # @param lines (Array)
-  # @return String
   def lines_to_html(lines)
-    out = ''
+    out = ""
     lines.each_with_index do |line, index|
       out << "%2d: #{line}</br>" % (index + 1)
     end
     out
   end
-  # rubocop:enable Style/FormatString
 
-  ##
-  # Make questions
   def make_questions
     list = find_make_methods
     list.each { |m| @questions += send m }
@@ -97,7 +72,7 @@ class BaseCodeAI
 
   def find_make_methods
     list = public_methods.sort
-    list.select! { |name| name.to_s.start_with? 'make_' }
+    list.select! { |name| name.to_s.start_with? "make_" }
     list.delete(:make_questions)
     list
   end

data/lib/asker/ai/code/code_ai_factory.rb

@@ -1,13 +1,9 @@
+require_relative "javascript_code_ai"
+require_relative "python_code_ai"
+require_relative "ruby_code_ai"
+require_relative "sql_code_ai"
+require_relative "../../logger"
 
-require 'rainbow'
-require_relative 'javascript_code_ai'
-require_relative 'problem_code_ai'
-require_relative 'python_code_ai'
-require_relative 'ruby_code_ai'
-require_relative 'sql_code_ai'
-
-##
-# CodeAI factory
 module CodeAIFactory
   ##
   # Return CodeAI associated to Code.type
@@ -18,8 +14,6 @@ module CodeAIFactory
     case type
     when :javascript
       return JavascriptCodeAI.new(code)
-    when :problem
-      return ProblemCodeAI.new(code)
     when :python
       return PythonCodeAI.new(code)
     when :ruby
@@ -29,7 +23,7 @@ module CodeAIFactory
     when :vagrantfile
       return RubyCodeAI.new(code)
     else
-      puts Rainbow("[ERROR] <#{type}> is not valid type").red.bright
+      Logger.warn "CodeAIFactory: Invalid type (#{type})"
     end
     nil
   end

data/lib/asker/ai/code/javascript_code_ai.rb

@@ -1,7 +1,6 @@
-
-require_relative '../../lang/lang_factory'
-require_relative '../../ai/question'
-require_relative 'base_code_ai'
+require_relative "../../lang/lang_factory"
+require_relative "../../ai/question"
+require_relative "base_code_ai"
 
 class JavascriptCodeAI < BaseCodeAI
   def initialize(code)
@@ -13,25 +12,25 @@ class JavascriptCodeAI < BaseCodeAI
     questions = []
     # error_lines = []
     @lines.each_with_index do |line, index|
-      if line.strip.start_with?('//')
+      if line.strip.start_with?("//")
         lines = clone_array @lines
-        lines[index].sub!('//','').strip!
+        lines[index].sub!("//", "").strip!
 
         q = Question.new(:short)
         q.name = "#{name}-#{num}-uncomment"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << (index+1)
-        q.feedback = 'Comment symbol removed'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << (index + 1)
+        q.feedback = "Comment symbol removed"
         questions << q
-      elsif line.strip.size>0
+      elsif line.strip.size > 0
         lines = clone_array @lines
-        lines[index]='// ' + lines[index]
+        lines[index] = "// " + lines[index]
 
         q = Question.new(:short)
         q.name = "#{name}-#{num}-comment"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << (index+1)
-        q.feedback = 'Comment symbol added'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << (index + 1)
+        q.feedback = "Comment symbol added"
         questions << q
       end
     end
@@ -42,7 +41,7 @@ class JavascriptCodeAI < BaseCodeAI
     questions = []
     empty_lines = []
     used_lines = []
-    @lines.each_with_index do |line,index|
+    @lines.each_with_index do |line, index|
       if line.strip.size.zero?
         empty_lines << index
       else
@@ -52,24 +51,24 @@ class JavascriptCodeAI < BaseCodeAI
 
     used_lines.each do |index|
       lines = clone_array(@lines)
-      lines.insert(index, ' ' * (rand(4).to_i + 1))
+      lines.insert(index, " " * (rand(4).to_i + 1))
       if @lines.size < 4 || rand(2) == 0
         q = Question.new(:short)
         q.name = "#{name}-#{num}-codeok"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << '0'
-        q.feedback = 'Code is OK'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << "0"
+        q.feedback = "Code is OK"
         questions << q
       else
         q = Question.new(:choice)
         q.name = "#{name}-#{num}-codeok"
-        q.text = @lang.text_for(:code2,lines_to_html(lines))
+        q.text = @lang.text_for(:code2, lines_to_html(lines))
         others = (1..@lines.size).to_a.shuffle!
-        q.good = '0'
+        q.good = "0"
         q.bads << others[0].to_s
         q.bads << others[1].to_s
         q.bads << others[2].to_s
-        q.feedback = 'Code is OK'
+        q.feedback = "Code is OK"
       end
     end
 
@@ -79,13 +78,13 @@ class JavascriptCodeAI < BaseCodeAI
   def make_syntax_error
     questions = []
 
-    @lang.mistakes.each_pair do |key,values|
+    @lang.mistakes.each_pair do |key, values|
       error_lines = []
-      @lines.each_with_index do |line,index|
+      @lines.each_with_index do |line, index|
         error_lines << index if line.include?(key.to_s)
       end
 
-      v = values.split(',')
+      v = values.split(",")
       v.each do |value|
         error_lines.each do |index|
           lines = clone_array(@lines)
@@ -93,15 +92,15 @@ class JavascriptCodeAI < BaseCodeAI
           if @lines.size < 4 || rand(2) == 0
             q = Question.new(:short)
             q.name = "#{name}-#{num}-syntaxerror"
-            q.text = @lang.text_for(:code1,lines_to_html(lines))
-            q.shorts << (index+1)
+            q.text = @lang.text_for(:code1, lines_to_html(lines))
+            q.shorts << (index + 1)
             q.feedback = "Syntax error: '#{value}' must be '#{key}'"
           else
             q = Question.new(:choice)
             q.name = "#{name}-#{num}-syntaxerror"
-            q.text = @lang.text_for(:code2,lines_to_html(lines))
+            q.text = @lang.text_for(:code2, lines_to_html(lines))
             others = (1..@lines.size).to_a.shuffle!
-            others.delete(index+1)
+            others.delete(index + 1)
             q.good = (index + 1).to_s
             q.bads << others[0].to_s
             q.bads << others[1].to_s
@@ -141,20 +140,20 @@ class JavascriptCodeAI < BaseCodeAI
         if rand(2) == 0
           q = Question.new(:short)
           q.name = "#{name}-#{num}-variable"
-          q.text = @lang.text_for(:code1,lines_to_html(lines))
+          q.text = @lang.text_for(:code1, lines_to_html(lines))
           q.shorts << (index + 1)
-          q.feedback = "Variable error! Swapped lines #{(index+1)} with #{(k+1)}"
+          q.feedback = "Variable error! Swapped lines #{index + 1} with #{k + 1}"
         else
           q = Question.new(:choice)
           q.name = "#{name}-#{num}-variable"
-          q.text = @lang.text_for(:code2,lines_to_html(lines))
+          q.text = @lang.text_for(:code2, lines_to_html(lines))
           others = (1..@lines.size).to_a.shuffle!
-          others.delete(index+1)
+          others.delete(index + 1)
           q.good = (index + 1).to_s
           q.bads << others[0].to_s
           q.bads << others[1].to_s
           q.bads << others[2].to_s
-          q.feedback = "Variable error! Swapped lines #{(index+1)} with #{(k+1)}"
+          q.feedback = "Variable error! Swapped lines #{index + 1} with #{k + 1}"
         end
         questions << q
       end

data/lib/asker/ai/code/python_code_ai.rb

@@ -1,11 +1,10 @@
-
-require_relative '../../lang/lang_factory'
-require_relative '../../ai/question'
-require_relative 'base_code_ai'
+require_relative "../../lang/lang_factory"
+require_relative "../../ai/question"
+require_relative "base_code_ai"
 
 class PythonCodeAI < BaseCodeAI
   def initialize(code)
-    @lang = LangFactory.instance.get('python')
+    @lang = LangFactory.instance.get("python")
     super code
   end
 
@@ -13,25 +12,25 @@ class PythonCodeAI < BaseCodeAI
     questions = []
     # error_lines = []
     @lines.each_with_index do |line, index|
-      if line.strip.start_with?('#')
+      if line.strip.start_with?("#")
         lines = clone_array @lines
-        lines[index].sub!('#','').strip!
+        lines[index].sub!("#", "").strip!
 
         q = Question.new(:short)
         q.name = "#{name}-#{num}-uncomment"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << (index+1)
-        q.feedback = 'Comment symbol removed'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << (index + 1)
+        q.feedback = "Comment symbol removed"
         questions << q
-      elsif line.strip.size>0
+      elsif line.strip.size > 0
         lines = clone_array @lines
-        lines[index]='# ' + lines[index]
+        lines[index] = "# " + lines[index]
 
         q = Question.new(:short)
         q.name = "#{name}-#{num}-comment"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << (index+1)
-        q.feedback = 'Comment symbol added'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << (index + 1)
+        q.feedback = "Comment symbol added"
         questions << q
       end
     end
@@ -42,7 +41,7 @@ class PythonCodeAI < BaseCodeAI
     questions = []
     empty_lines = []
     used_lines = []
-    @lines.each_with_index do |line,index|
+    @lines.each_with_index do |line, index|
       if line.strip.size.zero?
         empty_lines << index
       else
@@ -52,24 +51,24 @@ class PythonCodeAI < BaseCodeAI
 
     used_lines.each do |index|
       lines = clone_array(@lines)
-      lines.insert(index, ' ' * (rand(4).to_i + 1))
+      lines.insert(index, " " * (rand(4).to_i + 1))
       if @lines.size < 4 || rand(2) == 0
         q = Question.new(:short)
         q.name = "#{name}-#{num}-codeok"
-        q.text = @lang.text_for(:code1,lines_to_html(lines))
-        q.shorts << '0'
-        q.feedback = 'Code is OK'
+        q.text = @lang.text_for(:code1, lines_to_html(lines))
+        q.shorts << "0"
+        q.feedback = "Code is OK"
         questions << q
       else
         q = Question.new(:choice)
         q.name = "#{name}-#{num}-codeok"
-        q.text = @lang.text_for(:code2,lines_to_html(lines))
+        q.text = @lang.text_for(:code2, lines_to_html(lines))
         others = (1..@lines.size).to_a.shuffle!
-        q.good = '0'
+        q.good = "0"
         q.bads << others[0].to_s
         q.bads << others[1].to_s
         q.bads << others[2].to_s
-        q.feedback = 'Code is OK'
+        q.feedback = "Code is OK"
       end
     end
 
@@ -79,13 +78,13 @@ class PythonCodeAI < BaseCodeAI
   def make_syntax_error
     questions = []
 
-    @lang.mistakes.each_pair do |key,values|
+    @lang.mistakes.each_pair do |key, values|
       error_lines = []
-      @lines.each_with_index do |line,index|
+      @lines.each_with_index do |line, index|
         error_lines << index if line.include?(key.to_s)
       end
 
-      v = values.split(',')
+      v = values.split(",")
       v.each do |value|
         error_lines.each do |index|
           lines = clone_array(@lines)
@@ -93,15 +92,15 @@ class PythonCodeAI < BaseCodeAI
           if @lines.size < 4 || rand(2) == 0
             q = Question.new(:short)
             q.name = "#{name}-#{num}-syntaxerror"
-            q.text = @lang.text_for(:code1,lines_to_html(lines))
-            q.shorts << (index+1)
+            q.text = @lang.text_for(:code1, lines_to_html(lines))
+            q.shorts << (index + 1)
             q.feedback = "Syntax error: '#{value}' must be '#{key}'"
           else
             q = Question.new(:choice)
             q.name = "#{name}-#{num}-syntaxerror"
-            q.text = @lang.text_for(:code2,lines_to_html(lines))
+            q.text = @lang.text_for(:code2, lines_to_html(lines))
             others = (1..@lines.size).to_a.shuffle!
-            others.delete(index+1)
+            others.delete(index + 1)
             q.good = (index + 1).to_s
             q.bads << others[0].to_s
             q.bads << others[1].to_s
@@ -120,7 +119,7 @@ class PythonCodeAI < BaseCodeAI
     # error_lines = []
     @lines.each_with_index do |line, index|
       # Search Variable assignment
-      m = /\s*(\w*)\s*\=\w*/.match(line)
+      m = /\s*(\w*)\s*=\w*/.match(line)
       i = []
       unless m.nil?
         varname = (m.values_at 1)[0]
@@ -141,20 +140,20 @@ class PythonCodeAI < BaseCodeAI
         if rand(2) == 0
           q = Question.new(:short)
           q.name = "#{name}-#{num}-variable"
-          q.text = @lang.text_for(:code1,lines_to_html(lines))
+          q.text = @lang.text_for(:code1, lines_to_html(lines))
           q.shorts << (index + 1)
-          q.feedback = "Variable error! Swapped lines #{(index+1)} with #{(k+1)}"
+          q.feedback = "Variable error! Swapped lines #{index + 1} with #{k + 1}"
         else
           q = Question.new(:choice)
           q.name = "#{name}-#{num}-variable"
-          q.text = @lang.text_for(:code2,lines_to_html(lines))
+          q.text = @lang.text_for(:code2, lines_to_html(lines))
           others = (1..@lines.size).to_a.shuffle!
-          others.delete(index+1)
+          others.delete(index + 1)
           q.good = (index + 1).to_s
           q.bads << others[0].to_s
           q.bads << others[1].to_s
           q.bads << others[2].to_s
-          q.feedback = "Variable error! Swapped lines #{(index+1)} with #{(k+1)}"
+          q.feedback = "Variable error! Swapped lines #{index + 1} with #{k + 1}"
         end
         questions << q
       end