ask-ruby-harness 0.3.0 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d70bd6e8f4bbf2d01ad1e3b68a49ca668edb25730dc7473690815a4416de02bd
-  data.tar.gz: c3e5f670a81444bc2022a32d57ea64f0ab09435b6d49a2e31333607b0d758850
+  metadata.gz: bc926a8ba86f90bbc682d1361f4b436decfb071f543303a4f1055b7d8e986b59
+  data.tar.gz: b49641a4b3d21015363f0744ea28a5a146dd42eec21859120faee3977adfcba1
 SHA512:
-  metadata.gz: 5f973f3223d742de9f530bd2eaf91f70ef5ed2e6ec0376a5103d9ea6683401bc5002934dd1aa5ffa0731bf4e6fffe387d4f11a4e180258d61439bfbc7955bd73
-  data.tar.gz: b8326c07280c08a863073d8c01db0e90688799eef058dc63a5ecb44d268c6f153fb70de3db28795c2265a10602a7ad3a3dcc0cb609eec0aa007ee448895bba96
+  metadata.gz: fe9cef5ac7bab9ae6742e988b0e46359d95809aedc91995918dd49d1481e770819d1e08388b90e60a3d1db0b4344dd32309ff317808283bf9ef4031104cd1713
+  data.tar.gz: b29401a3227880eb954e684b14fe4b197da492da840d1ab068f594f10007e6309deeeae95ca6bc5afcd6108fbadb1e119589bba5c478eb4ff959d9dbefba809e

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+## [0.3.2] — 2026-08-12
+
+### Fixed
+
+- **ERB-safe `config/database.yml` parsing** — `database_yaml` now renders
+  ERB (Rails-style) before YAML loading. Raw `YAML.safe_load` choked on the
+  ERB most real database.yml files embed (ENV/credentials), so the named
+  database fallback reported "not found" for those apps.
+- **Env-name lookup for named databases** — `database: "production"` from a
+  development-booted server now resolves that environment's own section in
+  `config/database.yml`: its flat single-DB config, or its `primary` pool
+  for multi-DB apps.
+
 ## [0.3.0] — 2026-08-10
 
 ### Added

data/lib/ask/ruby/harness/tools/run_tests.rb

@@ -30,6 +30,14 @@ module Ask
             files = files.map { |f| rel_to_run_root(f, run_root) }
             runner = detect_runner(run_root)
 
+            # rake test only takes files (TEST env); expand directory args to
+            # their *_test.rb files. Rails and rspec expand dirs natively.
+            if runner == :minitest
+              expanded = expand_minitest_directories(files, run_root)
+              return expanded unless expanded.is_a?(Array)
+              files = expanded
+            end
+
             failed_tests = failed_only ? load_failed_tests(run_root) : nil
             if failed_only && failed_tests.empty?
               return Ask::Result.failure("No failed tests from the previous run to rerun.")
@@ -40,6 +48,10 @@ module Ask
             json_path = artifact_dir.join("last-test.json")
             status_path = artifact_dir.join("last-failures.json")
 
+            # A child that produces no JSON must not be masked by a previous
+            # run's stale file — parse_results only looks at this path.
+            json_path.delete if json_path.exist?
+
             command, env = build_command(runner, files, name, failed_tests, json_path)
             outcome = run(command, env, log_path, timeout, run_root)
 
@@ -101,6 +113,25 @@ module Ask
             Pathname.new(File.expand_path(file, app_root)).relative_path_from(run_root).to_s
           end
 
+          # rake_test_loader requires each arg as a file — a directory arg
+          # explodes ("cannot load such file -- .../test"). Replace directory
+          # args with the *_test.rb files under them (relative to run_root),
+          # mirroring the standard Rake::TestTask pattern.
+          def expand_minitest_directories(files, run_root)
+            files.flat_map do |f|
+              dir = File.join(run_root.to_s, f)
+              next f unless File.directory?(dir)
+
+              matches = Dir.glob(File.join(dir, "**", "*_test.rb"))
+                          .map { |m| Pathname.new(m).relative_path_from(run_root).to_s }
+                          .uniq
+              if matches.empty?
+                return Ask::Result.failure("No *_test.rb files found under '#{f}'.")
+              end
+              matches
+            end.uniq
+          end
+
           def build_command(runner, files, name, failed_tests, json_path)
             case runner
             when :rspec
@@ -125,11 +156,25 @@ module Ask
               # arrives via RUBYOPT like everywhere else.
               args = ["bundle", "exec", "rake", "test"]
               env = injection_env(json_path)
-              env["TEST"] = files.first if files.size == 1
+              # Rake::TestTask reads TEST/TESTOPTS from the environment, so
+              # the child inherits whatever the parent run carried (nested
+              # runs!) unless it's overwritten or cleared here — a stray TEST
+              # pointing at the outer project's files would abort the inner
+              # run before any test loads.
+              env["TEST"] = files.any? ? files.join(",") : nil
               testopts = []
               testopts << "--name=#{name}" if name
               testopts << "--name=#{name_pattern(failed_tests)}" if failed_tests
-              env["TESTOPTS"] = testopts.join(" ") unless testopts.empty?
+              if testopts.empty?
+                env["TESTOPTS"] = nil
+              else
+                # rake's test task runs ruby through the shell, so unquoted
+                # TESTOPTS with `|` (failed_only alternations) or spaces gets
+                # split into bogus commands. Quote each option so it survives
+                # as one ARGV entry in rake_test_loader.
+                env["TESTOPTS"] = testopts.map { |o| "\"#{o}\"" }.join(" ")
+              end
+              %w[TESTOPT TEST_OPTS TEST_OPT].each { |k| env[k] = nil }
               [args, env]
             end
           end

data/lib/ask/ruby/harness/version.rb

@@ -3,7 +3,7 @@
 module Ask
   module Ruby
     module Harness
-      VERSION = "0.3.0"
+      VERSION = "0.3.2"
     end
   end
 end

data/lib/ask/ruby/harness.rb

@@ -97,7 +97,11 @@ module Ask
         # Config for a NAMED database. Resolution order:
         #   1. the host app's own configurations registry (Rails multi-DB —
         #      resolves credentials/ENV for us),
-        #   2. config/database.yml, the environment section's key.
+        #   2. config/database.yml, the current environment section's key,
+        #   3. config/database.yml, the named environment section itself —
+        #      "database: production" from a development-booted server
+        #      resolves production's config (its "primary" pool for
+        #      multi-DB apps).
         def database_config_for(name)
           name = name.to_s
           if ActiveRecord::Base.respond_to?(:configurations)
@@ -107,6 +111,15 @@ module Ask
 
           section = database_yaml_section
           config = section[name] if section.is_a?(Hash) && section[name].is_a?(Hash)
+          return sanitize_database_config(config) if config
+
+          yaml = database_yaml
+          env_section = yaml[name] if yaml.is_a?(Hash)
+          return nil unless env_section.is_a?(Hash)
+
+          # Multi-DB apps nest pools under the env key; single-DB apps keep
+          # the connection config flat under it.
+          config = env_section["primary"].is_a?(Hash) ? env_section["primary"] : env_section
           sanitize_database_config(config)
         end
 
@@ -205,12 +218,22 @@ module Ask
         private
 
         def database_yaml_section
+          yaml = database_yaml || {}
+          yaml[env] || yaml["development"] || {}
+        end
+
+        # Parses config/database.yml with ERB preprocessing (Rails-style) —
+        # most real database.yml files embed ENV/credentials ERB, which raw
+        # YAML.safe_load cannot parse. Returns nil when unreadable; the
+        # callers fall back to the Rails configurations registry.
+        def database_yaml
           path = app_root.join("config", "database.yml")
           return nil unless path.exist?
 
-          yaml = YAML.safe_load(path.read, aliases: true) || {}
-          yaml[env] || yaml["development"] || {}
-        rescue Psych::Exception
+          require "erb"
+          rendered = ERB.new(path.read).result
+          YAML.safe_load(rendered, aliases: true) || {}
+        rescue Psych::Exception, NameError, SyntaxError
           nil
         end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-ruby-harness
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.2
 platform: ruby
 authors:
 - Kaka Ruto