ask-ruby-harness 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d70bd6e8f4bbf2d01ad1e3b68a49ca668edb25730dc7473690815a4416de02bd
-  data.tar.gz: c3e5f670a81444bc2022a32d57ea64f0ab09435b6d49a2e31333607b0d758850
+  metadata.gz: b57d0a2408bc2432ed17401048b318263ac9e11709d73cd4eba7b2b47d2e9997
+  data.tar.gz: 910fa5fdc3a9a8da190fe05bd5326698043f4615853f3908648c05df55316d51
 SHA512:
-  metadata.gz: 5f973f3223d742de9f530bd2eaf91f70ef5ed2e6ec0376a5103d9ea6683401bc5002934dd1aa5ffa0731bf4e6fffe387d4f11a4e180258d61439bfbc7955bd73
-  data.tar.gz: b8326c07280c08a863073d8c01db0e90688799eef058dc63a5ecb44d268c6f153fb70de3db28795c2265a10602a7ad3a3dcc0cb609eec0aa007ee448895bba96
+  metadata.gz: 184e86499d3e1eede9de25e6ee241dc01dfaa2f504ae5de616c7e64cf845b83f12ee2e7681e55b7310078e72435db14f7a806e2526dcced4d70c298cecbb7518
+  data.tar.gz: 49e9aae381d3d619787f1420f103b1d09732de6370cb43dc367b5d2d82e8cb6f1043394e449812f53abbe13faff70aa3dd1761a020f8d556f41077e477a2942a

data/lib/ask/ruby/harness/tools/run_tests.rb

@@ -30,6 +30,14 @@ module Ask
             files = files.map { |f| rel_to_run_root(f, run_root) }
             runner = detect_runner(run_root)
 
+            # rake test only takes files (TEST env); expand directory args to
+            # their *_test.rb files. Rails and rspec expand dirs natively.
+            if runner == :minitest
+              expanded = expand_minitest_directories(files, run_root)
+              return expanded unless expanded.is_a?(Array)
+              files = expanded
+            end
+
             failed_tests = failed_only ? load_failed_tests(run_root) : nil
             if failed_only && failed_tests.empty?
               return Ask::Result.failure("No failed tests from the previous run to rerun.")
@@ -40,6 +48,10 @@ module Ask
             json_path = artifact_dir.join("last-test.json")
             status_path = artifact_dir.join("last-failures.json")
 
+            # A child that produces no JSON must not be masked by a previous
+            # run's stale file — parse_results only looks at this path.
+            json_path.delete if json_path.exist?
+
             command, env = build_command(runner, files, name, failed_tests, json_path)
             outcome = run(command, env, log_path, timeout, run_root)
 
@@ -101,6 +113,25 @@ module Ask
             Pathname.new(File.expand_path(file, app_root)).relative_path_from(run_root).to_s
           end
 
+          # rake_test_loader requires each arg as a file — a directory arg
+          # explodes ("cannot load such file -- .../test"). Replace directory
+          # args with the *_test.rb files under them (relative to run_root),
+          # mirroring the standard Rake::TestTask pattern.
+          def expand_minitest_directories(files, run_root)
+            files.flat_map do |f|
+              dir = File.join(run_root.to_s, f)
+              next f unless File.directory?(dir)
+
+              matches = Dir.glob(File.join(dir, "**", "*_test.rb"))
+                          .map { |m| Pathname.new(m).relative_path_from(run_root).to_s }
+                          .uniq
+              if matches.empty?
+                return Ask::Result.failure("No *_test.rb files found under '#{f}'.")
+              end
+              matches
+            end.uniq
+          end
+
           def build_command(runner, files, name, failed_tests, json_path)
             case runner
             when :rspec
@@ -125,11 +156,25 @@ module Ask
               # arrives via RUBYOPT like everywhere else.
               args = ["bundle", "exec", "rake", "test"]
               env = injection_env(json_path)
-              env["TEST"] = files.first if files.size == 1
+              # Rake::TestTask reads TEST/TESTOPTS from the environment, so
+              # the child inherits whatever the parent run carried (nested
+              # runs!) unless it's overwritten or cleared here — a stray TEST
+              # pointing at the outer project's files would abort the inner
+              # run before any test loads.
+              env["TEST"] = files.any? ? files.join(",") : nil
               testopts = []
               testopts << "--name=#{name}" if name
               testopts << "--name=#{name_pattern(failed_tests)}" if failed_tests
-              env["TESTOPTS"] = testopts.join(" ") unless testopts.empty?
+              if testopts.empty?
+                env["TESTOPTS"] = nil
+              else
+                # rake's test task runs ruby through the shell, so unquoted
+                # TESTOPTS with `|` (failed_only alternations) or spaces gets
+                # split into bogus commands. Quote each option so it survives
+                # as one ARGV entry in rake_test_loader.
+                env["TESTOPTS"] = testopts.map { |o| "\"#{o}\"" }.join(" ")
+              end
+              %w[TESTOPT TEST_OPTS TEST_OPT].each { |k| env[k] = nil }
               [args, env]
             end
           end

data/lib/ask/ruby/harness/version.rb

@@ -3,7 +3,7 @@
 module Ask
   module Ruby
     module Harness
-      VERSION = "0.3.0"
+      VERSION = "0.3.1"
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-ruby-harness
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Kaka Ruto