ask-ruby-harness 0.1.0 → 0.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd5a2b1d1916502e5eb5cc92220a4d06149817a05f2bf8ed00e8327630272881
-  data.tar.gz: 847841b9d7fd758f8fb2c3da5d19e8b51414f3e3f2ee94c8e398e3231abe3b6a
+  metadata.gz: 411e139b4a5cfe5e017a748753c36a1f811a45f719e2245c7789267d4fe9f476
+  data.tar.gz: bd78de0520de347c8ffb675c7c704187c98fc7971b3b4a30770c227479adf7f3
 SHA512:
-  metadata.gz: 604554da7aa7e84bd2d779cd68123645757d185000d62575694e51201ef1086e5419e48d24c70679546098a4352bf9c686184ff22725fec22d0995aafa6e02f2
-  data.tar.gz: 9f4bdf2110e1a2dd490cf59c0d0af545726bec839dc64f59e7cdfe8e6438170750ebe6e2dcc1530cedf51586001b8d7a686897b2c46368eefd60c2a3a25a010f
+  metadata.gz: 4010a7f88a99c289dc68a1bbb40e7b8b829ac794b2a9daf609558128dad5b809f1a6900fae0d8d4c46d795ab69aa5802aa4cfde361256601c913d893f2551000
+  data.tar.gz: 6c0362992da2df7e54e0191fbc494c35c90641d538c9f2f7ea63e58b8a33a5d4a9248f32ee58def32d5db09547c83887dd598f7dbe524fc98b19a29c04a6f4bb

data/CHANGELOG.md

@@ -1,3 +1,24 @@
+## [0.2.1] — 2026-08-10
+
+### Fixed
+
+- **Standalone DB connection guard** — `QueryDatabase` now checks whether a
+  connection spec is *defined* (pool presence) instead of `connected?`
+  (which stays false until the first checkout), so `establish_connection`
+  from `ASK_DATABASE_URL`/`database.yml` is actually honored.
+- **Relative sqlite paths in `database.yml`** — resolved against the app
+  root (like Rails does) instead of the harness's cwd.
+
+## [0.2.0] — 2026-08-10
+
+### Added
+
+- **Monorepo support in `run_tests`** — when the `file:` param points into a
+  subproject (a directory with its own Gemfile/Rakefile), the suite runs
+  there, so rake/rails resolve the subproject's tasks. Artifacts
+  (`tmp/test/.ask/`) live in the subproject too. (The MCP server for this
+  gem lives in the separate `ask-ruby-harness-mcp` gem.)
+
 ## [0.1.0] — 2026-08-10
 
 ### Added

data/lib/ask/ruby/harness/audit_log.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "json"
+require "active_support/notifications"
 require "active_support/core_ext/string/filters"
 
 module Ask

data/lib/ask/ruby/harness/tools/query_database.rb

@@ -30,10 +30,10 @@ module Ask
               )
             end
 
-            unless Ask::Ruby::Harness.database_connected?
+            unless Ask::Ruby::Harness.database_configured?
               Ask::Ruby::Harness.connect_database!
             end
-            unless Ask::Ruby::Harness.database_connected?
+            unless Ask::Ruby::Harness.database_configured?
               return Ask::Result.failure(
                 "Database not connected. Set ASK_DATABASE_URL or provide a config/database.yml."
               )

data/lib/ask/ruby/harness/tools/run_tests.rb

@@ -24,34 +24,38 @@ module Ask
 
           def execute(file: nil, name: nil, failed_only: false, timeout: DEFAULT_TIMEOUT)
             files = split_files(file)
-            runner = detect_runner
+            # Monorepo support: a file inside a subproject (a dir with its
+            # own Gemfile/Rakefile) runs that project's suite.
+            run_root = resolve_run_root(files)
+            files = files.map { |f| rel_to_run_root(f, run_root) }
+            runner = detect_runner(run_root)
 
-            failed_tests = failed_only ? load_failed_tests : nil
+            failed_tests = failed_only ? load_failed_tests(run_root) : nil
             if failed_only && failed_tests.empty?
               return Ask::Result.failure("No failed tests from the previous run to rerun.")
             end
 
-            artifact_dir = app_root.join(*ARTIFACT_DIR).tap(&:mkpath)
+            artifact_dir = run_root.join(*ARTIFACT_DIR).tap(&:mkpath)
             log_path = artifact_dir.join("last-test.log")
             json_path = artifact_dir.join("last-test.json")
             status_path = artifact_dir.join("last-failures.json")
 
             command, env = build_command(runner, files, name, failed_tests, json_path)
-            outcome = run(command, env, log_path, timeout)
+            outcome = run(command, env, log_path, timeout, run_root)
 
             results = parse_results(runner, json_path)
             unless results
               # A killed run can't produce results — report it structurally
               # instead of failing, so the agent still gets the artifact path.
-              return Ask::Result.ok(data: timed_out_report(runner, command, env, outcome, status_path, log_path)) if outcome[:timed_out]
+              return Ask::Result.ok(data: timed_out_report(runner, command, env, outcome, status_path, log_path, run_root)) if outcome[:timed_out]
 
               return Ask::Result.failure(
                 "Test run finished without machine-readable results (#{runner}); " \
-                "full output at #{rel(log_path)}"
+                "full output at #{rel(log_path, run_root)}"
               )
             end
 
-            report = build_report(runner, command, env, outcome, results, status_path, log_path)
+            report = build_report(runner, command, env, outcome, results, status_path, log_path, run_root)
             Ask::Result.ok(data: report)
           end
 
@@ -64,14 +68,39 @@ module Ask
 
           # Rails app → bin/rails test; rspec in the bundle with a spec/ dir →
           # rspec; anything else → minitest via rake test.
-          def detect_runner
-            return :rails if app_root.join("bin", "rails").exist?
-            lockfile = app_root.join("Gemfile.lock")
+          def detect_runner(run_root)
+            return :rails if run_root.join("bin", "rails").exist?
+            lockfile = run_root.join("Gemfile.lock")
             rspec = lockfile.exist? && lockfile.read.include?("rspec")
-            return :rspec if rspec && app_root.join("spec").directory?
+            return :rspec if rspec && run_root.join("spec").directory?
             :minitest
           end
 
+          # --- monorepo support -------------------------------------------
+
+          # For a file inside a subproject of a monorepo (a dir with its own
+          # Gemfile/Rakefile), run the suite there so rake/rails resolve the
+          # subproject's tasks. Only when ALL files share the same subproject;
+          # otherwise (or at the app root itself) fall back to app_root.
+          def resolve_run_root(files)
+            roots = files.map { |f| project_root_for(f) }.uniq
+            roots.size == 1 && !roots.first.nil? ? roots.first : app_root
+          end
+
+          def project_root_for(file)
+            dir = File.expand_path(File.dirname(file), app_root)
+            root = app_root.to_s
+            while dir != root && dir.start_with?(root + File::SEPARATOR)
+              return Pathname.new(dir) if %w[Gemfile Rakefile].any? { |n| File.exist?(File.join(dir, n)) }
+              dir = File.dirname(dir)
+            end
+            nil
+          end
+
+          def rel_to_run_root(file, run_root)
+            Pathname.new(File.expand_path(file, app_root)).relative_path_from(run_root).to_s
+          end
+
           def build_command(runner, files, name, failed_tests, json_path)
             case runner
             when :rspec
@@ -129,7 +158,7 @@ module Ask
             "/#{escaped.join('|')}/"
           end
 
-          def run(command, env, log_path, timeout)
+          def run(command, env, log_path, timeout, run_root)
             # The harness server may run with a deliberately small pool
             # (e.g. RAILS_MAX_THREADS=1 in its MCP config). Test runs are a
             # separate concern — let them use the app's normal pool sizes and
@@ -139,7 +168,7 @@ module Ask
             # would otherwise hijack it).
             child_env = env.merge("RAILS_MAX_THREADS" => nil)
             ENV.each_key { |k| child_env[k] = nil if k.start_with?("BUNDLE") }
-            pid = Process.spawn(child_env, *command, chdir: app_root.to_s,
+            pid = Process.spawn(child_env, *command, chdir: run_root.to_s,
                                 out: [log_path.to_s, "w"], err: [:child, :out])
             status = nil
             timed_out = false
@@ -159,7 +188,7 @@ module Ask
             { exit_status: status&.exitstatus, timed_out: timed_out }
           end
 
-          def build_report(runner, command, env, outcome, results, status_path, log_path)
+          def build_report(runner, command, env, outcome, results, status_path, log_path, run_root)
             summary = results[:summary]
             failed_tests = results[:failed_tests]
             persist_failed_tests(runner, failed_tests, status_path)
@@ -171,12 +200,12 @@ module Ask
               timed_out: outcome[:timed_out],
               summary: summary,
               failed_tests: failed_tests,
-              artifact: rel(log_path),
+              artifact: rel(log_path, run_root),
               next: summary[:failures] + summary[:errors] > 0 ? "run_tests(failed_only: true)" : nil
             }
           end
 
-          def timed_out_report(runner, command, env, outcome, status_path, log_path)
+          def timed_out_report(runner, command, env, outcome, status_path, log_path, run_root)
             persist_failed_tests(runner, [], status_path)
             {
               framework: runner.to_s,
@@ -185,7 +214,7 @@ module Ask
               timed_out: true,
               summary: nil,
               failed_tests: nil,
-              artifact: rel(log_path),
+              artifact: rel(log_path, run_root),
               next: nil
             }
           end
@@ -240,8 +269,8 @@ module Ask
             status_path.write(JSON.pretty_generate(framework: runner.to_s, failed_tests: failed_tests))
           end
 
-          def load_failed_tests
-            path = app_root.join(*ARTIFACT_DIR, "last-failures.json")
+          def load_failed_tests(run_root)
+            path = run_root.join(*ARTIFACT_DIR, "last-failures.json")
             return [] unless path.exist?
             JSON.parse(path.read).fetch("failed_tests", []).map { |t| symbolize_keys(t) }
           rescue JSON::ParserError
@@ -252,8 +281,8 @@ module Ask
             hash.each_with_object({}) { |(k, v), h| h[k.to_sym] = v }
           end
 
-          def rel(path)
-            path.relative_path_from(app_root).to_s
+          def rel(path, base = app_root)
+            path.relative_path_from(base).to_s
           end
         end
       end

data/lib/ask/ruby/harness/version.rb

@@ -3,7 +3,7 @@
 module Ask
   module Ruby
     module Harness
-      VERSION = "0.1.0"
+      VERSION = "0.2.1"
     end
   end
 end

data/lib/ask/ruby/harness.rb

@@ -72,7 +72,7 @@ module Ask
         #
         # Connection sources, in order: ASK_DATABASE_URL, config/database.yml.
         def connect_database!
-          return if database_connected?
+          return if database_configured?
 
           config = ENV["ASK_DATABASE_URL"] || database_config_from_yaml
           ActiveRecord::Base.establish_connection(config) if config
@@ -80,8 +80,17 @@ module Ask
           warn "[ask-ruby-harness] database connect failed: #{e.message}"
         end
 
-        def database_connected?
-          defined?(ActiveRecord::Base) && ActiveRecord::Base.connected?
+        # Whether a connection spec is defined. Uses the pool presence, not
+        # `connected?` — ActiveRecord's connected? stays false until a
+        # connection is actually checked out, while pool.with_connection
+        # establishes lazily on first use.
+        def database_configured?
+          defined?(ActiveRecord::Base) &&
+            ActiveRecord::Base.connection_handler.retrieve_connection_pool(
+              ActiveRecord::Base.connection_specification_name
+            )
+        rescue StandardError
+          false
         end
 
         private
@@ -178,7 +187,14 @@ module Ask
           section = section["primary"] if section.is_a?(Hash) && section["primary"].is_a?(Hash)
           return nil unless section.is_a?(Hash)
 
-          section.slice(*Configuration::DATABASE_CONFIG_KEYS).presence
+          config = section.slice(*Configuration::DATABASE_CONFIG_KEYS)
+          # Resolve relative sqlite paths against app_root, like Rails does —
+          # the harness may run with a different cwd than the project root.
+          if config["adapter"].to_s.include?("sqlite") &&
+             config["database"] && !config["database"].start_with?("/", ":")
+            config["database"] = app_root.join(config["database"]).to_s
+          end
+          config.presence
         rescue Psych::Exception
           nil
         end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-ruby-harness
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.1
 platform: ruby
 authors:
 - Kaka Ruto