ask-github 0.1.0 → 0.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 81872d8db5d4f3e8a63eed5fb7bb856daa386f447f522331d8c30b97400ad0a5
-  data.tar.gz: d86d708a8e4fbaac994a2cedaab52458434fae36b08f9c7cae98d8b70b9ae079
+  metadata.gz: 61e0c09960d2b923d6209cc171870ccc4517b594fb4764ae7c5ffb611fe09e78
+  data.tar.gz: 456ca8833ac0e354809e09d2cf1b84ea7b1354a26589aa74533981ebe63b5c4b
 SHA512:
-  metadata.gz: 925160b0799b93e9c2665429c319594913a9346ab461ca9d14ba90809a7e264715c729f5513365681845f48f247ab468f6a91169361089f6346e52c910cf58e1
-  data.tar.gz: 0f44993f6e054c65512ddbed2a2ea0b2cef9e0436093e9edf0d224b55fbe94872964606ab0099eb0476036eb3adaa6a747e873f9cb2e3736d413f4eac2881c68
+  metadata.gz: db1fd215ba903feca7ba4c09fded2c10d7c306b54906224ee3a373f3ef3f0f85708535845d0a7abd46ed09aef82f9c4dfb1943f2b116682a1c085b056ef3dc49
+  data.tar.gz: 591f2708a9538d55114a9c6add830b7409f030ab8313dd1a36c68b1cae38900e50c4dd7285a3e84725ccf8c33a38c348f90ed0ec73400bd470f3cc71c607c76f

data/lib/ask/github/version.rb

@@ -2,6 +2,6 @@
 
 module Ask
   module GitHub
-    VERSION = "0.1.0"
+    VERSION = "0.1.1"
   end
 end

data/lib/ask/skills/github.issue_triage/SKILL.md

@@ -0,0 +1,144 @@
+---
+name: github.issue_triage
+description: Systematic approach for triaging GitHub issues — reproduce, classify, check duplicates, label, prioritize
+---
+
+Use this skill when asked to handle a new GitHub issue, classify bug reports,
+or organize a queue of unprocessed issues.
+
+## Step 1: Reproduce the Issue
+
+If the issue describes a bug, the first step is reproduction:
+
+```ruby
+client = Ask::GitHub.client
+issue = client.issue("owner/repo", ISSUE_NUMBER)
+puts issue.title
+puts issue.body
+```
+
+Extract from the issue body:
+1. **Steps to reproduce** — are they complete and accurate?
+2. **Expected behavior** — what should happen
+3. **Actual behavior** — what happens instead
+4. **Environment** — OS, version, browser, dependencies
+5. **Error messages** — exact text, stack traces, screenshots
+
+If steps are missing, ask for them. Never triage a bug that can't be reproduced.
+
+## Step 2: Classify the Issue
+
+Determine what type of issue it is:
+
+**Bug** — Unexpected behavior, crash, error
+- Severity: Critical (production outage) / Major (broken feature) / Minor (cosmetic)
+
+**Feature Request** — New capability or enhancement
+- Scope: Small (add param) / Medium (new endpoint) / Large (new subsystem)
+
+**Question** — How-to, clarification,usage help
+- Answerable from docs? Redirect to docs first.
+
+**Task** — Chore, tech debt, CI fix, dependency update
+- Effort: Small / Medium / Large
+
+## Step 3: Check for Duplicates
+
+Search for similar existing issues:
+
+```ruby
+# Search for keywords from the issue title
+similar = client.search_issues("keyword repo:owner/repo is:issue")
+similar.items.each { |i| puts "##{i.number}: #{i.title} (#{i.state})" }
+```
+
+Check both open AND closed issues — a previously closed issue might have been
+reopened in a new form.
+
+Mark as duplicate if:
+- Same root cause (different symptom? still a duplicate)
+- Same feature request (even different proposed API shape)
+- References the same error message or stack trace
+
+If duplicate found, add a comment:
+```ruby
+client.add_comment("owner/repo", ISSUE_NUMBER, "Duplicate of #123. Closing.")
+client.update_issue("owner/repo", ISSUE_NUMBER, state: "closed")
+```
+
+## Step 4: Add Labels
+
+Apply appropriate labels based on classification:
+
+```ruby
+labels = []
+labels << "bug" if bug
+labels << "enhancement" if feature
+labels << "question" if question
+labels << priority_label(severity) # "critical", "high", "medium", "low"
+labels << "needs-reproduction" if steps_to_repro_missing
+labels << "good-first-issue" if simple and well-scoped
+
+client.add_labels_to_an_issue("owner/repo", ISSUE_NUMBER, labels)
+```
+
+If the issue needs more information to be actionable:
+```ruby
+labels << "needs-info"
+client.update_issue("owner/repo", ISSUE_NUMBER, labels: labels)
+```
+
+## Step 5: Prioritize
+
+Priority matrix based on:
+
+```
+              | Critical | Major | Minor
+User Impact   | High     | High  | Low
+Workaround    | None     | Some  | Has
+Frequency     | Always   | Often | Rare
+Scope         | All      | Some  | Edge
+```
+
+**Critical** — Fix immediately, patch release: P0
+- Production outage, data loss, security vulnerability
+
+**High** — Fix this sprint: P1
+- Feature broken for most users, no workaround
+
+**Medium** — Schedule next sprint: P2
+- Feature broken for some users, has workaround
+
+**Low** — Backlog, community PR welcome: P3
+- Enhancement, nice-to-have, rare edge case
+
+## Step 6: Add Context
+
+If the issue references code, trace through the codebase to add helpful context:
+
+```ruby
+# Search for related code
+search_paths = ["app/", "lib/"]  # adjust for repo structure
+Glob.new.call(pattern: "app/**/*.rb") # check the repo structure
+```
+
+Add a triage comment summarizing:
+1. Brief reproduction status
+2. Classification
+3. Priority with reasoning
+4. Suggested approach (if bug: fix direction; if feature: implementation sketch)
+5. @mention relevant maintainer if needed
+
+```ruby
+client.add_comment("owner/repo", ISSUE_NUMBER, "Triage summary: ...")
+```
+
+## Failure Mode Guide
+
+| Situation | Action |
+|-----------|--------|
+| Can't reproduce | Label `needs-info`, ask for more details |
+| Incomplete report | Request specific missing information |
+| Security issue | Do NOT file publicly — create private advisory |
+| Controversial feature request | Label `needs-discussion`, ping maintainers |
+| Issue spam | Label `invalid`, close immediately |

data/lib/ask/skills/github.pr_review/SKILL.md

@@ -0,0 +1,143 @@
+---
+name: github.pr_review
+description: Systematic methodology for reviewing GitHub pull requests
+---
+
+Use this skill when asked to review a GitHub pull request. Follow the steps
+in order — each provides context needed for the next.
+
+## Step 1: Understand the Change
+
+First, get the big picture:
+
+```ruby
+client = Ask::GitHub.client
+files = client.pull_request_files("owner/repo", PR_NUMBER)
+```
+
+Review the file list:
+- **Total files changed** — is this a reasonable scope?
+- **File types** — config, app code, tests, migrations, docs?
+- **Lines added vs deleted** — is it mostly new code or refactoring?
+
+Then get the full diff for each file:
+
+```ruby
+files.each do |f|
+  puts "#{f.filename}: +#{f.additions}/-#{f.deletions}"
+end
+```
+
+For large PRs, focus on the core logic files and skip generated/config changes
+unless they're the purpose of the PR.
+
+## Step 2: Read the PR Description and Related Issues
+
+```ruby
+pr = client.pull_request("owner/repo", PR_NUMBER)
+puts pr.title
+puts pr.body
+```
+
+Check for:
+- **Motivation** — is the WHY clear?
+- **Related issues** — does `pr.body` reference #123 or "Closes #123"?
+- **Testing strategy** — does it mention how it was tested?
+- **Deployment considerations** — migrations, config changes, feature flags?
+
+If issues are referenced, review them for context:
+
+```ruby
+client.issue("owner/repo", ISSUE_NUMBER)
+```
+
+## Step 3: Review Tests First
+
+Look at the test files changed:
+
+```ruby
+test_files = files.select { |f| f.filename.match?(/_test\.rb|_spec\.rb$/) }
+test_files.each do |f|
+  # Read the test content
+  client.contents("owner/repo", path: f.filename)
+end
+```
+
+Check:
+- **Coverage** — does every new method/logic path have a test?
+- **Edge cases** — empty state, error handling, boundary conditions?
+- **Test quality** — are they testing the behavior or the implementation?
+- **Setup/teardown** — are shared states properly isolated?
+
+## Step 4: Review Core Logic
+
+Review the main implementation files:
+
+```ruby
+app_files = files.reject { |f| f.filename.match?(/_test\.rb|_spec\.rb$/) }
+app_files.each do |f|
+  content = client.contents("owner/repo", path: f.filename)
+  # Review the content
+end
+```
+
+What to look for:
+- **Security**: SQL injection (raw SQL, string interpolation), mass assignment,
+  authentication bypass, exposed credentials
+- **Correctness**: Off-by-one errors, nil checks, edge case handling
+- **Performance**: N+1 queries, missing eager loading, unnecessary allocations
+- **Pattern consistency**: Follows existing code conventions?
+- **Error handling**: What happens when external services fail?
+
+## Step 5: Check for Common Anti-Patterns
+
+Scan for these common issues:
+
+1. **Hard-coded values** — should be config or environment variables
+2. **TODO/FIXME/HACK comments** — left-behind development artifacts
+3. **Commented-out code** — should be removed before merge
+4. **Overly complex methods** — more than 10-15 lines suggests refactoring needed
+5. **Duplicate logic** — extract to shared method or concern
+6. **Missing validations** — user input not validated before database insert
+
+## Step 6: Assess Test Results and CI
+
+If available, check CI status:
+
+```ruby
+# Check commit status
+client.commit_status("owner/repo", pr.head.sha)
+```
+
+If tests are failing or CI is red, DO NOT approve the PR until that's addressed.
+
+## Step 7: Write the Review
+
+Structure your review feedback:
+
+1. **Summary** — 2-3 sentences about what the PR does
+2. **Positive feedback** — what's done well (specific examples)
+3. **Required changes** — bugs, security issues, breaking tests
+4. **Suggestions** — improvements that are optional (performance, style)
+5. **Questions** — anything unclear that the author should clarify
+
+Use GitHub's review API:
+
+```ruby
+client.create_pull_request_review(
+  "owner/repo",
+  PR_NUMBER,
+  body: "Summary...",
+  event: "COMMENT" # or "APPROVE" or "REQUEST_CHANGES"
+)
+```
+
+## Failure Mode Guide
+
+| Situation | Action |
+|-----------|--------|
+| No test coverage | Request tests before approval |
+| Security vulnerability | Block with clear explanation, suggest fix |
+| PR has merge conflicts | Note that it needs rebase before review |
+| Large PR (>500 lines) | Focus on core logic, note scoping concerns |
+| Missing description | Ask for context before detailed review |

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-github
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.1.1
 platform: ruby
 authors:
 - Kaka Ruto
@@ -137,6 +137,8 @@ files:
 - lib/ask/github/context.rb
 - lib/ask/github/error_guide.rb
 - lib/ask/github/version.rb
+- lib/ask/skills/github.issue_triage/SKILL.md
+- lib/ask/skills/github.pr_review/SKILL.md
 homepage: https://github.com/ask-rb/ask-github
 licenses:
 - MIT