ask-coding-providers 0.3.1 → 0.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f1e380717ee69fa2d0da0df5a2c706e2b6e8ef3509ea6f6baad0c96d170d62f3
-  data.tar.gz: 21d327fadd79f5fbbdce88c71e1009b2f45b03431bd7cf29e258f4bcb07b3b05
+  metadata.gz: 546ff8509486604af6cc4f8fa7060bb91797a147b77336de0c71f4ca340d9ebf
+  data.tar.gz: 544b15d771c6c03bef753c3ee349b755a2bf484b07a58e3cb034f6e812fd3848
 SHA512:
-  metadata.gz: 975feb731eb168bd1a291c395e6421fd882ca9b0a23766602dde39352a187cb79c354df70d531e4516eb6050854e2086bbe3c629185e7751ea6d54c6554eca3a
-  data.tar.gz: 23cf6fe197707a8a0d456fbc8299f004cbb87134b17393a634305d227d1ada59b1bf476458ad482cc734317be8b87ae0972e240f6bc87a5d2a08ee1576707c57
+  metadata.gz: bb40d05d7c73881d57333164f48ac7becad1e973448e5b29c7e3404de7bc57fb1204598303561ebe35e0f5b34da1921a03eec253d56e2c7958b4c74df0b2af4e
+  data.tar.gz: 2ecef478830899e6e1d8192a6de02e75df7d28900e9132c9eeb34e408aa1fa2adce1cce0854c4a7318254b82de3dcc02be66705c0b6c328d89570d7360b96405

data/CHANGELOG.md

@@ -0,0 +1,78 @@
+# Changelog
+
+## [0.3.2] - 2026-08-10
+
+### Added
+
+- **Declarative agent sessions.** `create_session` accepts an `agent:`
+  name — the ask-agent convention (`agents/<name>/agent.rb` +
+  `instructions.md`, discovered from the working directory). The session
+  is built via `Ask::Agent.new`, so the definition's tools, skills
+  (agent_dir), and instructions apply, while harness-level options
+  (model, system prompt, approval, plan mode, todos) still win. The
+  emitting approval queue is passed through, so approval events stream
+  exactly like the plain path.
+
+
+
+### Added
+
+- **Per-session system prompts.** `create_session` accepts a
+  `system_prompt:` override for the session (takes precedence over the
+  adapter-level  session option), so hosts like
+  ask-coding-harness can give every workspace its own instructions.
+
+
+
+### Fixed
+
+- **Claude adapter streamed nothing** — the inner `each do |block|` loop
+  shadowed the method's `&block` parameter, so `block.call` invoked the
+  content Hash and every streaming turn failed. The loop variable is now
+  `content_block`; `model.streaming` events stream correctly.
+- **Codex session store** — `find_sessions` bound 2 parameters for 3 SQL
+  placeholders (silently returned `[]`); `find_recent_tui_session` passed
+  bind variables as separate arguments to `get_first_row` (silently
+  returned `nil`). Both now bind correctly.
+
+### Added
+
+- **External adapter tests** — Claude Code CLI streaming (stubbed
+  processes), Codex app-server client lifecycle, and read-only ZCode/Codex
+  session-store queries against temp SQLite fixtures. Full suite passes
+  the 70% coverage gate.
+
+
+### Added
+
+- **Rich event stream from the `ask_agent` adapter.** Sessions now emit
+  `model.thinking`, `tool.use`, `tool.delta`, `tool.result` (with
+  `isError`/`durationMs`), `approval.required`, `approval.updated`,
+  `plan.proposed`, `plan.approved`, `plan.rejected`, `todos.updated`,
+  `turn.aborted`, and `error` events in addition to the existing
+  `model.streaming`/`turn.completed`/`turn.failed`. Existing consumers keep
+  working unchanged.
+- **Persistent in-process sessions.** Each `create_session` id maps to one
+  `Ask::Agent::Session` instance whose conversation history accumulates
+  across turns.
+- **Approval controls.** `approve_action`, `reject_action`, `approve_all`,
+  `reject_all`, `pending_approvals`, plus `approve_plan`/`reject_plan`/
+  `pending_plan` for plan mode. `approval:` accepts `:off`, `:require`
+  (tools listed in `approval_required:` queue for human review), or `:auto`
+  (queue exists, never blocks).
+- **Plan mode and todos.** `plan_mode:` and `todos:` pass through to the
+  session and their events stream to subscribers.
+- **Abort support.** `abort(session_id)` stops the current turn, which
+  emits `turn.aborted`.
+- **Turn completion waits for approvals.** `send_and_stream` keeps the
+  stream open until the turn fully settles (follow-up turns included),
+  bounded by `turn_timeout`.
+
+### Fixed
+
+- `turn.started` is emitted after subscribing, so subscribers always
+  receive it.
+- Sessions created but never run no longer crash `list_sessions` /
+  `session_history`.
+- Approval mode is validated at adapter construction (fail fast).
+- Session listing sorts deterministically.

data/LICENSE

@@ -0,0 +1,21 @@
+MIT License
+
+Copyright (c) 2026 Kaka Ruto
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

data/lib/ask/coding_providers/acp/adapter.rb

@@ -64,7 +64,7 @@ module Ask
           @client&.running? || false
         end
 
-        def create_session(workspace_path, mode: nil)
+        def create_session(workspace_path, mode: nil, system_prompt: nil, **)
           ensure_running
           params = { cwd: workspace_path || @cwd }
           session = @client.session_new(**params)

data/lib/ask/coding_providers/adapter.rb

@@ -14,7 +14,7 @@ module Ask
       # @param workspace_path [String] the working directory
       # @param mode [String, nil] permission mode
       # @return [String] the session ID
-      def create_session(workspace_path, mode: nil)
+      def create_session(workspace_path, mode: nil, system_prompt: nil, **)
         raise NotImplementedError, "#{self.class} must implement #create_session"
       end
 

data/lib/ask/coding_providers/ask_agent/adapter.rb

@@ -149,7 +149,13 @@ module Ask
         # @param model [String, nil] model override for this session
         # @param system_prompt [String, nil] system prompt override for this
         #   session (takes precedence over any system_prompt in session_opts)
-        def create_session(workspace_path, mode: nil, model: nil, system_prompt: nil)
+        # @param agent [String, nil] declarative agent name (ask-agent
+        #   convention: agents/<name>/agent.rb + instructions.md, discovered
+        #   from the workspace's working directory). When given, the session
+        #   is built via Ask::Agent.new so the definition's tools, skills,
+        #   and instructions apply; the harness-level options (model,
+        #   system_prompt, approval, plan mode, todos) still win.
+        def create_session(workspace_path, mode: nil, model: nil, system_prompt: nil, agent: nil)
           ensure_started
           sid = "sess_#{SecureRandom.uuid}"
           @mutex.synchronize do
@@ -158,6 +164,7 @@ module Ask
               mode: mode,
               model: model || @model_id,
               system_prompt: system_prompt,
+              agent: agent,
               created_at: Time.now,
               session: nil,
               subscribers: [],
@@ -367,36 +374,71 @@ module Ask
         # ── Session construction ──
 
         def build_session(entry)
-          prompt = entry[:system_prompt] || @session_opts[:system_prompt]
-          chat = build_chat(entry[:model], prompt)
+          session = entry[:agent] ? build_agent_session(entry) : build_plain_session(entry)
+          session.on_event { |event| translate_event(entry, session, event) }
+          session
+        end
 
-          queue = EmittingApprovalQueue.new(
-            on_submit: ->(a) { emit_approval(entry, a, :pending) },
-            on_status: ->(a) { emit_approval(entry, a, a.status) }
-          )
+        # Build a session from a declarative agent definition (ask-agent
+        # convention). The definition's tools, skills (agent_dir), and
+        # instructions apply; harness-level options win where set. Agents
+        # are discovered from the working directory (the harness runs the
+        # session inside its workspace).
+        #
+        # The emitting approval queue is passed through Ask::Agent.new's
+        # opts, so Session#build_approval wires it with the session's
+        # apply/reject/register callbacks — approval events stream exactly
+        # like the plain path.
+        def build_agent_session(entry)
+          queue = emitting_queue(entry)
+          opts = {
+            approval: approval_config(queue),
+            plan_mode: @plan_mode,
+            todos: @todos,
+            max_turns: @max_turns,
+            # Caller options win over the definition; a nil model lets the
+            # definition's own model apply.
+            model: (entry[:model] unless entry[:model] == @model_id)
+          }.compact
+          opts[:system_prompt] = entry[:system_prompt] if entry[:system_prompt]
+          Ask::Agent.new(entry[:agent], **opts)
+        end
 
-          approval_cfg =
-            case @approval
-            when APPROVAL_REQUIRE then { queue: queue, require_approval: @approval_required }
-            when APPROVAL_AUTO then { queue: queue }
-            when APPROVAL_OFF then nil
-            else
-              raise ArgumentError, "approval must be one of #{APPROVAL_MODES.inspect}, got #{@approval.inspect}"
-            end
+        # Build the default session (no declarative agent).
+        def build_plain_session(entry)
+          prompt = entry[:system_prompt] || @session_opts[:system_prompt]
+          chat = build_chat(entry[:model], prompt)
 
           Ask::Agent::Session.new(
             model: chat,
             tools: @tools,
             max_turns: @max_turns,
-            approval: approval_cfg,
+            approval: approval_config(emitting_queue(entry)),
             plan_mode: @plan_mode,
             todos: @todos,
             **@session_opts
-          ).tap do |session|
-            session.on_event { |event| translate_event(entry, session, event) }
+          )
+        end
+
+        def emitting_queue(entry)
+          EmittingApprovalQueue.new(
+            on_submit: ->(a) { emit_approval(entry, a, :pending) },
+            on_status: ->(a) { emit_approval(entry, a, a.status) }
+          )
+        end
+
+        def approval_config(queue)
+          case @approval
+          when APPROVAL_REQUIRE then { queue: queue, require_approval: @approval_required }
+          when APPROVAL_AUTO then { queue: queue }
+          when APPROVAL_OFF then nil
+          else
+            raise ArgumentError, "approval must be one of #{APPROVAL_MODES.inspect}, got #{@approval.inspect}"
           end
         end
 
+
+
         def build_chat(model_id, system_prompt = nil)
           chat = Ask::Agent::Chat.new(
             model: model_id,

data/lib/ask/coding_providers/claude/adapter.rb

@@ -38,7 +38,7 @@ module Ask
           @started
         end
 
-        def create_session(workspace_path, mode: nil)
+        def create_session(workspace_path, mode: nil, system_prompt: nil, **)
           ensure_started
           sid = "sess_#{SecureRandom.uuid}"
           @sessions[sid] = { workspace: workspace_path, mode: mode, created_at: Time.now }

data/lib/ask/coding_providers/codex/adapter.rb

@@ -42,7 +42,7 @@ module Ask
           @client&.running? || false
         end
 
-        def create_session(workspace_path, mode: nil)
+        def create_session(workspace_path, mode: nil, system_prompt: nil, **)
           ensure_running
           thread = @client.thread_start(cwd: workspace_path)
           tid = thread["id"] || thread[:id]

data/lib/ask/coding_providers/version.rb

@@ -2,6 +2,6 @@
 
 module Ask
   module CodingProviders
-    VERSION = "0.3.1"
+    VERSION = "0.3.3"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-coding-providers
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.3
 platform: ruby
 authors:
 - Kaka Ruto
@@ -73,6 +73,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- CHANGELOG.md
+- LICENSE
 - README.md
 - lib/ask-coding-providers.rb
 - lib/ask/coding_providers.rb
@@ -110,7 +112,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 4.0.18
 specification_version: 4
 summary: Coding agent adapters for the ask-rb ecosystem
 test_files: []