ask-auth 0.3.2 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d41ca49d1114503dc3a3830efb730823fd598c1dca1249b2c06bc808be7c4743
-  data.tar.gz: 17b4718e99c515ba26424ce90b104ad4dfc416871e2ee2598ff5f62b67524bd7
+  metadata.gz: 8b6984f31cfde1336e6309204570981998b06055ab1be0a8112f9e30a947eac9
+  data.tar.gz: 4eb5d482ff745689d26b53378358c6cab098a30583ade8549b93298977bf2980
 SHA512:
-  metadata.gz: 90118e173e9fa7e9a675dacb331d14fe179f006b72679c2201a3395b121f0637dd91058f99efa098a1aefcf33224f730c40ce5bcbe9a80b37932edcfef73f791
-  data.tar.gz: 73b8d4681b7a3a74a7f92600e26c819e9123b796975d4100e6784fcb948f9412fecef3c7791dd095f41f114a00dadf59ed05c0e4f04eb9dddaee22fd74e5bba9
+  metadata.gz: 4281565d7ff34c10b2f1c2d8cbbdd669748fb1f4037fc1ef7ecb132f22cb4b821658ca7c5e39d228ec7a1ebe5148e6adf2892cd34191a121900297b81891b861
+  data.tar.gz: 4f5227bd2484737269442f9af081df85f5f72670d50206c0e01d431338193a58e36aa074aeb9e8d9244dd0687975c6c2d1b280e7edb20116454fcdddea830d65

data/CHANGELOG.md

@@ -1,3 +1,27 @@
+## [0.3.4] — 2026-08-18
+
+### Fixed
+
+- **Token exchange requests JSON by default.** Added `Accept: application/json`
+  header to `token_exchange` so providers that default to form-encoded
+  responses (e.g. GitHub) return parseable JSON.
+
+## [0.3.3] — 2026-08-18
+
+### Fixed
+
+- **`OAuth#fetch_oauth_state` tolerates string keys.** Cookie session stores
+  serialize to JSON, converting symbol keys to strings. The verifier lookup
+  now falls back to `value[key.to_s]` when the symbol lookup returns nil.
+
+### Added
+
+- **`OAuth` accepts `client_secret:` for token exchange.** Providers that
+  require a client secret (e.g. GitHub OAuth) can now pass it at
+  construction. The secret is included in `token_exchange` and `refresh`
+  requests when present, and omitted when nil — preserving backwards
+  compatibility with PKCE-only flows.
+
 ## [0.3.2] — 2026-08-13
 
 ### Added

data/lib/ask/auth/providers/oauth.rb

@@ -29,12 +29,14 @@ module Ask
       # Subclasses override #parse_token_response to add provider-specific
       # fields (e.g. an account id from the id_token).
       class OAuth
-        attr_reader :client_id, :redirect_uri
+        attr_reader :client_id, :client_secret, :redirect_uri
 
-        def initialize(storage: nil, client_id: nil, authorize_url: nil, token_url: nil,
+        def initialize(storage: nil, client_id: nil, client_secret: nil,
+          authorize_url: nil, token_url: nil,
           redirect_uri: nil, scope: nil, http: Ask::Auth::OAuth::HTTP)
           @storage = storage
           @client_id = client_id
+          @client_secret = client_secret
           @authorize_url = authorize_url
           @token_url = token_url
           @redirect_uri = redirect_uri
@@ -121,7 +123,8 @@ module Ask
         def token_exchange(**params)
           raise OAuthError, "token_url not configured" if @token_url.to_s.empty?
 
-          status, body = @http.post_form(@token_url, params)
+          params[:client_secret] = client_secret if client_secret
+          status, body = @http.post_form(@token_url, params, headers: { "Accept" => "application/json" })
           raise OAuthError, "token exchange failed (#{status}): #{body.to_s[0, 200]}" unless status == 200
 
           body
@@ -153,7 +156,12 @@ module Ask
           return nil unless @storage.respond_to?(:fetch) && user
 
           value = @storage.fetch(:oauth_state, user: user)
-          value.is_a?(Hash) ? value[key] : nil
+          return nil unless value.is_a?(Hash)
+
+          # Symbol keys survive Ruby→JSON→Ruby round-trips, but cookie
+          # session stores serialize to JSON (converting symbols to strings).
+          # Support both by falling back to the string representation.
+          value[key] || value[key.to_s]
         end
       end
     end

data/lib/ask/auth/version.rb

@@ -2,6 +2,6 @@
 
 module Ask
   module Auth
-    VERSION = "0.3.2"
+    VERSION = "0.3.4"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-auth
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 0.3.4
 platform: ruby
 authors:
 - Kaka Ruto