ask-agent 0.40.16 → 0.40.18

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c21109424c4b8f3216504c2a4aa1174e29b7fd9542436969a09d5281f9fdeb83
-  data.tar.gz: 024ea7d9470db47178237c36f5b2a36eb71ffedad9754a482e0f6aa6667f39e9
+  metadata.gz: e97d8067438c6de7e631a5837fc93355b9db6a2b94fd143d0e4421b59c9ec177
+  data.tar.gz: 4853729a9c4fa158bca58146b8b9e8305b6264cb1a12fb2b5750d8a2bcc79d03
 SHA512:
-  metadata.gz: 8ffb7ad67edcf4cca883837f1bf69dd1d9cecfc7b55a036c1a0b926d114e2cf1ee240fe369e671c2fc5b84183412fc7627648add81b014fe24a33a5377e67b60
-  data.tar.gz: 93379d0652c02ee137d46c97e1ea4b31098b57b2f912617bf0de66ba6044216f2011e18c665d959939ad8da7823293baadc74fab2e04adc7672313f722e1bffb
+  metadata.gz: 75def0a97595224d12c77fdbfadb875608c11afc0247b10e37058de1d1004f37addc1eb1ccbe64dd1c28a0a0f712ae024efe42d5372341a4876b6e8b32f5b0eb
+  data.tar.gz: 526100d9bc12da6404419c2ab21b64b73f735e0b5c773ced77816eb231c23f0816cce4a9b344108a542fc3b50f8b84781bb81244dc6e991c89435e26e0ef4920

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+## [0.40.17] — 2026-09-18
+
+### Added
+
+- **`decision_provider` — a session can take a decision provider, and its
+  tool calls get judged.** Set it globally
+  (`Ask::Agent.configure { |c| c.decision_provider = :typesafe }`) or per
+  session. `Ask::Decisions::AgentAdapter` then wires a gate in front of every
+  tool call and an output judge behind it; ask-agent itself never requires
+  ask-decisions, and with the setting unset nothing changes at all.
+
+### Changed
+
+- Requires `ask-core >= 0.12.0` for the decision vocabulary.
+
+
 ## [0.40.10] — 2026-09-05
 
 ### Fixed

data/lib/ask/agent/configuration.rb

@@ -6,7 +6,8 @@ module Ask
       attr_accessor :default_model, :default_provider, :default_max_turns,
                     :compactor_enabled, :compactor_threshold, :parallel_tool_execution,
                     :max_tool_retries, :prompt_caching, :default_evaluator_model,
-                    :audit_log, :compactor_reserve_tokens, :compactor_keep_recent_tokens
+                    :audit_log, :compactor_reserve_tokens, :compactor_keep_recent_tokens,
+                    :decision_provider
 
       # @return [Middleware::Pipeline] the middleware pipeline for provider calls
       attr_reader :middleware

data/lib/ask/agent/session.rb

@@ -20,6 +20,60 @@ module Ask
       attr_reader :meta_agent_results
       # @return [Ask::Skills::Registry, nil] auto-discovered skills registry
       attr_reader :skills_registry
+      # @return [Ask::Decisions::AgentAdapter, nil] decision adapter (when decision_provider is set)
+      attr_reader :decision_adapter
+
+      # Build a Session from a discovered Definition class and directory.
+      #
+      # This is the shared implementation used by both Ask::Agent.new(name)
+      # and Session.new(name:). It resolves the definition's config, tools,
+      # and instructions, then applies any caller-supplied overrides.
+      #
+      # @param klass [Class] the Definition subclass
+      # @param dir [String] the agent directory path
+      # @param opts [Hash] runtime overrides (model, provider, tools, system_prompt, etc.)
+      # @return [Session]
+      def self.build_from_definition(klass, dir, opts = {})
+        config = klass._config
+        session_opts = { model: config[:model] || Ask::Agent.configuration.default_model }
+
+        # Pass optional config
+        session_opts[:provider] = config[:provider] if config[:provider]
+        session_opts[:max_turns] = config[:max_turns] if config[:max_turns]
+        session_opts[:parallel_tools] = config[:parallel_tools] if config.key?(:parallel_tools)
+        session_opts[:skills_disclosure] = config[:skills_disclosure] if config.key?(:skills_disclosure)
+
+        # Pass arbitrary session options
+        if config[:options]
+          session_opts.merge!(config[:options])
+        end
+
+        # Pass agent directory for per-agent skills discovery
+        session_opts[:agent_dir] = dir
+
+        # Resolve tools
+        tools = resolve_definition_tools(config[:tools], dir)
+        session_opts[:tools] = tools if tools.any?
+
+        # Load instructions
+        prompt = klass.instructions_content
+        session_opts[:system_prompt] = prompt if prompt
+
+        # Apply schedule if defined
+        schedule = config[:schedule]
+        if schedule
+          task_block = ->(_sess = nil) {
+            agent = build_from_definition(klass, dir)
+            agent.run("")
+          }
+          Ask::Agent.configuration.scheduler.every(schedule, name: File.basename(dir), &task_block)
+        end
+
+        # Caller-supplied runtime options win over the definition's config.
+        session_opts.merge!(opts) unless opts.empty?
+
+        new(**session_opts)
+      end
 
       def initialize(model:, tools: [], max_turns: 25, max_tool_retries: 3,
                      compactor: nil, hooks: {}, state: nil, persistence: nil,
@@ -151,6 +205,25 @@ module Ask
           )
         end
 
+        # Decision provider integration: wire Gate, OutputJudge, and
+        # other decision components when a decision_provider is configured.
+        # This is opt-in — when not set, everything works as before.
+        decision_provider_name = chat_options.delete(:decision_provider) || Ask::Agent.configuration.decision_provider
+        decision_config = chat_options.delete(:decision_config) || {}
+        @decision_adapter = nil
+        if decision_provider_name && defined?(Ask::Decisions)
+          require "ask/decisions/agent_adapter" unless defined?(Ask::Decisions::AgentAdapter)
+          @decision_adapter = Ask::Decisions::AgentAdapter.new(decision_provider_name, decision_config)
+
+          # Wire Gate (before_tool) and OutputJudge (after_tool) into hooks.
+          existing_before = Array(@hooks.instance_variable_get(:@before_tool))
+          existing_after = Array(@hooks.instance_variable_get(:@after_tool))
+          @hooks = Hooks.new(
+            before_tool: @decision_adapter.before_tool_hooks + existing_before,
+            after_tool: existing_after + @decision_adapter.after_tool_hooks
+          )
+        end
+
         @system_context = build_system_context(system_prompt)
         apply_system_context
 
@@ -1127,6 +1200,34 @@ end
 
       # Recursively convert string keys to symbol keys in hashes.
       # Needed when loading session data that was serialized through JSON.
+      # Resolve tool specs (symbols, strings, or classes) from a Definition
+      # into instantiated tool objects. Symbols are looked up in the agent's
+      # per-agent tools/ directory first, then shared tools, then the global
+      # Ask::Tools registry.
+      def self.resolve_definition_tools(tool_specs, dir)
+        tools = []
+        tool_specs.each do |spec|
+          case spec
+          when Symbol, String
+            name = spec.to_s
+            # Try per-agent tools directory
+            agent_tool_path = File.join(dir, "tools", "#{name}.rb")
+            if File.exist?(agent_tool_path)
+              require agent_tool_path
+            end
+
+            resolved = Ask::Agent.resolve_tool_symbol(name)
+            if resolved
+              tool_class = resolved.is_a?(Class) ? resolved : Ask::Tools[name]
+              tools << tool_class if tool_class
+            end
+          when Class
+            tools << spec
+          end
+        end
+        tools
+      end
+
       def self.deep_symbolize_keys(obj)
         case obj
         when Hash

data/lib/ask/agent/sub_agent.rb

@@ -161,7 +161,7 @@ module Ask
         @provider = config[:provider]
 
         # Resolve tools from definition
-        resolved_tools = Ask::Agent.__send__(:resolve_definition_tools, config[:tools] || [], dir)
+        resolved_tools = Ask::Agent::Session.resolve_definition_tools(config[:tools] || [], dir)
         @tools = resolved_tools.map { |t| t.is_a?(Class) ? t.new : t }
 
         # Load instructions from definition

data/lib/ask/agent/version.rb

@@ -2,6 +2,6 @@
 
 module Ask
   module Agent
-    VERSION = "0.40.16"
+    VERSION = "0.40.18"
   end
 end

data/lib/ask/agent.rb

@@ -94,7 +94,7 @@ module Ask
         raise UnknownAgent, "Unknown agent: #{name.inspect}. Searched agents/ and app/agents/." unless entry
 
         klass, dir = entry
-        build_session_from_definition(klass, dir, opts)
+        Session.build_from_definition(klass, dir, opts)
       end
 
       # Force re-discovery of agent definitions.
@@ -188,73 +188,6 @@ module Ask
           @shared_tools[tool_name] = tool_name
         end
       end
-
-      def build_session_from_definition(klass, dir, opts = {})
-        config = klass._config
-        session_opts = { model: config[:model] || Ask::Agent.configuration.default_model }
-
-        # Pass optional config
-        session_opts[:provider] = config[:provider] if config[:provider]
-        session_opts[:max_turns] = config[:max_turns] if config[:max_turns]
-        session_opts[:parallel_tools] = config[:parallel_tools] if config.key?(:parallel_tools)
-        session_opts[:skills_disclosure] = config[:skills_disclosure] if config.key?(:skills_disclosure)
-
-        # Pass arbitrary session options
-        if config[:options]
-          session_opts.merge!(config[:options])
-        end
-
-        # Pass agent directory for per-agent skills discovery
-        session_opts[:agent_dir] = dir
-
-        # Resolve tools
-        tools = resolve_definition_tools(config[:tools], dir)
-        session_opts[:tools] = tools if tools.any?
-
-        # Load instructions
-        prompt = klass.instructions_content
-        session_opts[:system_prompt] = prompt if prompt
-
-        # Apply schedule if defined
-        schedule = config[:schedule]
-        if schedule
-          task_block = ->(sess = nil) {
-            agent = build_session_from_definition(klass, dir)
-            agent.run("")
-          }
-          Ask::Agent.configuration.scheduler.every(schedule, name: File.basename(dir), &task_block)
-        end
-
-        # Caller-supplied runtime options (model/provider/api_key/api_base/...)
-        # win over the definition's config.
-        session_opts.merge!(opts) unless opts.empty?
-
-        Session.new(**session_opts)
-      end
-
-      def resolve_definition_tools(tool_specs, dir)
-        tools = []
-        tool_specs.each do |spec|
-          case spec
-          when Symbol, String
-            name = spec.to_s
-            # Try per-agent tools directory
-            agent_tool_path = File.join(dir, "tools", "#{name}.rb")
-            if File.exist?(agent_tool_path)
-              require agent_tool_path
-            end
-
-            resolved = resolve_tool_symbol(name)
-            if resolved
-              tool_class = resolved.is_a?(Class) ? resolved : Ask::Tools[name]
-              tools << tool_class if tool_class
-            end
-          when Class
-            tools << spec
-          end
-        end
-        tools
-      end
     end
 
     # Register the global config
@@ -336,12 +269,24 @@ end
 #   Ask.chat("Tell me about X", model: "gpt-4o")
 #   Ask.chat("Stream this") { |chunk| puts chunk.content }
 #
+# With a named definition:
+#
+#   Ask.chat("Check health", name: "health_check")
+#   Ask.chat("Check health", name: "health_check", model: "claude-sonnet-4")
+#
 module Ask
-  def self.chat(message, model: nil, system_prompt: nil, &block)
-    session = Agent::Session.new(
-      model: model || Agent.configuration.default_model,
-      system_prompt: system_prompt
-    )
+  def self.chat(message, name: nil, model: nil, system_prompt: nil, &block)
+    session = if name
+      overrides = {}
+      overrides[:model] = model if model
+      overrides[:system_prompt] = system_prompt if system_prompt
+      Agent.new(name, **overrides)
+    else
+      Agent::Session.new(
+        model: model || Agent.configuration.default_model,
+        system_prompt: system_prompt
+      )
+    end
     if block
       session.run(message, &block)
     else

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-agent
 version: !ruby/object:Gem::Version
-  version: 0.40.16
+  version: 0.40.18
 platform: ruby
 authors:
 - Kaka Ruto
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.11.4
+        version: 0.12.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.11.4
+        version: 0.12.0
 - !ruby/object:Gem::Dependency
   name: ask-state-providers
   requirement: !ruby/object:Gem::Requirement