ask-agent 0.25.2 → 0.25.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d6d5dd31344228811bd4c7993547c9e0f9d7c39c779f58250d82ad95f271bd7d
-  data.tar.gz: ba08c57e9fc7dfc410e6a835ffab1076d1f4b5704bee866f7a38e158da712d34
+  metadata.gz: ec5991dad0128d2383500176d9872d4fda5ac504f81826eeac343a1b8435616b
+  data.tar.gz: f62dd7104119cd637c2ca590bc8c3e7c7c6c32e8f85d2d0e7e2cc2cbd2e8b019
 SHA512:
-  metadata.gz: 5d46b653b22b50dee9597238cc65ce5fe72c3840322e1ecd03efccfe6494a4494bff473f3bc3c4eff1ae56df849142a45f52bc77e23c9a93a9c240f465d7db68
-  data.tar.gz: 9c158ab0aa0be906723681458ea54d90b15cd7289647e7acb8527faf367ead4490919a84b0a2e71186b4b93945ac065db063a33ead26b2532d0d50efd2dd8bf3
+  metadata.gz: 0ea8e0cf1e8750265f971b7379db7fddbc8c425d7f765835bc1d2b23e0fdf79001b2ceb93cc70e5647999e4327f6aa0ae3e56ed6708cdd8c66ea8e0006ddb039
+  data.tar.gz: bd758b33c296cd20fd90429d269fb079b5a1501b074c854d1dcfe27c007c2234b509693e7a136abf801738c775ed7c64894e2e2bc7c7414499f14ec2bbd6b416

data/CHANGELOG.md

@@ -1,3 +1,23 @@
+## [0.25.3] - 2026-08-04
+
+### Fixed
+
+- **Tools now respect the session's `parallel_tools` setting.** The agent
+  loop dispatched tool calls straight to `execute_parallel`, so tools always
+  ran in worker threads — even with `parallel_tools: false`. Sequential
+  sessions now run tools in the caller thread, which is what frameworks
+  like Rails rely on for per-request context (`CurrentAttributes` are
+  thread-local). The loop calls `ToolExecutor#execute`, which honors the
+  executor's `parallel` flag.
+- **Parallel tool threads inherit the caller's thread-local state.** When
+  tools do run in threads (parallel mode), `execute_parallel` copies the
+  caller's `Thread.current` locals into each worker thread first, so
+  per-request context (Rails `CurrentAttributes`, log tags, etc.) reaches
+  the tools instead of being nil.
+- `ToolExecutor#execute` accepts a `result_callback:` kwarg (invoked per
+  completed tool in both sequential and parallel modes); sequential
+  execution reports results through it too, matching parallel behavior.
+
 ## [0.25.2] - 2026-08-03
 
 ### Fixed

data/lib/ask/agent/context_source.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+require "time"
 
 module Ask
   module Agent

data/lib/ask/agent/context_sources.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+require "time"
 
 module Ask
   module Agent

data/lib/ask/agent/extensions/audit_log/active_record_writer.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+require "time"
 
 module Ask
   module Agent

data/lib/ask/agent/extensions/audit_log.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require "json"
+require "time"
 
 module Ask
   module Agent

data/lib/ask/agent/loop.rb

@@ -79,12 +79,17 @@ module Ask
 
         if user_tool_calls.any?
           # Execute user tool calls locally
-          user_results = tool_executor.execute_parallel(
-            user_tool_calls, tools, hooks, event_emitter, ToolAbortController.new
-          ) do |tool_call_id, result|
-            tc = user_tool_calls[tool_call_id]
-            chat.add_message(role: :tool, content: result[:message].to_s, tool_call_id: tool_call_id) if tc
-          end
+          # Respect the session's parallel_tools setting: parallel tools run
+          # in threads (with the caller's thread-local context inherited);
+          # sequential tools run in the caller thread so per-request context
+          # (e.g. Rails CurrentAttributes) is visible without any copying.
+          user_results = tool_executor.execute(
+            user_tool_calls, tools, hooks: hooks, event_emitter: event_emitter,
+            result_callback: lambda do |tool_call_id, result|
+              tc = user_tool_calls[tool_call_id]
+              chat.add_message(role: :tool, content: result[:message].to_s, tool_call_id: tool_call_id) if tc
+            end
+          )
           all_tool_results.concat(user_results)
         end
 

data/lib/ask/agent/meta_agent.rb

@@ -2,6 +2,7 @@
 
 require "set"
 require "json"
+require "time"
 
 module Ask
   module Agent

data/lib/ask/agent/telemetry.rb

@@ -3,6 +3,7 @@
 require "fileutils"
 require "json"
 require "securerandom"
+require "time"
 
 module Ask
   module Agent

data/lib/ask/agent/tool_executor.rb

@@ -19,7 +19,7 @@ module Ask
 
       attr_writer :telemetry
 
-      def execute(tool_calls, tools, hooks:, event_emitter:, session_id: nil)
+      def execute(tool_calls, tools, hooks:, event_emitter:, session_id: nil, result_callback: nil)
         return [] if tool_calls.empty?
 
         @total_executions = 0
@@ -27,9 +27,11 @@ module Ask
         sibling_abort = ToolAbortController.new
 
         if @parallel
-          execute_parallel(tool_calls, tools, hooks, event_emitter, sibling_abort)
+          execute_parallel(tool_calls, tools, hooks, event_emitter, sibling_abort, &result_callback)
         else
-          execute_sequential(tool_calls, tools, hooks, event_emitter, sibling_abort)
+          execute_sequential(tool_calls, tools, hooks, event_emitter, sibling_abort) do |id, result|
+            result_callback&.call(id, result)
+          end
         end
       end
 
@@ -38,8 +40,15 @@ module Ask
         mutex = Mutex.new
         results = {}
 
+        # Inherit the caller's thread-local state (Rails CurrentAttributes
+        # and similar frameworks store per-request context in Thread.current)
+        # so tools see the same context they would in a sequential run.
+        inherited_locals = {}
+        Thread.current.keys.each { |key| inherited_locals[key] = Thread.current[key] }
+
         tool_calls.each do |id, tool_call|
           threads << Thread.new do
+            inherited_locals.each { |key, value| Thread.current[key] = value }
             begin
               if sibling_abort.aborted?
                 mutex.synchronize { results[id] = aborted_result(tool_call) }
@@ -75,13 +84,14 @@ module Ask
         tool_calls.keys.map { |id| results[id] }.compact
       end
 
-      def execute_sequential(tool_calls, tools, hooks, event_emitter, sibling_abort)
+      def execute_sequential(tool_calls, tools, hooks, event_emitter, sibling_abort, &result_callback)
         results = []
         tool_calls.each do |id, tool_call|
           break if sibling_abort.aborted?
 
           result = execute_single_tool(tool_call, tools, hooks, event_emitter, sibling_abort)
           results << result
+          result_callback&.call(id, result)
           break if result[:critical_failure]
           break if result[:halted]
         end

data/lib/ask/agent/version.rb

@@ -2,6 +2,6 @@
 
 module Ask
   module Agent
-    VERSION = "0.25.2"
+    VERSION = "0.25.3"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ask-agent
 version: !ruby/object:Gem::Version
-  version: 0.25.2
+  version: 0.25.3
 platform: ruby
 authors:
 - Kaka Ruto