asin 1.1.2 → 2.0.0

data/spec/lib/config_spec.rb

@@ -8,31 +8,31 @@ module ASIN
       end
 
       it "should fail with wrong configuration key" do
-        lambda { @helper.configure :wrong => 'key' }.should raise_error(ArgumentError)
+        expect(lambda { @helper.configure :wrong => 'key' }).to raise_error(ArgumentError)
       end
 
       it "should not override the configuration" do
         config = @helper.configure :key => 'wont get overridden'
-        config.key.should_not be_nil
+        expect(config.key).to_not be_nil
 
         config = @helper.configure :secret => 'is also set'
-        config.key.should_not be_nil
-        config.secret.should_not be_nil
+        expect(config.key).to_not be_nil
+        expect(config.secret).to_not be_nil
       end
 
       it "should work with a configuration block" do
         conf = ASIN::Configuration.configure do |config|
           config.key = 'bla'
         end
-        conf.key.should eql('bla')
+        expect(conf.key).to eql('bla')
       end
 
       it "should read configuration from yml" do
         config = ASIN::Configuration.configure :yaml => 'spec/asin.yml'
-        config.secret.should eql('secret_yml')
-        config.key.should eql('key_yml')
-        config.host.should eql('host_yml')
-        config.logger.should eql('logger_yml')
+        expect(config.secret).to eql('secret_yml')
+        expect(config.key).to eql('key_yml')
+        expect(config.host).to eql('host_yml')
+        expect(config.logger).to eql('logger_yml')
       end
 
       it "should read configuration from yml with block" do
@@ -40,8 +40,8 @@ module ASIN
           config.secret = nil
           config.key = yml['secret']
         end
-        conf.secret.should be_nil
-        conf.key.should eql('secret_yml')
+        expect(conf.secret).to be_nil
+        expect(conf.key).to eql('secret_yml')
       end
     end
   end

data/spec/lib/search_spec.rb

@@ -10,84 +10,95 @@ module ASIN
 
       it "should lookup a book", :vcr do
         items = @helper.lookup(ANY_ASIN)
-        items.first.title.should =~ /Learn Objective/
+        expect(items.first.title).to match(/Learn Objective/)
       end
 
       it "should have metadata", :vcr do
         items = @helper.lookup(ANY_ASIN, :ResponseGroup => :Medium)
         item = items.first
-        item.asin.should eql(ANY_ASIN)
-        item.title.should =~ /Learn Objective/
-        item.amount.should eql(3999)
-        item.details_url.should eql("http://www.amazon.com/Learn-Objective-C-Mac-Series/dp/1430218150%3FSubscriptionId%3DAKIAIBNLWSCV5OXMPD6A%26tag%3Dphoet-20%26linkCode%3Dxm2%26camp%3D2025%26creative%3D165953%26creativeASIN%3D1430218150")
-        item.image_url.should eql("http://ecx.images-amazon.com/images/I/41kq5bDvnUL.jpg")
-        item.review.should =~ /Take your coding skills to the next level/
+        expect(item.asin).to eql(ANY_ASIN)
+        expect(item.title).to match(/Learn Objective/)
+        expect(item.sales_rank).to eql('209840')
+        expect(item.amount).to eql(3999)
+        expect(item.details_url).to eql("http://www.amazon.com/Learn-Objective-C-Mac-Series/dp/1430218150%3FSubscriptionId%3DAKIAIBNLWSCV5OXMPD6A%26tag%3Dphoet-20%26linkCode%3Dxm2%26camp%3D2025%26creative%3D165953%26creativeASIN%3D1430218150")
+        expect(item.image_url).to eql("http://ecx.images-amazon.com/images/I/41kq5bDvnUL.jpg")
+        expect(item.review).to match(/Take your coding skills to the next level/)
+
+        # <ItemAttributes>
+        expect(item.item_height).to       eql("925")
+        expect(item.item_length).to       eql("752")
+        expect(item.item_width).to        eql("71")
+        expect(item.item_weight).to       eql("137")
+        expect(item.package_height).to    eql("102")
+        expect(item.package_length).to    eql("921")
+        expect(item.package_width).to     eql("701")
+        expect(item.package_weight).to    eql("123")
+        expect(item.author.count).to      eql(2)
+        expect(item.author.first).to      eql("Scott Knaster")
+        expect(item.binding).to           eql("Paperback")
+        expect(item.brand).to             eql("Apress")
+        expect(item.ean).to               eql("9781430218159")
+        expect(item.edition).to           eql("1")
+        expect(item.isbn).to              eql("1430218150")
+        expect(item.label).to             eql("Apress")
+        expect(item.language).to          eql("English")
+        expect(item.formatted_price).to   eql("$39.99")
+        expect(item.manufacturer).to      eql("Apress")
+        expect(item.mpn).to               eql("978-1-4302-1815-9")
+        expect(item.page_count).to        eql("360")
+        expect(item.part_number).to       eql("978-1-4302-1815-9")
+        expect(item.product_group).to     eql("Book")
+        expect(item.publication_date).to  eql("2009-01-07")
+        expect(item.publisher).to         eql("Apress")
+        expect(item.sku).to               eql("mon0001920250")
+        expect(item.studio).to            eql("Apress")
+
+        # <OfferSummary>
+        expect(item.total_new).to eql("56")
+        expect(item.total_used).to eql("62")
       end
 
       it "should lookup multiple response groups", :vcr do
         items = @helper.lookup(ANY_ASIN, :ResponseGroup => [:Small, :AlternateVersions])
 
         item = items.first
-        item.asin.should eql(ANY_ASIN)
-        item.title.should =~ /Learn Objective/
+        expect(item.asin).to eql(ANY_ASIN)
+        expect(item.title).to match(/Learn Objective/)
       end
 
       it "should lookup multiple books", :vcr do
         items = @helper.lookup(ANY_ASIN, ANY_OTHER_ASIN)
 
-        items.last.title.should =~ /Beginning iPhone Development/
-        items.first.title.should =~ /Learn Objective-C/
-      end
-
-      it "should return a custom item class", :vcr do
-        module TEST
-          class TestItem
-            attr_accessor :testo
-            def initialize(hash)
-              @testo = hash
-            end
-          end
-        end
-        @helper.configure :item_type => TEST::TestItem
-        @helper.lookup(ANY_ASIN).first.testo.should_not be_nil
-      end
-
-      it "should return a raw value", :vcr do
-        @helper.configure :item_type => :raw
-        @helper.lookup(ANY_ASIN).first['ItemAttributes']['Title'].should_not be_nil
-      end
-
-      it "should return a mash value", :vcr do
-        @helper.configure :item_type => :mash
-        @helper.lookup(ANY_ASIN).first.ItemAttributes.Title.should_not be_nil
+        expect(items.last.title).to match(/Beginning iPhone Development/)
+        expect(items.first.title).to match(/Learn Objective-C/)
       end
 
       it "should search_keywords and handle a single result", :vcr do
         items = @helper.search_keywords('0471317519')
-        items.first.title.should =~ /A Self-Teaching Guide/
+        expect(items.first.title).to match(/A Self-Teaching Guide/)
       end
 
       it "should search_keywords a book with fulltext", :vcr do
         items = @helper.search_keywords 'Learn', 'Objective-C'
-        items.should have(10).things
-        items.first.title.should =~ /Learn Objective-C /
+        expect(items).to have(10).things
+        expect(items.first.title).to match(/Learn Objective-C /)
       end
 
       it "should search_keywords never mind music", :vcr do
         items = @helper.search_keywords 'nirvana', 'never mind', :SearchIndex => :Music
-        items.should have(10).things
-        items.map(&:title).join.should =~ /Nevermind/
+        expect(items).to have(10).things
+        expect(items.map(&:title).join).to match(/Nevermind/)
       end
 
       it "should search music", :vcr do
         items = @helper.search :SearchIndex => :Music
-        items.should have(0).things
+        expect(items).to have(0).things
       end
 
       it "should search never mind music", :vcr do
         items = @helper.search :Keywords => 'nirvana', :SearchIndex => :Music
-        items.should have(10).things
-        items.map(&:title).join.should =~ /Nevermind/
+        expect(items).to have(10).things
+        expect(items.map(&:title).join).to match(/Nevermind/)
       end
     end
   end

data/spec/lib/similarity_spec.rb

@@ -10,14 +10,14 @@ module ASIN
 
       it "should find similar items", :vcr do
         items = @helper.similar(ANY_ASIN)
-        items.should have(10).elements
-        items.first.title.should =~ /Programming in Objective-C/
+        expect(items).to have(10).elements
+        expect(items.first.title).to match(/Programming in Objective-C/)
       end
 
       it "should find similar items for multiple asins and different config", :vcr do
         items = @helper.similar(ANY_ASIN, ANY_OTHER_ASIN, :SimilarityType => :Intersection, :ResponseGroup => :Small)
-        items.should have(4).elements
-        items.first.title.should =~ /Beginning iOS 5 Development/
+        expect(items).to have(4).elements
+        expect(items.first.title).to match(/Beginning iOS 5 Development/)
       end
     end
   end

data/spec/spec_helper.rb

@@ -5,10 +5,14 @@ unless Net.const_defined? :HTTPSession
   class Net::HTTPSession < Net::HTTP::HTTPSession; end
 end
 
+require 'coveralls'
+Coveralls.wear!
+
+require 'pry' unless defined? JRUBY_VERSION
 require 'rspec'
 require 'asin'
 require 'asin/client' # is somehow needed for jruby
-require 'pry'
+require 'asin/adapter'
 require 'httpclient'
 require 'vcr'
 require 'httpi'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: asin
 version: !ruby/object:Gem::Version
-  version: 1.1.2
+  version: 2.0.0
 platform: ruby
 authors:
 - Peter Schröder
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-08 00:00:00.000000000 Z
+date: 2014-03-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: crack
@@ -38,6 +38,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '1.1'
+- !ruby/object:Gem::Dependency
+  name: rash
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0.4'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0.4'
 - !ruby/object:Gem::Dependency
   name: httpi
   requirement: !ruby/object:Gem::Requirement
@@ -136,20 +150,6 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 2.11.0
-- !ruby/object:Gem::Dependency
-  name: pry
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.9.9
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ~>
-      - !ruby/object:Gem::Version
-        version: 0.9.9
 description: Amazon Simple INterface - Support for ItemLookup, SimilarityLookup, Search,
   BrowseNode and Cart Operations.
 email:
@@ -160,7 +160,8 @@ extra_rdoc_files: []
 files:
 - .document
 - .gitignore
-- .rvmrc
+- .irbrc
+- .rspec
 - .travis.yml
 - CHANGELOG.md
 - Gemfile
@@ -168,11 +169,9 @@ files:
 - README.md
 - asin.gemspec
 - lib/asin.rb
+- lib/asin/adapter.rb
 - lib/asin/client.rb
 - lib/asin/configuration.rb
-- lib/asin/simple_cart.rb
-- lib/asin/simple_item.rb
-- lib/asin/simple_node.rb
 - lib/asin/version.rb
 - rakefile.rb
 - spec/asin.yml
@@ -221,7 +220,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: asin
-rubygems_version: 2.0.0
+rubygems_version: 2.0.3
 signing_key: 
 specification_version: 4
 summary: Amazon Simple INterface - Support for ItemLookup, SimilarityLookup, Search,

data/lib/asin/simple_cart.rb

@@ -1,54 +0,0 @@
-require 'hashie'
-
-module ASIN
-
-  # = SimpleCart
-  #
-  # The +SimpleCart+ class is a wrapper for the Amazon XML-REST-Response.
-  #
-  # A Hashie::Mash is used for the internal data representation and can be accessed over the +raw+ attribute.
-  #
-  class SimpleCart
-
-    attr_reader :raw
-
-    def initialize(hash)
-      @raw = Hashie::Mash.new(hash)
-    end
-
-    def cart_id
-      @raw.CartId
-    end
-
-    def hmac
-      @raw.HMAC
-    end
-
-    def url
-      @raw.PurchaseURL
-    end
-
-    def price
-      @raw.SubTotal.FormattedPrice
-    end
-
-    def items
-      return [] unless @raw.CartItems
-      @raw.CartItems.CartItem.is_a?(Array) ? @raw.CartItems.CartItem : [@raw.CartItems.CartItem]
-    end
-
-    def saved_items
-      return [] unless @raw.SavedForLaterItems
-      @raw.SavedForLaterItems.SavedForLaterItem.is_a?(Array) ? @raw.SavedForLaterItems.SavedForLaterItem : [@raw.SavedForLaterItems.SavedForLaterItem]
-    end
-
-    def valid?
-      @raw.Request.IsValid == 'True'
-    end
-
-    def empty?
-      @raw.CartItems.nil?
-    end
-
-  end
-end

data/lib/asin/simple_item.rb

@@ -1,44 +0,0 @@
-require 'hashie'
-
-module ASIN
-
-  # =SimpleItem
-  #
-  # The +SimpleItem+ class is a wrapper for the Amazon XML-REST-Response.
-  #
-  # A Hashie::Mash is used for the internal data representation and can be accessed over the +raw+ attribute.
-  #
-  class SimpleItem
-
-    attr_reader :raw
-
-    def initialize(hash)
-      @raw = Hashie::Mash.new(hash)
-    end
-
-    def asin
-      @raw.ASIN
-    end
-
-    def title
-      @raw.ItemAttributes!.Title
-    end
-
-    def amount
-      @raw.ItemAttributes!.ListPrice!.Amount.to_i
-    end
-
-    def details_url
-      @raw.DetailPageURL
-    end
-
-    def review
-       @raw.EditorialReviews!.EditorialReview!.Content
-    end
-
-    def image_url
-      @raw.LargeImage!.URL
-    end
-  end
-
-end

data/lib/asin/simple_node.rb

@@ -1,44 +0,0 @@
-require 'hashie'
-
-module ASIN
-
-  # =SimpleNode
-  #
-  # The +SimpleNode+ class is a wrapper for the Amazon XML-REST-Response.
-  #
-  # A Hashie::Mash is used for the internal data representation and can be accessed over the +raw+ attribute.
-  #
-  class SimpleNode
-
-    attr_reader :raw
-
-    def initialize(hash)
-      @raw = Hashie::Mash.new(hash)
-    end
-
-    def name
-      @raw.Name
-    end
-
-    def node_id
-      @raw.BrowseNodeId
-    end
-
-    def children
-      return [] unless @raw.Children
-      @raw.Children.BrowseNode.is_a?(Array) ? @raw.Children.BrowseNode : [@raw.Children.BrowseNode]
-    end
-
-    def ancestors
-      return [] unless @raw.Ancestors
-      @raw.Ancestors.BrowseNode.is_a?(Array) ? @raw.Ancestors.BrowseNode : [@raw.Ancestors.BrowseNode]
-    end
-
-    def top_item_set
-      return [] unless @raw.TopItemSet
-      @raw.TopItemSet.TopItem.is_a?(Array) ? @raw.TopItemSet.TopItem : [@raw.TopItemSet.TopItem]
-    end
-
-  end
-
-end