ashmont 0.11.0 → 0.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 2f6ca58a042c682e1897e0c7036a559cba64d843
-  data.tar.gz: 43f0ec1f2702b8f5878e7da24744cba7b047440d
+  metadata.gz: c90dea55b8adcbac2014088d175f82e2a0a385a5
+  data.tar.gz: 3a6953e23e57801dd221bec59fbde18e2cb57e73
 SHA512:
-  metadata.gz: 01c453adb9c23b7f08f46e5bcdfc65b09305b1992b22ff587b36ff9dc9834177db83e17490571352dcd381f62ce8c2f16926c87dab083cd7123d43b89705db52
-  data.tar.gz: cc9d490e0004ae7fce9d7e12f7a4149d8d3238ca4e65e37f3893de43e86ff267e227c32c81c0cccdb041219a7864b514d7c65a6c92ec03fee6bcc9bd0c771faa
+  metadata.gz: 320322cb4bd27c2ad4661f8003d227d5ff15985974f14b0d61a844aefcaf55f0d5e3d1c3c292b46347fd6d936a37a6c272c4f254e10c22ade16bd5e12292be6f
+  data.tar.gz: 3539cd26e86cd6300c804e4e0d988781f38a9de3225b8b55abf7897832268bb0108c91f5beec676d952efa7053fd3bd534d34eaad7153e8cb7f9406c076f2cc3

data/CHANGELOG.md

@@ -1,3 +1,6 @@
+##v0.11.1
+* ADDED: #primary_payment_account to Customer to get the first primary_payment_method
+
 ## v0.11.0
 * ADDED: #primary_payment_method to Customer to choose between credit cards and paypal
 

data/lib/ashmont/customer.rb

@@ -12,7 +12,9 @@ module Ashmont
     end
 
     def credit_card
+      # old way
       credit_cards[0]
+      # primary_payment_account # too general
     end
 
     def credit_cards
@@ -37,19 +39,18 @@ module Ashmont
     
     def primary_payment_method
       #currently, usually there is only one payment method, paypal or credit_card
-      payment_methods = { credit_cards.count => :credit_cards, 
-                          paypal_accounts.count => :paypal_accounts }
-      chosen_method = (payment_methods[payment_methods.keys.max])
-      remote_customer.send(chosen_method)
-    end
-    
-    def primary_payment_account
       if persisted?
-        primary_payment_method[]
+        payment_methods = { credit_cards.count => :credit_cards, 
+                            paypal_accounts.count => :paypal_accounts }
+        chosen_method = (payment_methods[payment_methods.keys.max])
+        remote_customer.send(chosen_method)
       else
         []
       end
-      
+    end
+    
+    def primary_payment_account
+        primary_payment_method[0]
     end
     
     def has_billing_info?

data/lib/ashmont/version.rb

@@ -1,3 +1,3 @@
 module Ashmont
-  VERSION = "0.11.0"
+  VERSION = "0.11.1"
 end

data/spec/ashmont/customer_spec.rb

@@ -2,27 +2,83 @@ require 'spec_helper'
 require 'ashmont/customer'
 
 describe Ashmont::Customer do
-  
-  it 'chooses paypal_accounts as the primary_payment_method when the customer does' do
-    token = "xyz"
-    remote_customer = stub("customer", :paypal_accounts => ["first", "second"], :credit_cards => [])
-    Braintree::Customer.stubs(:find => remote_customer)
+  describe '#primaray_payment_method' do
+    it 'chooses paypal_accounts as the primary_payment_method when the customer does' do
+      token = "xyz"
+      remote_customer = stub("customer", :paypal_accounts => ["first", "second"], :credit_cards => [])
+      Braintree::Customer.stubs(:find => remote_customer)
 
-    result = Ashmont::Customer.new(token).primary_payment_method
+      result = Ashmont::Customer.new(token).primary_payment_method
 
-    expect(Braintree::Customer).to have_received(:find).with(token)
-    expect(result).to eq(["first", "second"])    
+      expect(Braintree::Customer).to have_received(:find).with(token)
+      expect(result).to eq(["first", "second"])    
+    end
+
+    it 'chooses credit_cards as the primary_payment_method when the customer does' do
+      token = "xyz"
+      remote_customer = stub("customer", :paypal_accounts => [], :credit_cards => ["first", "second"])
+      Braintree::Customer.stubs(:find => remote_customer)
+
+      result = Ashmont::Customer.new(token).primary_payment_method
+
+      expect(Braintree::Customer).to have_received(:find).with(token)
+      expect(result).to eq(["first", "second"])    
+    end
   end
+  
+  describe '#primary_payment_account' do
+    it 'returns the first account of the primary_payment_method when it is paypal' do
+      token = "xyz"
+      remote_customer = stub("customer", :paypal_accounts => ["first", "second"], :credit_cards => [])
+      Braintree::Customer.stubs(:find => remote_customer)
 
-  it 'chooses credit_cards as the primary_payment_method when the customer does' do
-    token = "xyz"
-    remote_customer = stub("customer", :paypal_accounts => [], :credit_cards => ["first", "second"])
-    Braintree::Customer.stubs(:find => remote_customer)
+      result = Ashmont::Customer.new(token).primary_payment_account
 
-    result = Ashmont::Customer.new(token).primary_payment_method
+      expect(Braintree::Customer).to have_received(:find).with(token)
+      expect(result).to eq("first")
+    end
 
-    expect(Braintree::Customer).to have_received(:find).with(token)
-    expect(result).to eq(["first", "second"])    
+    it 'returns the first account of the primary_payment_method when it is a credit card' do
+      token = "xyz"
+      remote_customer = stub("customer", :paypal_accounts => [], :credit_cards => ["first", "second"])
+      Braintree::Customer.stubs(:find => remote_customer)
+
+      result = Ashmont::Customer.new(token).primary_payment_account
+
+      expect(Braintree::Customer).to have_received(:find).with(token)
+      expect(result).to eq("first")
+    end
+
+    it 'when the payment account is a credit card, it returns credit card attributes' do
+      token = "xyz"
+      first_credit_card_attributes = { token: "3328xj", 
+        billing_address: nil, 
+        bin: "411111", 
+        card_type: "Visa", 
+        cardholder_name: nil, 
+        customer_id: "898484653", 
+        expiration_month: "12", 
+        expiration_year: "2021", 
+        last_4: "1111", 
+        prepaid: "Unknown", 
+        payroll: "Unknown", 
+        product_id: "Unknown", 
+        commercial: "Unknown", 
+        debit: "Unknown", 
+        durbin_regulated: "Unknown", 
+        healthcare: "Unknown", 
+        country_of_issuance: "Unknown", 
+        issuing_bank: "Unknown", 
+        image_url: "https://assets.braintreegateway.com/payment_method_logo/visa.png?environment=sandbox"
+      }
+      remote_customer = stub("customer", :paypal_accounts => [], :credit_cards => [first_credit_card_attributes, "second"])
+      Braintree::Customer.stubs(:find => remote_customer)
+
+      result = Ashmont::Customer.new(token).primary_payment_account
+
+      expect(Braintree::Customer).to have_received(:find).with(token)
+      expect(result).to eq(first_credit_card_attributes)              
+    end
   end
 
   it "returns all paypal accounts" do
@@ -51,7 +107,7 @@ describe Ashmont::Customer do
 
   it "returns its first credit card" do
     token = "xyz"
-    remote_customer = stub("customer", :credit_cards => ["first", "second"])
+    remote_customer = stub("customer", :credit_cards => ["first", "second"], :paypal_accounts => [])
     Braintree::Customer.stubs(:find => remote_customer)
 
     result = Ashmont::Customer.new(token).credit_card

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ashmont
 version: !ruby/object:Gem::Version
-  version: 0.11.0
+  version: 0.11.1
 platform: ruby
 authors:
 - thoughtbot