ashikawa-core 0.11.0 → 0.12.0

data/spec/unit/configuration_spec.rb

@@ -3,12 +3,12 @@ require 'unit/spec_helper'
 require 'ashikawa-core/configuration'
 
 describe Ashikawa::Core::Configuration do
-  let(:url) { double }
-  let(:logger) { double }
-  let(:adapter) { double }
-  let(:connection) { double }
-  let(:username) { double }
-  let(:password) { double }
+  let(:url) { 'http://localhost:8530' }
+  let(:logger) { instance_double('Logger') }
+  let(:adapter) { double('Adapter') }
+  let(:connection) { instance_double('Ashikawa::Core::Connection') }
+  let(:username) { 'jeff' }
+  let(:password) { 'bowling!' }
 
   its(:url) { should be_nil }
   its(:logger) { should be_nil }
@@ -38,7 +38,7 @@ describe Ashikawa::Core::Configuration do
 
     it 'should construct a connection' do
       expect(Ashikawa::Core::Connection).to receive(:new)
-        .with(url, { logger: logger, adapter: adapter })
+        .with(url, '_system', { logger: logger, adapter: adapter })
         .and_return(connection)
       expect(subject.connection).to be connection
     end
@@ -55,7 +55,7 @@ describe Ashikawa::Core::Configuration do
 
     it 'should construct a connection' do
       expect(Ashikawa::Core::Connection).to receive(:new)
-        .with(url, {})
+        .with(url, '_system', {})
         .and_return(connection)
       expect(subject.connection).to be connection
     end

data/spec/unit/connection_spec.rb

@@ -5,14 +5,24 @@ require 'ashikawa-core/connection'
 describe Ashikawa::Core::Connection do
   let(:request_stub) { Faraday::Adapter::Test::Stubs.new }
   let(:response_headers) { { 'content-type' => 'application/json; charset=utf-8' } }
-  subject { Ashikawa::Core::Connection.new(ARANGO_HOST, adapter: [:test, request_stub]) }
+  let(:options) { instance_double('Hash') }
+  subject { Ashikawa::Core::Connection.new(ARANGO_HOST, '_system', adapter: [:test, request_stub]) }
 
   its(:scheme) { should eq('http') }
   its(:host) { should eq('localhost') }
   its(:port) { should eq(8529) }
 
+  describe 'initialization' do
+    it 'should create the Faraday connection using FaradayFactory' do
+      options = double('Options')
+      expect(Ashikawa::Core::FaradayFactory).to receive(:create_connection)
+        .with('http://localhost:8529/_db/my_db/_api', options)
+      Ashikawa::Core::Connection.new('http://localhost:8529', 'my_db', options)
+    end
+  end
+
   it 'should send a get request' do
-    request_stub.get('/_api/my/path') do
+    request_stub.get('/_db/_system/_api/my/path') do
       [200, response_headers, JSON.generate({ 'name' => 'dude' })]
     end
 
@@ -22,7 +32,7 @@ describe Ashikawa::Core::Connection do
   end
 
   it 'should send a post request' do
-    request_stub.post('/_api/my/path') do |request|
+    request_stub.post('/_db/_system/_api/my/path') do |request|
       expect(request[:body]).to eq("{\"name\":\"new_collection\"}")
       [200, response_headers, JSON.generate({ 'name' => 'dude' })]
     end
@@ -32,7 +42,7 @@ describe Ashikawa::Core::Connection do
   end
 
   it 'should send a put request' do
-    request_stub.put('/_api/my/path') do |request|
+    request_stub.put('/_db/_system/_api/my/path') do |request|
       expect(request[:body]).to eq('{"name":"new_collection"}')
       [200, response_headers, JSON.generate({ 'name' => 'dude' })]
     end
@@ -42,7 +52,7 @@ describe Ashikawa::Core::Connection do
   end
 
   it 'should send a delete request' do
-    request_stub.delete('/_api/my/path') do |_|
+    request_stub.delete('/_db/_system/_api/my/path') do |_|
       [200, response_headers, JSON.generate({ 'name' => 'dude' })]
     end
 
@@ -53,12 +63,11 @@ describe Ashikawa::Core::Connection do
   context 'with database suffix' do
     let(:database_name) { 'ashikawa' }
     subject do
-      Ashikawa::Core::Connection.new("#{ARANGO_HOST}/_db/#{database_name}", adapter: [:test, request_stub])
+      Ashikawa::Core::Connection.new(ARANGO_HOST, database_name, adapter: [:test, request_stub])
     end
 
     its(:database_name) { should eq database_name }
 
-    let(:options) { double('Options') }
     it 'should be able to send a request without database suffix' do
       expect(subject).to receive(:send_request)
         .with("#{ARANGO_HOST}/_api/some_endpoint", options)
@@ -69,11 +78,10 @@ describe Ashikawa::Core::Connection do
 
   context 'without database suffix' do
     subject do
-      Ashikawa::Core::Connection.new(ARANGO_HOST, adapter: [:test, request_stub])
+      Ashikawa::Core::Connection.new(ARANGO_HOST, '_system', adapter: [:test, request_stub])
     end
 
     its(:database_name) { should eq '_system' }
-    let(:options) { double('Options') }
     it 'should be able to send a request without database suffix' do
       expect(subject).to receive(:send_request)
         .with("#{ARANGO_HOST}/_api/some_endpoint", options)
@@ -95,7 +103,7 @@ describe Ashikawa::Core::Connection do
     it 'should send the authentication data with every GET request' do
       skip 'Find out how to check for basic auth via Faraday Stubs'
 
-      request_stub.get('/_api/my/path') do |_|
+      request_stub.get('/_db/_system/_api/my/path') do |_|
         [200, response_headers, JSON.generate({ 'name' => 'dude' })]
       end
 
@@ -111,7 +119,8 @@ describe Ashikawa::Core::Connection do
     let(:error_num) { 15 }
 
     it "should throw a general client error for I'm a teapot" do
-      request_stub.get('/_api/bad/request') do
+
+      request_stub.get('/_db/_system/_api/bad/request') do
         [
           418,
           response_headers,
@@ -127,7 +136,7 @@ describe Ashikawa::Core::Connection do
     end
 
     it 'should throw its own exception when doing a bad request' do
-      request_stub.get('/_api/bad/request') do
+      request_stub.get('/_db/_system/_api/bad/request') do
         [400, response_headers, '{}']
       end
 
@@ -139,7 +148,7 @@ describe Ashikawa::Core::Connection do
     end
 
     it 'should throw its own exception when doing a bad request' do
-      request_stub.get('/_api/secret') do
+      request_stub.get('/_db/_system/_api/secret') do
         [401, response_headers, '']
       end
 
@@ -151,7 +160,7 @@ describe Ashikawa::Core::Connection do
     end
 
     it 'should throw a general server error for the generic server error' do
-      request_stub.get('/_api/bad/request') do
+      request_stub.get('/_db/_system/_api/bad/request') do
         [
           500,
           response_headers,
@@ -167,7 +176,7 @@ describe Ashikawa::Core::Connection do
     end
 
     it 'should raise an exception if a document is not found' do
-      request_stub.get('/_api/document/4590/333') do
+      request_stub.get('/_db/_system/_api/document/4590/333') do
         [404, response_headers, '']
       end
 
@@ -177,7 +186,7 @@ describe Ashikawa::Core::Connection do
     end
 
     it 'should raise an exception if a collection is not found' do
-      request_stub.get('/_api/collection/4590') do
+      request_stub.get('/_db/_system/_api/collection/4590') do
         [404, response_headers, '']
       end
 
@@ -187,7 +196,7 @@ describe Ashikawa::Core::Connection do
     end
 
     it 'should raise an exception if an index is not found' do
-      request_stub.get('/_api/index/4590/333') do
+      request_stub.get('/_db/_system/_api/index/4590/333') do
         [404, response_headers, '']
       end
 
@@ -197,7 +206,7 @@ describe Ashikawa::Core::Connection do
     end
 
     it 'should raise an exception for unknown pathes' do
-      request_stub.get('/_api/unknown_path/4590/333') do
+      request_stub.get('/_db/_system/_api/unknown_path/4590/333') do
         [404, response_headers, '']
       end
 
@@ -207,7 +216,7 @@ describe Ashikawa::Core::Connection do
     end
 
     it 'should raise an error if a malformed JSON was returned from the server' do
-      request_stub.get('/_api/document/4590/333') do
+      request_stub.get('/_db/_system/_api/document/4590/333') do
         [200, response_headers, '{"a":1']
       end
 
@@ -216,33 +225,4 @@ describe Ashikawa::Core::Connection do
       request_stub.verify_stubbed_calls
     end
   end
-
-  describe 'initializing Faraday' do
-    subject { Ashikawa::Core::Connection }
-    let(:adapter) { double('Adapter') }
-    let(:logger) { double('Logger') }
-    let(:blocky) { double('Block') }
-
-    it 'should initalize with specific logger and adapter' do
-      expect(Faraday).to receive(:new).with("#{ARANGO_HOST}/_api").and_yield(blocky)
-      expect(blocky).to receive(:request).with(:json)
-      expect(blocky).to receive(:response).with(:logger, logger)
-      expect(blocky).to receive(:response).with(:error_response)
-      expect(blocky).to receive(:response).with(:json)
-      expect(blocky).to receive(:adapter).with(adapter)
-
-      subject.new(ARANGO_HOST, adapter: adapter, logger: logger)
-    end
-
-    it 'should initialize with defaults when no specific logger and adapter was given' do
-      expect(Faraday).to receive(:new).with("#{ARANGO_HOST}/_api").and_yield(blocky)
-      expect(blocky).to receive(:request).with(:json)
-      expect(blocky).to receive(:response).with(:logger, NullLogger.instance)
-      expect(blocky).to receive(:response).with(:error_response)
-      expect(blocky).to receive(:response).with(:json)
-      expect(blocky).to receive(:adapter).with(Faraday.default_adapter)
-
-      subject.new(ARANGO_HOST)
-    end
-  end
 end

data/spec/unit/cursor_spec.rb

@@ -1,10 +1,11 @@
 # -*- encoding : utf-8 -*-
 require 'unit/spec_helper'
 require 'ashikawa-core/cursor'
+require 'ashikawa-core/database'
 
 describe Ashikawa::Core::Cursor do
   subject { Ashikawa::Core::Cursor }
-  let(:database) { double }
+  let(:database) { instance_double('Ashikawa::Core::Database') }
 
   describe 'cursor for a non-complete batch' do
     let(:response) { server_response('cursor/26011191') }
@@ -83,7 +84,7 @@ describe Ashikawa::Core::Cursor do
 
     it 'should be enumerable' do
       first = true
-      result = double
+      document = instance_double('Ashikawa::Core::Document')
 
       expect(database).to receive(:send_request)
         .twice
@@ -98,9 +99,9 @@ describe Ashikawa::Core::Cursor do
 
       expect(Ashikawa::Core::Document).to receive(:new)
         .exactly(5).times
-        .and_return(result)
+        .and_return(document)
 
-      expect(subject.map { |i| i }[0]).to eq(result)
+      expect(subject.map { |i| i }[0]).to eq(document)
     end
 
     it 'should return edge objects when recieving data from an edge collection' do

data/spec/unit/database_spec.rb

@@ -5,21 +5,12 @@ require 'ashikawa-core/database'
 describe Ashikawa::Core::Database do
   subject { Ashikawa::Core::Database }
 
-  let(:url) { double }
-  let(:host) { double }
-  let(:port) { double }
-  let(:scheme) { double }
-  let(:connection) { double('connection', host: host, port: port, scheme: scheme) }
-  let(:js_function) { double }
-  let(:collections) { double }
-  let(:transaction) { double }
-  let(:logger) { double }
-  let(:adapter) { double }
-  let(:configuration) { double }
-  let(:raw_collection) { double }
-  let(:collection) { double }
+  let(:connection) { instance_double('Ashikawa::Core::Connection', host: 'localhost', port: 8529, scheme: 'https') }
+  let(:collection) { instance_double('Ashikawa::Core::Collection') }
+  let(:raw_collection) { double('RawCollection') }
 
   it 'should initialize with a configuration object' do
+    configuration = instance_double('Ashikawa::Core::Configuration')
     expect(Ashikawa::Core::Configuration).to receive(:new)
       .and_return(configuration)
     expect(configuration).to receive(:connection)
@@ -41,9 +32,8 @@ describe Ashikawa::Core::Database do
       subject.query
     end
 
-    let(:database_list) { double('DatabaseList') }
-
     it 'should list all databases' do
+      database_list = %w(_system cupcakes ponies)
       expect(connection).to receive(:send_request)
         .with('database')
         .and_return({ 'result' => database_list, 'error' => false, 'code' => 200 })
@@ -108,7 +98,6 @@ describe Ashikawa::Core::Database do
     end
 
     it 'should truncate all documents in all collections' do
-      collection = double('Collection')
       allow(subject).to receive(:collections)
         .and_return([collection])
       expect(collection).to receive(:truncate)
@@ -210,6 +199,9 @@ describe Ashikawa::Core::Database do
     end
 
     it 'should create a transaction' do
+      js_function = 'function () { return 5; }'
+      collections = { read: ['collection_1'] }
+      transaction = instance_double('Ashikawa::Core::Transaction')
       expect(Ashikawa::Core::Transaction).to receive(:new)
         .with(subject, js_function, collections)
         .and_return(transaction)

data/spec/unit/document_spec.rb

@@ -1,16 +1,17 @@
 # -*- encoding : utf-8 -*-
 require 'unit/spec_helper'
 require 'ashikawa-core/document'
+require 'ashikawa-core/database'
 
 describe Ashikawa::Core::Document do
-  let(:database) { double }
-  let(:id) { 164 }
-  let(:path) { 'document/164' }
-  let(:key) { double }
-  let(:revision) { double }
-  let(:first_name) { double }
-  let(:last_name) { double }
-  let(:more_info) { double }
+  let(:database) { instance_double('Ashikawa::Core::Database') }
+  let(:id) { '23914039/25880119' }
+  let(:path) { 'document/23914039/25880119' }
+  let(:key) { '25880119' }
+  let(:revision) { '13728680' }
+  let(:first_name) { 'Jeff' }
+  let(:last_name) { 'Lebowski' }
+  let(:more_info) { 'This is valuable information' }
   let(:delete_payload) { { delete: {} } }
   let(:raw_data) do
     {
@@ -59,7 +60,7 @@ describe Ashikawa::Core::Document do
   describe 'initialized document with ID' do
     subject { Ashikawa::Core::Document.new(database, raw_data) }
 
-    let(:new_last_name) { double }
+    let(:new_last_name) { 'Dudemeister' }
     let(:raw_data_without_id_and_new_last_name) do
       {
         'first_name' => first_name,
@@ -91,7 +92,7 @@ describe Ashikawa::Core::Document do
         .with(path, {})
         .and_return({ 'name' => 'Jeff' })
 
-      refreshed_subject = subject.refresh!
+      refreshed_subject = subject.refresh
       expect(refreshed_subject).to eq(subject)
       expect(subject['name']).to eq('Jeff')
     end

data/spec/unit/edge_spec.rb

@@ -1,17 +1,18 @@
 # -*- encoding : utf-8 -*-
 require 'unit/spec_helper'
 require 'ashikawa-core/edge'
+require 'ashikawa-core/database'
 
 describe Ashikawa::Core::Edge do
-  let(:database) { double }
-  let(:id) { 412 }
-  let(:path) { 'edge/412' }
-  let(:key) { double }
-  let(:revision) { double }
-  let(:from_id) { double }
-  let(:to_id) { double }
-  let(:first_name) { double }
-  let(:last_name) { double }
+  let(:database) { instance_double('Ashikawa::Core::Database') }
+  let(:id) { '23914039/25880119' }
+  let(:path) { 'edge/23914039/25880119' }
+  let(:key) { '25880119' }
+  let(:revision) { '13728680' }
+  let(:from_id) { 'nodes/source_node' }
+  let(:to_id) { 'nodes/target_node' }
+  let(:first_name) { 'Jeff' }
+  let(:last_name) { 'Lebowski' }
   let(:raw_data) do
     {
       '_id' => id,
@@ -23,7 +24,7 @@ describe Ashikawa::Core::Edge do
       'last_name' => last_name
     }
   end
-  let(:new_last_name) { double }
+  let(:new_last_name) { 'Dudemeister' }
   let(:raw_data_without_meta_data_and_new_last_name) do
     {
       'first_name' => first_name,
@@ -57,7 +58,7 @@ describe Ashikawa::Core::Edge do
   end
 
   describe 'initializing edge with additional data' do
-    let(:more_info) { double }
+    let(:more_info) { 'Some very important information' }
     let(:additional_data) { { more_info: more_info } }
     subject { Ashikawa::Core::Edge.new(database, raw_data, additional_data) }
 

data/spec/unit/exception_spec.rb

@@ -15,7 +15,7 @@ describe Ashikawa::Core::NoCollectionProvidedException do
 end
 
 describe Ashikawa::Core::ClientError do
-  let(:error_message) { double }
+  let(:error_message) { 'The client did not do what it should do' }
   subject { Ashikawa::Core::ClientError.new(error_message) }
   its(:to_s) { should be(error_message) }
 end
@@ -49,7 +49,7 @@ describe Ashikawa::Core::IndexNotFoundException do
 end
 
 describe Ashikawa::Core::ServerError do
-  let(:error_message) { double }
+  let(:error_message) { 'The server is misbehaving' }
   subject { Ashikawa::Core::ServerError.new(error_message) }
   its(:to_s) { should be(error_message) }
 end

data/spec/unit/faraday_factory_spec.rb

@@ -0,0 +1,51 @@
+# -*- encoding : utf-8 -*-
+require 'unit/spec_helper'
+require 'ashikawa-core/faraday_factory'
+
+describe Ashikawa::Core::FaradayFactory do
+  describe 'FaradayFactory.create_connection' do
+    subject { Ashikawa::Core::FaradayFactory }
+    let(:config_block) { double('Block') }
+    let(:api_string) { double('ApiString') }
+
+    before do
+      allow(Faraday).to receive(:new).with(api_string).and_yield(config_block)
+      allow(config_block).to receive(:request).with(:json)
+      allow(config_block).to receive(:response).with(:error_response)
+      allow(config_block).to receive(:response).with(:json)
+      allow(config_block).to receive(:adapter).with(Faraday.default_adapter)
+    end
+
+    it 'should initialize with a specific logger' do
+      logger = double('Logger')
+      expect(config_block).to receive(:response).with(:minimal_logger, logger, debug_headers: false)
+      subject.create_connection(api_string, logger: logger)
+    end
+
+    it 'should initialize with a specific adapter' do
+      adapter = double('Adapter')
+      expect(config_block).to receive(:adapter).with(adapter)
+      subject.create_connection(api_string, adapter: adapter)
+    end
+
+    it 'should initialize with the default adapter when no specific adapter was given' do
+      expect(config_block).to receive(:adapter).with(Faraday.default_adapter)
+      subject.create_connection(api_string, {})
+    end
+
+    it 'should allow to add additional request middlewares with options' do
+      expect(config_block).to receive(:request).with(:my_middleware, :options)
+      subject.create_connection(api_string, additional_request_middlewares: [[:my_middleware, :options]])
+    end
+
+    it 'should allow to add additional response middlewares with options' do
+      expect(config_block).to receive(:response).with(:my_middleware, :options)
+      subject.create_connection(api_string, additional_response_middlewares: [[:my_middleware, :options]])
+    end
+
+    it 'should allow to add additional middlewares with options' do
+      expect(config_block).to receive(:use).with(:my_middleware, :options)
+      subject.create_connection(api_string, additional_middlewares: [[:my_middleware, :options]])
+    end
+  end
+end