asciidoctor-plantuml 0.0.12 → 0.0.16

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a0eec1ab5b66560c09d54f1c5a44f4ca764b41fd8112a2c1ba791de3936ff4d8
-  data.tar.gz: a806b6892710155ae5d36aee9e3fe0830f30d4606ec8c6b27b3533187f389f80
+  metadata.gz: fe7b55f293e7f815c3107f7cb42b8118b2f5cbcc2d46ddc04c003c8e855ae2ff
+  data.tar.gz: ded1cc190a25eca2b172fc459a4f77d4f629e484f0112b5d1693686433d2197c
 SHA512:
-  metadata.gz: d4924630cd2c797eed3741a6f1b70c2f8eba15b781884a7b76934d090869570615712dd637be42d472610acbf4ea13894c07319c059a213aa9a3c2559e4ac305
-  data.tar.gz: 4243885ff01513113b5e34412532196b708250cba696c0c094b7a77cb96c656b2302a60aabd37589a6ee398df401506b76cb929ed3ac5631efa54928af580dce
+  metadata.gz: ce55a9ec6de14f336fb5330b2a0f5d9369236c8c213fa306a59ba0f14aaddab50a40412ffc3156b16bb6e742ba8b50238f4c06768e22b7def34eedea9d4da0e9
+  data.tar.gz: 9aa54dd2b91d173bf8225581bacb82cc2c6b2d8316ceea4f948959cb8696acb0f7f045b01c9f97a80c2476a3d7bc20fae75099c51936420c3763e581bc1bb379

data/lib/asciidoctor_plantuml/plantuml.rb

@@ -3,7 +3,6 @@
 require 'uri'
 require 'open-uri'
 require 'zlib'
-require 'open-uri'
 require 'net/http'
 
 module Asciidoctor
@@ -11,8 +10,8 @@ module Asciidoctor
   module PlantUml
     # PlantUML Configuration
     class Configuration
-      DEFAULT_URL = ENV['PLANTUML_URL'] || ''
-      DEFAULT_ENCODING = ENV['PLANTUML_ENCODING'] || 'legacy'
+      DEFAULT_URL = ENV.fetch('PLANTUML_URL', '')
+      DEFAULT_ENCODING = ENV.fetch('PLANTUML_ENCODING', 'legacy')
 
       attr_accessor :url, :txt_enable, :svg_enable, :png_enable, :encoding
 
@@ -80,10 +79,9 @@ module Asciidoctor
         end
 
         def plantuml_content_format(code, format, attrs = {})
-          if %w[png svg].include?(format)
-            plantuml_img_content(code, format, attrs)
-          elsif format == 'txt' && txt_enabled?
-            plantuml_txt_content(code, format, attrs)
+          if %w[png svg txt].include?(format) &&
+             method("#{format}_enabled?").call
+            method("plantuml_#{format}_content").call(code, format, attrs)
           else
             plantuml_invalid_content(format, attrs)
           end
@@ -94,9 +92,7 @@ module Asciidoctor
 
           return plantuml_disabled_content(code, attrs) unless enabled?
 
-          unless valid_uri?(server_url)
-            return plantuml_server_unavailable_content(server_url, attrs)
-          end
+          return plantuml_server_unavailable_content(server_url, attrs) unless valid_uri?(server_url)
 
           plantuml_content_format(code, format, attrs)
         end
@@ -125,7 +121,7 @@ module Asciidoctor
             plantuml_ascii_content(f.read, attrs)
           end
         rescue OpenURI::HTTPError, Errno::ECONNREFUSED, SocketError
-          plantuml_img_content(code, format, attrs)
+          plantuml_png_content(code, format, attrs)
         end
 
         def plantuml_ascii_content(code, attrs = {})
@@ -140,7 +136,7 @@ module Asciidoctor
           content + '</div>'
         end
 
-        def plantuml_img_content(code, format, attrs = {})
+        def plantuml_png_content(code, format, attrs = {})
           content = '<div class="imageblock">'
           content += '<div class="content">'
           content += '<img '
@@ -154,37 +150,43 @@ module Asciidoctor
           content + '</div>'
         end
 
-        def plantuml_invalid_content(format, attrs = {})
-          content = '<div class="listingblock">'
+        def plantuml_svg_content(code, format, attrs = {})
+          content = '<div class="imageblock">'
           content += '<div class="content">'
-          content += '<pre '
+          content += '<object type="image/svg+xml" '
+          content += "data=\"#{gen_url(code, format)}\" "
           content += "id=\"#{attrs['id']}\" " if attrs['id']
-          content += 'class="plantuml plantuml-error"> '
-          content += "PlantUML Error: Invalid format \"#{format}\""
-          content += '</pre>'
+          content += "width=\"#{attrs['width']}\" " if attrs['width']
+          content += "height=\"#{attrs['height']}\" " if attrs['height']
+          content += '>'
+          attrs['id'] = 'fallback_' + attrs['id'] if attrs['id']
+          content += plantuml_png_content(code, format, attrs)
+          content += '</object>'
           content += '</div>'
           content + '</div>'
         end
 
+        def plantuml_invalid_content(format, attrs = {})
+          error = "PlantUML Error: Invalid format \"#{format}\""
+          _plantuml_error_content(error, attrs)
+        end
+
         def plantuml_server_unavailable_content(url, attrs = {})
-          content = '<div class="listingblock">'
-          content += '<div class="content">'
-          content += '<pre '
-          content += "id=\"#{attrs['id']}\" " if attrs['id']
-          content += 'class="plantuml plantuml-error"> '
-          content += "Error: cannot connect to PlantUML server at \"#{url}\""
-          content += '</pre>'
-          content += '</div>'
-          content + '</div>'
+          error = "Error: cannot connect to PlantUML server at \"#{url}\""
+          _plantuml_error_content(error, attrs)
         end
 
         def plantuml_disabled_content(code, attrs = {})
+          _plantuml_error_content(code, attrs)
+        end
+
+        def _plantuml_error_content(error, attrs = {})
           content = '<div class="listingblock">'
           content += '<div class="content">'
           content += '<pre '
           content += "id=\"#{attrs['id']}\" " if attrs['id']
           content += 'class="plantuml plantuml-error">\n'
-          content += code
+          content += error
           content += '</pre>'
           content += '</div>'
           content + '</div>'
@@ -244,11 +246,9 @@ module Asciidoctor
         end
 
         def expand_path(path, current, last, separator)
-          path = path[1..-1] if path.start_with?(separator) && current.zero?
+          path = path[1..] if path.start_with?(separator) && current.zero?
 
-          unless path.end_with?(separator) || current == last
-            path = [path, separator]
-          end
+          path = [path, separator] unless path.end_with?(separator) || current == last
 
           path
         end
@@ -259,15 +259,13 @@ module Asciidoctor
     class BlockProcessor < Asciidoctor::Extensions::BlockProcessor
       use_dsl
       named :plantuml
-      on_context :listing
+      on_context :listing, :literal
       content_model :simple
 
       def process(parent, target, attrs)
         lines = target.lines
 
-        unless target.lines[0] =~ /@startuml/
-          lines = ['@startuml'] + target.lines
-        end
+        lines = ['@startuml'] + target.lines unless target.lines[0] =~ /@startuml/
 
         lines += ['@enduml'] unless target.lines[-1] =~ /@enduml/
 

data/lib/asciidoctor_plantuml/version.rb

@@ -2,6 +2,6 @@
 
 module Asciidoctor
   module PlantUML
-    VERSION = '0.0.12'
+    VERSION = '0.0.16'
   end
 end

data/test/test_plantuml.rb

@@ -17,6 +17,17 @@ DOC_BASIC = <<~ENDOFSTRING
   ----
 ENDOFSTRING
 
+DOC_BASIC_LITERAL = <<~ENDOFSTRING
+  = Hello PlantUML!
+
+  [plantuml, format="png"]
+  .Title Of this
+  ....
+  User -> (Start)
+  User --> (Use the application) : Label
+  ....
+ENDOFSTRING
+
 DOC_BASIC2 = <<~ENDOFSTRING
   = Hello PlantUML!
 
@@ -31,6 +42,20 @@ DOC_BASIC2 = <<~ENDOFSTRING
   ----
 ENDOFSTRING
 
+DOC_BASIC2_LITERAL = <<~ENDOFSTRING
+  = Hello PlantUML!
+
+  [plantuml, format="png"]
+  .Title Of this
+  [[fig-xref]]
+  ....
+  @startuml
+  User -> (Start)
+  User --> (Use the application) : Label
+  @enduml
+  ....
+ENDOFSTRING
+
 DOC_BASIC3 = <<~ENDOFSTRING
   = Hello Compound PlantUML!
 
@@ -43,6 +68,18 @@ DOC_BASIC3 = <<~ENDOFSTRING
   ----
 ENDOFSTRING
 
+DOC_BASIC3_LITERAL = <<~ENDOFSTRING
+  = Hello Compound PlantUML!
+
+  [plantuml, format="png"]
+  ....
+  [COMP1]
+  [COMP2]
+  [COMP1] -> [COMP2]
+  [COMP2] --> [COMP3]
+  ....
+ENDOFSTRING
+
 DOC_ID = <<~ENDOFSTRING
   = Hello PlantUML!
 
@@ -105,6 +142,28 @@ DOC_MULTI = <<~ENDOFSTRING
   ----
 ENDOFSTRING
 
+DOC_MULTI_LITERAL = <<~ENDOFSTRING
+  = Hello PlantUML!
+
+  [plantuml, format="png"]
+  ....
+  User -> (Start)
+  User --> (Use the application) : Label
+  ....
+
+  [plantuml, format="png"]
+  ....
+  User -> (Start)
+  User --> (Use the application) : Label
+  ....
+
+  [plantuml, format="txt"]
+  ....
+  User -> (Start)
+  User --> (Use the application) : Label
+  ....
+ENDOFSTRING
+
 DOC_TXT = <<~ENDOFSTRING
   = Hello PlantUML!
 
@@ -115,15 +174,28 @@ DOC_TXT = <<~ENDOFSTRING
   ----
 ENDOFSTRING
 
+DOC_SVG = <<~ENDOFSTRING
+  = Hello PlantUML!
+
+  [plantuml, format="svg"]
+  ----
+  User -> (Start)
+  User --> (Use the application) : Label
+  ----
+ENDOFSTRING
+
 class PlantUmlTest < Test::Unit::TestCase
   GENURL = 'http://localhost:8080/plantuml/png/U9npA2v9B2efpStX2YrEBLBGjLFG20Q9Q4Bv804WIw4a8rKXiQ0W9pCviIGpFqzJmKh19p4fDOVB8JKl1QWT05kd5wq0'
   GENURL2 = 'http://localhost:8080/plantuml/png/U9npA2v9B2efpStXYdRszmqmZ8NGHh4mleAkdGAAa15G22Pc7Clba9gN0jGE00W75Cm0'
   GENURL_ENCODING = 'http://localhost:8080/plantuml/png/~1U9npA2v9B2efpStX2YrEBLBGjLFG20Q9Q4Bv804WIw4a8rKXiQ0W9pCviIGpFqzJmKh19p4fDOVB8JKl1QWT05kd5wq0'
+  SVGGENURL = 'http://localhost:8080/plantuml/svg/~1U9npA2v9B2efpStX2YrEBLBGjLFG20Q9Q4Bv804WIw4a8rKXiQ0W9pCviIGpFqzJmKh19p4fDOVB8JKl1QWT05kd5wq0'
 
   def setup
     Asciidoctor::PlantUml.configure do |c|
       c.url = 'http://localhost:8080/plantuml'
       c.txt_enable = true
+      c.png_enable = true
+      c.svg_enable = true
     end
   end
 
@@ -140,8 +212,40 @@ class PlantUmlTest < Test::Unit::TestCase
     assert_equal GENURL, element['src']
   end
 
+  def test_plantuml_block_literal_processor
+    html = ::Asciidoctor.convert(
+      StringIO.new(DOC_BASIC_LITERAL), backend: 'html5'
+    )
+    page = Nokogiri::HTML(html)
+
+    elements = page.css('img.plantuml')
+
+    assert_equal elements.size, 1
+
+    element = elements.first
+
+    assert_equal GENURL, element['src']
+  end
+
   def test_plantuml_block_processor2
-    html = ::Asciidoctor.convert(StringIO.new(DOC_BASIC2), backend: 'html5')
+    html = ::Asciidoctor.convert(
+      StringIO.new(DOC_BASIC2), backend: 'html5'
+    )
+    page = Nokogiri::HTML(html)
+
+    elements = page.css('img.plantuml')
+
+    assert_equal elements.size, 1
+
+    element = elements.first
+
+    assert_equal GENURL, element['src']
+  end
+
+  def test_plantuml_block_literal_processor2
+    html = ::Asciidoctor.convert(
+      StringIO.new(DOC_BASIC2_LITERAL), backend: 'html5'
+    )
     page = Nokogiri::HTML(html)
 
     elements = page.css('img.plantuml')
@@ -166,6 +270,21 @@ class PlantUmlTest < Test::Unit::TestCase
     assert_equal GENURL2, element['src']
   end
 
+  def test_plantuml_block_literal_processor3
+    html = ::Asciidoctor.convert(
+      StringIO.new(DOC_BASIC3_LITERAL), backend: 'html5'
+    )
+    page = Nokogiri::HTML(html)
+
+    elements = page.css('img.plantuml')
+
+    assert_equal elements.size, 1
+
+    element = elements.first
+
+    assert_equal GENURL2, element['src']
+  end
+
   def test_plantuml_block_processor_encoding
     Asciidoctor::PlantUml.configure do |c|
       c.encoding = 'deflate'
@@ -229,7 +348,7 @@ class PlantUmlTest < Test::Unit::TestCase
     assert_equal elements.size, 1
   end
 
-  def test_plantuml_multiple
+  def test_plantuml_multiple_listing
     html = ::Asciidoctor.convert(StringIO.new(DOC_MULTI), backend: 'html5')
     page = Nokogiri::HTML(html)
 
@@ -240,6 +359,19 @@ class PlantUmlTest < Test::Unit::TestCase
     assert_equal elements.size, 0
   end
 
+  def test_plantuml_multiple_literal
+    html = ::Asciidoctor.convert(
+      StringIO.new(DOC_MULTI_LITERAL), backend: 'html5'
+    )
+    page = Nokogiri::HTML(html)
+
+    elements = page.css('img.plantuml')
+    assert elements.size >= 2
+
+    elements = page.css('.plantuml-error')
+    assert_equal elements.size, 0
+  end
+
   def test_plantuml_bad_server
     Asciidoctor::PlantUml.configure do |c|
       c.url = 'http://nonexistent.com/plantuml'
@@ -299,4 +431,44 @@ class PlantUmlTest < Test::Unit::TestCase
     elements = page.css('pre.plantuml-error')
     assert_equal elements.size, 1
   end
+
+  def test_svg
+    Asciidoctor::PlantUml.configure do |c|
+      c.url = 'http://localhost:8080/plantuml'
+      c.svg_enable = true
+    end
+
+    html = ::Asciidoctor.convert(StringIO.new(DOC_SVG), backend: 'html5')
+    page = Nokogiri::HTML(html)
+    elements = page.css("object[type='image/svg+xml']")
+    assert_equal elements.size, 1
+
+    element = elements.first
+
+    assert_equal SVGGENURL, element['data']
+  end
+
+  def test_disable_svg
+    Asciidoctor::PlantUml.configure do |c|
+      c.url = 'http://localhost:8080/plantuml'
+      c.svg_enable = false
+    end
+
+    html = ::Asciidoctor.convert(StringIO.new(DOC_SVG), backend: 'html5')
+    page = Nokogiri::HTML(html)
+    elements = page.css('pre.plantuml-error')
+    assert_equal elements.size, 1
+  end
+
+  def test_disable_png
+    Asciidoctor::PlantUml.configure do |c|
+      c.url = 'http://localhost:8080/plantuml'
+      c.png_enable = false
+    end
+
+    html = ::Asciidoctor.convert(StringIO.new(DOC_BASIC_LITERAL), backend: 'html5')
+    page = Nokogiri::HTML(html)
+    elements = page.css('pre.plantuml-error')
+    assert_equal elements.size, 1
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: asciidoctor-plantuml
 version: !ruby/object:Gem::Version
-  version: 0.0.12
+  version: 0.0.16
 platform: ruby
 authors:
 - Horacio Sanson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-11 00:00:00.000000000 Z
+date: 2022-04-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.2'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.3'
+        version: '2.2'
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: 1.13.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.6'
+        version: 1.13.4
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -58,35 +58,35 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.66'
+        version: '1.28'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.66'
+        version: '1.28'
 - !ruby/object:Gem::Dependency
   name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.5'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.3'
+        version: '3.5'
 - !ruby/object:Gem::Dependency
   name: asciidoctor
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.6
+        version: 2.0.17
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -96,7 +96,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.5.6
+        version: 2.0.17
     - - "<"
       - !ruby/object:Gem::Version
         version: 3.0.0
@@ -114,7 +114,8 @@ files:
 homepage: https://github.com/hsanson/asciidoctor-plantuml
 licenses:
 - MIT
-metadata: {}
+metadata:
+  rubygems_mfa_required: 'true'
 post_install_message: 
 rdoc_options: []
 require_paths:
@@ -123,15 +124,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.3'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Asciidoctor support for PlantUML diagrams.