asana 2.0.0 → 2.0.2

data/lib/asana/authentication/oauth2/bearer_token_authentication.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Asana
   module Authentication
     module OAuth2
@@ -24,8 +26,7 @@ module Asana
         #
         # Returns nothing.
         def configure(connection)
-          connection.authorization :Bearer, @token
-          connection.request :oauth2, token_type: 'bearer'
+          connection.request :authorization, 'Bearer', @token
         end
       end
     end

data/lib/asana/authentication/oauth2/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'oauth2'
 
 module Asana

data/lib/asana/authentication/oauth2.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'oauth2/bearer_token_authentication'
 require_relative 'oauth2/access_token_authentication'
 require_relative 'oauth2/client'
@@ -31,10 +33,10 @@ module Asana
         client = Client.new(client_id: client_id,
                             client_secret: client_secret,
                             redirect_uri: 'urn:ietf:wg:oauth:2.0:oob')
-        STDOUT.puts '1. Go to the following URL to authorize the ' \
-          " application: #{client.authorize_url}"
-        STDOUT.puts '2. Paste the authorization code here: '
-        auth_code = STDIN.gets.chomp
+        $stdout.puts '1. Go to the following URL to authorize the  ' \
+                     "application: #{client.authorize_url}"
+        $stdout.puts '2. Paste the authorization code here: '
+        auth_code = $stdin.gets.chomp
         client.token_from_auth_code(auth_code)
       end
     end

data/lib/asana/authentication/token_authentication.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Asana
   module Authentication
     # Public: Represents an API token authentication mechanism.
@@ -13,7 +15,7 @@ module Asana
       #
       # Returns nothing.
       def configure(connection)
-        connection.basic_auth(@token, '')
+        connection.request :authorization, :basic, @token, ''
       end
     end
   end

data/lib/asana/authentication.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'authentication/oauth2'
 require_relative 'authentication/token_authentication'
 

data/lib/asana/client/configuration.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Asana
   class Client
     # Internal: Represents a configuration DSL for an Asana::Client.
@@ -17,7 +19,7 @@ module Asana
       # Public: Initializes an empty configuration object.
       def initialize
         @configuration = {
-            :log_asana_change_warnings => true
+          log_asana_change_warnings: true
         }
       end
 
@@ -100,7 +102,6 @@ module Asana
       #
       # Raises ArgumentError if the OAuth2 configuration arguments are invalid.
       #
-      # rubocop:disable Metrics/MethodLength
       def oauth2(value)
         case value
         when ::OAuth2::AccessToken
@@ -111,8 +112,8 @@ module Asana
           from_bearer_token(value[:bearer_token])
         else
           error 'Invalid OAuth2 configuration: pass in either an ' \
-            '::OAuth2::AccessToken object of your own or a hash ' \
-            'containing :refresh_token or :bearer_token.'
+                '::OAuth2::AccessToken object of your own or a hash ' \
+                'containing :refresh_token or :bearer_token.'
         end
       end
 
@@ -158,7 +159,7 @@ module Asana
       end
 
       def requiring(hash, *keys)
-        missing_keys = keys.select { |k| !hash.key?(k) }
+        missing_keys = keys.reject { |k| hash.key?(k) }
         missing_keys.any? && error("Missing keys: #{missing_keys.join(', ')}")
         keys.map { |k| hash[k] }
       end

data/lib/asana/client.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'authentication'
 require_relative 'client/configuration'
 require_relative 'resources'
@@ -59,12 +61,12 @@ module Asana
         @resource = resource
       end
 
-      def method_missing(m, *args, **kwargs, &block)
-        @resource.public_send(m, *([@client] + args), **kwargs, &block)
+      def method_missing(method_name, *args, **kwargs, &block)
+        @resource.public_send(method_name, *([@client] + args), **kwargs, &block)
       end
 
-      def respond_to_missing?(m, *)
-        @resource.respond_to?(m)
+      def respond_to_missing?(method_name, *)
+        @resource.respond_to?(method_name)
       end
     end
 
@@ -72,15 +74,15 @@ module Asana
     #
     # Yields a {Asana::Client::Configuration} object as a configuration
     # DSL. See {Asana::Client} for usage examples.
-    def initialize
-      config = Configuration.new.tap { |c| yield c }.to_h
+    def initialize(&block)
+      config = Configuration.new.tap(&block).to_h
       @http_client =
-        HttpClient.new(authentication:            config.fetch(:authentication),
-                       adapter:                   config[:faraday_adapter],
-                       user_agent:                config[:user_agent],
-                       debug_mode:                config[:debug_mode],
+        HttpClient.new(authentication: config.fetch(:authentication),
+                       adapter: config[:faraday_adapter],
+                       user_agent: config[:user_agent],
+                       debug_mode: config[:debug_mode],
                        log_asana_change_warnings: config[:log_asana_change_warnings],
-                       default_headers:           config[:default_headers],
+                       default_headers: config[:default_headers],
                        &config[:faraday_configuration])
     end
 

data/lib/asana/errors.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Asana
   # Public: Defines the different errors that the Asana API may throw, which the
   # client code may want to catch.
@@ -19,8 +21,8 @@ module Asana
     # user could not be authenticated.
     NotAuthorized = Class.new(APIError) do
       def to_s
-        'Valid credentials were not provided with the request, so the API could '\
-        'not associate a user with the request.'
+        'Valid credentials were not provided with the request, so the API could ' \
+          'not associate a user with the request.'
       end
     end
 
@@ -28,8 +30,8 @@ module Asana
     # that requires a premium account (Payment Required).
     PremiumOnly = Class.new(APIError) do
       def to_s
-        'The endpoint that is being requested is only available to premium '\
-        'users.'
+        'The endpoint that is being requested is only available to premium ' \
+          'users.'
       end
     end
 
@@ -37,18 +39,18 @@ module Asana
     # access the requested resource or to perform the requested action on it.
     Forbidden = Class.new(APIError) do
       def to_s
-        'The authorization and request syntax was valid but the server is refusing '\
-        'to complete the request. This can happen if you try to read or write '\
-        'to objects or properties that the user does not have access to.'
+        'The authorization and request syntax was valid but the server is refusing ' \
+          'to complete the request. This can happen if you try to read or write ' \
+          'to objects or properties that the user does not have access to.'
       end
     end
 
     # Public: A 404 error. Raised when the requested resource doesn't exist.
     NotFound = Class.new(APIError) do
       def to_s
-        'Either the request method and path supplied do not specify a known '\
-        'action in the API, or the object specified by the request does not '\
-        'exist.'
+        'Either the request method and path supplied do not specify a known ' \
+          'action in the API, or the object specified by the request does not ' \
+          'exist.'
       end
     end
 
@@ -59,11 +61,12 @@ module Asana
       attr_accessor :phrase
 
       def initialize(phrase)
+        super()
         @phrase = phrase
       end
 
       def to_s
-        "There has been an error on Asana's end. Use this unique phrase to "\
+        "There has been an error on Asana's end. Use this unique phrase to " \
         'identify the problem when contacting support: ' + %("#{@phrase}")
       end
     end
@@ -74,6 +77,7 @@ module Asana
       attr_accessor :errors
 
       def initialize(errors)
+        super()
         @errors = errors
       end
 
@@ -89,6 +93,7 @@ module Asana
       attr_accessor :retry_after_seconds
 
       def initialize(retry_after_seconds)
+        super()
         @retry_after_seconds = retry_after_seconds
       end
 

data/lib/asana/http_client/environment_info.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative '../version'
 require 'openssl'
 
@@ -6,7 +8,7 @@ module Asana
     # Internal: Adds environment information to a Faraday request.
     class EnvironmentInfo
       # Internal: The default user agent to use in all requests to the API.
-      USER_AGENT = "ruby-asana v#{Asana::VERSION}".freeze
+      USER_AGENT = "ruby-asana v#{Asana::VERSION}"
 
       def initialize(user_agent = nil)
         @user_agent = user_agent || USER_AGENT
@@ -19,7 +21,7 @@ module Asana
       # environment.
       def configure(builder)
         builder.headers[:user_agent] = @user_agent
-        builder.headers[:"X-Asana-Client-Lib"] = header
+        builder.headers[:'X-Asana-Client-Lib'] = header
       end
 
       private
@@ -33,21 +35,20 @@ module Asana
           .map { |k, v| "#{k}=#{v}" }.join('&')
       end
 
-      # rubocop:disable Metrics/MethodLength
       def os
-        if RUBY_PLATFORM =~ /win32/ || RUBY_PLATFORM =~ /mingw/
+        case RUBY_PLATFORM
+        when /win32/, /mingw/
           'windows'
-        elsif RUBY_PLATFORM =~ /linux/
+        when /linux/
           'linux'
-        elsif RUBY_PLATFORM =~ /darwin/
+        when /darwin/
           'darwin'
-        elsif RUBY_PLATFORM =~ /freebsd/
+        when /freebsd/
           'freebsd'
         else
           'unknown'
         end
       end
-      # rubocop:enable Metrics/MethodLength
     end
   end
 end

data/lib/asana/http_client/error_handling.rb

@@ -1,4 +1,4 @@
-require 'multi_json'
+# frozen_string_literal: true
 
 require_relative '../errors'
 
@@ -27,37 +27,34 @@ module Asana
       # Raises [Asana::Errors::ServerError] when there's a server problem.
       # Raises [Asana::Errors::APIError] when the API returns an unknown error.
       #
-      # rubocop:disable all
-      def handle(num_retries=0, &request)
+      # rubocop:disable Metrics/AbcSize
+      def handle(num_retries = 0, &request)
         request.call
       rescue Faraday::ClientError => e
         raise e unless e.response
+
         case e.response[:status]
-          when 400 then raise invalid_request(e.response)
-          when 401 then raise not_authorized(e.response)
-          when 402 then raise payment_required(e.response)
-          when 403 then raise forbidden(e.response)
-          when 404 then raise not_found(e.response)
-          when 412 then recover_response(e.response)
-          when 429 then raise rate_limit_enforced(e.response)
-          when 500 then raise server_error(e.response)
-          else raise api_error(e.response)
+        when 400 then raise invalid_request(e.response)
+        when 401 then raise not_authorized(e.response)
+        when 402 then raise payment_required(e.response)
+        when 403 then raise forbidden(e.response)
+        when 404 then raise not_found(e.response)
+        when 412 then recover_response(e.response)
+        when 429 then raise rate_limit_enforced(e.response)
+        when 500 then raise server_error(e.response)
+        else raise api_error(e.response)
         end
       # Retry for timeouts or 500s from Asana
       rescue Faraday::ServerError => e
-        if num_retries < MAX_RETRIES
-          handle(num_retries + 1, &request)
-        else
-          raise server_error(e.response)
-        end
+        raise server_error(e.response) unless num_retries < MAX_RETRIES
+
+        handle(num_retries + 1, &request)
       rescue Net::ReadTimeout => e
-        if num_retries < MAX_RETRIES
-          handle(num_retries + 1, &request)
-        else
-          raise e
-        end
+        raise e unless num_retries < MAX_RETRIES
+
+        handle(num_retries + 1, &request)
       end
-      # rubocop:enable all
+      # rubocop:enable Metrics/AbcSize
 
       # Internal: Returns an InvalidRequest exception including a list of
       # errors.
@@ -112,13 +109,15 @@ module Asana
 
       # Internal: Parser a response body from JSON.
       def body(response)
-        MultiJson.load(response[:body])
+        JSON.parse(response[:body])
       end
 
+      # rubocop:disable Style/OpenStructUse
       def recover_response(response)
         r = response.dup.tap { |res| res[:body] = body(response) }
         Response.new(OpenStruct.new(env: OpenStruct.new(r)))
       end
+      # rubocop:enable Style/OpenStructUse
     end
   end
 end

data/lib/asana/http_client/response.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Asana
   class HttpClient
     # Internal: Represents a response from the Asana API.

data/lib/asana/http_client.rb

@@ -1,6 +1,7 @@
+# frozen_string_literal: true
+
 require 'faraday'
-require 'faraday_middleware'
-require 'faraday_middleware/multi_json'
+require 'faraday/follow_redirects'
 
 require_relative 'http_client/error_handling'
 require_relative 'http_client/environment_info'
@@ -11,7 +12,7 @@ module Asana
   # parsing and common options.
   class HttpClient
     # Internal: The API base URI.
-    BASE_URI = 'https://app.asana.com/api/1.0'.freeze
+    BASE_URI = 'https://app.asana.com/api/1.0'
 
     # Public: Initializes an HttpClient to make requests to the Asana API.
     #
@@ -130,7 +131,8 @@ module Asana
         yield builder if request_config
         configure_format(builder)
         add_middleware(builder)
-        @config.call(builder) if @config
+        configure_redirects(builder)
+        @config&.call(builder)
         use_adapter(builder, @adapter)
       end
     end
@@ -147,13 +149,16 @@ module Asana
     end
 
     def configure_format(builder)
-      builder.request :multi_json
-      builder.response :multi_json
+      builder.request :json
+      builder.response :json
     end
 
     def add_middleware(builder)
       builder.use Faraday::Response::RaiseError
-      builder.use FaradayMiddleware::FollowRedirects
+    end
+
+    def configure_redirects(builder)
+      builder.response :follow_redirects
     end
 
     def use_adapter(builder, adapter)
@@ -170,79 +175,75 @@ module Asana
     end
 
     def log_request(method, url, body)
-      STDERR.puts format('[%s] %s %s (%s)',
-                         self.class,
-                         method.to_s.upcase,
-                         url,
-                         body.inspect)
+      warn format('[%<klass>s] %<method>s %<url>s (%<bodt>s)',
+                  klass: self.class,
+                  method: method.to_s.upcase,
+                  url: url,
+                  body: body.inspect)
     end
 
+    # rubocop:disable Metrics/AbcSize
+    # rubocop:disable Metrics/MethodLength
     def log_asana_change_headers(request_headers, response_headers)
       change_header_key = nil
 
       response_headers.each_key do |key|
-        if key.downcase == 'asana-change'
-            change_header_key = key
-        end
+        change_header_key = key if key.downcase == 'asana-change'
       end
 
-      if change_header_key != nil
-        accounted_for_flags = Array.new
+      return if change_header_key.nil?
 
-        if request_headers == nil
-          request_headers = {}
-        end
-        # Grab the request's asana-enable flags
-        request_headers.each_key do |req_header|
-          if req_header.downcase == 'asana-enable'
-            request_headers[req_header].split(',').each do |flag|
-              accounted_for_flags.push(flag)
-            end
-          elsif req_header.downcase == 'asana-disable'
-            request_headers[req_header].split(',').each do |flag|
-              accounted_for_flags.push(flag)
-            end
+      accounted_for_flags = []
+
+      request_headers = {} if request_headers.nil?
+      # Grab the request's asana-enable flags
+      request_headers.each_key do |req_header|
+        case req_header.downcase
+        when 'asana-enable', 'asana-disable'
+          request_headers[req_header].split(',').each do |flag|
+            accounted_for_flags.push(flag)
           end
         end
+      end
+
+      changes = response_headers[change_header_key].split(',')
 
-        changes = response_headers[change_header_key].split(',')
-
-        changes.each do |unsplit_change|
-          change = unsplit_change.split(';')
-
-          name = nil
-          info = nil
-          affected = nil
-
-          change.each do |unsplit_field|
-            field = unsplit_field.split('=')
-
-            field[0].strip!
-            field[1].strip!
-            if field[0] == 'name'
-                name = field[1]
-            elsif field[0] == 'info'
-                info = field[1]
-            elsif field[0] == 'affected'
-                affected = field[1]
-            end
-
-            # Only show the error if the flag was not in the request's asana-enable header
-            if !(accounted_for_flags.include? name) && (affected == 'true')
-              message1 = 'This request is affected by the "%s"' +
-              ' deprecation. Please visit this url for more info: %s'
-              message2 = 'Adding "%s" to your "Asana-Enable" or ' +
-              '"Asana-Disable" header will opt in/out to this deprecation ' +
-              'and suppress this warning.'
-
-              STDERR.puts format(message1, name, info)
-              STDERR.puts format(message2, name)
-            end
+      changes.each do |unsplit_change|
+        change = unsplit_change.split(';')
+
+        name = nil
+        info = nil
+        affected = nil
+
+        change.each do |unsplit_field|
+          field = unsplit_field.split('=')
+
+          field[0].strip!
+          field[1].strip!
+          case field[0]
+          when 'name'
+            name = field[1]
+          when 'info'
+            info = field[1]
+          when 'affected'
+            affected = field[1]
           end
+
+          # Only show the error if the flag was not in the request's asana-enable header
+          next unless !(accounted_for_flags.include? name) && (affected == 'true')
+
+          message1 = 'This request is affected by the "%s" ' \
+                     'deprecation. Please visit this url for more info: %s'
+          message2 = 'Adding "%s" to your "Asana-Enable" or ' \
+                     '"Asana-Disable" header will opt in/out to this deprecation ' \
+                     'and suppress this warning.'
+
+          warn format(message1, name, info)
+          warn format(message2, name)
         end
       end
     end
+    # rubocop:enable Metrics/AbcSize
+    # rubocop:enable Metrics/MethodLength
   end
 end
-
-

data/lib/asana/resource_includes/attachment_uploading.rb

@@ -1,3 +1,7 @@
+# frozen_string_literal: true
+
+require 'faraday/multipart'
+
 module Asana
   module Resources
     # Internal: Mixin to add the ability to upload an attachment to a specific
@@ -11,8 +15,6 @@ module Asana
       # options  - [Hash] the request I/O options
       # data     - [Hash] extra attributes to post
       #
-      # rubocop:disable Metrics/AbcSize
-      # rubocop:disable Metrics/MethodLength
       def attach(filename: required('filename'),
                  mime: required('mime'),
                  io: nil, options: {}, **data)
@@ -21,9 +23,9 @@ module Asana
                    path = File.expand_path(filename)
                    raise ArgumentError, "file #{filename} doesn't exist" unless File.exist?(path)
 
-                   Faraday::FilePart.new(path, mime)
+                   Faraday::Multipart::FilePart.new(path, mime)
                  else
-                   Faraday::FilePart.new(io, mime, filename)
+                   Faraday::Multipart::FilePart.new(io, mime, filename)
                  end
 
         response = client.post("/#{self.class.plural_name}/#{gid}/attachments",
@@ -33,8 +35,6 @@ module Asana
 
         Attachment.new(parse(response).first, client: client)
       end
-      # rubocop:enable Metrics/MethodLength
-      # rubocop:enable Metrics/AbcSize
     end
   end
 end

data/lib/asana/resource_includes/collection.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'response_helper'
 
 module Asana
@@ -40,7 +42,7 @@ module Asana
       def last
         @elements.last
       end
-      
+
       # Public: Returns the size of the collection.
       def size
         to_a.size
@@ -49,9 +51,7 @@ module Asana
 
       # Public: Returns a String representation of the collection.
       def to_s
-        "#<Asana::Collection<#{@type}> " \
-          "[#{@elements.map(&:inspect).join(', ')}" +
-          (@next_page_data ? ', ...' : '') + ']>'
+        "#<Asana::Collection<#{@type}> [#{@elements.map(&:inspect).join(', ')}#{@next_page_data ? ', ...' : ''}]>"
       end
       alias inspect to_s
 

data/lib/asana/resource_includes/event.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'events'
 
 module Asana

data/lib/asana/resource_includes/event_subscription.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'events'
 
 module Asana

data/lib/asana/resource_includes/events.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'event'
 
 module Asana
@@ -89,13 +91,14 @@ module Asana
 
       # Internal: Returns the formatted params for the poll request.
       def params
-        { resource: @resource, sync: @sync }.reject { |_, v| v.nil? }
+        { resource: @resource, sync: @sync }.compact
       end
 
       # Internal: Executes a block if at least @wait seconds have passed since
       # @last_poll.
       def rate_limiting
         return if @last_poll && Time.now - @last_poll <= @wait
+
         yield.tap { @last_poll = Time.now }
       end
     end

data/lib/asana/resource_includes/registry.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require_relative 'resource'
 require 'set'