asana-ruby 0.0.2 → 0.0.3

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: fcb87ac5035e40cf6275846cbeb6eb1d2bfa544c
+  data.tar.gz: 64791fb64e5711bd87b63eec22392c4a24fb3fc1
+SHA512:
+  metadata.gz: dab1fb334f808dd446e96b13a7f3bab3d02cfe76d6bde00934d0eeed21ff58e6a21c78e79408156ba0a96b0394989c5a909d32ff7e383e178f1eb0bf94b249be
+  data.tar.gz: f117a8d20c4e1de00c7544050183183f29187b23797017ef99e761d8c73e70401b110cd4ab430d54a8eb3329af2dc7616032a510918d3ac45cb2ecf759a605a2

data/.ruby-gemset

@@ -0,0 +1 @@
+asana-ruby

data/.ruby-version

@@ -0,0 +1 @@
+2.0.0

data/asana.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'rspec', '~> 2.11'
   gem.add_development_dependency 'guard'
   gem.add_development_dependency 'guard-rspec'
-  gem.add_development_dependency 'vcr', '~> 2.2.4'
+  gem.add_development_dependency 'vcr', '2.6.0'
   gem.add_development_dependency 'webmock', '~> 1.8.8'
   gem.add_development_dependency 'pry'
   gem.add_development_dependency 'pry-debugger'

data/lib/asana/resources/tag.rb

@@ -1,3 +1,5 @@
 class Asana::Tag < Asana::Resource
-
+  def tasks
+    get(:tasks)
+  end
 end

data/lib/asana/resources/task.rb

@@ -1,5 +1,5 @@
 module Asana
-  class Task < Asana::Resource
+  class Task < Resource
     # don't want update_attribute because it posts all data to asana instead of just changed attributes
     alias :update_attribute :method_not_allowed
     # create a task via a project or workspace instead

data/lib/asana/resources/workspace.rb

@@ -1,4 +1,3 @@
-require 'pry'
 module Asana
   class Workspace < Asana::Resource
     def create_task(options = {})
@@ -20,24 +19,47 @@ module Asana
     def tasks(options = {})
       options.merge!(assignee: 'me') unless options[:assignee] or options['assignee']
 
-      get("tasks?assignee=#{options[:assignee]}").map{|h| Asana::Task.find h["id"]}
+      url = "tasks?assignee=#{options[:assignee]}"
+
+      url += "&include_archived=true" if options[:include_archived]
+
+      get(url).map { |h| Asana::Task.find h["id"] }
     rescue Exception => e
       $stderr.puts "ERROR: #{e.message}"
       $stderr.puts "RESPONSE: #{e.response.body}" if e.respond_to?(:response)
     end
 
+    def completed_tasks
+      tasks.select(&:completed?)
+    end
+
     # TODO imporve this when Asana API is more advanced
     def find_or_create_tag(options = {})
-      tags.find {|t| t.name == options[:name]} || create_tag(options)
+      options[:name].strip! if options[:name]
+
+      # try to load from cache first, if not found, force reload, if still not found, create one
+      find_tag_from_list(tags, options) || find_tag_from_list(tags(true), options) || create_tag(options)
     end
 
     def create_tag(options = {})
       response = post("tags", nil, {data: options}.to_json)
-      Asana::Tag.new(connection.format.decode(response.body))
+      Asana::Tag.new(connection.format.decode(response.body), true)
     end
 
-    def tags
+    # Resource.new(record, true) is the trick to initialize a persisted record
+    def tags(force_reload = false)
+      return @tags if defined?(@tags) and !force_reload
+      @tags ||= get(:tags).map{|h| Asana::Tag.new(h, true)}
+    end
+
+    # expensive query: reload each task by id
+    # only use this if Asana::Tag.new(tag, true) doesn't work as expected
+    def load_tags_by_id
       get(:tags).map{|h| Asana::Tag.find h["id"]}
     end
+
+    def find_tag_from_list(tag_list, options = {})
+      tag_list.find {|t| t.name && options[:name] && t.name.strip == options[:name] }
+    end
   end
 end

data/lib/asana/version.rb

@@ -1,3 +1,3 @@
 module Asana
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/asana/resources/project_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
 module Asana
-  describe Project do
-    use_vcr_cassette
+  describe Project, vcr: true do
     before do
       authorize_with_asana
     end
@@ -10,7 +9,7 @@ module Asana
     describe '.all' do
       it 'should return all of the user\'s projects' do
         projects = Project.all
-        projects.should be_instance_of Array
+        projects.should be_instance_of ActiveResource::Collection
         projects.first.should be_instance_of Project
       end
     end

data/spec/asana/resources/tag_spec.rb

@@ -2,6 +2,23 @@ require 'spec_helper'
 
 module Asana
   describe Tag do
+    describe "#tasks" do
+      let(:tag) { Tag.new }
 
+      before do
+        Asana.configure do |nothing|
+        end
+
+        tag.stub(:id).and_return("1234")
+      end
+
+      it "should get the info from /tags/<tag id>/tasks" do
+        fake_response = double("response", body: "{}")
+        fake_connection = double("ActiveResource::Connection")
+        expect(fake_connection).to receive(:get).with("/api/1.0/tags/1234/tasks", anything()).and_return(fake_response)
+        expect(tag).to receive(:connection).and_return(fake_connection)
+        tag.tasks
+      end
+    end
   end
 end

data/spec/asana/resources/task_spec.rb

@@ -1,7 +1,6 @@
 require 'spec_helper'
 
-describe Asana::Task do
-  use_vcr_cassette
+describe Asana::Task, vcr: true do
   before do
     authorize_with_asana
   end

data/spec/asana/resources/user_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
 module Asana
-  describe User do
-    use_vcr_cassette
+  describe User, vcr: true do
     before do
       authorize_with_asana
     end

data/spec/asana/resources/workspace_spec.rb

@@ -1,8 +1,7 @@
 require 'spec_helper'
 
 module Asana
-  describe Workspace do
-    use_vcr_cassette
+  describe Workspace, vcr: true do
     before do
       authorize_with_asana
     end
@@ -40,25 +39,64 @@ module Asana
       it "should return task instances" do
         workspace.tasks.first.should be_instance_of Task
       end
+
+      context "with include_archived set to true in options" do
+        it "should pass the option as part of the query string for the API endpoint" do
+          stub_request(:any, "app.asana.com")
+          workspace.tasks(include_archived: true)
+
+          to_url = %r{app.asana.com/api/1.0/workspaces/#{workspace.id}/tasks}
+          a_request(:get, to_url).with(
+            query: hash_including({include_archived: 'true'})
+          ).should have_been_made
+        end
+      end
+    end
+
+    describe ".completed_tasks" do
+      it "returns only completed tasks" do
+        expect(workspace.completed_tasks.all?(&:completed)).to be
+      end
     end
 
     describe "tags" do
+      let(:fake_tag) { double("Asana::Tag", name: "Test") }
+
       subject { workspace }
       its(:tags) { should be_instance_of Array }
       it "should return task instances" do
         workspace.tags.first.should be_instance_of Tag
       end
+
+      it "should memoize tags" do
+        expect(Asana::Tag).to receive(:new).and_return(fake_tag)
+        Asana::Tag.stub(:new).and_return(fake_tag)
+        expect(workspace).to receive(:get).once.and_return([fake_tag])
+        workspace.tags # first time
+        workspace.tags # second time
+      end
+
+      it "should return the same result with force_reload (if no changes)" do
+        expect(workspace.tags.size).to be > 0 # it'd be meaningless to compare if there are no tags
+        expect(workspace.tags).to eq workspace.tags(true)
+      end
     end
 
     describe ".find_or_create_tag" do
+      let(:fake_tag) { double("Asana::Tag", name: "Test") }
+
+      before do
+        expect(workspace).to receive(:tags).at_least(:once).and_return([fake_tag])
+      end
+
       it "should not create two tags of the same name" do
-        tag1 = workspace.find_or_create_tag(name: 'test .find_or_create_tag')
-        tag2 = workspace.find_or_create_tag(name: 'test .find_or_create_tag')
-        tag1.id.should == tag2.id
+        test_tag = workspace.find_or_create_tag(name: "Test")
+        expect(test_tag).to be(fake_tag)
       end
 
-      it "should only create tag account by one" do
-        expect { 3.times { workspace.find_or_create_tag(name: '3 times') } }.to change { workspace.tags.size }.by(1)
+      it "should create a tag that doesn't yet exist" do
+        new_tag = workspace.find_or_create_tag(name: "Nope")
+        expect(new_tag).to be_instance_of(Asana::Tag)
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,4 +1,5 @@
 require 'asana'
+require 'webmock/rspec'
 require 'vcr'
 require 'active_resource'
 
@@ -6,10 +7,7 @@ VCR.configure do |c|
   c.cassette_library_dir = 'spec/fixtures/cassettes'
   c.hook_into :webmock
   c.default_cassette_options = { :record => :new_episodes }
-end
-
-RSpec.configure do |c|
-  c.extend VCR::RSpec::Macros
+  c.configure_rspec_metadata!
 end
 
 def authorize_with_asana

metadata

@@ -1,115 +1,141 @@
 --- !ruby/object:Gem::Specification
 name: asana-ruby
 version: !ruby/object:Gem::Version
-  version: 0.0.2
-  prerelease: 
+  version: 0.0.3
 platform: ruby
 authors:
 - Harley Trung
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-07-31 00:00:00.000000000 Z
+date: 2013-10-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
-  requirement: &2164496820 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '3.0'
   type: :runtime
   prerelease: false
-  version_requirements: *2164496820
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rake
-  requirement: &2164495280 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2164495280
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
-  requirement: &2164530680 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: '2.11'
   type: :development
   prerelease: false
-  version_requirements: *2164530680
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '2.11'
 - !ruby/object:Gem::Dependency
   name: guard
-  requirement: &2164528100 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2164528100
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: guard-rspec
-  requirement: &2164525920 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2164525920
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: vcr
-  requirement: &2152078520 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - '='
       - !ruby/object:Gem::Version
-        version: 2.2.4
+        version: 2.6.0
   type: :development
   prerelease: false
-  version_requirements: *2152078520
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.6.0
 - !ruby/object:Gem::Dependency
   name: webmock
-  requirement: &2152058920 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.8.8
   type: :development
   prerelease: false
-  version_requirements: *2152058920
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 1.8.8
 - !ruby/object:Gem::Dependency
   name: pry
-  requirement: &2152053660 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2152053660
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry-debugger
-  requirement: &2164691420 !ruby/object:Gem::Requirement
-    none: false
+  requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ! '>='
+    - - '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
-  version_requirements: *2164691420
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Ruby API wrapper for Asana, supporting workspaces, projects, tasks, tags,
   users and stories
 email:
@@ -119,6 +145,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- .ruby-gemset
+- .ruby-version
 - Gemfile
 - Guardfile
 - LICENSE
@@ -146,33 +174,26 @@ files:
 - spec/spec_helper.rb
 homepage: ''
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4158906422461001836
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4158906422461001836
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.17
+rubygems_version: 2.0.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Ruby wrapper for Asana
 test_files:
 - spec/asana/asana_spec.rb