as_json_representations 0.5.0 → 0.6.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: daa006efc48883832cee9320fdd7c6f97857739664befca6e43a9926b7e32f87
-  data.tar.gz: aca509444daca9ce848074ddab33a5e7db143d5bc4aef381fb55e8c62f208fc5
+  metadata.gz: 1a8d39dc3e4957b77b602263d9193606cd5ab4989fbb035512eb921c7df2bd8d
+  data.tar.gz: bd36c60219711176968616cebc6851afbd73e8e4af4543d4eb319570fc1d5be0
 SHA512:
-  metadata.gz: 171f411f75287d344bfc1372dbde7fdaf97384c149ca704ef948eff4330d23fbb91e2f15057a42f3184e783a767025da2de26aaa931e3e68c062a25dcdcd372c
-  data.tar.gz: 0257036af2c8696a39a11afe994523c178185c705a00bb448cbfd04125cd457701420c3c122cad7605ca14ddd6cc89f1039742e18f5176c3c22d51d962b94840
+  metadata.gz: 57cfcc22d77af7b41ab3540c7692ef12e49e9fad3c1b23f347782154db756a5717438e115d52d5b4bad32b6fd8cf3afac303ce4277797483ff9c7bd842154d31
+  data.tar.gz: 546a24dea5c3e795761b1ff9ad693401da479ab38061865920372bb3272b1c89207f7c46d4b6af41bc00d613e6dd35ead5b24eafa2e7748c34667f1394bebfd7

data/.gitignore

@@ -9,4 +9,5 @@
 
 # rspec failure tracking
 .rspec_status
+.byebug_history
 *.gem

data/CHANGELOG.md

@@ -0,0 +1,9 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
+and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
+
+## [v0.6.1] - 2022-02-24
+- Fixed bug when use string as representation name with collections
+

data/Gemfile

@@ -1,6 +1,8 @@
-source "https://rubygems.org"
+source 'https://rubygems.org'
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in as_json_representations.gemspec
 gemspec
+
+gem 'byebug'

data/Gemfile.lock

@@ -1,13 +1,14 @@
 PATH
   remote: .
   specs:
-    as_json_representations (0.5.0)
+    as_json_representations (0.6.1)
 
 GEM
   remote: https://rubygems.org/
   specs:
+    byebug (11.0.1)
     diff-lcs (1.3)
-    rake (10.5.0)
+    rake (13.0.1)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)
       rspec-expectations (~> 3.7.0)
@@ -27,9 +28,10 @@ PLATFORMS
 
 DEPENDENCIES
   as_json_representations!
-  bundler (~> 1.15)
-  rake (~> 10.0)
+  bundler (~> 2.3)
+  byebug
+  rake (~> 13.0)
   rspec (~> 3.0)
 
 BUNDLED WITH
-   1.17.2
+   2.3.8

data/README.md

@@ -155,6 +155,8 @@ When you includes representation module (parent) into other module (child):
 You can use this ActiveRecord option when you define a representation:
 
 * [includes](https://apidock.com/rails/ActiveRecord/QueryMethods/includes)
+* [eager_load](https://apidock.com/rails/ActiveRecord/QueryMethods/eager_load)
+* [preload](https://apidock.com/rails/ActiveRecord/QueryMethods/preload)
 
 ```
 representation :private, includes: [:city]

data/as_json_representations.gemspec

@@ -21,7 +21,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.add_development_dependency 'bundler', '~> 1.15'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler', '~> 2.3'
+  spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rspec', '~> 3.0'
 end

data/lib/as_json_representations/collection.rb

@@ -8,15 +8,18 @@ module AsJsonRepresentations
       base.class_eval do
         def as_json(options={})
           subject = self
+          representation = options[:representation]&.to_sym
 
-          # call supported methods of ActiveRecord::QueryMethods
-          %i[includes eager_load].each do |method|
-            next unless respond_to? method
+          if representation && respond_to?(:klass) && klass.respond_to?(:representations)
+            # call supported methods of ActiveRecord::QueryMethods
+            QUERY_METHODS.each do |method|
+              next unless respond_to? method
 
-            args = klass.representations.dig(options[:representation], method)
+              args = klass.representations.dig(representation, method)
 
-            # we need to reassign because ActiveRecord returns new object
-            subject = subject.public_send(method, args) if args
+              # we need to reassign because ActiveRecord returns new object
+              subject = subject.public_send(method, args) if args
+            end
           end
 
           return super if respond_to? :super

data/lib/as_json_representations/version.rb

@@ -1,3 +1,3 @@
 module AsJsonRepresentations
-  VERSION = '0.5.0'
+  VERSION = '0.6.1'
 end

data/lib/as_json_representations.rb

@@ -1,6 +1,8 @@
 require 'as_json_representations/collection.rb'
 
 module AsJsonRepresentations
+  QUERY_METHODS = %i[includes eager_load preload].freeze
+
   module ClassMethods
     def representation(name, options={}, &block)
       @representations ||= {}
@@ -11,7 +13,7 @@ module AsJsonRepresentations
       extend_representation_name = options[:extend] == true ? name : options[:extend]
       extend_representation = (parent_entity || self).representations[extend_representation_name]
 
-      %i[includes eager_load].each do |option|
+      QUERY_METHODS.each do |option|
         next unless (extend_option_value = extend_representation[option])
         @representations[name][option] = extend_option_value + (options[option] || [])
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: as_json_representations
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.6.1
 platform: ruby
 authors:
 - rjurado01
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-08-24 00:00:00.000000000 Z
+date: 2022-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -62,6 +62,7 @@ files:
 - ".gitignore"
 - ".rspec"
 - ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - Gemfile.lock
 - LICENSE.txt
@@ -92,7 +93,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: Creates representations of your model data