as_deprecation_tracker 1.5.0 → 1.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 423aa104af4ca208621d8c1e8eee3c3fb1c1ed4f
-  data.tar.gz: 841eec03f2e5fec185ff747b9413978d58d44e3f
+SHA256:
+  metadata.gz: 94c74b7722e33f69b5743cbfc62be2865ca4c21cca306debf8074a77a7bffdac
+  data.tar.gz: 865ab2109f6932f7d6a3b273c96beca663d30f3620f31b0f24c53da51111f6a6
 SHA512:
-  metadata.gz: c135f7983f1fda478172f436ef533aa135ae2dabcceaaca184f851614180ebcd1ffc1545d1cbc02d1fabd9ea466351185aa0c54ac0617299308d1b356b954ae7
-  data.tar.gz: c6fda97efae671f2e1875905bd694903023322e12441677520405698330b3b7970b7be9ea892399ad8b97f39c8ae169f82433e31260ca19bf84e9c6484804fdc
+  metadata.gz: 41e1b084ad9861d787f81595f80051785bba2cecd63510a755d60d0c310159d5185afd1a60f05037d71cbe510f26bb7084b687c21e99cb7daec663c7a83aff9d
+  data.tar.gz: 5a4e354638d0097fd9089e09e7a52ebb19b0af04d930717a13641ac091c581befc20bab1133e1e289f8bcde75b13dee425e7457f4d4bff730ad94f7621af888e

data/.github/workflows/ci.yml

@@ -0,0 +1,38 @@
+---
+name: CI
+
+on:
+  pull_request:
+  push:
+
+
+concurrency:
+  group: ${{ github.ref_name }}
+  cancel-in-progress: true
+
+jobs:
+  ruby:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby_version:
+          - '2.7.6'
+          - '3.0.4'
+          - '3.1.2'
+        rails_version:
+          - '6.0.5.1'
+          - '6.1.6.1'
+          - '7.0.3.1'
+          - '7.1.6'
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby_version }}
+          bundler-cache: true
+        env:
+          RAILS_VERSION: ${{ matrix.rails_version }}
+      - name: Run tests
+        run: bundle exec rake

data/CHANGELOG.md

@@ -5,6 +5,16 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](http://keepachangelog.com/)
 and this project adheres to [Semantic Versioning](http://semver.org/).
 
+## 1.7.0
+
+### Fixed
+- Fix compatibility with Rails 7.1 (PR thanks to @lhellebr)
+
+## 1.6.0
+
+### Fixed
+- Fix array splat errors under Ruby 3 (PR thanks to @evgeni)
+
 ## 1.5.0
 
 ### Added

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2016-2017 Dominic Cleal
+Copyright (c) 2016-2022 Dominic Cleal
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/README.md

@@ -1,3 +1,13 @@
+# This gem is deprecated
+
+This gem is no longer maintained and users should consider migrating to
+`deprecation_toolkit` instead, which is more likely to work with newer Ruby and
+Rails versions.
+
+* [Shopify: Introducing the deprecation toolkit](https://engineering.shopify.com/blogs/engineering/introducing-the-deprecation-toolkit)
+* [deprecation_toolkit (GitHub)](https://github.com/shopify/deprecation_toolkit)
+* [deprecation_toolkit (RubyGems)](https://rubygems.org/gems/deprecation_toolkit)
+
 # as_deprecation_tracker
 
 Tracks known ActiveSupport (Rails) deprecation warnings and catches new issues
@@ -143,6 +153,15 @@ initialisation, as deprecation processing can be disabled until the whitelist
 is fully formed. ASDT will queue events while paused and processes them when
 `resume!` is called.
 
+## Alternatives
+
+Shopify have open-sourced a gem that works very similarly to ASDT and is worth
+a look. It supports more configuration options when seeing a new or removed
+deprecation warning, and also supports `Kernel#warn`.
+
+* [Shopify: Introducing the deprecation toolkit](https://engineering.shopify.com/blogs/engineering/introducing-the-deprecation-toolkit)
+* [deprecation_toolkit (GitHub)](https://github.com/shopify/deprecation_toolkit)
+
 ## License
 
-Copyright (c) 2016-2017 Dominic Cleal.  Distributed under the MIT license.
+Copyright (c) 2016-2022 Dominic Cleal.  Distributed under the MIT license.

data/Rakefile

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 require 'rubocop/rake_task'
@@ -11,4 +12,4 @@ end
 
 RuboCop::RakeTask.new
 
-task default: %w(rubocop test)
+task default: %w[rubocop test]

data/config.ru

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'rubygems'
 require 'bundler'
 

data/lib/as_deprecation_tracker/configuration.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ASDeprecationTracker
   # Maintains configuration for one instance (usually global)
   class Configuration
@@ -6,7 +7,7 @@ module ASDeprecationTracker
     alias register_behavior? register_behavior
 
     def initialize
-      @envs = %w(test)
+      @envs = %w[test]
       @line_tolerance = 10
       @register_behavior = ASDeprecationTracker.env('DISABLE').nil?
       @whitelist_file = File.join('config', 'as_deprecation_whitelist.yaml')

data/lib/as_deprecation_tracker/railtie.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'as_deprecation_tracker/receiver'
 
 module ASDeprecationTracker
@@ -6,7 +7,16 @@ module ASDeprecationTracker
   class Railtie < ::Rails::Railtie
     initializer 'as_deprecation_tracker.deprecation_notifications', after: :load_environment_config, if: -> { ASDeprecationTracker.active? } do
       Receiver.attach_to :rails, ASDeprecationTracker.receiver
-      ActiveSupport::Deprecation.behavior = :notify if ASDeprecationTracker.config.register_behavior?
+
+      if ASDeprecationTracker.config.register_behavior?
+        # Rails >= 7.1 deprecates ActiveSupport::Deprecation.behavior= in favor of the
+        # per-application deprecators registry; older Rails versions don't have it.
+        if Rails.application.respond_to?(:deprecators)
+          Rails.application.deprecators.behavior = :notify
+        else
+          ActiveSupport::Deprecation.behavior = :notify
+        end
+      end
 
       whitelist = ASDeprecationTracker.config.whitelist_file
       ([Rails.root] + engine_roots).each do |root|

data/lib/as_deprecation_tracker/receiver.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'active_support/subscriber'
 require 'as_deprecation_tracker/writer'
 

data/lib/as_deprecation_tracker/version.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module ASDeprecationTracker
-  VERSION = '1.5.0'.freeze
+  VERSION = '1.7.0'
 end

data/lib/as_deprecation_tracker/whitelist.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'as_deprecation_tracker/whitelist_entry'
 
 module ASDeprecationTracker
@@ -12,7 +13,7 @@ module ASDeprecationTracker
     end
 
     def add_to_list(*entries)
-      entries.flatten.each { |entry| @list << WhitelistEntry.new(entry.symbolize_keys) }
+      entries.flatten.each { |entry| @list << WhitelistEntry.new(**entry.symbolize_keys) }
     end
     alias add add_to_list
 

data/lib/as_deprecation_tracker/whitelist_entry.rb

@@ -1,9 +1,10 @@
 # frozen_string_literal: true
+
 module ASDeprecationTracker
   # Configuration of a whitelisted (known) deprecation warning matched by data
   # such as a message and/or callstack
   class WhitelistEntry
-    KNOWN_KEYS = %w(callstack engine message).freeze
+    KNOWN_KEYS = %w[callstack engine message].freeze
     MESSAGE_CLEANUP_RE = Regexp.new('\ADEPRECATION WARNING: (.+) \(called from.*')
     CALLSTACK_FILE_RE = Regexp.new('\A(.*?)(?::(\d+))?(?::in `(.+)\')?\z')
 
@@ -13,14 +14,13 @@ module ASDeprecationTracker
       @message = message
     end
 
-    # rubocop:disable Metrics/CyclomaticComplexity
     def matches?(deprecation)
       return false if @message.present? && !message_matches?(deprecation[:message])
       return false if @callstack.present? && !callstack_matches?(deprecation[:callstack])
       return false if @engine_root.present? && !engine_root_matches?(deprecation[:callstack])
+
       true
     end
-    # rubocop:enable Metrics/CyclomaticComplexity
 
     private
 
@@ -60,11 +60,13 @@ module ASDeprecationTracker
 
     def line_number_within_tolerance(line1, line2)
       return true if line1.nil? || line2.nil?
+
       (line1 - line2).abs <= ASDeprecationTracker.config.line_tolerance
     end
 
     def method_name_matches(method1, method2)
       return true if method1.nil? || method2.nil?
+
       method1 == method2
     end
 
@@ -76,7 +78,7 @@ module ASDeprecationTracker
       ::Rails::Engine.descendants.each do |engine|
         begin
           return engine.root.to_s if engine_name.to_s == engine.engine_name.to_s
-        rescue NoMethodError, RuntimeError # rubocop:disable Lint/HandleExceptions
+        rescue NoMethodError, RuntimeError
           # Ignore failures with singleton engine subclasses etc.
         end
       end

data/lib/as_deprecation_tracker/writer.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'as_deprecation_tracker/whitelist_entry'
 require 'rails/backtrace_cleaner'
 

data/lib/as_deprecation_tracker.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 # Entry point, provides constant with access to global configuration only
 module ASDeprecationTracker
   require 'as_deprecation_tracker/configuration'
@@ -36,6 +37,6 @@ module ASDeprecationTracker
   end
 
   def self.env(name)
-    ENV.fetch("AS_DEPRECATION_#{name}", ENV["ASDT_#{name}"])
+    ENV.fetch("AS_DEPRECATION_#{name}", ENV.fetch("ASDT_#{name}", nil))
   end
 end

data/test/as_deprecation_tracker_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 class ASDeprecationTrackerTest < ASDeprecationTracker::TestCase

data/test/configuration_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 class ConfigurationTest < ASDeprecationTracker::TestCase

data/test/internal/config/routes.rb

@@ -1,4 +1,3 @@
 # frozen_string_literal: true
-Rails.application.routes.draw do
-  #
-end
+#
+# No routes in test app

data/test/railtie_test.rb

@@ -1,8 +1,14 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 class RailtieTest < ASDeprecationTracker::TestCase
   def test_deprecation_behavior
-    assert_equal [ActiveSupport::Deprecation::DEFAULT_BEHAVIORS[:notify]], ActiveSupport::Deprecation.behavior
+    behavior = if Rails.application.respond_to?(:deprecators)
+                 ActiveSupport.deprecator.behavior
+               else
+                 ActiveSupport::Deprecation.behavior
+               end
+    assert_equal [ActiveSupport::Deprecation::DEFAULT_BEHAVIORS[:notify]], behavior
   end
 end

data/test/receiver_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 class ReceiverTest < ASDeprecationTracker::TestCase

data/test/test_helper.rb

@@ -1,6 +1,11 @@
 # frozen_string_literal: true
+
 require 'minitest/autorun'
-require 'mocha/mini_test'
+require 'mocha/minitest'
+# Rails < 7.1's active_support/logger_thread_safe_level.rb uses Logger without
+# requiring it, relying on something else to have loaded it first. combustion's
+# minimal footprint doesn't happen to, unlike a typical full Rails app.
+require 'logger'
 require 'combustion'
 
 require 'as_deprecation_tracker'
@@ -17,7 +22,7 @@ module ASDeprecationTracker
         ENV.update(new_env)
         yield
       ensure
-        new_env.keys.each { |k| ENV.delete(k) }
+        new_env.each_key { |k| ENV.delete(k) }
         ENV.update(backup)
       end
     end

data/test/whitelist_entry_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 class WhitelistEntryTest < ASDeprecationTracker::TestCase
@@ -133,9 +134,9 @@ class WhitelistEntryTest < ASDeprecationTracker::TestCase
 
   def entry(overrides = {})
     entry_hash = default_deprecation.merge(overrides).compact
-    entry_hash[:callstack].map! { |line| line.sub(Rails.root.to_s + '/', '') } if entry_hash[:callstack].is_a?(Array)
+    entry_hash[:callstack].map! { |line| line.sub("#{Rails.root}/", '') } if entry_hash[:callstack].is_a?(Array)
 
     ASDeprecationTracker::WhitelistEntry.any_instance.expects(:engine_root).with(overrides[:engine]).returns("/home/user/engines/#{overrides[:engine]}") if overrides.key?(:engine)
-    ASDeprecationTracker::WhitelistEntry.new(entry_hash)
+    ASDeprecationTracker::WhitelistEntry.new(**entry_hash)
   end
 end

data/test/whitelist_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 class WhitelistTest < ASDeprecationTracker::TestCase

data/test/writer_test.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 require 'test_helper'
 
 class WriterTest < ASDeprecationTracker::TestCase

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: as_deprecation_tracker
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 1.7.0
 platform: ruby
 authors:
 - Dominic Cleal
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-04-03 00:00:00.000000000 Z
+date: 2026-08-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -45,6 +45,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/ci.yml"
 - CHANGELOG.md
 - LICENSE
 - README.md
@@ -73,8 +74,9 @@ files:
 homepage: https://github.com/domcleal/as_deprecation_tracker
 licenses:
 - MIT
-metadata: {}
-post_install_message: 
+metadata:
+  rubygems_mfa_required: 'true'
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -89,9 +91,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.8
-signing_key: 
+rubygems_version: 3.5.9
+signing_key:
 specification_version: 4
 summary: Track known ActiveSupport deprecation warnings
 test_files: []