as2 0.5.0 → 0.5.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 40b3957adcdaa34f7df9fe0ee83966f7076e80bc9dc9c02b8f27a4fb22395fda
-  data.tar.gz: 1d8002959f6b4afa70c94fd363c9d97c15b2f20a82ee96b1bc39ebba8a55972e
+  metadata.gz: 2cc88a7c3befd19715a142f886fcac0429911b1b2c6d4df8e5c6f6797c6469c2
+  data.tar.gz: ba6943a989242be148d7e39c896f61747b8455888883b60ff179d6bf53e25309
 SHA512:
-  metadata.gz: bb04b23ab84f14e131e74e3a213e71ae5f3009f805af08b7cc1c88dc3798745639e4cffea1a85811df51a522776797f236da98c82ab84863dd5891c0b37fc243
-  data.tar.gz: a71c9ea6c4c82637103ae1353e5b54cee88ad4f52b388883b0b409c24722247bbd0ead903ca5ef00ba1df41403ab11f1d6b4b03f9d03f58af39ccb399848adf0
+  metadata.gz: 14dc1ecb69d8678db913d9ee2425ae35f3e2e1b9a927a3a573e36e9a704dd4a7ab994d7c98182bf0053f40520040f0001fbc8b1390c82ebd57aa7e5c3495e99c
+  data.tar.gz: e43327ebbeac9bd46a2ccc4e3cd13f6354de46a3507fe01b134ecf33feef6643555c63e2ad2310debf8b3a23ec88c985d869087bf4cce29a2c54d8d06cfa753a

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.5.1, August 10, 2022
+
+  * Any HTTP 2xx status received from a partner should be considered successful. [#12](https://github.com/andjosh/as2/pull/12)
+
 ## 0.5.0, March 21, 2022
 
   * improvements to `As2::Client`. improve compatibility with non-Mendelson AS2 servers. [#8](https://github.com/andjosh/as2/pull/8)

data/README.md

@@ -30,12 +30,10 @@ along.
        will see a MIC verification failure. AS2 RFC specifically prefers sha1 and
        mentions md5. Mendelson AS2 server supports a number of other algorithms.
        (sha256, sha512, etc)
-  2. Payload bodies (typically EDI files) can be binary or base64 encoded. We
-     error if the body is not base64-encoded.
-  3. Payload bodies can have a few different mime types. We expect only
-     `application/EDI-Consent`. We're unable to receive content that has any other
+  2. Payload bodies can have a few different mime types. We expect a type that
+     matches `application/EDI-*`. We're unable to receive content that has any other
      mime type. https://datatracker.ietf.org/doc/html/rfc1767#section-1
-  4. AS2 partners may agree to use separate certificates for data encryption and data signing.
+  3. AS2 partners may agree to use separate certificates for data encryption and data signing.
      We do not support separate certificates for these purposes.
 
 ## Installation

data/as2.gemspec

@@ -11,7 +11,7 @@ Gem::Specification.new do |spec|
 
   spec.summary       = %q{Simple AS2 server and client implementation}
   spec.description   = %q{Simple AS2 server and client implementation. Follows the AS2 implementation from http://as2.mendelson-e-c.com}
-  spec.homepage      = "https://github.com/andjosh/as2"
+  spec.homepage      = "https://github.com/alexdean/as2"
   spec.license       = "MIT"
 
   # Prevent pushing this gem to RubyGems.org by setting 'allowed_push_host', or

data/lib/as2/client.rb

@@ -95,7 +95,7 @@ module As2
           resp = http.request(req)
         end
 
-        if resp.code == '200'
+        if resp && resp.code.start_with?('2')
           mdn_report = evaluate_mdn(
                          mdn_content_type: resp['Content-Type'],
                          mdn_body: resp.body,

data/lib/as2/message.rb

@@ -2,6 +2,28 @@ module As2
   class Message
     attr_reader :verification_error
 
+    # given multiple parts of a message, choose the one most likely to be the actual content we care about
+    #
+    # @param [Array<Mail::Part>]
+    # @return [Mail::Part, nil]
+    def self.choose_attachment(mail_parts)
+      return nil if mail_parts.nil?
+
+       # if there are multiple content parts, try to prefer the EDI content.
+      candidates = mail_parts
+                   .select { |part| part.content_type.to_s['pkcs7-signature'].nil? } # skip signature
+                   .sort_by { |part| part.content_type.to_s.match(/^application\/edi/i) ? 0 : 1 }
+      candidates[0]
+    end
+
+    # @param [Mail::Part] attachment
+    # @param [String] mic_algorithm
+    # @return [String] message integrity check string
+    def self.mic(attachment, mic_algorithm)
+      digest = As2::DigestSelector.for_code(mic_algorithm)
+      digest.base64digest(attachment.raw_source.lstrip)
+    end
+
     def initialize(message, private_key, public_certificate)
       # TODO: might need to use OpenSSL::PKCS7.read_smime rather than .new sometimes
       @pkcs7 = OpenSSL::PKCS7.new(message)
@@ -80,8 +102,7 @@ module As2
     end
 
     def mic
-      digest = As2::DigestSelector.for_code(mic_algorithm)
-      digest.base64digest(attachment.raw_source.strip)
+      self.class.mic(attachment, mic_algorithm)
     end
 
     def mic_algorithm
@@ -90,13 +111,11 @@ module As2
 
     # Return the attached file, use .filename and .body on the return value
     def attachment
-      if mail.has_attachments?
-        # TODO: match 'application/edi*', test with 'application/edi-x12'
-        # test also with "application/edi-consent; name=this_is_a_filename.txt"
-        mail.parts.find{ |a| a.content_type.match(/^application\/edi/) }
-      else
-        mail
-      end
+      self.class.choose_attachment(parts)
+    end
+
+    def parts
+      mail&.parts
     end
 
     private

data/lib/as2/version.rb

@@ -1,3 +1,3 @@
 module As2
-  VERSION = "0.5.0"
+  VERSION = "0.5.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: as2
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.2
 platform: ruby
 authors:
 - OfficeLuv
@@ -9,7 +9,7 @@ authors:
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-03-21 00:00:00.000000000 Z
+date: 2022-09-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: mail
@@ -168,7 +168,7 @@ files:
 - lib/as2/mime_generator.rb
 - lib/as2/server.rb
 - lib/as2/version.rb
-homepage: https://github.com/andjosh/as2
+homepage: https://github.com/alexdean/as2
 licenses:
 - MIT
 metadata: