arx 0.3.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b2fa216412d2bdf6261f3fd1ada0b0c50498f13e5a8142dfd3db3433b693e4b4
-  data.tar.gz: 31c272fcc9d1ed4750e88d4c179035a0f37995f1afc030378e656f402a2dfeec
+  metadata.gz: 71eb1bee2ff468ea9327736e613e40b414c2b630d4f21b148da648500af3a47e
+  data.tar.gz: 8592a476d3abbeedfe2bef11637498b551fd478d643c5985a7c6a119aa79ca80
 SHA512:
-  metadata.gz: 8b8c8abf18d875a40e098f95dfb7452389a3b44691ecae568028563b12e5aa02e8b0233bf7fdfc25df58594df30b43f4caca37cf57df43240006ff22a5cfcdec
-  data.tar.gz: a8a40c0d3ccd18a86945e69a136b2275dcfd88a2ddc3678ab3b555f576e68b1d50d346b1c1a233def7bff62cb60fa0a071a870fcd6c41f34dcb8cf217d422437
+  metadata.gz: c9d708bd3f7d244f8557da0c9dba42d66c9a344a8f0316463879e76cc385fcf895c4c4089a5340543e166d771958d975fac685d27908755be0575e97f70625c2
+  data.tar.gz: 382f4ec892499c9e3b062693755aaa4af6c86790a830aaee39a2435d8af902d7e6bdcfc91712eaa539ef3e066c6a6ae04c151327951477194b0ca722848b0d2c

data/CHANGELOG.md

@@ -1,3 +1,64 @@
+# 1.1.0
+
+#### Major changes
+
+- Change `bundler` requirement to `>= 1.17` in `arx.gemspec`. ([#53](https://github.com/eonu/arx/pull/53))
+- Remove `Arx.find` alias of `Arx.search`. ([#57](https://github.com/eonu/arx/pull/57))
+- Add `Query#group` for subquery grouping support. ([#59](https://github.com/eonu/arx/pull/59))
+
+#### Minor changes
+
+- Add contributing guidelines (`CONTRIBUTING.md`). ([#48](https://github.com/eonu/arx/pull/48))
+- Add issue templates to `./github/ISSUE_TEMPLATE` for ([#49](https://github.com/eonu/arx/pull/49), [#54](https://github.com/eonu/arx/pull/54), [#55](https://github.com/eonu/arx/pull/55)):
+  - **Error or warning**<br>For reporting an error or warning generated by Arx.
+  - **Unexpected or incorrect functionality**<br>For reporting something that doesn't seem to be working correctly or is unexpected.
+  - **Improvement to an existing feature**<br>For suggesting an improvement to a feature already offered by Arx.
+  - **Suggesting a new feature**<br>For proposing a new feature to Arx that would be beneficial.
+- Add a pull request template at `./github/PULL_REQUEST_TEMPLATE.md`. ([#49](https://github.com/eonu/arx/pull/49))
+- Remove issue templates from `CONTRIBUTING.md`. ([#49](https://github.com/eonu/arx/pull/49))
+- Remove `LICENSE` from YARD documentation (remove from `.yardopts`). ([#50](https://github.com/eonu/arx/pull/50))
+- Add RVM ruby version `2.6` to `.travis.yml`. ([#53](https://github.com/eonu/arx/pull/53))
+- Add contributor code-of-conduct (`CODE_OF_CONDUCT.md`). ([#56](https://github.com/eonu/arx/pull/56))
+- Thank Scholastica in `README.md`. ([#58](https://github.com/eonu/arx/pull/58))
+- Add `bin/console` for gem debugging. ([#60](https://github.com/eonu/arx/pull/60))
+- Modify `gem:debug` rake task to run `bin/console`. ([#60](https://github.com/eonu/arx/pull/60))
+
+# 1.0.1
+
+#### Major changes
+
+- Add cases to handle `nil` query returns. ([#45](https://github.com/eonu/arx/pull/45))
+- Add support for the `coveralls` gem (`.coveralls.yml` configuration file). ([#42](https://github.com/eonu/arx/pull/42))
+
+#### Minor changes
+
+- Add code coverage badge to `README.md`. ([#42](https://github.com/eonu/arx/pull/42))
+- Remove documentation badge from top of `README.md`. ([#42](https://github.com/eonu/arx/pull/42))
+- Change author email from `ed@mail.eonu.net` to `ed@eonu.net`. ([#43](https://github.com/eonu/arx/pull/43))
+- Change `ends_with_connective?` to `end_with_connective?` to follow typical Ruby patterns. ([#44](https://github.com/eonu/arx/pull/44))
+- Add `/coverage/` directory to `.gitignore`. ([#45](https://github.com/eonu/arx/pull/45))
+- Remove version numbers from paper identifiers in error message in `README.md`. ([#46](https://github.com/eonu/arx/pull/46))
+
+# 1.0.0
+
+#### Major changes
+
+- Change `Query` connective instance methods ([#38](https://github.com/eonu/arx/pull/38)):
+  - `#&` -> `#and`
+  - `#|` -> `#or`
+  - `#!` -> `#and_not`
+- Split version number from paper identifier in `Paper` (add `version` key-word argument to `#id` and `#url`, and add `#version`). ([#39](https://github.com/eonu/arx/pull/39))
+- Add `Cleaner.extract_id` and `Cleaner.extract_version`. ([#39](https://github.com/eonu/arx/pull/39))
+- Make `Query#add_connective` always return `self`. ([#40](https://github.com/eonu/arx/pull/40))
+- Redefine `Arx.search` to user `Paper.parse`'s `search` key-word argument. ([#40](https://github.com/eonu/arx/pull/40))
+- Implement all tests. ([#40](https://github.com/eonu/arx/pull/40))
+
+#### Minor changes
+
+- Change declared regular expression literals from `%r""` to standard `//`. ([#39](https://github.com/eonu/arx/pull/39))
+- Remove `#extract_id` from `Query` and use `Cleaner.extract_id` instead. ([#39](https://github.com/eonu/arx/pull/39))
+- Redefine `Paper#revision?` to use the new `#version` instead of `#updated_at` and`#published_at`. ([#39](https://github.com/eonu/arx/pull/39))
+
 # 0.3.2
 
 #### Major changes

data/README.md

@@ -7,8 +7,8 @@
 [![License](https://img.shields.io/github/license/eonu/arx.svg)](https://github.com/eonu/arx/blob/master/LICENSE)
 
 [![Maintainability](https://api.codeclimate.com/v1/badges/e94073dfa8c3e2442298/maintainability)](https://codeclimate.com/github/eonu/arx/maintainability)
-[![Documentation](https://img.shields.io/badge/docs-rubydoc.info-blue.svg)](https://www.rubydoc.info/github/eonu/arx/master/toplevel)
 [![Build Status](https://travis-ci.com/eonu/arx.svg?branch=master)](https://travis-ci.com/eonu/arx)
+[![Coverage Status](https://coveralls.io/repos/github/eonu/arx/badge.svg?branch=feature%2Fcoveralls)](https://coveralls.io/github/eonu/arx?branch=feature%2Fcoveralls)
 
 **A Ruby interface for querying academic papers on the arXiv search API.**
 
@@ -24,6 +24,23 @@ Although [Scholastica](https://github.com/scholastica) offer a great [Ruby gem](
 
 *Arx is a gem that allows for quick and easy querying of the arXiv search API, without having to worry about manually writing your own search query strings or parse the resulting XML query response to find the data you need.*
 
+## Example
+
+Suppose we wish to search for:
+
+> Papers in the `cs.FL` (Formal Languages and Automata Theory) category whose title contains `"Buchi Automata"`, not authored by `Tomáš Babiak`, sorted by submission date (latest first).
+
+This query can be executed with the following code:
+
+```ruby
+require 'arx'
+
+papers = Arx(sort_by: :date_submitted) do |query|
+  query.category('cs.FL')
+  query.title('Buchi Automata').and_not.author('Tomáš Babiak')
+end
+```
+
 ## Features
 
 - Ruby classes `Arx::Paper`, `Arx::Author` and `Arx::Category` that wrap the resulting Atom XML query result from the search API.
@@ -43,6 +60,10 @@ $ gem install arx
 
 The documentation for Arx is hosted on [![rubydoc.info](https://img.shields.io/badge/docs-rubydoc.info-blue.svg)](https://www.rubydoc.info/github/eonu/arx/master/toplevel).
 
+## Contributing
+
+All contributions to Arx are greatly appreciated. Contribution guidelines can be found [here](/CONTRIBUTING.md).
+
 ## Usage
 
 Before you start using Arx, you'll have to ensure that the gem is required (either in your current working file, or shell such as [IRB](https://en.wikipedia.org/wiki/Interactive_Ruby_Shell)):
@@ -178,16 +199,49 @@ q.author('Dominik Edelmann')
 q.category('math.NA')
 ```
 
-To change the logical connective used to chain subqueries, use the `&()` (and), `|()` (or) and `!()` (and not) instance methods between the subquery calls:
+To change the logical connective used to chain subqueries, use the `and`, `or`, `and_not` instance methods between the subquery calls:
 
 ```ruby
 # Papers authored by "Eleonora Andreotti" in neither the "Numerical Analysis" (math.NA) or "Combinatorics (math.CO)" categories.
 q = Arx::Query.new
 q.author('Eleonora Andreotti')
-q.!()
+q.and_not
 q.category('math.NA', 'math.CO', connective: :or)
 ```
 
+#### Grouping subqueries
+
+Sometimes you'll have a query that requires nested or grouped logic, using parentheses. This can be done using the `Arx::Query#group` method.
+
+This method accepts a block and basically parenthesises the result of whichever methods were called within the block.
+
+For example, this will allow the last query from the previous section to be written as:
+
+```ruby
+# Papers authored by "Eleonora Andreotti" in neither the "Numerical Analysis" (math.NA) or "Combinatorics (math.CO)" categories.
+q = Arx::Query.new
+q.author('Eleonora Andreotti')
+q.and_not
+q.group do
+  q.category('math.NA').or.category('math.CO')
+end
+```
+
+Another more complicated example with two grouped subqueries:
+
+```ruby
+# Papers whose title contains "Buchi Automata", either authored by "Tomáš Babiak", or in the "Formal Languages and Automata Theory (cs.FL)" category and not the "Computational Complexity (cs.CC)" category.
+q = Arx::Query.new
+q.title('Buchi Automata')
+q.group do
+  q.author('Tomáš Babiak')
+  q.or
+  q.group do
+    q.category('cs.FL').and_not.category('cs.CC')
+  end
+end
+```
+
 ### Running search queries
 
 Search queries can be executed with the `Arx()` method (alias of `Arx.search`). This method contains the same parameters as the `Arx::Query` initializer - including the list of IDs.
@@ -202,9 +256,7 @@ Calling the `Arx()` method with a block allows for the construction and executio
 # Papers in the cs.FL category whose title contains "Buchi Automata", not authored by Tomáš Babiak
 results = Arx(sort_by: :date_submitted) do |query|
   query.category('cs.FL')
-  query.title('Buchi Automata')
-  query.!()
-  query.author('Tomáš Babiak')
+  query.title('Buchi Automata').and_not.author('Tomáš Babiak')
 end
 
 results.size #=> 18
@@ -220,9 +272,7 @@ The `Arx()` method accepts a predefined `Arx::Query` object through the `query`
 # Papers in the cs.FL category whose title contains "Buchi Automata", not authored by Tomáš Babiak
 q = Arx::Query.new(sort_by: :date_submitted)
 q.category('cs.FL')
-q.title('Buchi Automata')
-q.!()
-q.author('Tomáš Babiak')
+q.title('Buchi Automata').and_not.author('Tomáš Babiak')
 
 results = Arx(query: q)
 results.size #=> 18
@@ -259,9 +309,18 @@ paper = Arx('1809.09415')
 #=> #<Arx::Paper:0x00007fb657b59bd0>
 
 paper.id
+#=> "1809.09415"
+paper.id(version: true)
 #=> "1809.09415v1"
 paper.url
+#=> "http://arxiv.org/abs/1809.09415"
+paper.url(version: true)
 #=> "http://arxiv.org/abs/1809.09415v1"
+paper.version
+#=> 1
+paper.revision?
+#=> false
+
 paper.title
 #=> "On finitely ambiguous Büchi automata"
 paper.summary
@@ -280,20 +339,18 @@ paper.published_at
 #=> #<DateTime: 2018-09-25T11:40:39+00:00 ((2458387j,42039s,0n),+0s,2299161j)>
 paper.updated_at
 #=> #<DateTime: 2018-09-25T11:40:39+00:00 ((2458387j,42039s,0n),+0s,2299161j)>
-paper.revision?
-#=> false
 
 # Paper's comment
 paper.comment?
 #=> false
 paper.comment
-#=> Arx::Error::MissingField (arXiv paper 1809.09415v1 is missing the `comment` metadata field)
+#=> Arx::Error::MissingField (arXiv paper 1809.09415 is missing the `comment` metadata field)
 
 # Paper's journal reference
 paper.journal?
 #=> false
 paper.journal
-#=> Arx::Error::MissingField (arXiv paper 1809.09415v1 is missing the `journal` metadata field)
+#=> Arx::Error::MissingField (arXiv paper 1809.09415 is missing the `journal` metadata field)
 
 # Paper's PDF URL
 paper.pdf?
@@ -339,4 +396,14 @@ category.name
 #=> "cond-mat"
 category.full_name
 #=> "Condensed Matter"
-```
+```
+
+# Thanks
+
+A large portion of this library is based on the brilliant work done by [Scholastica](https://github.com/scholastica) in their [`arxiv`](https://github.com/scholastica/arxiv) gem for retrieving individual papers from arXiv through the search API.
+
+Arx was created mostly due to the seemingly inactive nature of Scholastica's repository. Additionally, it would have been infeasible to contribute such large changes to an already well-established gem, especially since https://scholasticahq.com/ appears to be dependent upon this gem.
+
+---
+
+Nevertheless, a special thanks goes out to Scholastica for providing the influence for Arx.

data/Rakefile

@@ -13,7 +13,7 @@ namespace :gem do
 
   desc 'Debug the gem (load into IRB)'
   task :debug do
-    exec 'bundle exec rake install && irb -I lib/arx.rb -r arx'
+    exec 'bin/console'
   end
 
   desc 'Prepare a new gem release'

data/arx.gemspec

@@ -6,7 +6,7 @@ Gem::Specification.new do |spec|
   spec.name          = 'arx'
   spec.version       = Arx::VERSION
   spec.authors       = ['Edwin Onuonga']
-  spec.email         = ['ed@mail.eonu.net']
+  spec.email         = ['ed@eonu.net']
   spec.homepage      = 'https://github.com/eonu/arx'
 
   spec.summary       = %q{A Ruby interface for querying academic papers on the arXiv search API.}
@@ -21,10 +21,11 @@ Gem::Specification.new do |spec|
   spec.add_runtime_dependency 'nokogiri', '~> 1.10'
   spec.add_runtime_dependency 'nokogiri-happymapper', '~> 0.8'
 
-  spec.add_development_dependency 'bundler', '~> 2.0'
+  spec.add_development_dependency 'bundler', '>= 1.17'
   spec.add_development_dependency 'rake', '~> 12.3'
-  spec.add_development_dependency 'thor', '~> 0.20'
+  spec.add_development_dependency 'thor', '~> 0.19.4'
   spec.add_development_dependency 'rspec', '~> 3.7'
+  spec.add_development_dependency 'coveralls', '0.8.22'
 
   spec.metadata = {
     'source_code_uri' => spec.homepage,

data/lib/arx/cleaner.rb

@@ -4,11 +4,50 @@ module Arx
   # @private
   class Cleaner
 
-    # Cleans strings.
-    # @param [String] string Removes newline/return characters and multiple spaces from a string.
-    # @return [String] The cleaned string.
-    def self.clean(string)
-      string.gsub(/\r\n|\r|\n/, ' ').strip.squeeze ' '
+    # arXiv paper URL prefix format
+    URL_PREFIX = /^(https?\:\/\/)?(www.)?arxiv\.org\/abs\//
+
+    class << self
+
+      # Cleans strings.
+      # @param [String] string Removes newline/return characters and multiple spaces from a string.
+      # @return [String] The cleaned string.
+      def clean(string)
+        string.gsub(/\r\n|\r|\n/, ' ').strip.squeeze ' '
+      end
+
+      # Attempt to extract an arXiv identifier from a string such as a URL.
+      #
+      # @param string [String] The string to extract the ID from.
+      # @param version [Boolean] Whether or not to include the paper's version.
+      # @return [String] The extracted ID.
+      def extract_id(string, version: false)
+        if version == !!version
+          if string.is_a? String
+            trimmed = /#{URL_PREFIX}.+\/?$/.match?(string) ? string.gsub(/(#{URL_PREFIX})|(\/$)/, '') : string
+            raise ArgumentError.new("Couldn't extract arXiv identifier from: #{string}") unless Validate.id? trimmed
+            version ? trimmed : trimmed.sub(/v[0-9]+$/, '')
+          else
+            raise TypeError.new("Expected `string` to be a String, got: #{string.class}")
+          end
+        else
+          raise TypeError.new("Expected `version` to be boolean (TrueClass or FalseClass), got: #{version.class}")
+        end
+      end
+
+      # Attempt to extract a version number from an arXiv identifier.
+      #
+      # @param string [String] The arXiv identifier to extract the version number from.
+      # @return [String] The extracted version number.
+      def extract_version(string)
+        reversed = extract_id(string, version: true).reverse
+
+        if /^[0-9]+v/.match? reversed
+          reversed.partition('v').first.reverse.to_i
+        else
+          raise ArgumentError.new("Couldn't extract version number from identifier: #{string}")
+        end
+      end
     end
   end
 end

data/lib/arx/entities/paper.rb

@@ -13,18 +13,33 @@ module Arx
     # @example
     #   1705.01662v1
     #   cond-mat/0211034
+    # @param version [Boolean] Whether or not to include the paper's version.
     # @return [String] The paper's identifier.
-    def id
-      @id.sub /https?\:\/\/arxiv\.org\/abs\//, ''
+    def id(version: false)
+      Cleaner.extract_id @id, version: version
     end
 
     # The URL of the paper on the arXiv website.
     # @example
     #   http://arxiv.org/abs/1705.01662v1
     #   http://arxiv.org/abs/cond-mat/0211034
+    # @param version [Boolean] Whether or not to include the paper's version.
     # @return [String] The paper's arXiv URL.
-    def url
-      @id
+    def url(version: false)
+      "http://arxiv.org/abs/#{id version: version}"
+    end
+
+    # The version of the paper.
+    # @return [Integer] The paper's version.
+    def version
+      Cleaner.extract_version @id
+    end
+
+    # Whether the paper is a revision or not.
+    # @note A paper is a revision if its {version} is greater than 1.
+    # @return [Boolean]
+    def revision?
+      version > 1
     end
 
     # @!method updated_at
@@ -58,13 +73,6 @@ module Arx
     # @return [Array<Category>]
     has_many :categories, Category, tag: 'category'
 
-    # Whether the paper is a revision or not.
-    # @note A paper is a revision if {updated_at} differs from {published_at}.
-    # @return [Boolean]
-    def revision?
-      @published_at != @updated_at
-    end
-
     # @!method summary
     # The summary (or abstract) of the paper.
     # @return [String]
@@ -152,9 +160,10 @@ module Arx
     end
 
     inspector *%i[
-      id url title summary authors
+      id url version revision?
+      title summary authors
       primary_category categories
-      published_at updated_at revision?
+      published_at updated_at
       comment? comment
       journal? journal
       pdf? pdf_url

data/lib/arx/query/query.rb

@@ -22,13 +22,6 @@ module Arx
       and_not: 'ANDNOT'
     }
 
-    # Logical connective method names.
-    CONNECTIVE_METHODS = {
-      '&': :and,
-      '!': :and_not,
-      '|': :or
-    }
-
     # Supported fields for the search queries made to the arXiv search API.
     # @see https://arxiv.org/help/prep arXiv metadata fields
     # @see https://arxiv.org/help/api/user-manual#query_details arXiv user manual (query details)
@@ -73,31 +66,30 @@ module Arx
 
       ids.flatten!
       unless ids.empty?
-        ids.map! {|id| extract_id id}
-        Validate.ids ids
+        ids.map! &Cleaner.method(:extract_id)
         @query << "&#{PARAMS[:id_list]}=#{ids * ','}"
       end
 
       yield self if block_given?
     end
 
-    # @!method &
+    # @!method and
     # Logical conjunction (+AND+) of subqueries.
     # @see https://arxiv.org/help/api/user-manual#query_details arXiv user manual
     # @return [self]
 
-    # @!method !
+    # @!method and_not
     # Logical negated conjunction (+ANDNOT+) of subqueries.
     # @see https://arxiv.org/help/api/user-manual#query_details arXiv user manual
     # @return [self]
 
-    # @!method |
+    # @!method or
     # Logical disjunction (+OR+) of subqueries.
     # @see https://arxiv.org/help/api/user-manual#query_details arXiv user manual
     # @return [self]
 
-    CONNECTIVE_METHODS.each do |symbol, connective|
-      define_method(symbol) { add_connective connective }
+    CONNECTIVES.keys.each do |connective|
+      define_method(connective) { add_connective connective }
     end
 
     # @!method title(*values, exact: true, connective: :and)
@@ -181,6 +173,20 @@ module Arx
       end
     end
 
+    # Creates a nested subquery (grouped statements with parentheses).
+    #
+    # @return [self]
+    def group
+      add_connective :and unless end_with_connective?
+      @query << (search_query? ? '+' : "&#{PARAMS[:search_query]}=")
+
+      @query << CGI.escape('(')
+      yield
+      @query << CGI.escape(')')
+
+      self
+    end
+
     # Returns the query string.
     #
     # @return [String]
@@ -196,8 +202,9 @@ module Arx
     # @param connective [Symbol] The symbol of the logical connective to add.
     # @return [self]
     def add_connective(connective)
-      return unless search_query?
-      @query << "+#{CONNECTIVES[connective]}" unless ends_with_connective?
+      if search_query?
+        @query << "+#{CONNECTIVES[connective]}" unless end_with_connective? || start_of_group?
+      end
       self
     end
 
@@ -205,13 +212,10 @@ module Arx
     #
     # @param subquery [String] The subquery to add.
     def add_subquery(subquery)
+      add_connective :and unless end_with_connective?
+
       if search_query?
-        if ends_with_connective?
-          @query << "+#{subquery}"
-        else
-          add_connective :and
-          @query << "+#{subquery}"
-        end
+        @query << (start_of_group? ? "#{subquery}" : "+#{subquery}")
       else
         @query << "&#{PARAMS[:search_query]}=#{subquery}"
       end
@@ -229,10 +233,17 @@ module Arx
     #
     # @see CONNECTIVES
     # @return [Boolean]
-    def ends_with_connective?
+    def end_with_connective?
       CONNECTIVES.values.any? &@query.method(:end_with?)
     end
 
+    # Whether the query string ends in a start-of-group character '('.
+    #
+    # @return [Boolean]
+    def start_of_group?
+      @query.end_with? CGI.escape('(')
+    end
+
     # Parenthesizes a string with CGI-escaped parentheses.
     #
     # @param string [String] The string to parenthesize.
@@ -248,18 +259,5 @@ module Arx
     def enquote(string)
       CGI.escape("\"") + string + CGI.escape("\"")
     end
-
-    # Attempt to extract an ID from an arXiv URL.
-    #
-    # @param url [String] The URL to extract the ID from.
-    # @return [String] The extracted ID if successful, otherwise the original string.
-    def extract_id(url)
-      prefix = %r"^(https?\:\/\/)?(www.)?arxiv\.org\/abs\/"
-      if %r"#{prefix}.*$".match? url
-        url.sub(prefix, '').sub(%r"\/$", '')
-      else
-        url
-      end
-    end
   end
 end

data/lib/arx/query/validate.rb

@@ -94,7 +94,9 @@ module Arx
       # @see NEW_IDENTIFIER_FORMAT
       # @see OLD_IDENTIFIER_FORMAT
       def id?(id)
-        NEW_IDENTIFIER_FORMAT.match?(id) || OLD_IDENTIFIER_FORMAT.match?(id)
+        return true if NEW_IDENTIFIER_FORMAT.match? id
+        return true if OLD_IDENTIFIER_FORMAT.match?(id) && Arx::CATEGORIES.keys.include?(id.split('/').first)
+        false
       end
     end
   end

data/lib/arx/version.rb

@@ -4,9 +4,9 @@ module Arx
 
   # The current version of Arx.
   VERSION = {
-    major: 0,
-    minor: 3,
-    patch: 2,
+    major: 1,
+    minor: 1,
+    patch: 0,
     meta: nil,
   }.compact.values.join('.').freeze
 end

data/lib/arx.rb

@@ -32,7 +32,7 @@ module Arx
   #   1705.01662v1
   #   1412.0135
   #   0706.0001v2
-  NEW_IDENTIFIER_FORMAT = %r"^\d{4}\.\d{4,5}(v\d+)?$"
+  NEW_IDENTIFIER_FORMAT = /^\d{4}\.\d{4,5}(v\d+)?$/
 
   # The legacy arXiv paper identifier scheme (before 1 April 2007).
   #
@@ -40,7 +40,7 @@ module Arx
   # @example
   #   math/0309136v1
   #   cond-mat/0211034
-  OLD_IDENTIFIER_FORMAT = %r"^[a-z]+(\-[a-z]+)?\/\d{7}(v\d+)?$"
+  OLD_IDENTIFIER_FORMAT = /^[a-z]+(\-[a-z]+)?\/\d{7}(v\d+)?$/
 
   class << self
 
@@ -59,12 +59,23 @@ module Arx
       yield query if block_given?
 
       document = Nokogiri::XML(open ENDPOINT + query.to_s + '&max_results=10000').remove_namespaces!
-      results = Paper.parse(document, single: false).reject {|paper| paper.id.empty?}
-      raise Error::MissingPaper.new(ids.first) if results.empty? && ids.size == 1
-      ids.size == 1 && results.size == 1 ? results.first : results
+      results = Paper.parse(document, single: ids.size == 1)
+
+      if results.is_a? Paper
+        raise Error::MissingPaper.new(ids.first) if results.title.empty?
+      elsif results.is_a? Array
+        results.reject! {|paper| paper.title.empty?}
+      elsif results.nil?
+        if ids.size == 1
+          raise Error::MissingPaper.new(ids.first)
+        else
+          results = []
+        end
+      end
+
+      results
     end
 
-    alias_method :find, :search
     alias_method :get, :search
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arx
 version: !ruby/object:Gem::Version
-  version: 0.3.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Edwin Onuonga
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-03-30 00:00:00.000000000 Z
+date: 2019-04-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -42,16 +42,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.17'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '1.17'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.20'
+        version: 0.19.4
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.20'
+        version: 0.19.4
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -94,9 +94,23 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.7'
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.8.22
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.8.22
 description: 
 email:
-- ed@mail.eonu.net
+- ed@eonu.net
 executables: []
 extensions: []
 extra_rdoc_files: []