aruba 1.0.0 → 1.1.0

data/lib/aruba/event_bus.rb

@@ -1,5 +1,5 @@
-require 'aruba/event_bus/name_resolver'
-require 'aruba/errors'
+require "aruba/event_bus/name_resolver"
+require "aruba/errors"
 
 module Aruba
   # Event bus
@@ -33,7 +33,9 @@ module Aruba
     def register(event_ids, handler_object = nil, &handler_proc)
       handler = handler_proc || handler_object
 
-      fail ArgumentError, 'Please pass either an object#call or a handler block' if handler.nil? || !handler.respond_to?(:call)
+      if handler.nil? || !handler.respond_to?(:call)
+        raise ArgumentError, "Please pass either an object#call or a handler block"
+      end
 
       Array(event_ids).flatten.each do |id|
         @handlers[
@@ -51,7 +53,7 @@ module Aruba
     #   handler.
     #
     def notify(event)
-      fail NoEventError, 'Please pass an event object, not a class' if event.is_a?(Class)
+      raise NoEventError, "Please pass an event object, not a class" if event.is_a?(Class)
 
       @handlers[event.class.to_s].each { |handler| handler.call(event) }
     end

data/lib/aruba/event_bus/name_resolver.rb

@@ -1,4 +1,4 @@
-require 'aruba/errors'
+require "aruba/errors"
 
 # Event notification library
 module Aruba
@@ -10,16 +10,16 @@ module Aruba
       # Helpers for Resolvers
       module ResolveHelpers
         def camel_case(underscored_name)
-          underscored_name.to_s.split('_').map { |word| word.upcase[0] + word[1..-1] }.join
+          underscored_name.to_s.split("_").map { |word| word.upcase[0] + word[1..-1] }.join
         end
 
         # Thanks ActiveSupport
         # (Only needed to support Ruby 1.9.3 and JRuby)
-        # rubocop:disable Metrics/CyclomaticComplexity
         def constantize(camel_cased_word)
-          names = camel_cased_word.split('::')
+          names = camel_cased_word.split("::")
 
-          # Trigger a built-in NameError exception including the ill-formed constant in the message.
+          # Trigger a built-in NameError exception including the ill-formed
+          # constant in the message.
           Object.const_get(camel_cased_word) if names.empty?
 
           # Remove the first blank element in case of '::ClassName' notation.
@@ -49,7 +49,6 @@ module Aruba
             end
           end
         end
-        # rubocop:enable Metrics/CyclomaticComplexity
       end
 
       # @private
@@ -120,7 +119,8 @@ module Aruba
       class FailingResolver
         class << self
           def match?(event_id)
-            fail ArgumentError, %(Input type "#{event_id.class}" of event_id "#{event_id}" is invalid)
+            raise ArgumentError,
+                  %(Input type "#{event_id.class}" of event_id "#{event_id}" is invalid)
           end
 
           def supports
@@ -147,10 +147,11 @@ module Aruba
 
       def transform(event_id)
         resolvers.find { |r| r.match? event_id }.new.transform(default_namespace, event_id)
-      rescue => e
-        # rubocop:disable Layout/LineLength
-        raise EventNameResolveError, %(Transforming "#{event_id}" into an event class failed. Supported types are: #{@resolvers.map(&:supports).flatten.join(', ')}. #{e.message}.\n\n#{e.backtrace.join("\n")})
-        # rubocop:enable Layout/LineLength
+      rescue StandardError => e
+        types = @resolvers.map(&:supports).flatten.join(", ")
+        message = "Transforming \"#{event_id}\" into an event class failed." \
+          " Supported types are: #{types}. #{e.message}."
+        raise EventNameResolveError, message, cause: e
       end
     end
   end

data/lib/aruba/events.rb

@@ -4,7 +4,8 @@ module Aruba
   module Events
     # Basic event
     #
-    # This is not meant for direct use - BasicEvent.new - by users. It is inherited by normal events
+    # This is not meant for direct use - BasicEvent.new - by users. It is
+    # inherited by normal events
     #
     # @private
     class BasicEvent

data/lib/aruba/file_size.rb

@@ -1,4 +1,4 @@
-require 'delegate'
+require "delegate"
 
 # Aruba
 module Aruba

data/lib/aruba/generators/script_file.rb

@@ -23,7 +23,7 @@ module Aruba
 
     def header
       if script_starts_with_shebang?
-        ''
+        ""
       elsif interpreter_is_absolute_path?
         format("#!%s\n", interpreter)
       elsif interpreter_is_just_the_name_of_shell?
@@ -40,7 +40,7 @@ module Aruba
     end
 
     def script_starts_with_shebang?
-      content.start_with? '#!'
+      content.start_with? "#!"
     end
   end
 end

data/lib/aruba/hooks.rb

@@ -21,12 +21,10 @@ module Aruba
     # @param [Proc] block
     #   The block which should be run for the hook
     def append(label, block)
-      if store.key?(label.to_sym) && store[label.to_sym].respond_to?(:<<)
-        store[label.to_sym] << block
-      else
+      unless store.key?(label.to_sym) && store[label.to_sym].respond_to?(:<<)
         store[label.to_sym] = []
-        store[label.to_sym] << block
       end
+      store[label.to_sym] << block
     end
 
     # Run hook

data/lib/aruba/in_config_wrapper.rb

@@ -15,14 +15,17 @@ module Aruba
     end
 
     def method_missing(name, *args)
-      fail ArgumentError, 'Options take no argument' if args.any?
-      fail UnknownOptionError, %(Option "#{name}" is unknown. Please use only earlier defined options) unless config.key? name
+      if config.key? name
+        raise ArgumentError, "Options take no argument" if args.any?
 
-      config[name]
+        config[name]
+      else
+        super
+      end
     end
 
-    def respond_to_missing?(*)
-      true
+    def respond_to_missing?(name, _include_private)
+      config.key? name
     end
   end
 end

data/lib/aruba/initializer.rb

@@ -1,5 +1,5 @@
-require 'thor/group'
-require 'thor/actions'
+require "thor/group"
+require "thor/actions"
 
 # Aruba
 module Aruba
@@ -15,7 +15,7 @@ module Aruba
 
       # Add gem to gemfile
       def add_gem
-        file = 'Gemfile'
+        file = "Gemfile"
         creator = if File.exist? file
                     :append_to_file
                   else
@@ -23,9 +23,10 @@ module Aruba
                   end
 
         content = if File.exist? file
-                    file_ends_with_carriage_return = File.open(file, 'r').readlines.last.match(/.*\n$/)
+                    file_ends_with_carriage_return =
+                      File.open(file, "r").readlines.last.match(/.*\n$/)
 
-                    prefix = file_ends_with_carriage_return ? '' : "\n"
+                    prefix = file_ends_with_carriage_return ? "" : "\n"
 
                     %(#{prefix}gem 'aruba', '~> #{Aruba::VERSION}')
                   else
@@ -53,7 +54,8 @@ module Aruba
         end
 
         def start(*)
-          fail ArgumentError, %(Unknown test framework. Please use one of :rspec, :cucumber or :minitest)
+          raise ArgumentError,
+                %(Unknown test framework. Please use one of :rspec, :cucumber or :minitest)
         end
       end
     end
@@ -77,7 +79,7 @@ module Aruba
       end
 
       def create_helper
-        file = 'spec/spec_helper.rb'
+        file = "spec/spec_helper.rb"
         creator = if File.exist? file
                     :append_to_file
                   else
@@ -93,7 +95,7 @@ module Aruba
       end
 
       def create_support_file
-        create_file 'spec/support/aruba.rb', <<~EOS
+        create_file "spec/support/aruba.rb", <<~EOS
           require 'aruba/rspec'
         EOS
       end
@@ -118,7 +120,7 @@ module Aruba
       end
 
       def create_support_file
-        create_file 'features/support/aruba.rb', <<~EOS
+        create_file "features/support/aruba.rb", <<~EOS
           require 'aruba/cucumber'
         EOS
       end
@@ -143,7 +145,7 @@ module Aruba
       end
 
       def create_helper
-        file =  'test/test_helper.rb'
+        file =  "test/test_helper.rb"
         creator = if File.exist? file
                     :append_to_file
                   else
@@ -159,7 +161,7 @@ module Aruba
       end
 
       def create_example
-        create_file 'test/use_aruba_with_minitest.rb', <<~EOS
+        create_file "test/use_aruba_with_minitest.rb", <<~EOS
           $LOAD_PATH.unshift File.expand_path('../test', __FILE__)
 
           require 'test_helper'
@@ -206,7 +208,7 @@ module Aruba
       begin
         initializers.find { |i| i.match? test_framework }.start [], {}
       rescue ArgumentError => e
-        $stderr.puts e.message
+        warn e.message
         exit 0
       end
 

data/lib/aruba/matchers/base/base_matcher.rb

@@ -1,4 +1,4 @@
-require 'aruba/matchers/base/object_formatter'
+require "aruba/matchers/base/object_formatter"
 
 # Aruba
 module Aruba
@@ -33,6 +33,8 @@ module Aruba
 
       # @private
       module HashFormatting
+        module_function
+
         # `{ :a => 5, :b => 2 }.inspect` produces:
         #
         #     {:a=>5, :b=>2}
@@ -45,7 +47,6 @@ module Aruba
         def improve_hash_formatting(inspect_string)
           inspect_string.gsub(/(\S)=>(\S)/, '\1 => \2')
         end
-        module_function :improve_hash_formatting
       end
 
       include HashFormatting
@@ -70,16 +71,6 @@ module Aruba
         def failure_message_when_negated
           "expected #{description_of @actual} not to #{description}"
         end
-
-        # @private
-        # rubocop:disable Naming/PredicateName
-        def self.has_default_failure_messages?(matcher)
-          matcher.method(:failure_message).owner == self &&
-            matcher.method(:failure_message_when_negated).owner == self
-        rescue NameError
-          false
-        end
-        # rubocop:enable Naming/PredicateName
       end
 
       include DefaultFailureMessages

data/lib/aruba/matchers/base/message_indenter.rb

@@ -8,9 +8,9 @@ module Aruba
         module_function
 
         def indent_multiline_message(message)
-          message = message.sub(/\n+\z/, '')
+          message = message.sub(/\n+\z/, "")
           message.lines.map do |line|
-            /\S/.match?(line) ? '   ' + line : line
+            /\S/.match?(line) ? "   #{line}" : line
           end.join
         end
       end

data/lib/aruba/matchers/base/object_formatter.rb

@@ -12,8 +12,6 @@ module Aruba
         prepare_for_inspection(object).inspect
       end
 
-      # rubocop:disable Metrics/CyclomaticComplexity
-
       # @private
       # Prepares the provided object to be formatted by wrapping it as needed
       # in something that, when `inspect` is called on it, will produce the
@@ -46,7 +44,6 @@ module Aruba
 
         InspectableItem.new(inspection)
       end
-      # rubocop:enable Metrics/CyclomaticComplexity
 
       # @private
       def self.prepare_hash(input)
@@ -55,7 +52,7 @@ module Aruba
         end
       end
 
-      TIME_FORMAT = '%Y-%m-%d %H:%M:%S'.freeze
+      TIME_FORMAT = "%Y-%m-%d %H:%M:%S".freeze
 
       if Time.method_defined?(:nsec)
         # @private
@@ -64,7 +61,7 @@ module Aruba
         end
       end
 
-      DATE_TIME_FORMAT = '%a, %d %b %Y %H:%M:%S.%N %z'.freeze
+      DATE_TIME_FORMAT = "%a, %d %b %Y %H:%M:%S.%N %z".freeze
 
       # ActiveSupport sometimes overrides inspect. If `ActiveSupport` is
       # defined use a custom format string that includes more time precision.

data/lib/aruba/matchers/collection.rb

@@ -1 +1 @@
-Aruba.platform.require_matching_files('../collection/**/*.rb', __FILE__)
+Aruba.platform.require_matching_files("../collection/**/*.rb", __FILE__)

data/lib/aruba/matchers/collection/all.rb

@@ -1,4 +1,4 @@
-require 'rspec/expectations'
+require "rspec/expectations"
 
 # Aruba
 module Aruba

data/lib/aruba/matchers/collection/include_an_object.rb

@@ -1,5 +1,5 @@
-require 'aruba/matchers/base/base_matcher'
-require 'aruba/matchers/base/message_indenter'
+require "aruba/matchers/base/base_matcher"
+require "aruba/matchers/base/message_indenter"
 
 # Aruba
 module Aruba
@@ -29,9 +29,7 @@ module Aruba
       # @api private
       # @return [String]
       def failure_message
-        unless iterable?
-          return "#{improve_hash_formatting(super)}, but was not iterable"
-        end
+        return "#{improve_hash_formatting(super)}, but was not iterable" unless iterable?
 
         return failed_objects.first if failed_objects.size == 1
 
@@ -91,7 +89,9 @@ module Aruba
 
       def failure_message_for_item(index, failure_message)
         failure_message = indent_multiline_message(add_new_line_if_needed(failure_message))
-        indent_multiline_message("object at index #{index} failed to match:#{failure_message}")
+        indent_multiline_message(
+          "object at index #{index} failed to match:#{failure_message}"
+        )
       end
 
       def add_new_line_if_needed(message)

data/lib/aruba/matchers/command.rb

@@ -1 +1 @@
-Aruba.platform.require_matching_files('../command/**/*.rb', __FILE__)
+Aruba.platform.require_matching_files("../command/**/*.rb", __FILE__)

data/lib/aruba/matchers/command/be_successfully_executed.rb

@@ -1,7 +1,7 @@
-require 'rspec/expectations/version'
+require "rspec/expectations/version"
 
-require 'aruba/matchers/command/have_exit_status'
-require 'aruba/matchers/command/have_finished_in_time'
+require "aruba/matchers/command/have_exit_status"
+require "aruba/matchers/command/have_finished_in_time"
 
 # @!method be_successfuly_executed
 #   This matchers checks if execution of <command> was successful
@@ -29,7 +29,9 @@ RSpec::Matchers.define :be_successfully_executed do
   end
 
   failure_message do |_actual|
-    "Expected `#{@actual}` to succeed but got non-zero exit status and the following output:\n\n#{@old_actual.output}\n"
+    "Expected `#{@actual}` to succeed" \
+      " but got non-zero exit status and the following output:" \
+      "\n\n#{@old_actual.output}\n"
   end
 end
 

data/lib/aruba/matchers/command/have_exit_status.rb

@@ -23,7 +23,9 @@ RSpec::Matchers.define :have_exit_status do |expected|
     @old_actual.stop
     @actual = actual.exit_status
 
-    raise "Expected #{@old_actual} to respond to #exit_status" unless @old_actual.respond_to? :exit_status
+    unless @old_actual.respond_to? :exit_status
+      raise "Expected #{@old_actual} to respond to #exit_status"
+    end
 
     values_match? expected, @actual
   end

data/lib/aruba/matchers/command/have_finished_in_time.rb

@@ -1,4 +1,4 @@
-require 'rspec/expectations/version'
+require "rspec/expectations/version"
 
 # @!method run_too_long
 #   This matchers checks if <command> run too long. Say the timeout is 10
@@ -24,7 +24,9 @@ RSpec::Matchers.define :have_finished_in_time do
     @old_actual = actual
     @actual     = @old_actual.commandline
 
-    raise "Expected #{@old_actual} to respond to #timed_out?" unless @old_actual.respond_to? :timed_out?
+    unless @old_actual.respond_to? :timed_out?
+      raise "Expected #{@old_actual} to respond to #timed_out?"
+    end
 
     @old_actual.stop
 

data/lib/aruba/matchers/command/have_output.rb

@@ -1,4 +1,4 @@
-require 'aruba/matchers/base/message_indenter'
+require "aruba/matchers/base/message_indenter"
 
 # @!method have_output
 #   This matchers checks if <command> has created output
@@ -19,7 +19,9 @@ RSpec::Matchers.define :have_output do |expected|
   match do |actual|
     @old_actual = actual
 
-    raise "Expected #{@old_actual} to respond to #output" unless @old_actual.respond_to? :output
+    unless @old_actual.respond_to? :output
+      raise "Expected #{@old_actual} to respond to #output"
+    end
 
     @old_actual.stop