aruba 1.0.0.pre.alpha.2 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: dec3a8796a3872177a32dbe51a56a7a01f0e3bcf
-  data.tar.gz: ff77b1f73face0704272353c2dd8e42a27ab9c3b
+SHA256:
+  metadata.gz: 78af1111ebd1c66984dd8ad454318e6eba06e183cfd844bcf1e5e794103ea756
+  data.tar.gz: a4821903017781b016eb1510833e31c9421e79589a69b804d7fab1bc646e8d1c
 SHA512:
-  metadata.gz: 03a6bc22996a8e67e71ac9a2e23b0b365ec0afb2bb4194bcbeb16341515b24a9ffda9008ea3e31ac9e51bf4177edc38d8fbe1168352fdee300b1ffe9bd25c524
-  data.tar.gz: 0efce8bcec7f4c934870983171212023098b213d0cbec047ee0d80edf08e454cb542bc76f5b3930ec86c3528f62a718bab8fb92ea855381c2d18c77037dca563
+  metadata.gz: 11b800a1afc27d83cd804685793e1ddc2cba21151b648a2f62ebc4016566d7cacc7c3f9fef578259ed0a00b50dd5ab6d0fd0a45c11f454b88a4648af3b4138e9
+  data.tar.gz: af2fc428c1fc809e39e87e7060be821a44a5fcba1b3cc131f7334e8ad2a516dc90375aea4d28b13299b51c5147c820a2bc765c936fee5095182b58a1ac1d3de3

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -29,7 +29,8 @@
 - [ ] Bug fix (non-breaking change which fixes an issue)
 - [ ] New feature (non-breaking change which adds functionality)
 - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
-- [ ] Refactoring (cleanup of codebase withouth changing any existing functionality)
+- [ ] Refactoring (cleanup of codebase without changing any existing functionality)
+- [ ] Update documentation
 
 ## Checklist:
 

data/.rspec

@@ -1,4 +1,3 @@
 --color
---format Fuubar
 --order random
 --warnings

data/.rubocop.yml

@@ -1,188 +1,52 @@
+require:
+  - rubocop-performance
+  - rubocop-rspec
+
 AllCops:
   Exclude:
     - tmp/**/*
+    - vendor/**/*
   DisplayCopNames: true
-# Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles.
-Style/HashSyntax:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Exclude:
-    - lib/aruba/api.rb
-    - lib/aruba/api/*.rb
-    - lib/aruba/platform.rb
-
-Metrics/AbcSize:
-  Enabled: false
-
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Lint/RescueException:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Lint/UnusedBlockArgument:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Lint/UnusedMethodArgument:
-  Enabled: false
-
-Lint/UselessAssignment:
-  Enabled: false
-
-# Configuration parameters: AllowURI.
-Metrics/LineLength:
-  Max: 169
-  Exclude:
-    - lib/aruba/api.rb
-    - lib/aruba/api/deprecated.rb
-    - aruba.gemspec
-
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 18
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/AlignParameters:
-  Enabled: false
-
-Style/CaseEquality:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/CharacterLiteral:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/ClassCheck:
-  Enabled: false
-
-Style/ClassVars:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredMethods.
-Style/CollectionMethods:
-  Enabled: false
+  TargetRubyVersion: 2.4
 
-Style/Documentation:
-  Enabled: false
-
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
-  Enabled: false
-
-Style/Lambda:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/LeadingCommentSpace:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
+# Use older RuboCop default
 Style/PercentLiteralDelimiters:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-# Configuration parameters: SupportedStyles.
-Style/RaiseArgs:
-  # EnforcedStyle: compact
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Enabled: false
-
-# Configuration parameters: MaxSlashes.
-Style/RegexpLiteral:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAsExpressionSeparator.
-Style/Semicolon:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SignalException:
-  Enabled: false
-
-# Configuration parameters: Methods.
-Style/SingleLineBlockParams:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceBeforeFirstArg:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceAfterComma:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceAroundKeyword:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceAfterNot:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SpaceBeforeBlockBraces:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceBeforeComma:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-Style/SpaceInsideBlockBraces:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceInsideBrackets:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceInsideParens:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiterals:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
-Style/TrivialAccessors:
-  Enabled: false
-
-Style/RaiseArgs:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Style/IfInsideElse:
-  Enabled: false
-
-Style/IdenticalConditionalBranches:
-  Enabled: false
+  PreferredDelimiters:
+    '%w': ()
+
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Code is currently broken with frozen string literal comments applied.
+# TODO: Enable and fix build
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Be relatively lenient with line length
+Layout/LineLength:
+  Max: 94
+
+# Enable new cops from RuboCop 0.80, 0.81 and 0.84
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+Lint/RaiseException:
+  Enabled: true
+Lint/StructNewOverride:
+  Enabled: true
+Style/ExponentialNotation:
+  Enabled: true
+Style/HashEachMethods:
+  Enabled: true
+Style/HashTransformKeys:
+  Enabled: true
+Style/HashTransformValues:
+  Enabled: true
+Style/SlicingWithRange:
+  Enabled: true
+
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,216 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-05-31 23:12:24 +0200 using RuboCop version 0.84.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 7
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - 'lib/aruba/platforms/announcer.rb'
+
+# Offense count: 2
+# Configuration parameters: CheckForMethodsWithNoSideEffects.
+Lint/Void:
+  Exclude:
+    - 'lib/aruba/platforms/announcer.rb'
+    - 'lib/aruba/platforms/unix_environment_variables.rb'
+
+# Offense count: 26
+# Configuration parameters: IgnoredMethods.
+Metrics/AbcSize:
+  Max: 116
+
+# Offense count: 72
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 594
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 158
+
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
+Metrics/CyclomaticComplexity:
+  Max: 12
+
+# Offense count: 28
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 59
+
+# Offense count: 3
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 182
+
+# Offense count: 3
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 8
+
+# Offense count: 5
+# Configuration parameters: IgnoredMethods.
+Metrics/PerceivedComplexity:
+  Max: 13
+
+# Offense count: 1
+Naming/ConstantName:
+  Exclude:
+    - 'lib/aruba/platform.rb'
+
+# Offense count: 5
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'lib/aruba/initializer.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'lib/aruba/api/core.rb'
+
+# Offense count: 14
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os, pp
+Naming/MethodParameterName:
+  Exclude:
+    - 'lib/aruba/aruba_path.rb'
+    - 'lib/aruba/config_wrapper.rb'
+    - 'lib/aruba/platforms/announcer.rb'
+    - 'lib/aruba/platforms/aruba_logger.rb'
+    - 'lib/aruba/platforms/unix_platform.rb'
+    - 'lib/aruba/tasks/docker_helpers.rb'
+
+# Offense count: 1
+Performance/Caller:
+  Exclude:
+    - 'lib/aruba/platforms/unix_platform.rb'
+
+# Offense count: 51
+# Configuration parameters: Prefixes.
+# Prefixes: when, with, without
+RSpec/ContextWording:
+  Exclude:
+    - 'spec/aruba/api/filesystem_spec.rb'
+    - 'spec/aruba/api/runtime_spec.rb'
+    - 'spec/aruba/api_spec.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+    - 'spec/aruba/matchers/file_spec.rb'
+    - 'spec/aruba/matchers/path_spec.rb'
+    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
+    - 'spec/support/shared_contexts/aruba.rb'
+
+# Offense count: 10
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/aruba/api/runtime_spec.rb'
+    - 'spec/aruba/jruby_spec.rb'
+    - 'spec/aruba/matchers/collection_spec.rb'
+    - 'spec/aruba/matchers/command/have_output_size_spec.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+    - 'spec/aruba/matchers/directory_spec.rb'
+    - 'spec/aruba/matchers/file_spec.rb'
+    - 'spec/aruba/matchers/path_spec.rb'
+    - 'spec/aruba/platform/simple_table_spec.rb'
+    - 'spec/aruba/rspec_spec.rb'
+
+# Offense count: 19
+# Configuration parameters: Max.
+RSpec/ExampleLength:
+  Exclude:
+    - 'spec/aruba/api/core_spec.rb'
+    - 'spec/aruba/api/filesystem_spec.rb'
+    - 'spec/aruba/aruba_path_spec.rb'
+    - 'spec/aruba/matchers/collection_spec.rb'
+
+# Offense count: 4
+# Configuration parameters: CustomTransform, IgnoreMethods.
+RSpec/FilePath:
+  Exclude:
+    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
+    - 'spec/aruba/platforms/command_monitor_spec.rb'
+    - 'spec/event_bus/name_resolver_spec.rb'
+    - 'spec/event_bus_spec.rb'
+
+# Offense count: 298
+# Configuration parameters: AssignmentOnly.
+RSpec/InstanceVariable:
+  Exclude:
+    - 'spec/aruba/api/bundler_spec.rb'
+    - 'spec/aruba/api/commands_spec.rb'
+    - 'spec/aruba/api/core_spec.rb'
+    - 'spec/aruba/api/filesystem_spec.rb'
+    - 'spec/aruba/api_spec.rb'
+    - 'spec/aruba/matchers/command/have_output_size_spec.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+    - 'spec/aruba/matchers/directory_spec.rb'
+    - 'spec/aruba/matchers/file_spec.rb'
+    - 'spec/aruba/matchers/path_spec.rb'
+    - 'spec/aruba/processes/in_process_spec.rb'
+    - 'spec/event_bus_spec.rb'
+    - 'spec/support/shared_contexts/aruba.rb'
+
+# Offense count: 32
+RSpec/MultipleExpectations:
+  Max: 5
+
+# Offense count: 187
+RSpec/NestedGroups:
+  Max: 6
+
+# Offense count: 1
+RSpec/UnspecifiedException:
+  Exclude:
+    - 'spec/aruba/runtime_spec.rb'
+
+# Offense count: 2
+Security/Open:
+  Exclude:
+    - 'lib/aruba/processes/spawn_process.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
+# SupportedStyles: inline, group
+Style/AccessModifierDeclarations:
+  Exclude:
+    - 'lib/aruba/matchers/collection/all.rb'
+
+# Offense count: 3
+# Configuration parameters: AllowOnConstant.
+Style/CaseEquality:
+  Exclude:
+    - 'lib/aruba/matchers/base/object_formatter.rb'
+
+# Offense count: 12
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'fixtures/cli-app/lib/cli/app.rb'
+    - 'fixtures/cli-app/lib/cli/app/suppress_simple_cov_output.rb'
+    - 'fixtures/empty-app/lib/cli/app.rb'
+    - 'lib/aruba/api/bundler.rb'
+    - 'lib/aruba/matchers/collection/include_an_object.rb'
+    - 'lib/aruba/platforms/command_monitor.rb'
+    - 'lib/aruba/setup.rb'
+    - 'lib/aruba/tasks/docker_helpers.rb'
+
+# Offense count: 83
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  Enabled: false
+
+# Offense count: 2
+Style/MethodMissingSuper:
+  Exclude:
+    - 'lib/aruba/platforms/command_monitor.rb'