aruba 1.0.0.pre.alpha.2 → 1.0.0.pre.alpha.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: dec3a8796a3872177a32dbe51a56a7a01f0e3bcf
-  data.tar.gz: ff77b1f73face0704272353c2dd8e42a27ab9c3b
+SHA256:
+  metadata.gz: edbb16f00c301a3cb9b030dcabe626cd35e3bfebdd8e76efc47ccb78963b632c
+  data.tar.gz: 3cfea7febab3db1a8943a6a25c6724a5fcd51db9916a9426619767b4260479d6
 SHA512:
-  metadata.gz: 03a6bc22996a8e67e71ac9a2e23b0b365ec0afb2bb4194bcbeb16341515b24a9ffda9008ea3e31ac9e51bf4177edc38d8fbe1168352fdee300b1ffe9bd25c524
-  data.tar.gz: 0efce8bcec7f4c934870983171212023098b213d0cbec047ee0d80edf08e454cb542bc76f5b3930ec86c3528f62a718bab8fb92ea855381c2d18c77037dca563
+  metadata.gz: 31f78dc5373408128c519af63839ed5e85a0fe4d749fc475b96aa36803ec98b5d04b072c69df39ac7fc25ee47a4189e22a6e6943f3df94d9c2e2de7cd831e177
+  data.tar.gz: e6342327449b14d5a91a96fb5df785e911a451b17d6745c4e7986ad3ea79bd4c36a7c48a10020255e8afb2855ccb1df04277ef44c266223c68b2ebf5f3af8a89

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -29,7 +29,8 @@
 - [ ] Bug fix (non-breaking change which fixes an issue)
 - [ ] New feature (non-breaking change which adds functionality)
 - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
-- [ ] Refactoring (cleanup of codebase withouth changing any existing functionality)
+- [ ] Refactoring (cleanup of codebase without changing any existing functionality)
+- [ ] Update documentation
 
 ## Checklist:
 

data/.rubocop.yml

@@ -1,188 +1,13 @@
 AllCops:
   Exclude:
     - tmp/**/*
+    - vendor/**/*
   DisplayCopNames: true
-# Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles.
-Style/HashSyntax:
-  Enabled: false
+  TargetRubyVersion: 2.2
 
-Metrics/ModuleLength:
-  Exclude:
-    - lib/aruba/api.rb
-    - lib/aruba/api/*.rb
-    - lib/aruba/platform.rb
-
-Metrics/AbcSize:
-  Enabled: false
-
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Lint/RescueException:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Lint/UnusedBlockArgument:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Lint/UnusedMethodArgument:
-  Enabled: false
-
-Lint/UselessAssignment:
-  Enabled: false
-
-# Configuration parameters: AllowURI.
-Metrics/LineLength:
-  Max: 169
-  Exclude:
-    - lib/aruba/api.rb
-    - lib/aruba/api/deprecated.rb
-    - aruba.gemspec
-
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 18
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/AlignParameters:
-  Enabled: false
-
-Style/CaseEquality:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/CharacterLiteral:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/ClassCheck:
-  Enabled: false
-
-Style/ClassVars:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredMethods.
-Style/CollectionMethods:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false
-
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
-  Enabled: false
-
-Style/Lambda:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/LeadingCommentSpace:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
+# Use older RuboCop default
 Style/PercentLiteralDelimiters:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-# Configuration parameters: SupportedStyles.
-Style/RaiseArgs:
-  # EnforcedStyle: compact
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Enabled: false
-
-# Configuration parameters: MaxSlashes.
-Style/RegexpLiteral:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAsExpressionSeparator.
-Style/Semicolon:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SignalException:
-  Enabled: false
-
-# Configuration parameters: Methods.
-Style/SingleLineBlockParams:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceBeforeFirstArg:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceAfterComma:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceAroundKeyword:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceAfterNot:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SpaceBeforeBlockBraces:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceBeforeComma:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-Style/SpaceInsideBlockBraces:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceInsideBrackets:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceInsideParens:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiterals:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
-Style/TrivialAccessors:
-  Enabled: false
-
-Style/RaiseArgs:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Style/IfInsideElse:
-  Enabled: false
+  PreferredDelimiters:
+    '%w': ()
 
-Style/IdenticalConditionalBranches:
-  Enabled: false
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,364 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2019-05-06 11:32:53 +0200 using RuboCop version 0.66.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 5
+# Configuration parameters: Include.
+# Include: **/*.gemfile, **/Gemfile, **/gems.rb
+Bundler/DuplicatedGem:
+  Exclude:
+    - 'Gemfile'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: with_first_parameter, with_fixed_indentation
+Layout/AlignParameters:
+  Exclude:
+    - 'lib/aruba/api/commands.rb'
+    - 'lib/aruba/processes/basic_process.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+Layout/ClosingHeredocIndentation:
+  Exclude:
+    - 'lib/aruba/initializer.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: leading, trailing
+Layout/DotPosition:
+  Exclude:
+    - 'spec/aruba/matchers/collection_spec.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
+Layout/IndentHeredoc:
+  Exclude:
+    - 'lib/aruba/initializer.rb'
+
+# Offense count: 7
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - 'lib/aruba/platforms/announcer.rb'
+
+# Offense count: 6
+Lint/AmbiguousRegexpLiteral:
+  Exclude:
+    - 'lib/aruba/cucumber/testing_frameworks.rb'
+
+# Offense count: 2
+# Configuration parameters: MaximumRangeSize.
+Lint/MissingCopEnableDirective:
+  Exclude:
+    - 'lib/aruba/configuration.rb'
+    - 'lib/aruba/processes/spawn_process.rb'
+
+# Offense count: 1
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/aruba/platforms/unix_environment_variables.rb'
+
+# Offense count: 2
+# Configuration parameters: CheckForMethodsWithNoSideEffects.
+Lint/Void:
+  Exclude:
+    - 'lib/aruba/platforms/announcer.rb'
+    - 'lib/aruba/platforms/unix_environment_variables.rb'
+
+# Offense count: 28
+Metrics/AbcSize:
+  Max: 116
+
+# Offense count: 69
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 585
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 131
+
+# Offense count: 19
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 18
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 167
+
+# Offense count: 3
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 8
+
+# Offense count: 4
+Metrics/PerceivedComplexity:
+  Max: 10
+
+# Offense count: 1
+Naming/ConstantName:
+  Exclude:
+    - 'lib/aruba/platform.rb'
+
+# Offense count: 8
+# Configuration parameters: Blacklist.
+# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'lib/aruba/initializer.rb'
+    - 'spec/aruba/matchers/command_spec.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'lib/aruba/api/core.rb'
+
+# Offense count: 18
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db
+Naming/UncommunicativeMethodParamName:
+  Exclude:
+    - 'lib/aruba/aruba_path.rb'
+    - 'lib/aruba/config_wrapper.rb'
+    - 'lib/aruba/event_bus/name_resolver.rb'
+    - 'lib/aruba/matchers/base/object_formatter.rb'
+    - 'lib/aruba/platforms/announcer.rb'
+    - 'lib/aruba/platforms/aruba_logger.rb'
+    - 'lib/aruba/platforms/unix_platform.rb'
+    - 'lib/aruba/tasks/docker_helpers.rb'
+
+# Offense count: 1
+Performance/Caller:
+  Exclude:
+    - 'lib/aruba/platforms/unix_platform.rb'
+
+# Offense count: 2
+Security/Open:
+  Exclude:
+    - 'lib/aruba/processes/spawn_process.rb'
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: inline, group
+Style/AccessModifierDeclarations:
+  Exclude:
+    - 'lib/aruba/in_config_wrapper.rb'
+    - 'lib/aruba/matchers/base/base_matcher.rb'
+    - 'lib/aruba/matchers/collection/all.rb'
+
+# Offense count: 3
+Style/CaseEquality:
+  Exclude:
+    - 'lib/aruba/matchers/base/object_formatter.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/CharacterLiteral:
+  Exclude:
+    - 'spec/support/shared_contexts/aruba.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: is_a?, kind_of?
+Style/ClassCheck:
+  Exclude:
+    - 'lib/aruba/api/filesystem.rb'
+
+# Offense count: 1
+Style/CommentedKeyword:
+  Exclude:
+    - 'spec/aruba/api_spec.rb'
+
+# Offense count: 13
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'fixtures/cli-app/lib/cli/app.rb'
+    - 'fixtures/cli-app/lib/cli/app/suppress_simple_cov_output.rb'
+    - 'fixtures/empty-app/lib/cli/app.rb'
+    - 'lib/aruba/api/bundler.rb'
+    - 'lib/aruba/colorizer.rb'
+    - 'lib/aruba/matchers/collection/include_an_object.rb'
+    - 'lib/aruba/platforms/command_monitor.rb'
+    - 'lib/aruba/setup.rb'
+    - 'lib/aruba/tasks/docker_helpers.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+Style/Encoding:
+  Exclude:
+    - 'aruba.gemspec'
+    - 'fixtures/cli-app/cli-app.gemspec'
+    - 'fixtures/empty-app/cli-app.gemspec'
+    - 'spec/spec_helper.rb'
+
+# Offense count: 1
+Style/EvalWithLocation:
+  Exclude:
+    - 'spec/support/helpers/reporting.rb'
+
+# Offense count: 16
+# Cop supports --auto-correct.
+Style/ExpandPathArguments:
+  Exclude:
+    - 'Gemfile'
+    - 'Rakefile'
+    - 'bin/console'
+    - 'exe/aruba'
+    - 'features/support/env.rb'
+    - 'features/support/simplecov_setup.rb'
+    - 'fixtures/cli-app/bin/aruba-test-cli'
+    - 'fixtures/cli-app/cli-app.gemspec'
+    - 'fixtures/cli-app/lib/cli/app.rb'
+    - 'fixtures/cli-app/spec/spec_helper.rb'
+    - 'fixtures/empty-app/cli-app.gemspec'
+    - 'fixtures/empty-app/lib/cli/app.rb'
+    - 'fixtures/getting-started-app/Gemfile'
+
+# Offense count: 85
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  Enabled: false
+
+# Offense count: 2
+Style/IdenticalConditionalBranches:
+  Exclude:
+    - 'lib/aruba/hooks.rb'
+
+# Offense count: 10
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'Gemfile'
+    - 'features/support/env.rb'
+    - 'lib/aruba/cucumber/command.rb'
+    - 'lib/aruba/matchers/collection/include_an_object.rb'
+    - 'lib/aruba/platforms/unix_environment_variables.rb'
+    - 'lib/aruba/setup.rb'
+    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: line_count_dependent, lambda, literal
+Style/Lambda:
+  Exclude:
+    - 'spec/aruba/hooks_spec.rb'
+
+# Offense count: 5
+Style/MethodMissingSuper:
+  Exclude:
+    - 'lib/aruba/config_wrapper.rb'
+    - 'lib/aruba/in_config_wrapper.rb'
+    - 'lib/aruba/platforms/command_monitor.rb'
+    - 'lib/aruba/tasks/docker_helpers.rb'
+
+# Offense count: 3
+Style/MissingRespondToMissing:
+  Exclude:
+    - 'lib/aruba/in_config_wrapper.rb'
+    - 'lib/aruba/platforms/command_monitor.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: literals, strict
+Style/MutableConstant:
+  Exclude:
+    - 'lib/aruba/colorizer.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: Whitelist.
+# Whitelist: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
+Style/NestedParenthesizedCalls:
+  Exclude:
+    - 'spec/aruba/matchers/collection_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/aruba/contracts/is_power_of_two.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/aruba/api/bundler.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'lib/aruba/cucumber/command.rb'
+    - 'lib/aruba/cucumber/file.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, explicit
+Style/RescueStandardError:
+  Exclude:
+    - 'lib/aruba/contracts/absolute_path.rb'
+    - 'lib/aruba/contracts/is_power_of_two.rb'
+    - 'lib/aruba/contracts/relative_path.rb'
+    - 'lib/aruba/event_bus/name_resolver.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAsExpressionSeparator.
+Style/Semicolon:
+  Exclude:
+    - 'lib/aruba/platforms/aruba_fixed_size_file_creator.rb'
+
+# Offense count: 44
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: only_raise, only_fail, semantic
+Style/SignalException:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/StderrPuts:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/aruba/initializer.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+# Offense count: 411
+# Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Metrics/LineLength:
+  Max: 174