aruba 0.14.2 → 0.14.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f83f6a317a039d5d392c8c8d7ab294c482120d51
-  data.tar.gz: 080fda83821e31910ad169685d0c65713ca4ea2d
+  metadata.gz: d1a28b38002e8be7a18ef7f565bf01e03af948af
+  data.tar.gz: 9d9a66748e6626e01c26c1aaf81f0c6d9531adc4
 SHA512:
-  metadata.gz: 90cd237f159cc8679d9a3e4e43a758959892e55fa2c099decefc6cbdd8cc0acae3b0fe54d19325bc8ac50430eaa80d1f8d19f51376f340ba74ed76fd1436ea9d
-  data.tar.gz: fbc8e31a727d7ce1a59072bdfa21fbd5ab0994db40a824610946c47fe9d95c66f91c892679745084f45f000dccad04bb8c84df1f955deb6d16ec78f1745c2580
+  metadata.gz: d622dcb0c21bd5f01ec339928e9638f1a0dfc7bcfc0aa52026832672c37037294dd94082e376ed8094eff08269563f8c1b7fe28601941bb971b0d9fff11e8d48
+  data.tar.gz: 1bc9c24af389bd3daccde3fc5dd84c779e749060684a6e425386c60d063a02da8be5670dc3c067a6af26f8e38c269fb9eefe3ab535f9d72b50e12f43affbf2b7

data/.travis.yml

@@ -10,7 +10,7 @@ rvm:
   - 2.1.8
   - 2.2.4
   - 2.3.0
-  - jruby
+  - jruby-1.7.26
   - jruby-20mode
   - jruby-21mode
   - rbx
@@ -30,6 +30,10 @@ matrix:
     env: JRUBY_OPTS='--dev'
   - rvm: jruby-9.0.1.0-21mode
     env: JRUBY_OPTS='--dev'
+branches:
+  only:
+    - master
+    - still
 notifications:
   email:
     - cukes-devs@googlegroups.com

data/Gemfile

@@ -53,6 +53,12 @@ group :development, :test do
     gem 'cucumber', '~> 2.0'
   end
 
+  if RUBY_VERSION < '1.9.2'
+    gem 'contracts', '~> 0.15.0'
+  else
+    gem 'contracts', '~> 0.16.0'
+  end
+
   if RUBY_VERSION >= '1.9.3'
     # Make aruba compliant to ruby community guide
     gem 'rubocop', '~> 0.32', '< 0.41.1'

data/History.md

@@ -1,58 +1,15 @@
-#  UNRELEASED
-
-## [v1.0.0](https://github.com/cucumber/aruba/compare/v0.11.0...v1.0.0)
-
-* Support for rubies older than 1.9.3 is discontinued - e.g 1.8.7 and 1.9.2
-* aruba requires "cucumber 2" for the feature steps. The rest of aruba should
-  be usable by whatever testing framework you are using.
-* Overwriting methods for configuration is discontinued. You need to use
-  `aruba.config.<variable>` or `Aruba.configure { |config| config.<variable>`
-  instead.
-* "aruba/reporting" will be removed. Please use `@debug`-tag + `byebug`,
-  `debugger`, `pry` to troubleshoot your feature tests.
-* Set environment variables will have only effect on `#run` and the like +
-  `#with_environment { }`.
-* The process environment will be fully resetted between tests. Sharing state
-  via ENV['VAR'] = 'shared state' between tests will not be possible anymore.
-  Please make that obvious by using explicit steps or use the aruba API for
-  that.
-* There will be a major cleanup for command execution. There will be only
-  `run` and `run_simple` left. `run_interactive` is replaced by `run`.
-* Setting the root directory of aruba via method overwrite or configuration -
-  this should be your project root directory where the test suite is run.
-* The direct use of "InProcess", "DebugProcess" and "SpawnProcess" is not
-  supported anymore. You need to use "Command" instead. But be careful, it has
-  a different API.
-* HOME can be configured via `Aruba.configure {}` and defaults to
-  `File.join(aruba.config.root_directory, aruba.config.working_directory?)`
-  if `aruba/cucumber` or `aruba/rspec` is used.
-* Use different working directories based on test suite - RSpec, Cucumber.
-  It's `tmp/rspec` and `tmp/cucumber` now to make sure they do not overwrite
-  the test results from each other.
-* The use of `@interactive` is discontinued. You need to use
-  `#last_command_started`-method to get access to the interactively started
-  command.
-* If multiple commands have been started, each output has to be check
-  separately
-
-  ```cucumber
-  Scenario: Detect stdout from all processes
-    When I run `printf "hello world!\n"`
-    And I run `cat` interactively
-    And I type "hola"
-    And I type ""
-    Then the stdout should contain:
-      """
-      hello world!
-      """
-    And the stdout should contain:
-      """
-      hola
-      """
-    And the stderr should not contain anything
-  ```
-
-# RELEASED
+#  RELEASED
+
+## [v0.14.3](https://github.com/cucumber/aruba/compare/v0.14.2...v0.14.3)
+
+* Fix path bug (#422)
+* Ensure non-deprecated methods do not use deprecated methods
+* Update dependency on childprocess
+* Fix encoding output on JRuby
+
+## [v0.14.2](https://github.com/cucumber/aruba/compare/v0.14.1...v0.14.2)
+
+* Handle empty JRUBY_OPTS on JRuby
 
 ## [v0.14.1](https://github.com/cucumber/aruba/compare/v0.14.0...v0.14.1)
 
@@ -80,7 +37,7 @@
 * Fix circular require warnings (issue #339)
 * Fix use of old instances variable "@io_wait" (issue #341). Now the
   default value for io_wait_timeout can be set correctly.
-* Make it possible to announce information on command error, using a new option 
+* Make it possible to announce information on command error, using a new option
   called `activate_announcer_on_command_failure` (PR #335, @njam)
 * Re-integrate `event-bus`-library into `aruba`-core (PR #342)
 
@@ -301,7 +258,7 @@
 * Do not trigger Announcer API deprecation warning (issue #277)
 
 ## [v0.7.1](https://github.com/cucumber/aruba/compare/v0.7.0...v0.7.1)
-* Do not break if @interactive is used 
+* Do not break if @interactive is used
 
 ## [v0.7.0](https://github.com/cucumber/aruba/compare/v0.6.2...v0.7.0)
 * Introducing root_directory (issue #232)

data/Rakefile

@@ -8,8 +8,7 @@ require 'cucumber/rake/task'
 
 Cucumber::Rake::Task.new do |t|
   t.cucumber_opts = ""
-  # t.cucumber_opts = "--format Cucumber::Pro --out cucumber-pro.log" if ENV['CUCUMBER_PRO_TOKEN']
-  t.cucumber_opts << "--format pretty"
+  t.cucumber_opts << "--format progress"
 end
 
 Cucumber::Rake::Task.new(:cucumber_wip) do |t|
@@ -19,7 +18,7 @@ end
 require 'rspec/core/rake_task'
 desc "Run RSpec"
 RSpec::Core::RakeTask.new do |spec|
-  spec.rspec_opts = ['--color', '--format documentation', '--warnings']
+  spec.rspec_opts = ['--color', '--format progress', '--warnings']
 end
 
 namespace :travis do

data/aruba.gemspec

@@ -14,7 +14,7 @@ Gem::Specification.new do |s|
   s.homepage    = 'http://github.com/cucumber/aruba'
 
   s.add_runtime_dependency 'cucumber', '>= 1.3.19'
-  s.add_runtime_dependency 'childprocess', '~> 0.5.6'
+  s.add_runtime_dependency 'childprocess', '~> 0.8.0'
   s.add_runtime_dependency 'ffi', '~> 1.9.10'
   s.add_runtime_dependency 'rspec-expectations', '>= 2.99'
   s.add_runtime_dependency 'contracts', '~> 0.9'

data/features/getting_started/run_commands.feature

@@ -23,6 +23,7 @@ Feature: Run commands with Aruba
         \"\"\"
     """
 
+  @requires-bash
   Scenario: Bash Program
     Given an executable named "bin/cli" with:
     """bash
@@ -33,6 +34,7 @@ Feature: Run commands with Aruba
     When I successfully run `cucumber`
     Then the features should all pass
 
+  @requires-bash
   Scenario: Bash Program run via bash
     Given a file named "features/hello_aruba.feature" with:
     """
@@ -51,6 +53,7 @@ Feature: Run commands with Aruba
     When I successfully run `cucumber`
     Then the features should all pass
 
+  @requires-ruby
   Scenario: Ruby Program
     Given an executable named "bin/cli" with:
     """ruby
@@ -61,6 +64,7 @@ Feature: Run commands with Aruba
     When I successfully run `cucumber`
     Then the features should all pass
 
+  @requires-ruby
   Scenario: Ruby Program via "ruby"
     Given a file named "features/hello_aruba.feature" with:
     """
@@ -79,6 +83,7 @@ Feature: Run commands with Aruba
     When I successfully run `cucumber`
     Then the features should all pass
 
+  @requires-python
   Scenario: Python Program
     Given an executable named "bin/cli" with:
     """python
@@ -89,6 +94,7 @@ Feature: Run commands with Aruba
     When I successfully run `cucumber`
     Then the features should all pass
 
+  @requires-python
   Scenario: Python Program via "python"
     Given a file named "features/hello_aruba.feature" with:
     """
@@ -107,6 +113,7 @@ Feature: Run commands with Aruba
     When I successfully run `cucumber`
     Then the features should all pass
 
+  @requires-perl
   Scenario: Perl Program
     Given an executable named "bin/cli" with:
     """perl
@@ -117,6 +124,7 @@ Feature: Run commands with Aruba
     When I successfully run `cucumber`
     Then the features should all pass
 
+  @requires-perl
   Scenario: Perl Program via "perl"
     Given a file named "features/hello_aruba.feature" with:
     """
@@ -135,6 +143,7 @@ Feature: Run commands with Aruba
     When I successfully run `cucumber`
     Then the features should all pass
 
+  @requires-java
   Scenario: Java Program
 
     It's even possible to compile and run Java programs with Aruba.
@@ -162,6 +171,7 @@ Feature: Run commands with Aruba
     When I successfully run `cucumber`
     Then the features should all pass
 
+  @requires-posix-standard-tools
   Scenario: POSIX standard tools
     Given a file named "features/hello_aruba.feature" with:
     """

data/features/hooks/after/command.feature

@@ -19,6 +19,8 @@ Feature: After command hooks
   Scenario: Run a simple command with an "after(:command)"-hook
     Given a file named "spec/support/hooks.rb" with:
     """
+    require 'aruba'
+
     Aruba.configure do |config|
       config.after :command do |cmd|
         puts "after the run of `#{cmd.commandline}`"

data/features/hooks/before/command.feature

@@ -21,6 +21,8 @@ Feature: before_cmd hooks
   Scenario: Run a simple command with a "before(:command)"-hook
     Given a file named "spec/support/hooks.rb" with:
     """
+    require 'aruba'
+
     Aruba.configure do |config|
       config.before :command do |cmd|
         puts "before the run of `#{cmd.commandline}`"
@@ -47,6 +49,8 @@ Feature: before_cmd hooks
   Scenario: Run a simple command with a "before(:cmd)"-hook (deprecated)
     Given a file named "spec/support/hooks.rb" with:
     """
+    require 'aruba'
+
     Aruba.configure do |config|
       config.before :cmd do |cmd|
         puts "before the run of `#{cmd}`"

data/features/step_definitions/hooks.rb

@@ -1,5 +1,65 @@
 require 'cucumber/platform'
 
+Before '@requires-python' do |scenario|
+  next unless Aruba.platform.which('python').nil?
+
+  if Cucumber::VERSION < '2'
+    scenario.skip_invoke!
+  else
+    skip_this_scenario
+  end
+end
+
+Before '@requires-zsh' do |scenario|
+  next unless Aruba.platform.which('zsh').nil?
+
+  if Cucumber::VERSION < '2'
+    scenario.skip_invoke!
+  else
+    skip_this_scenario
+  end
+end
+
+Before '@requires-java' do |scenario|
+  next unless Aruba.platform.which('javac').nil?
+
+  if Cucumber::VERSION < '2'
+    scenario.skip_invoke!
+  else
+    skip_this_scenario
+  end
+end
+
+Before '@requires-perl' do |scenario|
+  next unless Aruba.platform.which('perl').nil?
+
+  if Cucumber::VERSION < '2'
+    scenario.skip_invoke!
+  else
+    skip_this_scenario
+  end
+end
+
+Before '@requires-ruby' do |scenario|
+  next unless Aruba.platform.which('ruby').nil?
+
+  if Cucumber::VERSION < '2'
+    scenario.skip_invoke!
+  else
+    skip_this_scenario
+  end
+end
+
+Before '@requires-posix-standard-tools' do |scenario|
+  next unless Aruba.platform.which('printf').nil?
+
+  if Cucumber::VERSION < '2'
+    scenario.skip_invoke!
+  else
+    skip_this_scenario
+  end
+end
+
 Before '@requires-ruby-version-193' do |scenario|
   next if RUBY_VERSION >= '1.9.3'
 

data/features/steps/command/output.feature

@@ -81,33 +81,12 @@ Feature: All output of commands which were executed
     When I run `cucumber`
     Then the features should all pass
 
-  @posix
-  Scenario: Detect exact one-line output for posix commands
+  Scenario: Detect exact one-line output
     Given a file named "features/output.feature" with:
     """cucumber
     Feature: Run command
       Scenario: Run command
-        When I run `printf 'hello world'`
-        Then the output should contain exactly:
-        \"\"\"
-        hello world
-        \"\"\"
-    """
-    When I run `cucumber`
-    Then the features should all pass
-
-  Scenario: Detect exact one-line output for ruby commands
-    Given an executable named "bin/cli" with:
-    """ruby
-    #!/usr/bin/env ruby
-
-    print "hello world"
-    """
-    And a file named "features/output.feature" with:
-    """cucumber
-    Feature: Run command
-      Scenario: Run command
-        When I run `cli`
+        When I run `echo 'hello world'`
         Then the output should contain exactly:
         \"\"\"
         hello world

data/features/steps/command/shell.feature

@@ -22,7 +22,7 @@ Feature: Running shell commands
 
         puts "Hello"
         \"\"\"
-        Then the output should contain exactly "Hello"
+        Then the output should contain "Hello"
 
       Scenario: Running python script
         When I run the following script:
@@ -89,7 +89,7 @@ Feature: Running shell commands
         \"\"\"ruby
         puts "Hello, Aruba!"
         \"\"\"
-        Then the output should contain exactly "Hello, Aruba!"
+        Then the output should contain "Hello, Aruba!"
     """
     When I run `cucumber`
     Then the features should all pass

data/features/steps/overview.feature

@@ -4,45 +4,10 @@ Feature: Overview of steps
   Who would like to use `aruba`
   But didn't know which steps are available
 
-  Background:
+  Scenario: Use cucumber output formatter
     Given I use a fixture named "cli-app"
-
-  Scenario: Use information found in repository
-    Given an executable named "bin/cli" with:
-    """
-    #!/bin/bash
-    git clone https://github.com/cucumber/aruba.git
-    cd aruba
-    grep -E "When|Given|Then" lib/aruba/cucumber/*.rb | awk -F ":" '{ $1 = ""; print $0}' |sort
-    """
     And a file named "features/run.feature" with:
     """
-    Feature: Run it
-      Scenario: Run command
-        When I run `cli`
-        Then the output should contain:
-        \"\"\"
-        Cloning into 'aruba'...
-        \"\"\"
-        And the output should contain:
-        \"\"\"
-        Given(/^
-        \"\"\"
-        And the output should contain:
-        \"\"\"
-        When(/^
-        \"\"\"
-        And the output should contain:
-        \"\"\"
-        Then(/^
-        \"\"\"
-    """
-    When I run `cucumber`
-    Then the features should all pass
-
-  Scenario: Use cucumber output formatter
-    Given a file named "features/run.feature" with:
-    """
     Feature: Run it
       Scenario: Run command
         Given a directory named "features"

data/lib/aruba/api/command.rb

@@ -282,6 +282,7 @@ module Aruba
             expect(command).to be_successfully_executed
           rescue RSpec::Expectations::ExpectationNotMetError => e
             aruba.announcer.activate(aruba.config.activate_announcer_on_command_failure)
+            aruba.event_bus.notify Events::CommandStopped.new(command)
             raise e
           end
         end

data/lib/aruba/command.rb

@@ -56,6 +56,8 @@ module Aruba
 
     # Terminate command
     def terminate(*)
+      return if __getobj__.stopped?
+
       __getobj__.terminate
       event_bus.notify Events::CommandStopped.new(self)