aruba 0.14.10 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aac7113c05858afc5a48b644bdb6e29427357319e13d6b7c5fb0c2a4d5afef4b
-  data.tar.gz: 463b5d14a0f1c0a2cbab30a5f51ab188916e077e8e00364d635353cdcb9346af
+  metadata.gz: 63d0e00b28a69fa235c0586425c501669cb313ce3dae63a76a33386eb358085e
+  data.tar.gz: be16476fe85c35d571574194c46c426cbb5805fff5fe2277b04b3f32f7098dc8
 SHA512:
-  metadata.gz: e525789f39d2f6cb13f178a174eae0c55a02ea8b8487353da9f075cc7dcab54498638ea101a7727bb9c87265d1232f711d9294988c81eb0de71408fa26113dde
-  data.tar.gz: 9604df096eb13935a3fe24114c9c381dc8cd0f3f749b01bcdde73e315dd1d8d23ba0dd819c0277517974b0a588788b787f9b648131a1a257a5cc954aea7ef966
+  metadata.gz: 77fcdcd8b492e23fc72be16b48dd9913a3e7615ade362006cff3754661c0176c4483ce9d78ac7aa9d0c4da08ff1ae2c4f741b0f80ff93a221b10f7f2806b7c5f
+  data.tar.gz: 1d8f1f0f2879f5fef29c3baeee8d2041cd2d130e8cdfed5e77dac075960c0fd6ee0c813f6be1400e176b3a6846819946f1e5b56a02be2933b1e1b7682c313102

data/.cucumberproignore

@@ -0,0 +1,3 @@
+/
+!features/
+features/04_aruba_api/command/run_simple.feature

data/.github/ISSUE_TEMPLATE.md

@@ -0,0 +1,48 @@
+<!-- These sections are meant as guidance for you, to help you give the kind of information we'll need to help with your issue. If a section  doesn't seem to fit, just skip it.
+
+In general: Please provide as much information as you can to help us solving your problem -->
+
+## Summary
+
+<!--- Provide a general summary description of the issue -->
+
+## Expected Behavior
+
+<!--- If you're describing a bug, tell us what should happen -->
+<!--- If you're suggesting a change/improvement, tell us how it should work -->
+<!--- Feel free to use Given / Then / Then if that helps, but please add some plain-language context too -->
+
+## Current Behavior
+
+<!--- If describing a bug, tell us what happens instead of the expected behavior -->
+<!--- If suggesting a change/improvement, explain the difference from current behavior -->
+
+<!--- If you have got some output place it in the code block below. Otherwise remove it. -->
+~~~
+~~~
+
+## Possible Solution
+
+<!--- Not obligatory, but suggest a fix/reason for the bug, -->
+<!--- or ideas how to implement the addition or change -->
+
+## Steps to Reproduce (for bugs)
+
+<!--- Provide a link to a live example, or an unambiguous set of steps to -->
+<!--- reproduce this bug. Include code to reproduce, if relevant -->
+1.
+2.
+3.
+4.
+
+## Context & Motivation
+
+<!--- How has this issue affected you? What are you trying to accomplish? -->
+<!--- Providing context helps us come up with a solution that is most useful in the real world -->
+
+## Your Environment
+
+<!--- If you're reporting a bug, include as many relevant details about the environment you experienced the bug in -->
+* Version used:
+* Operating System and version:
+* Link to your project:

data/.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,41 @@
+<!-- These sections are meant as guidance for you. If something doesn't fit, you can just skip it. -->
+
+## Summary
+
+<!--- Provide a general summary description of your changes -->
+
+## Details
+
+<!--- Describe your changes in detail -->
+
+## Motivation and Context
+
+<!--- Why is this change required? What problem does it solve? -->
+<!--- If it fixes an open issue, please link to the issue here. -->
+
+## How Has This Been Tested?
+
+<!--- Please add tests for changes to the code, otherwise we probably won't merge it -->
+
+<!--- Please describe in detail how you tested your changes. -->
+<!--- Include details of your testing environment, tests ran to see how -->
+<!--- your change affects other areas of the code, etc. -->
+
+## Screenshots (if appropriate):
+
+## Types of changes
+
+<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->
+- [ ] Bug fix (non-breaking change which fixes an issue)
+- [ ] New feature (non-breaking change which adds functionality)
+- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
+- [ ] Refactoring (cleanup of codebase without changing any existing functionality)
+- [ ] Update documentation
+
+## Checklist:
+
+<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->
+<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->
+- [ ] I've added tests for my code
+- [ ] My change requires a change to the documentation.
+- [ ] I have updated the documentation accordingly.

data/.gitignore

@@ -28,6 +28,7 @@ tmp
 .bundle
 doc
 Gemfile.lock
+Gemfile.local
 cucumber-pro.log
 
 ## Ruby versioniser

data/.rspec

@@ -1,3 +1,3 @@
 --color
---format Fuubar
 --order random
+--warnings

data/.rubocop.yml

@@ -1,192 +1,31 @@
+require:
+  - rubocop-performance
+
 AllCops:
   Exclude:
     - tmp/**/*
-    - vendor/bundle/**/*
+    - vendor/**/*
   DisplayCopNames: true
+  TargetRubyVersion: 2.4
 
-# Cop supports --auto-correct.
-# Configuration parameters: SupportedStyles.
-Style/HashSyntax:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Exclude:
-    - lib/aruba/api.rb
-    - lib/aruba/api/*.rb
-    - lib/aruba/platform.rb
-
-Metrics/AbcSize:
-  Enabled: false
-
-Lint/AmbiguousRegexpLiteral:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Lint/RescueException:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Lint/UnusedBlockArgument:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Lint/UnusedMethodArgument:
-  Enabled: false
-
-Lint/UselessAssignment:
-  Enabled: false
-
-# Configuration parameters: AllowURI.
-Metrics/LineLength:
-  Max: 169
-  Exclude:
-    - lib/aruba/api.rb
-    - aruba.gemspec
-
-# Configuration parameters: CountComments.
-Metrics/MethodLength:
-  Max: 18
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/AlignParameters:
-  Enabled: false
-
-Style/CaseEquality:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/CharacterLiteral:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/ClassCheck:
-  Enabled: false
-
-Style/ClassVars:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredMethods.
-Style/CollectionMethods:
-  Enabled: false
-
-Style/Documentation:
-  Enabled: false
-
-Style/DotPosition:
-  EnforcedStyle: trailing
-
-# Configuration parameters: MinBodyLength.
-Style/GuardClause:
-  Enabled: false
-
-# Configuration parameters: MaxLineLength.
-Style/IfUnlessModifier:
-  Enabled: false
-
-Style/Lambda:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/LeadingCommentSpace:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredDelimiters.
+# Use older RuboCop default
 Style/PercentLiteralDelimiters:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-# Configuration parameters: SupportedStyles.
-Style/RaiseArgs:
-  # EnforcedStyle: compact
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/RedundantSelf:
-  Enabled: false
-
-# Configuration parameters: MaxSlashes.
-Style/RegexpLiteral:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: AllowAsExpressionSeparator.
-Style/Semicolon:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SignalException:
-  Enabled: false
-
-# Configuration parameters: Methods.
-Style/SingleLineBlockParams:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceBeforeFirstArg:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceAfterComma:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceAroundKeyword:
-  Enabled: false
+  PreferredDelimiters:
+    '%w': ()
 
-# Cop supports --auto-correct.
-Style/SpaceAfterNot:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/SpaceBeforeBlockBraces:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceBeforeComma:
+# Code is currently broken with frozen string literal comments applied.
+# TODO: Enable and fix build
+Style/FrozenStringLiteralComment:
   Enabled: false
 
+# TODO: This is placed in here so the auto-gen-config doesn't destroy these.
+# Most of these need to be manually tackled, the LineLength value currently is good enough to stop most of
+# these leaking through into the codebase
+# Offense count: 375+
 # Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
-Style/SpaceInsideBlockBraces:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceInsideBrackets:
-  Enabled: false
-
-# Cop supports --auto-correct.
-Style/SpaceInsideParens:
-  Enabled: false
+# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
+# URISchemes: http, https
+Layout/LineLength:
+  Max: 150
 
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles.
-Style/StringLiterals:
-  Enabled: false
-
-# Cop supports --auto-correct.
-# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, Whitelist.
-Style/TrivialAccessors:
-  Enabled: false
-
-Style/RaiseArgs:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Style/IfInsideElse:
-  Enabled: false
-
-Style/IdenticalConditionalBranches:
-  Enabled: false
+inherit_from: .rubocop_todo.yml

data/.rubocop_todo.yml

@@ -0,0 +1,262 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2020-01-01 19:49:41 +0100 using RuboCop version 0.78.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 7
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - 'lib/aruba/platforms/announcer.rb'
+
+# Offense count: 12
+Lint/AmbiguousRegexpLiteral:
+  Exclude:
+    - 'lib/aruba/cucumber/testing_frameworks.rb'
+
+# Offense count: 2
+# Configuration parameters: CheckForMethodsWithNoSideEffects.
+Lint/Void:
+  Exclude:
+    - 'lib/aruba/platforms/announcer.rb'
+    - 'lib/aruba/platforms/unix_environment_variables.rb'
+
+# Offense count: 29
+Metrics/AbcSize:
+  Max: 116
+
+# Offense count: 72
+# Configuration parameters: CountComments, ExcludedMethods.
+# ExcludedMethods: refine
+Metrics/BlockLength:
+  Max: 587
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ClassLength:
+  Max: 145
+
+# Offense count: 20
+# Configuration parameters: CountComments, ExcludedMethods.
+Metrics/MethodLength:
+  Max: 22
+
+# Offense count: 2
+# Configuration parameters: CountComments.
+Metrics/ModuleLength:
+  Max: 175
+
+# Offense count: 3
+# Configuration parameters: CountKeywordArgs.
+Metrics/ParameterLists:
+  Max: 8
+
+# Offense count: 4
+Metrics/PerceivedComplexity:
+  Max: 10
+
+# Offense count: 1
+Naming/ConstantName:
+  Exclude:
+    - 'lib/aruba/platform.rb'
+
+# Offense count: 5
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+Naming/HeredocDelimiterNaming:
+  Exclude:
+    - 'lib/aruba/initializer.rb'
+
+# Offense count: 1
+# Configuration parameters: EnforcedStyleForLeadingUnderscores.
+# SupportedStylesForLeadingUnderscores: disallowed, required, optional
+Naming/MemoizedInstanceVariableName:
+  Exclude:
+    - 'lib/aruba/api/core.rb'
+
+# Offense count: 16
+# Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
+# AllowedNames: io, id, to, by, on, in, at, ip, db, os
+Naming/MethodParameterName:
+  Exclude:
+    - 'lib/aruba/aruba_path.rb'
+    - 'lib/aruba/config_wrapper.rb'
+    - 'lib/aruba/matchers/base/object_formatter.rb'
+    - 'lib/aruba/platforms/announcer.rb'
+    - 'lib/aruba/platforms/aruba_logger.rb'
+    - 'lib/aruba/platforms/unix_platform.rb'
+    - 'lib/aruba/tasks/docker_helpers.rb'
+
+# Offense count: 1
+Performance/Caller:
+  Exclude:
+    - 'lib/aruba/platforms/unix_platform.rb'
+
+# Offense count: 2
+Security/Open:
+  Exclude:
+    - 'lib/aruba/processes/spawn_process.rb'
+
+# Offense count: 3
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: inline, group
+Style/AccessModifierDeclarations:
+  Exclude:
+    - 'lib/aruba/in_config_wrapper.rb'
+    - 'lib/aruba/matchers/base/base_matcher.rb'
+    - 'lib/aruba/matchers/collection/all.rb'
+
+# Offense count: 3
+Style/CaseEquality:
+  Exclude:
+    - 'lib/aruba/matchers/base/object_formatter.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+Style/CharacterLiteral:
+  Exclude:
+    - 'spec/support/shared_contexts/aruba.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: is_a?, kind_of?
+Style/ClassCheck:
+  Exclude:
+    - 'lib/aruba/api/filesystem.rb'
+
+# Offense count: 1
+Style/CommentedKeyword:
+  Exclude:
+    - 'spec/aruba/api_spec.rb'
+
+# Offense count: 12
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'fixtures/cli-app/lib/cli/app.rb'
+    - 'fixtures/cli-app/lib/cli/app/suppress_simple_cov_output.rb'
+    - 'fixtures/empty-app/lib/cli/app.rb'
+    - 'lib/aruba/api/bundler.rb'
+    - 'lib/aruba/matchers/collection/include_an_object.rb'
+    - 'lib/aruba/platforms/command_monitor.rb'
+    - 'lib/aruba/setup.rb'
+    - 'lib/aruba/tasks/docker_helpers.rb'
+
+# Offense count: 1
+Style/EvalWithLocation:
+  Exclude:
+    - 'spec/support/helpers/reporting.rb'
+
+# Offense count: 84
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: annotated, template, unannotated
+Style/FormatStringToken:
+  Enabled: false
+
+# Offense count: 2
+Style/IdenticalConditionalBranches:
+  Exclude:
+    - 'lib/aruba/hooks.rb'
+
+# Offense count: 7
+# Cop supports --auto-correct.
+Style/IfUnlessModifier:
+  Exclude:
+    - 'lib/aruba/cucumber/command.rb'
+    - 'lib/aruba/matchers/collection/include_an_object.rb'
+    - 'lib/aruba/platforms/unix_environment_variables.rb'
+    - 'lib/aruba/setup.rb'
+    - 'spec/aruba/platform/windows_environment_variables_spec.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: line_count_dependent, lambda, literal
+Style/Lambda:
+  Exclude:
+    - 'spec/aruba/hooks_spec.rb'
+
+# Offense count: 5
+Style/MethodMissingSuper:
+  Exclude:
+    - 'lib/aruba/config_wrapper.rb'
+    - 'lib/aruba/in_config_wrapper.rb'
+    - 'lib/aruba/platforms/command_monitor.rb'
+    - 'lib/aruba/tasks/docker_helpers.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: be, be_a, be_an, be_between, be_falsey, be_kind_of, be_instance_of, be_truthy, be_within, eq, eql, end_with, include, match, raise_error, respond_to, start_with
+Style/NestedParenthesizedCalls:
+  Exclude:
+    - 'spec/aruba/matchers/collection_spec.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/aruba/contracts/is_power_of_two.rb'
+
+# Offense count: 3
+# Cop supports --auto-correct.
+# Configuration parameters: PreferredDelimiters.
+Style/PercentLiteralDelimiters:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/aruba/api/bundler.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
+# SupportedStyles: slashes, percent_r, mixed
+Style/RegexpLiteral:
+  Exclude:
+    - 'lib/aruba/cucumber/command.rb'
+    - 'lib/aruba/cucumber/file.rb'
+
+# Offense count: 4
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: implicit, explicit
+Style/RescueStandardError:
+  Exclude:
+    - 'lib/aruba/contracts/absolute_path.rb'
+    - 'lib/aruba/contracts/is_power_of_two.rb'
+    - 'lib/aruba/contracts/relative_path.rb'
+    - 'lib/aruba/event_bus/name_resolver.rb'
+
+# Offense count: 1
+# Cop supports --auto-correct.
+# Configuration parameters: AllowAsExpressionSeparator.
+Style/Semicolon:
+  Exclude:
+    - 'lib/aruba/platforms/aruba_fixed_size_file_creator.rb'
+
+# Offense count: 40
+# Cop supports --auto-correct.
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: only_raise, only_fail, semantic
+Style/SignalException:
+  Enabled: false
+
+# Offense count: 2
+# Cop supports --auto-correct.
+Style/StderrPuts:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/aruba/initializer.rb'
+
+# Offense count: 6
+# Cop supports --auto-correct.
+# Configuration parameters: MinSize.
+# SupportedStyles: percent, brackets
+Style/SymbolArray:
+  EnforcedStyle: brackets

data/.simplecov

@@ -1,10 +1,9 @@
-# Run simplecov by default
-SimpleCov.start unless ENV.key? 'ARUBA_NO_COVERAGE'
-
 SimpleCov.configure do
+  # Activate branch coverage
+  enable_coverage :branch
+
   # ignore this file
   add_filter '.simplecov'
-  add_filter 'spec'
   add_filter 'features'
 
   # Rake tasks aren't tested with rspec
@@ -30,5 +29,8 @@ SimpleCov.configure do
 
   # Specs are reported on to ensure that all examples are being run and all
   # lets, befores, afters, etc are being used.
-  add_group 'Specs', 'spec'
+  add_group 'Specs', 'spec/'
 end
+
+# Run simplecov by default
+SimpleCov.start unless ENV.key? 'ARUBA_NO_COVERAGE'