arturo 0.2.3.3 → 0.2.3.4

data/app/controllers/arturo/features_controller.rb

@@ -83,7 +83,7 @@ module Arturo
         flash[:notice] = t('arturo.features.flash.updated', :name => @feature.to_s)
         redirect_to feature_path(@feature)
       else
-          flash[:alert] = t('arturo.features.flash.error_updating', :name => @feature.to_s)
+        flash[:alert] = t('arturo.features.flash.error_updating', :name => @feature.to_s)
         render :action => 'edit'
       end
     end

data/app/helpers/arturo/features_helper.rb

@@ -23,16 +23,5 @@ module Arturo
     def deployment_percentage_output_tag(id, value)
       content_tag(:output, value, { 'for' => id, 'class' => 'deployment_percentage no_js' })
     end
-
-    def error_messages_for(feature, attribute)
-      errors = feature.errors.on(attribute)
-      if errors && errors.any?
-        content_tag(:ul, :class => 'errors') do
-          errors.map { |msg| content_tag(:li, msg, :class => 'error') }.join(''.html_safe)
-        end
-      else
-        ''
-      end
-    end
   end
 end

data/app/models/arturo/feature.rb

@@ -8,7 +8,7 @@ module Arturo
     include Arturo::SpecialHandling
 
     Arturo::Feature::SYMBOL_REGEX = /^[a-zA-z][a-zA-Z0-9_]*$/
-    DEFAULT_ATTRIBUTES = { :deployment_percentage => 0 }
+    DEFAULT_ATTRIBUTES = { :deployment_percentage => 0 }.with_indifferent_access
 
     attr_readonly :symbol
 
@@ -78,8 +78,7 @@ module Arturo
       threshold = self.deployment_percentage || 0
       return false if threshold == 0
       return true if threshold == 100
-      (((feature_recipient.id + 17) * 13) % 100) < threshold
-      
+      (((feature_recipient.id + (self.id || 1) + 17) * 13) % 100) < threshold
     end
   end
 end

data/app/views/arturo/features/_form.html.erb

@@ -1,15 +1,19 @@
-<% form_for(feature, :as => 'feature', :url => (feature.new_record? ? features_path : feature_path(feature))) do |form| %>
+<% form_for(:feature, feature,
+                      :url => (feature.new_record? ? features_path : feature_path(feature)),
+                      :html => {
+                        :method => (feature.new_record? ? :post : :put)
+                      }) do |form| %>
   <fieldset>
     <legend><%= legend %></legend>
 
+    <%= error_messages_for(:feature, :object => feature) %>
+
     <%= form.label(:symbol) %>
     <%= form.text_field(:symbol, :required => 'required', :pattern => Arturo::Feature::SYMBOL_REGEX.source, :class => 'symbol') %>
-    <%= error_messages_for(feature, :symbol) %>
 
     <%= form.label(:deployment_percentage) %>
     <%= form.range_field(:deployment_percentage, :min => '0', :max => '100', :step => '1', :class => 'deployment_percentage') %>
     <%= deployment_percentage_output_tag 'feature_deployment_percentage', feature.deployment_percentage %>
-    <%= error_messages_for(feature, :deployment_percentage) %>
 
     <footer><%= form.submit %></footer>
   </fieldset>

data/lib/arturo/feature_availability.rb

@@ -24,7 +24,7 @@ module Arturo
     end
 
     # By default, returns current_user.
-    # 
+    #
     # If you would like to change this implementation, it is recommended
     # you do so in config/initializers/arturo_initializer.rb
     # @return [Object] the recipient of features.

data/lib/arturo/feature_management.rb

@@ -4,11 +4,11 @@ module Arturo
   # as a helper for all views. It provides a single method,
   # may_manage_features?, that returns whether or not the current user
   # may manage features. By default, it is implemented as follows:
-  # 
+  #
   #   def may_manage_features?
   #     current_user.present? && current_user.admin?
   #   end
-  # 
+  #
   # If you would like to change this implementation, it is recommended
   # you do so in config/initializers/arturo_initializer.rb
   module FeatureManagement

data/lib/generators/arturo/templates/arturo.css

@@ -43,12 +43,12 @@ output.deployment_percentage:after { content: "%"; }
   display: block;
 }
 
-.feature_new  label + input, .feature_new  label + textarea, .feature_new  label + select, 
+.feature_new  label + input, .feature_new  label + textarea, .feature_new  label + select,
 .feature_edit label + input, .feature_edit label + textarea, .feature_edit label + select {
   margin-top: 0.5em;
 }
 
-.feature_new  input + label, .feature_new  textarea + label, .feature_new  select + label, 
+.feature_new  input + label, .feature_new  textarea + label, .feature_new  select + label,
 .feature_edit input + label, .feature_edit textarea + label, .feature_edit select + label {
   margin-top: 1.5em;
 }

data/lib/generators/arturo/templates/arturo.js

@@ -16,7 +16,7 @@ if (typeof(jQuery) === 'function') {
       }
     }
   };
-  
+
   jQuery(function() {
     jQuery.arturo.linkAndShowOutputs();
   });

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification 
 name: arturo
 version: !ruby/object:Gem::Version 
-  hash: 85
+  hash: 91
   prerelease: false
   segments: 
   - 0
   - 2
   - 3
-  - 3
-  version: 0.2.3.3
+  - 4
+  version: 0.2.3.4
 platform: ruby
 authors: 
 - James A. Rosen
@@ -16,7 +16,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-11-02 00:00:00 -07:00
+date: 2010-11-04 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency