artsy-eventservice 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 730a1c3e93fc39daa432c14e98e4d3e470bd21d5
-  data.tar.gz: b91155920aa1d4d24d9c1c96e1b13cb822a121ca
+  metadata.gz: b78e01513fda0bf9edb4839c1996d5a55c59d422
+  data.tar.gz: 528d6a8bc07e57a6c157d80ea7af6f87ee2dc732
 SHA512:
-  metadata.gz: 26960c9c97661ea5bba215c7863f78162713e975ea60917527d0d6a3ba8fb6809a94ce1d34c7f9f2e6770aa07e628a4f950aacffd7cd089f3e7364b61eddc726
-  data.tar.gz: e4a4eddb337a77cba72ed97d39c9f06225ea42c40ffa34e92ffd6dc0d417a60582e7135387b9e2a04633aee652241a30f5c578bd48388b3f2121dd2bb730f29e
+  metadata.gz: c2df6cb05beab94d16aa9015fcca729fd8d5ce354feeab6ce8e3243dd331adc5d619578267810bf123ebf96a560469072a87bddf41bd5db2ff9580ec72e369f6
+  data.tar.gz: d865174232877df38968b9a963f84d4159dfae91c379b9df87b016e3829369c9d1f639759ffc2e6d9e0c2090d8d895f0981a0e1d6737a0c740a5746df4d5d6fb

data/Gemfile

@@ -8,7 +8,7 @@ gem 'rake'
 gem 'bunny' # for producing/consuming evets from RabbitMQ
 
 group :development do
-  gem 'rubocop', '~> 0.47.1', require: false
+  gem 'rubocop', '~> 0.48', require: false
   gem 'pry-nav'
   gem 'pry-stack_explorer'
   gem 'pry-rescue'

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    artsy-eventservice (1.0.4)
+    artsy-eventservice (1.0.5)
       bunny (~> 2.7.1)
 
 GEM
@@ -18,8 +18,9 @@ GEM
     diff-lcs (1.2.5)
     interception (0.5)
     method_source (0.8.2)
-    parser (2.4.0.0)
-      ast (~> 2.2)
+    parallel (1.12.1)
+    parser (2.4.0.2)
+      ast (~> 2.3)
     powerpack (0.1.1)
     pry (0.10.4)
       coderay (~> 1.1.0)
@@ -33,8 +34,8 @@ GEM
     pry-stack_explorer (0.4.9.2)
       binding_of_caller (>= 0.7)
       pry (>= 0.9.11)
-    rainbow (2.2.1)
-    rake (12.0.0)
+    rainbow (3.0.0)
+    rake (12.3.0)
     rspec (3.5.0)
       rspec-core (~> 3.5.0)
       rspec-expectations (~> 3.5.0)
@@ -48,15 +49,16 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.5.0)
     rspec-support (3.5.0)
-    rubocop (0.47.1)
-      parser (>= 2.3.3.1, < 3.0)
+    rubocop (0.52.1)
+      parallel (~> 1.10)
+      parser (>= 2.4.0.2, < 3.0)
       powerpack (~> 0.1)
-      rainbow (>= 1.99.1, < 3.0)
+      rainbow (>= 2.2.2, < 4.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (~> 1.0, >= 1.0.1)
-    ruby-progressbar (1.8.1)
+    ruby-progressbar (1.9.0)
     slop (3.6.0)
-    unicode-display_width (1.1.3)
+    unicode-display_width (1.3.0)
 
 PLATFORMS
   ruby
@@ -70,10 +72,10 @@ DEPENDENCIES
   rake
   rspec
   rspec-mocks
-  rubocop (~> 0.47.1)
+  rubocop (~> 0.48)
 
 RUBY VERSION
    ruby 2.3.0p0
 
 BUNDLED WITH
-   1.15.4
+   1.16.1

data/lib/artsy-eventservice/artsy/event_service.rb

@@ -2,9 +2,16 @@
 # frozen_string_literal: true
 module Artsy
   module EventService
+
+    # Post data without an event, data must be a string.
+    def self.post_data(topic:, data:, routing_key: nil)
+      return unless event_stream_enabled?
+      Publisher.publish_data(topic: topic, data: data, routing_key: routing_key)
+    end
+
     def self.post_event(topic:, event:, routing_key: nil)
       return unless event_stream_enabled?
-      Publisher.publish(topic: topic, event: event, routing_key: routing_key || event.routing_key)
+      Publisher.publish_event(topic: topic, event: event, routing_key: routing_key || event.routing_key)
     end
 
     def self.consume(**args)

data/lib/artsy-eventservice/artsy/event_service/publisher.rb

@@ -2,26 +2,37 @@
 module Artsy
   module EventService
     class Publisher
-      def self.publish(topic:, event:, routing_key: nil)
+      def self.publish_event(topic:, event:, routing_key: nil)
         new.post_event(topic: topic, event: event, routing_key: routing_key)
       end
 
-      def post_event(topic:, event:, routing_key: nil)
-        raise 'Event missing topic or verb.' if event.verb.to_s.empty? || topic.to_s.empty?
+      def self.publish_data(topic:, data:, routing_key: nil)
+        new.post_data(topic: topic, data: data, routing_key: routing_key)
+      end
+
+      def post_data(topic:, data:, routing_key: nil)
         RabbitMQConnection.get_channel do |channel|
           channel.confirm_select if config.confirms_enabled
           exchange = channel.topic(topic, durable: true)
           exchange.publish(
-            event.json,
-            routing_key: routing_key || event.verb,
+            data,
+            routing_key: routing_key,
             persistent: true,
             content_type: 'application/json',
             app_id: config.app_name
           )
-          raise 'Publishing event failed' if config.confirms_enabled && !channel.wait_for_confirms
+          raise 'Publishing data failed' if config.confirms_enabled && !channel.wait_for_confirms
         end
       end
 
+      def post_event(topic:, event:, routing_key: nil)
+        raise 'Event missing topic or verb.' if event.verb.to_s.empty? || topic.to_s.empty?
+        post_data(
+          topic: topic,
+          data: event.json,
+          routing_key: routing_key || event.verb)
+      end
+
       def config
         Artsy::EventService.config
       end

data/lib/artsy-eventservice/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module Artsy
   module EventService
-    VERSION = '1.0.4'
+    VERSION = '1.0.5'
   end
 end

data/spec/artsy-eventstream/artsy/event_service_spec.rb

@@ -21,16 +21,23 @@ describe Artsy::EventService do
       allow(Artsy::EventService).to receive(:config).and_return(double(event_stream_enabled: true))
     end
     describe '.post_event' do
-      it 'calls publish with proper params' do
-        expect(Artsy::EventService::Publisher).to receive(:publish).with(topic: 'test', event: event, routing_key: 'test.passed')
+      it 'calls publish_event with proper params' do
+        expect(Artsy::EventService::Publisher).to receive(:publish_event).with(topic: 'test', event: event, routing_key: 'test.passed')
 
         Artsy::EventService.post_event(topic: 'test', event: event)
       end
       it 'calls publish with proper params with routing key' do
-        expect(Artsy::EventService::Publisher).to receive(:publish).with(topic: 'test', event: event, routing_key: 'good.route')
+        expect(Artsy::EventService::Publisher).to receive(:publish_event).with(topic: 'test', event: event, routing_key: 'good.route')
 
         Artsy::EventService.post_event(topic: 'test', event: event, routing_key: 'good.route')
       end
     end
+    describe '.post_data' do
+      it 'calls publish_data with proper params' do
+        expect(Artsy::EventService::Publisher).to receive(:publish_data).with(topic: 'test', data: 'foo', routing_key: 'good.route')
+
+        Artsy::EventService.post_data(topic: 'test', data: 'foo', routing_key: 'good.route')
+      end
+    end
   end
 end

data/spec/artsy-eventstream/artsy/publisher_spec.rb

@@ -19,15 +19,15 @@ describe Artsy::EventService::Publisher do
 
   describe '.publish' do
     it 'fails when topic is empty' do
-      expect { Artsy::EventService::Publisher.publish(topic: nil, event: event) }.to raise_error 'Event missing topic or verb.'
+      expect { Artsy::EventService::Publisher.publish_event(topic: nil, event: event) }.to raise_error 'Event missing topic or verb.'
     end
     it 'fails when event.verb is empty' do
       allow(event).to receive(:verb).and_return('')
-      expect { Artsy::EventService::Publisher.publish(topic: 'test', event: event) }.to raise_error 'Event missing topic or verb.'
+      expect { Artsy::EventService::Publisher.publish_event(topic: 'test', event: event) }.to raise_error 'Event missing topic or verb.'
     end
     it 'fails when event.verb is nil' do
       allow(event).to receive(:verb).and_return(nil)
-      expect { Artsy::EventService::Publisher.publish(topic: 'test', event: event) }.to raise_error 'Event missing topic or verb.'
+      expect { Artsy::EventService::Publisher.publish_event(topic: 'test', event: event) }.to raise_error 'Event missing topic or verb.'
     end
     it 'uses verb as routing key when calling publish on the exchange without passing routing_key' do
       conn = double
@@ -48,7 +48,7 @@ describe Artsy::EventService::Publisher do
         content_type: 'application/json',
         app_id: 'artsy'
       )
-      Artsy::EventService::Publisher.publish(topic: 'test', event: event)
+      Artsy::EventService::Publisher.publish_event(topic: 'test', event: event)
     end
     it 'uses verb as routing key when calling publish on the exchange without passing routing_key' do
       conn = double
@@ -69,7 +69,7 @@ describe Artsy::EventService::Publisher do
         content_type: 'application/json',
         app_id: 'artsy'
       )
-      Artsy::EventService::Publisher.publish(topic: 'test', event: event, routing_key: 'good.route')
+      Artsy::EventService::Publisher.publish_event(topic: 'test', event: event, routing_key: 'good.route')
     end
     it 'raises an error if event publishing is unconfirmed' do
       conn = double
@@ -91,8 +91,8 @@ describe Artsy::EventService::Publisher do
         app_id: 'artsy'
       )
       expect do
-        Artsy::EventService::Publisher.publish(topic: 'test', event: event, routing_key: 'good.route')
-      end.to raise_error 'Publishing event failed'
+        Artsy::EventService::Publisher.publish_event(topic: 'test', event: event, routing_key: 'good.route')
+      end.to raise_error 'Publishing data failed'
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: artsy-eventservice
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Ashkan Nasseri
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-06 00:00:00.000000000 Z
+date: 2018-01-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny