artsy-eventservice 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 4a7279cae09152a9ac7a1ddace21b41204107959
-  data.tar.gz: 408d96afb3aed0492a616081d4e4697350216eb4
+  metadata.gz: 7bcde99f80b60c849663d0402629e335c000669f
+  data.tar.gz: d210c63aee1afc7473c3cd5f42da578368a6756f
 SHA512:
-  metadata.gz: 651025fc9da750f6b073566313bd669d032b3abce49fa6f8dcb2cf56d3084ab8bc22b57c7320d98479c82e12cca9ef08f398e3b56b6dffe8ea5f69763de0506e
-  data.tar.gz: 73eac6af6005a8a23b4810ed7daa675125332b07754928b6d83650a7d5bc92765ca9c3496ebe2f8e1a360ed9a8265bb6805f077b506d74e7b2c99d0b5b189a14
+  metadata.gz: 247bdd61719b7885eb5ccd531a4a7747575c983eb482dd88496ced9be9682c517a53fb24181ae18668cbe80639f068d7d30763de7a9bfbb7f3b5c781bfd71179
+  data.tar.gz: 4e8af51716145e1688661e52bcc1c014efc8ebca198a354e6f53632c414a27ea1b5d85e9515a716e9cc21de6d2f5a012a1db029b55f3275fee38588e27ae30ee

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    artsy-eventservice (1.0.1)
+    artsy-eventservice (1.0.2)
       bunny (~> 2.6.2)
 
 GEM

data/lib/artsy-eventservice/artsy/event_service/publisher.rb

@@ -4,18 +4,18 @@ module Artsy
     class Publisher
       include RabbitMQConnection
 
-      def self.publish(topic:, event:)
-        new.post_event(topic: topic, event: event)
+      def self.publish(topic:, event:, routing_key: nil)
+        new.post_event(topic: topic, event: event, routing_key: routing_key)
       end
 
-      def post_event(topic:, event:)
+      def post_event(topic:, event:, routing_key: nil)
         raise 'Event missing topic or verb.' if event.verb.to_s.empty? || topic.to_s.empty?
         connect_to_rabbit do |conn|
           channel = conn.create_channel
           exchange = channel.topic(topic, durable: true)
           exchange.publish(
             event.json,
-            routing_key: event.verb,
+            routing_key: routing_key || event.verb,
             persistent: true,
             content_type: 'application/json',
             app_id: config.app_name

data/lib/artsy-eventservice/artsy/event_service.rb

@@ -2,9 +2,9 @@
 # frozen_string_literal: true
 module Artsy
   module EventService
-    def self.post_event(topic:, event:)
+    def self.post_event(topic:, event:, routing_key: nil)
       return unless event_stream_enabled?
-      Publisher.publish(topic: topic, event: event)
+      Publisher.publish(topic: topic, event: event, routing_key: routing_key)
     end
 
     def self.consume(**args)

data/lib/artsy-eventservice/version.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 module Artsy
   module EventService
-    VERSION = '1.0.1'
+    VERSION = '1.0.2'
   end
 end

data/spec/artsy-eventstream/artsy/event_service_spec.rb

@@ -21,11 +21,16 @@ describe Artsy::EventService do
       allow(Artsy::EventService).to receive(:config).and_return(double(event_stream_enabled: true))
     end
     describe '.post_event' do
-      it 'does connect to rabbit' do
-        expect(Artsy::EventService::Publisher).to receive(:publish)
+      it 'calls publish with proper params' do
+        expect(Artsy::EventService::Publisher).to receive(:publish).with(topic: 'test', event: event, routing_key: nil)
 
         Artsy::EventService.post_event(topic: 'test', event: event)
       end
+      it 'calls publish with proper params with routing key' do
+        expect(Artsy::EventService::Publisher).to receive(:publish).with(topic: 'test', event: event, routing_key: 'good.route')
+
+        Artsy::EventService.post_event(topic: 'test', event: event, routing_key: 'good.route')
+      end
     end
   end
 end

data/spec/artsy-eventstream/artsy/publisher_spec.rb

@@ -29,7 +29,7 @@ describe Artsy::EventService::Publisher do
       allow(event).to receive(:verb).and_return(nil)
       expect { Artsy::EventService::Publisher.publish(topic: 'test', event: event) }.to raise_error 'Event missing topic or verb.'
     end
-    it 'calls publish on the exchange with proper data' do
+    it 'uses verb as routing key when calling publish on the exchange without passing routing_key' do
       conn = double
       channel = double
       exchange = double
@@ -48,5 +48,24 @@ describe Artsy::EventService::Publisher do
       )
       Artsy::EventService::Publisher.publish(topic: 'test', event: event)
     end
+    it 'uses verb as routing key when calling publish on the exchange without passing routing_key' do
+      conn = double
+      channel = double
+      exchange = double
+      allow(Bunny).to receive(:new).and_return(conn)
+      expect(conn).to receive(:start).once
+      expect(conn).to receive(:stop).once
+      allow(conn).to receive(:create_channel).and_return(channel)
+      allow(channel).to receive(:topic).with('test', durable: true).and_return(exchange)
+
+      expect(exchange).to receive(:publish).with(
+        JSON.generate(hello: true),
+        routing_key: 'good.route',
+        persistent: true,
+        content_type: 'application/json',
+        app_id: 'artsy'
+      )
+      Artsy::EventService::Publisher.publish(topic: 'test', event: event, routing_key: 'good.route')
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: artsy-eventservice
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Ashkan Nasseri
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-12 00:00:00.000000000 Z
+date: 2017-07-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bunny