artsy-auth 0.1.7 → 0.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ba8129acee8eb8eac60ecc4aed047f217b45436f
-  data.tar.gz: 947a25949d2e80127eafd392c766f6a264ef9700
+  metadata.gz: 7a2f2591b274cf4eba66d78b563365f51341cbaf
+  data.tar.gz: 38ba2fbbfe919ef424cfa0c1f8a8b7e07d11fc8c
 SHA512:
-  metadata.gz: 550df60be40618038c3f43e9272412fe9064b970348649ba84a09f28eac27f31cadf5d9464f5a8feb84900cca3fd838fbb876b256420a01e12d702146abc3bda
-  data.tar.gz: 0667722d66b01375bd12b688d1b7b815986b84f778222aa5ecf05a3b4dbb1d4eb637356d9158413a6b66548e245e966aeafa8215fe96203e1c517451d907384a
+  metadata.gz: b35055a3b5ab3b5e3de9f1a6e0454d5d45fda0977c2f117a620c0b2e057979fba571c621306117ec1215358c91dc48206a009a13a5c3a97c9e86cfca6e963088
+  data.tar.gz: df30a0ef5f1c67da6ae1635967043770191712fc3118f2ba0ed0d6f4bd91283a911ebced4ba82912f04255579cd4f30efd03ec247457969995a0f0a504690cbb

data/README.md

@@ -3,7 +3,7 @@
 Ruby Gem for adding Artsy's omniauth based authentication to your app.
 
 ## Installation
-Add following line to your Gemfile
+Add following line to your Gemfile.
 
 ```
 gem 'artsy-auth'
@@ -32,26 +32,27 @@ You also need to mount session related endpoints to your app, in your `config/ro
 mount ArtsyAuth::Engine => '/'
 ```
 
-In order to force authentication, you need to change your `ApplicationController` to inherit from ` ArtsyAuth::ApplicationController`, you also need to add (override) `authorize?` method there which gets a token and in your app you need to define how do you authorize that token, for example:
+In order to force authentication, you need to include 'ArtsyAuth::Authenticated' in your controller, you also need to add (override) `authorized_artsy_token?` method there which gets a token and in your app you need to define how do you authorize that token, for example:
 ```ruby
 class ApplicationController < ArtsyAuth::ApplicationController
   # Prevent CSRF attacks by raising an exception.
   protect_from_forgery with: :exception
 
-  # override applicaiton to decode token and allow only users with `tester` role
+  # This will make sure calls to this controller have proper session data
+  # if they don't it will redirect them to oauth url and once authenticated
+  # on successful authentication we'll call authorized_artsy_token
+  include ArtsyAuth::Authenticated
+
+  # override application to decode token and allow only users with `tester` role
   def authorized_artsy_token?(token)
     decoded_token, _headers = JWT.decode(token, 'some-secret')
     decoded_token['roles'].include? 'tester'
   end
 end
 ```
-Note that this will add authentication to all of your controllers, if you want to skip Artsy's authentication for specific controller you can skip it in your controller by adding:
-```ruby
-class TestController
-  skip_before_action :require_artsy_authentication
-end
-```
 
+# Update From Version < 0.1.7
+In previous versions you would change your `ApplicationController` to inherit from `ArtsyAuth::ApplicationController`, with versions > `0.1.7` you need to `include ArtsyAuth::Authenticated` like the example above.
 
 # Contributing
 

data/lib/artsy-auth.rb

@@ -1,8 +1,8 @@
+require 'artsy-auth/authenticated'
 require 'artsy-auth/config'
 require 'artsy-auth/engine'
-require 'artsy-auth/version'
-require 'artsy-auth/application_controller'
 require 'artsy-auth/session_controller'
+require 'artsy-auth/version'
 
 module ArtsyAuth
 end

data/lib/artsy-auth/{application_controller.rb → authenticated.rb}

@@ -1,6 +1,12 @@
 module ArtsyAuth
-  class ApplicationController < ActionController::Base
-    before_action :require_artsy_authentication
+  module Authenticated
+    extend ActiveSupport::Concern
+
+    included do
+      before_action :require_artsy_authentication
+    end
+
+    private
 
     def require_artsy_authentication
       if session[:access_token]

data/lib/artsy-auth/session_controller.rb

@@ -1,6 +1,5 @@
 module ArtsyAuth
-  class SessionsController < ApplicationController
-    skip_before_action :require_artsy_authentication
+  class SessionsController < ActionController::Base
     def create
       session[:user_id] = auth_hash['uid']
       session[:email] = auth_hash['info']['raw_info']['email']
@@ -19,4 +18,4 @@ module ArtsyAuth
       request.env['omniauth.auth']
     end
   end
-end
+end

data/lib/artsy-auth/version.rb

@@ -1,3 +1,3 @@
 module ArtsyAuth
-  VERSION = '0.1.7'.freeze
+  VERSION = '0.1.8'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: artsy-auth
 version: !ruby/object:Gem::Version
-  version: 0.1.7
+  version: 0.1.8
 platform: ruby
 authors:
 - Artsy
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-04-05 00:00:00.000000000 Z
+date: 2017-06-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth-oauth2
@@ -134,7 +134,7 @@ files:
 - config/initializers/omniauth.rb
 - config/routes.rb
 - lib/artsy-auth.rb
-- lib/artsy-auth/application_controller.rb
+- lib/artsy-auth/authenticated.rb
 - lib/artsy-auth/config.rb
 - lib/artsy-auth/engine.rb
 - lib/artsy-auth/session_controller.rb