artifactory 1.2.0 → 2.0.0

data/spec/integration/resources/system_spec.rb

@@ -10,7 +10,7 @@ module Artifactory
 
     describe '.ping' do
       it 'returns ok' do
-        expect(described_class.ping).to be_true
+        expect(described_class.ping).to be_truthy
       end
     end
 

data/spec/integration/resources/url_base_spec.rb

@@ -0,0 +1,22 @@
+require 'spec_helper'
+
+module Artifactory
+  describe Resource::URLBase, :integration do
+    describe '.all' do
+      it 'returns an array of UrlBases' do
+        results = described_class.all
+        expect(results).to be_a(Array)
+        expect(results.first).to be_a(described_class)
+      end
+    end
+
+    describe '.find' do
+      it 'finds a urlBase by url' do
+        base = described_class.find('http://33.33.33.20/artifactory')
+
+        expect(base).to be_a(described_class)
+        expect(base.url_base).to eq('http://33.33.33.20/artifactory')
+      end
+    end
+  end
+end

data/spec/integration/resources/user_spec.rb

@@ -31,14 +31,14 @@ module Artifactory
     describe '#delete' do
       it 'deletes the user from the server' do
         sethvargo = described_class.find('sethvargo')
-        expect(sethvargo.delete).to be_true
+        expect(sethvargo.delete).to be_truthy
       end
     end
 
     describe '#save' do
       it 'saves the user to the server' do
         user = described_class.new(name: 'schisamo')
-        expect(user.save).to be_true
+        expect(user.save).to be_truthy
       end
     end
   end

data/spec/spec_helper.rb

@@ -20,7 +20,6 @@ RSpec.configure do |config|
   # is focused, then all tests are executed.
   config.filter_run(focus: true)
   config.run_all_when_everything_filtered = true
-  config.treat_symbols_as_metadata_keys_with_true_values = true
 
   # Stuff to do on each run
   config.before(:each) { Artifactory.reset! }

data/spec/support/api_server/system_endpoints.rb

@@ -35,7 +35,50 @@ module Artifactory
                 <fileIntegrationRevisionRegExp>SNAPSHOT|(?:(?:[0-9]{8}.[0-9]{6})-(?:[0-9]+))</fileIntegrationRevisionRegExp>
               </repoLayout>
             </repoLayouts>
-          </config>
+            <urlBase>http://33.33.33.20/artifactory</urlBase>
+            <mailServer>
+              <enabled>true</enabled>
+              <host>smtp.gmail.com</host>
+              <port>25</port>
+              <username>us@example.com</username>
+              <password>ihopethisisnotyourpassword</password>
+              <from>artifactory@example.com</from>
+              <subjectPrefix>[Artifactory]</subjectPrefix>
+              <tls>true</tls>
+              <ssl>false</ssl>
+              <artifactoryUrl>http://33.33.33.20/artifactory</artifactoryUrl>
+            </mailServer>
+            <security>
+              <ldapSettings>
+                <ldapSetting>
+                  <key>example-ldap</key>
+                  <enabled>true</enabled>
+                  <ldapUrl>ldap://localhost/DC=examplecorp,DC=com</ldapUrl>
+                  <search>
+                    <searchFilter>sAMAccountName={0}</searchFilter>
+                    <searchBase>OU=Domain Users</searchBase>
+                    <searchSubTree>true</searchSubTree>
+                    <managerDn>CN=ldapbind,OU=Employees,OU=Domain Users,DC=examplecorp,DC=com</managerDn>
+                    <managerPassword>ldappassword</managerPassword>
+                  </search>
+                  <autoCreateUser>false</autoCreateUser>
+                  <emailAttribute>mail</emailAttribute>
+                </ldapSetting>
+              </ldapSettings>
+            </security>
+            <backups>
+              <backup>
+                <key>backup-daily</key>
+                <enabled>true</enabled>
+                <cronExp>0 0 2 ? * MON-FRI</cronExp>
+                <retentionPeriodHours>0</retentionPeriodHours>
+                <createArchive>false</createArchive>
+                <excludedRepositories/>
+                <sendMailOnError>true</sendMailOnError>
+                <excludeBuilds>false</excludeBuilds>
+             </backup>
+           </backups> 
+         </config>
         EOH
       end
 

data/spec/unit/artifactory_spec.rb

@@ -47,10 +47,10 @@ describe Artifactory do
   describe '.method_missing' do
     context 'when the client responds to the method' do
       let(:client) { double(:client) }
-      before { Artifactory.stub(:client).and_return(client) }
+      before { allow(Artifactory).to receive(:client).and_return(client) }
 
       it 'delegates the method to the client' do
-        client.stub(bacon: 'awesome')
+        allow(client).to receive(:bacon).and_return('awesome')
         expect { Artifactory.bacon }.to_not raise_error
       end
     end
@@ -64,7 +64,7 @@ describe Artifactory do
 
   describe '.respond_to_missing?' do
     let(:client) { double(:client) }
-    before { Artifactory.stub(:client).and_return(client) }
+    before { allow(Artifactory).to receive(:client).and_return(client) }
 
     it 'delegates to the client' do
       expect { Artifactory.respond_to_missing?(:foo) }.to_not raise_error

data/spec/unit/client_spec.rb

@@ -35,7 +35,7 @@ module Artifactory
       end
 
       it 'delegates to the class, injecting the client' do
-        Resource::Artifact.stub(:search)
+        allow(Resource::Artifact).to receive(:search)
         expect(Resource::Artifact).to receive(:search).with(client: subject)
         subject.artifact_search
       end

data/spec/unit/resources/artifact_spec.rb

@@ -5,8 +5,8 @@ module Artifactory
     let(:client) { double(:client) }
 
     before(:each) do
-      Artifactory.stub(:client).and_return(client)
-      client.stub(:get).and_return(response) if defined?(response)
+      allow(Artifactory).to receive(:client).and_return(client)
+      allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
     describe '.search' do
@@ -35,39 +35,28 @@ module Artifactory
     end
 
     describe '#upload' do
-      let(:client) { double(put: {}) }
-      before do
-        subject.client = client
-      end
+      let(:client)     { double(put: {}) }
+      let(:local_path) { '/local/path' }
+      let(:file)       { double(File) }
 
-      context 'when the artifact is a File' do
-        it 'PUTs the file to the server' do
-          file = double(file)
-          File.stub(:new).and_return(file)
-          expect(client).to receive(:put).with('libs-release-local/remote/path', file, {})
+      subject { described_class.new(client: client, local_path: local_path) }
 
-          subject.upload('libs-release-local', file, '/remote/path')
-        end
+      before do
+        allow(File).to receive(:new).with(local_path).and_return(file)
       end
 
       context 'when the artifact is a file path' do
         it 'PUTs the file at the path to the server' do
-          file = double(file)
-          path = '/fake/path'
-          File.stub(:new).with('/fake/path').and_return(file)
           expect(client).to receive(:put).with('libs-release-local/remote/path', file, {})
-
-          subject.upload('libs-release-local', path, '/remote/path')
+          subject.upload('libs-release-local', '/remote/path')
         end
       end
 
       context 'when matrix properties are given' do
         it 'converts the hash into matrix properties' do
-          file = double(file)
-          File.stub(:new).and_return(file)
           expect(client).to receive(:put).with('libs-release-local;branch=master;user=Seth%20Vargo/remote/path', file, {})
 
-          subject.upload('libs-release-local', file, '/remote/path',
+          subject.upload('libs-release-local', '/remote/path',
             branch: 'master',
             user: 'Seth Vargo',
           )
@@ -77,11 +66,9 @@ module Artifactory
       context 'when custom headers are given' do
         it 'passes the headers to the client' do
           headers = { 'Content-Type' => 'text/plain' }
-          file = double(file)
-          File.stub(:new).and_return(file)
           expect(client).to receive(:put).with('libs-release-local/remote/path', file, headers)
 
-          subject.upload('libs-release-local', file, '/remote/path', {}, headers)
+          subject.upload('libs-release-local', '/remote/path', {}, headers)
         end
       end
     end
@@ -90,7 +77,6 @@ module Artifactory
       it 'delegates to #upload' do
         expect(subject).to receive(:upload).with(
           'libs-release-local',
-          '/local/file',
           '/remote/path',
           { branch: 'master' },
           {
@@ -98,8 +84,7 @@ module Artifactory
             'X-Checksum-Sha1'   => 'ABCD1234',
           },
         )
-        subject.upload_with_checksum('libs-release-local', '/local/file', '/remote/path',
-          'ABCD1234',
+        subject.upload_with_checksum('libs-release-local', '/remote/path', 'ABCD1234',
           { branch: 'master' },
         )
       end
@@ -109,14 +94,11 @@ module Artifactory
       it 'delegates to #upload' do
         expect(subject).to receive(:upload).with(
           'libs-release-local',
-          '/local/file',
           '/remote/path',
           {},
-          {
-            'X-Explode-Archive' => true,
-          },
+          { 'X-Explode-Archive' => true },
         )
-        subject.upload_from_archive('libs-release-local', '/local/file', '/remote/path')
+        subject.upload_from_archive('libs-release-local', '/remote/path')
       end
     end
 
@@ -247,7 +229,7 @@ module Artifactory
       end
 
       it 'returns an empty array when the server responses with a 404' do
-        client.stub(:get).and_raise(Error::HTTPError.new('status' => 404))
+        allow(client).to receive(:get).and_raise(Error::HTTPError.new('status' => 404))
 
         result = described_class.versions
         expect(result).to be_a(Array)
@@ -293,7 +275,7 @@ module Artifactory
       end
 
       it 'returns an nil when the server responses with a 404' do
-        client.stub(:get).and_raise(Error::HTTPError.new('status' => 404))
+        allow(client).to receive(:get).and_raise(Error::HTTPError.new('status' => 404))
 
         expect(described_class.latest_version).to be_nil
       end
@@ -347,7 +329,7 @@ module Artifactory
     describe '#copy' do
       let(:destination) { '/to/here' }
       let(:options)     { Hash.new }
-      before { subject.stub(:copy_or_move) }
+      before { allow(subject).to receive(:copy_or_move) }
 
       it 'delegates to #copy_or_move' do
         expect(subject).to receive(:copy_or_move).with(:copy, destination, options)
@@ -370,7 +352,7 @@ module Artifactory
     describe '#move' do
       let(:destination) { '/to/here' }
       let(:options)     { Hash.new }
-      before { subject.stub(:copy_or_move) }
+      before { allow(subject).to receive(:copy_or_move) }
 
       it 'delegates to #copy_or_move' do
         expect(subject).to receive(:copy_or_move).with(:move, destination, options)

data/spec/unit/resources/backup_spec.rb

@@ -0,0 +1,61 @@
+require 'spec_helper'
+
+module Artifactory
+  describe Resource::Backup do
+    let(:client) { double(:client) }
+
+    before(:each) do
+      allow(Artifactory).to receive(:client).and_return(client)
+      allow(client).to receive(:get).and_return(response) if defined?(response)
+    end
+
+    describe '.all' do
+      doc = <<-XML
+        <config>
+          <backups>
+            <backup>
+              <key>backup-daily</key>
+            </backup>
+          </backups>
+        </config>
+      XML
+      let(:xml) do
+        REXML::Document.new(doc)
+      end
+
+      before do
+        allow(Resource::System).to receive(:configuration).and_return(xml)
+      end
+
+      it 'returns the backup settings' do
+        expect(described_class.all).to be_a(Array)
+        expect(described_class.all.first).to be_a(described_class)
+        expect(described_class.all.first.key).to eq('backup-daily')
+      end
+    end
+
+    describe '.find' do
+      doc = <<-XML
+        <config>
+          <backups>
+            <backup>
+              <key>backup-weekly</key>
+            </backup>
+          </backups>
+        </config>
+      XML
+      let(:xml) do
+        REXML::Document.new(doc)
+      end
+
+      before do
+        allow(Resource::System).to receive(:configuration).and_return(xml)
+      end
+
+      it 'returns the found backup setting' do
+        expect(described_class.find('backup-weekly')).to be_a(described_class)
+        expect(described_class.find('backup-weekly').key).to eq('backup-weekly')
+      end
+    end
+  end
+end

data/spec/unit/resources/base_spec.rb

@@ -36,7 +36,7 @@ module Artifactory
 
       context 'when the :client key is not present' do
         let(:client) { double }
-        before { Artifactory.stub(:client).and_return(client) }
+        before { allow(Artifactory).to receive(:client).and_return(client) }
 
         it 'uses Artifactory.client' do
           expect(described_class.extract_client!({})).to be(client)
@@ -97,7 +97,7 @@ module Artifactory
 
       it 'defaults to the Artifactory.client' do
         client = double
-        Artifactory.stub(:client).and_return(client)
+        allow(Artifactory).to receive(:client).and_return(client)
 
         expect(subject.client).to be(client)
       end
@@ -132,7 +132,7 @@ module Artifactory
 
     describe '#inspect' do
       it 'includes all the attributes' do
-        subject.stub(:attributes) do
+        allow(subject).to receive(:attributes) do
           { foo: 'bar' }
         end
 

data/spec/unit/resources/build_spec.rb

@@ -5,8 +5,8 @@ module Artifactory
     let(:client) { double(:client) }
 
     before(:each) do
-      Artifactory.stub(:client).and_return(client)
-      client.stub(:get).and_return(response) if defined?(response)
+      allow(Artifactory).to receive(:client).and_return(client)
+      allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
     describe '.all' do
@@ -25,7 +25,7 @@ module Artifactory
 
       context 'when the system has no builds' do
         it 'returns an empty array' do
-          client.stub(:get).and_raise(Error::HTTPError.new('status' => 404))
+          allow(client).to receive(:get).and_raise(Error::HTTPError.new('status' => 404))
           expect(described_class.all).to be_empty
         end
       end

data/spec/unit/resources/group_spec.rb

@@ -5,8 +5,8 @@ module Artifactory
     let(:client) { double(:client) }
 
     before(:each) do
-      Artifactory.stub(:client).and_return(client)
-      client.stub(:get).and_return(response) if defined?(response)
+      allow(Artifactory).to receive(:client).and_return(client)
+      allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
     describe '.all' do
@@ -18,9 +18,9 @@ module Artifactory
         ]
       end
       before do
-        described_class.stub(:from_url).with('a', client: client).and_return('a')
-        described_class.stub(:from_url).with('b', client: client).and_return('b')
-        described_class.stub(:from_url).with('c', client: client).and_return('c')
+        allow(described_class).to receive(:from_url).with('a', client: client).and_return('a')
+        allow(described_class).to receive(:from_url).with('b', client: client).and_return('b')
+        allow(described_class).to receive(:from_url).with('c', client: client).and_return('c')
       end
 
       it 'gets /api/security/groups' do
@@ -66,7 +66,7 @@ module Artifactory
         instance = described_class.from_hash(hash)
         expect(instance.name).to eq('readers')
         expect(instance.description).to eq('This list of read-only users')
-        expect(instance.auto_join).to be_true
+        expect(instance.auto_join).to be_truthy
         expect(instance.realm).to eq('artifactory')
         expect(instance.realm_attributes).to be_nil
       end

data/spec/unit/resources/layout_spec.rb

@@ -5,8 +5,8 @@ module Artifactory
     let(:client) { double(:client) }
 
     before(:each) do
-      Artifactory.stub(:client).and_return(client)
-      client.stub(:get).and_return(response) if defined?(response)
+      allow(Artifactory).to receive(:client).and_return(client)
+      allow(client).to receive(:get).and_return(response) if defined?(response)
     end
 
     describe '.all' do
@@ -24,7 +24,7 @@ module Artifactory
       end
 
       before do
-        Resource::System.stub(:configuration).and_return(xml)
+        allow(Resource::System).to receive(:configuration).and_return(xml)
       end
 
       it 'returns the layouts' do
@@ -49,7 +49,7 @@ module Artifactory
       end
 
       before do
-        Resource::System.stub(:configuration).and_return(xml)
+        allow(Resource::System).to receive(:configuration).and_return(xml)
       end
 
       it 'returns the found layout' do