arstotzka 1.3.2 → 1.4.0

data/spec/lib/arstotzka/method_builder_spec.rb

@@ -23,7 +23,7 @@ describe Arstotzka::MethodBuilder do
   let(:attr_names)   { [attr_name] }
   let(:json)         { {} }
   let(:instance)     { klass.new(json) }
-  let(:full_options) { Arstotzka::Options::DEFAULT_OPTIONS.merge(options) }
+  let(:full_options) { Arstotzka::Config::DEFAULT_CONFIGS.merge(options) }
 
   describe '#build' do
     context 'when it is called' do

data/spec/lib/arstotzka/options_spec.rb

@@ -3,7 +3,7 @@
 require 'spec_helper'
 
 describe Arstotzka::Options do
-  subject(:options) { described_class.new(options_hash) }
+  subject(:options) { Arstotzka.config.options(options_hash) }
 
   context 'when initializing without options' do
     let(:options_hash) { {} }

data/spec/lib/arstotzka_spec.rb

@@ -200,4 +200,167 @@ describe Arstotzka do
       expect(value).to eq(json['user']['name'])
     end
   end
+
+  context 'when changing configuration of case after class declaration' do
+    let(:json) { { the_value: 'snake', theValue: 'lower_camel', TheValue: 'upper_camel' } }
+
+    let(:dummy_class) do
+      Class.new(Arstotzka::Dummy) do
+        expose :the_value
+      end
+    end
+
+    after { described_class.reset_config }
+
+    context 'when changing case to snake' do
+      it 'changes the way the value is fetched' do
+        expect { described_class.configure { |c| c.case :snake } }
+          .to change(dummy, :the_value)
+          .from('lower_camel').to('snake')
+      end
+    end
+
+    context 'when changing case to upper_camel' do
+      it 'changes the way the value is fetched' do
+        expect { described_class.configure { |c| c.case :upper_camel } }
+          .to change(dummy, :the_value)
+          .from('lower_camel').to('upper_camel')
+      end
+    end
+
+    context 'when expose was set to cache' do
+      let(:dummy_class) do
+        Class.new(Arstotzka::Dummy) do
+          expose :the_value, cached: true
+        end
+      end
+
+      it 'does not change the way the value is fetched' do
+        expect { described_class.configure { |c| c.case :snake } }
+          .not_to change(dummy, :the_value)
+      end
+    end
+
+    context 'when arstotka was set to cache' do
+      before { described_class.configure { cached true } }
+
+      it 'does not change the way the value is fetched' do
+        expect { described_class.configure { |c| c.case :snake } }
+          .not_to change(dummy, :the_value)
+      end
+    end
+
+    context 'when expose defined the case' do
+      let(:dummy_class) do
+        Class.new(Arstotzka::Dummy) do
+          expose :the_value, case: :upper_camel
+        end
+      end
+
+      it 'does not change the way the value is fetched' do
+        expect { described_class.configure { |c| c.case :snake } }
+          .not_to change(dummy, :the_value)
+      end
+    end
+  end
+
+  context 'when changing configuration of cached after class declaration' do
+    let(:json) { { the_value: 'old value' } }
+
+    let(:dummy_class) do
+      Class.new(Arstotzka::Dummy) do
+        expose :the_value, case: :snake
+      end
+    end
+
+    after { described_class.reset_config }
+
+    context 'when cached is defined as true after in the config' do
+      context 'when first method call is after value change' do
+        let(:block) do
+          proc do
+            described_class.configure { cached true }
+            json[:the_value] = :symbol
+          end
+        end
+
+        it 'caches after cache change' do
+          expect(&block).to change(dummy, :the_value)
+            .from('old value').to(:symbol)
+        end
+      end
+
+      context 'when first method call is before value change' do
+        let(:block) do
+          proc do
+            described_class.configure { cached true }
+            dummy.the_value
+            json[:the_value] = :symbol
+          end
+        end
+
+        it 'caches the original value' do
+          expect(&block).not_to change(dummy, :the_value)
+        end
+      end
+    end
+
+    context 'when cached is defined as false after in the config' do
+      before { described_class.configure { cached true } }
+
+      let(:block) do
+        proc do
+          described_class.configure { cached false }
+          json[:the_value] = :symbol
+        end
+      end
+
+      it 'changes value' do
+        expect(&block).to change(dummy, :the_value)
+          .from('old value').to(:symbol)
+      end
+    end
+
+    context 'when cached was defined in expose' do
+      context 'when cached was set as true' do
+        let(:dummy_class) do
+          Class.new(Arstotzka::Dummy) do
+            expose :the_value, case: :snake, cached: true
+          end
+        end
+
+        let(:block) do
+          proc do
+            described_class.configure { cached false }
+            json[:the_value] = :symbol
+          end
+        end
+
+        it 'does not change cached state' do
+          expect(&block).not_to change(dummy, :the_value)
+        end
+      end
+
+      context 'when cached was set as false' do
+        let(:dummy_class) do
+          Class.new(Arstotzka::Dummy) do
+            expose :the_value, case: :snake, cached: false
+          end
+        end
+
+        let(:block) do
+          proc do
+            described_class.configure { cached true }
+            dummy.the_value
+            json[:the_value] = :symbol
+          end
+        end
+
+        it 'does not change cached state' do
+          expect(&block).to change(dummy, :the_value)
+            .from('old value').to(:symbol)
+        end
+      end
+    end
+  end
 end

data/spec/spec_helper.rb

@@ -2,7 +2,7 @@
 
 require 'simplecov'
 SimpleCov.start do
-  add_filter 'spec/support/models/'
+  add_filter 'spec/'
 end
 
 require 'pry-nav'

data/spec/support/models/restaurant.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+class Restaurant
+  include Arstotzka
+
+  expose :dishes, path: 'restaurant.complete_meals'
+
+  def initialize(hash)
+    @hash = hash
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arstotzka
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.4.0
 platform: ruby
 authors:
 - Darthjee
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-07 00:00:00.000000000 Z
+date: 2019-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.4.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.2.1
+        version: 1.4.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -220,9 +220,11 @@ files:
 - lib/arstotzka.rb
 - lib/arstotzka/base.rb
 - lib/arstotzka/class_methods.rb
+- lib/arstotzka/config.rb
 - lib/arstotzka/crawler.rb
 - lib/arstotzka/exception.rb
 - lib/arstotzka/fetcher.rb
+- lib/arstotzka/fetcher/cache.rb
 - lib/arstotzka/fetcher_builder.rb
 - lib/arstotzka/hash_reader.rb
 - lib/arstotzka/key_reader.rb
@@ -239,10 +241,13 @@ files:
 - spec/fixtures/arstotzka.json
 - spec/fixtures/complete_person.json
 - spec/fixtures/person.json
+- spec/integration/readme/arstotzka/config_spec.rb
 - spec/integration/readme/arstotzka_spec.rb
 - spec/integration/readme/my_parser_spec.rb
 - spec/integration/yard/arstotzka/class_methods_spec.rb
+- spec/integration/yard/arstotzka/config_spec.rb
 - spec/integration/yard/arstotzka/crawler_spec.rb
+- spec/integration/yard/arstotzka/fetcher/cache_spec.rb
 - spec/integration/yard/arstotzka/fetcher_builder_spec.rb
 - spec/integration/yard/arstotzka/fetcher_spec.rb
 - spec/integration/yard/arstotzka/hash_reader_spec.rb
@@ -253,7 +258,9 @@ files:
 - spec/integration/yard/arstotzka/type_cast_spec.rb
 - spec/integration/yard/arstotzka/wrapper_spec.rb
 - spec/integration/yard/arstotzka_spec.rb
+- spec/lib/arstotzka/config_spec.rb
 - spec/lib/arstotzka/crawler_spec.rb
+- spec/lib/arstotzka/fetcher/cache_spec.rb
 - spec/lib/arstotzka/fetcher_builder_spec.rb
 - spec/lib/arstotzka/fetcher_spec.rb
 - spec/lib/arstotzka/hash_reader_spec.rb
@@ -290,6 +297,7 @@ files:
 - spec/support/models/my_parser.rb
 - spec/support/models/person.rb
 - spec/support/models/request.rb
+- spec/support/models/restaurant.rb
 - spec/support/models/shopping_mall.rb
 - spec/support/models/star.rb
 - spec/support/models/star_gazer.rb
@@ -326,10 +334,13 @@ test_files:
 - spec/fixtures/arstotzka.json
 - spec/fixtures/complete_person.json
 - spec/fixtures/person.json
+- spec/integration/readme/arstotzka/config_spec.rb
 - spec/integration/readme/arstotzka_spec.rb
 - spec/integration/readme/my_parser_spec.rb
 - spec/integration/yard/arstotzka/class_methods_spec.rb
+- spec/integration/yard/arstotzka/config_spec.rb
 - spec/integration/yard/arstotzka/crawler_spec.rb
+- spec/integration/yard/arstotzka/fetcher/cache_spec.rb
 - spec/integration/yard/arstotzka/fetcher_builder_spec.rb
 - spec/integration/yard/arstotzka/fetcher_spec.rb
 - spec/integration/yard/arstotzka/hash_reader_spec.rb
@@ -340,7 +351,9 @@ test_files:
 - spec/integration/yard/arstotzka/type_cast_spec.rb
 - spec/integration/yard/arstotzka/wrapper_spec.rb
 - spec/integration/yard/arstotzka_spec.rb
+- spec/lib/arstotzka/config_spec.rb
 - spec/lib/arstotzka/crawler_spec.rb
+- spec/lib/arstotzka/fetcher/cache_spec.rb
 - spec/lib/arstotzka/fetcher_builder_spec.rb
 - spec/lib/arstotzka/fetcher_spec.rb
 - spec/lib/arstotzka/hash_reader_spec.rb
@@ -377,6 +390,7 @@ test_files:
 - spec/support/models/my_parser.rb
 - spec/support/models/person.rb
 - spec/support/models/request.rb
+- spec/support/models/restaurant.rb
 - spec/support/models/shopping_mall.rb
 - spec/support/models/star.rb
 - spec/support/models/star_gazer.rb