arstotzka 1.0.1 → 1.0.2

data/spec/lib/arstotzka/fetcher_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Arstotzka::Fetcher do
@@ -41,7 +43,7 @@ describe Arstotzka::Fetcher do
   end
 
   describe 'flatten options' do
-    let(:json) { [[[1,2],[3,4]],[[5,6],[7,8]]] }
+    let(:json) { [[[1, 2], [3, 4]], [[5, 6], [7, 8]]] }
 
     context 'when flatten option is true' do
       let(:options) { { flatten: true } }
@@ -70,7 +72,7 @@ describe Arstotzka::Fetcher do
 
   describe 'after option' do
     let(:instance) { MyParser.new(json) }
-    let(:json) { [ 100, 250, -25] }
+    let(:json) { [100, 250, -25] }
     let(:options) { { after: :sum } }
 
     it 'applies after call ' do

data/spec/lib/arstotzka/reader_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 shared_examples 'reader fetchin value' do
@@ -25,10 +27,10 @@ describe Arstotzka::Reader do
     described_class.new(path: path, case_type: case_type)
   end
 
-  let(:path) { %w(user full_name) }
+  let(:path) { %w[user full_name] }
   let(:json_file) { 'complete_person.json' }
   let(:full_json) { load_json_fixture_file(json_file) }
-  let(:json) { full_json  }
+  let(:json) { full_json }
   let(:sym_json) { json.symbolize_keys }
   let(:case_type) { :snake }
   let(:index) { 0 }
@@ -44,7 +46,7 @@ describe Arstotzka::Reader do
         let(:index) { 1 }
 
         context 'to snake_case' do
-          let(:path) { %w(user FullName) }
+          let(:path) { %w[user FullName] }
           let(:expected) { json['full_name'] }
 
           it_behaves_like 'reader fetchin value'
@@ -52,7 +54,7 @@ describe Arstotzka::Reader do
 
         context 'to upper_camel' do
           let(:case_type) { :upper_camel }
-          let(:path) { %w(user login_name) }
+          let(:path) { %w[user login_name] }
           let(:expected) { json['LoginName'] }
 
           it_behaves_like 'reader fetchin value'
@@ -60,7 +62,7 @@ describe Arstotzka::Reader do
 
         context 'to lower_camel' do
           let(:case_type) { :lower_camel }
-          let(:path) { %w(user birth_date) }
+          let(:path) { %w[user birth_date] }
           let(:expected) { json['birthDate'] }
 
           it_behaves_like 'reader fetchin value'
@@ -70,7 +72,7 @@ describe Arstotzka::Reader do
       context 'when key is found but value is null' do
         let(:json) { full_json['user'] }
         let(:index) { 1 }
-        let(:path) { %w(user password_reminder) }
+        let(:path) { %w[user password_reminder] }
 
         it do
           expect(subject.read(json, index)).to be_nil
@@ -84,7 +86,7 @@ describe Arstotzka::Reader do
       end
 
       context 'when json has both string and symble' do
-        let(:path) { %w(key) }
+        let(:path) { %w[key] }
         let(:json) { { key: 'symbol', 'key' => 'string' } }
 
         it 'fetches the string key first' do
@@ -94,7 +96,7 @@ describe Arstotzka::Reader do
     end
 
     context 'when the key is missing' do
-      let(:path) { %w(age) }
+      let(:path) { %w[age] }
 
       it do
         expect do
@@ -104,17 +106,17 @@ describe Arstotzka::Reader do
     end
   end
 
-  describe 'is_ended?' do
+  describe 'ended?' do
     context 'when index is within path' do
       let(:index) { 1 }
 
-      it { expect(subject.is_ended?(index)).to be_falsey }
+      it { expect(subject.ended?(index)).to be_falsey }
     end
 
     context 'when index is outside path' do
       let(:index) { 2 }
 
-      it { expect(subject.is_ended?(index)).to be_truthy }
+      it { expect(subject.ended?(index)).to be_truthy }
     end
   end
 end

data/spec/lib/arstotzka/wrapper_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Arstotzka::Wrapper do
@@ -79,20 +81,18 @@ describe Arstotzka::Wrapper do
       context 'with blank value' do
         let(:value) { '' }
 
-        it_behaves_like 'a result that is type cast', {
-          integer: NilClass,
-          float: NilClass,
-          string: String
-        }
+        it_behaves_like 'a result that is type cast',
+                        integer: NilClass,
+                        float: NilClass,
+                        string: String
 
         context 'when passing clazz parameter' do
           let(:options) { { type: type, clazz: Arstotzka::Wrapper::Dummy } }
 
-          it_behaves_like 'a result that is type cast', {
-            integer: NilClass,
-            float: NilClass,
-            string: Arstotzka::Wrapper::Dummy
-          }
+          it_behaves_like 'a result that is type cast',
+                          integer: NilClass,
+                          float: NilClass,
+                          string: Arstotzka::Wrapper::Dummy
         end
       end
 

data/spec/lib/arstotzka_spec.rb

@@ -1,9 +1,12 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 describe Arstotzka do
-  let(:dummy) { Arstotzka::Dummy.new(json) }
-  let(:json) { load_json_fixture_file('arstotzka.json') }
-  let(:value) { dummy.public_send(attribute) }
+  let(:dummy_class) { Arstotzka::Dummy }
+  let(:dummy)       { dummy_class.new(json) }
+  let(:json)        { load_json_fixture_file('arstotzka.json') }
+  let(:value)       { dummy.public_send(attribute) }
 
   context 'when parser is configured with no options' do
     let(:attribute) { :id }
@@ -115,12 +118,13 @@ describe Arstotzka do
   end
 
   context 'when casting the result' do
-    class Arstotzka::Dummy
-      expose :float_value, type: :float
-    end
-
-    let(:json) { { floatValue: '1' } }
+    let(:json)      { { floatValue: '1' } }
     let(:attribute) { :float_value }
+    let(:dummy_class) do
+      Class.new(Arstotzka::Dummy) do
+        expose :float_value, type: :float
+      end
+    end
 
     it do
       expect(value).to be_a(Float)

data/spec/spec_helper.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'simplecov'
 SimpleCov.start do
   add_filter 'spec/support/models/'
@@ -7,8 +9,8 @@ require 'pry-nav'
 require 'arstotzka'
 require 'safe_attribute_assignment'
 
-support_files = File.expand_path("spec/support/**/*.rb")
-Dir[support_files].sort.each { |file| require file  }
+support_files = File.expand_path('spec/support/**/*.rb')
+Dir[support_files].sort.each { |file| require file }
 
 RSpec.configure do |config|
   config.treat_symbols_as_metadata_keys_with_true_values = true
@@ -16,6 +18,8 @@ RSpec.configure do |config|
   config.filter_run :focus
   config.filter_run_excluding :integration unless ENV['ALL']
 
+  config.include Sinclair::Matchers
+
   config.order = 'random'
 
   config.before do

data/spec/support/fixture_helpers.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 require 'active_support'
 
 module FixtureHelpers
   def load_fixture_file(filename)
-      File.read (['./spec/', 'fixtures', filename].join('/'))
+    File.read(['./spec/', 'fixtures', filename].join('/'))
   end
 
   def load_json_fixture_file(filename)
@@ -12,7 +14,7 @@ module FixtureHelpers
   private
 
   def cached_json_fixture_file(filename)
-      ActiveSupport::JSON.decode(load_fixture_file(filename))
+    ActiveSupport::JSON.decode(load_fixture_file(filename))
   end
 end
 

data/spec/support/models.rb

@@ -1,5 +1,6 @@
-models = File.expand_path("spec/support/models/*.rb")
+# frozen_string_literal: true
+
+models = File.expand_path('spec/support/models/*.rb')
 Dir[models].sort.each do |file|
-  autoload file.gsub(/.*\/(.*)\..*/, '\1').camelize.to_sym, file
+  autoload file.gsub(%r{.*\/(.*)\..*}, '\1').camelize.to_sym, file
 end
-

data/spec/support/models/account.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class Account
+  private
+
+  def filter_income(transactions)
+    transactions.select(&:positive?)
+  end
+end

data/spec/support/models/arstotzka/dummy.rb

@@ -1,23 +1,27 @@
-class Arstotzka::Dummy
-  include Arstotzka
-  attr_reader :json
+# frozen_string_literal: true
 
-  expose :id
-  expose :name, path: 'user'
-  expose :father_name, full_path: 'father.name'
-  expose :age, cached: true
-  expose :house, class: ::House
-  expose :old_house, class: ::House, cached: true
-  expose :games, class: ::Game
-  expose :games_filtered, class: ::Game, after: :filter_games, full_path: 'games'
+module Arstotzka
+  class Dummy
+    include Arstotzka
+    attr_reader :json
 
-  def initialize(json)
-    @json = json
-  end
+    expose :id
+    expose :name, path: 'user'
+    expose :father_name, full_path: 'father.name'
+    expose :age, cached: true
+    expose :house, class: ::House
+    expose :old_house, class: ::House, cached: true
+    expose :games, class: ::Game
+    expose :games_filtered, class: ::Game, after: :filter_games, full_path: 'games'
+
+    def initialize(json)
+      @json = json
+    end
 
-  def filter_games(games)
-    games.select do |g|
-      g.publisher != 'sega'
+    def filter_games(games)
+      games.reject do |g|
+        g.publisher == 'sega'
+      end
     end
   end
 end

data/spec/support/models/arstotzka/fetcher/dummy.rb

@@ -1,3 +1,8 @@
-class Arstotzka::Fetcher::Dummy
-end
+# frozen_string_literal: true
 
+module Arstotzka
+  class Fetcher
+    class Dummy
+    end
+  end
+end

data/spec/support/models/arstotzka/type_cast.rb

@@ -1,6 +1,9 @@
-module Arstotzka::TypeCast
-  def to_money_float(value)
-    value.gsub(/\$ */, '').to_f
+# frozen_string_literal: true
+
+module Arstotzka
+  module TypeCast
+    def to_money_float(value)
+      value.gsub(/\$ */, '').to_f
+    end
   end
 end
-

data/spec/support/models/arstotzka/wrapper/dummy.rb

@@ -1,7 +1,12 @@
-class Arstotzka::Wrapper::Dummy
-  attr_reader :value
-  def initialize(value)
-    @value = value
+# frozen_string_literal: true
+
+module Arstotzka
+  class Wrapper
+    class Dummy
+      attr_reader :value
+      def initialize(value)
+        @value = value
+      end
+    end
   end
 end
-

data/spec/support/models/game.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Game
   include Arstotzka
   include SafeAttributeAssignment

data/spec/support/models/house.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class House
   include Arstotzka
   include ::SafeAttributeAssignment

data/spec/support/models/my_model.rb

@@ -0,0 +1,9 @@
+# frozen_string_literal: true
+
+class MyModel
+  attr_reader :json
+
+  def initialize(json)
+    @json = json
+  end
+end

data/spec/support/models/my_parser.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class MyParser
   include Arstotzka
 
@@ -6,7 +8,7 @@ class MyParser
   expose :total_money, full_path: 'accounts.balance', after: :sum,
                        cached: true, type: :money_float
   expose :total_owed, full_path: 'loans.value', after: :sum,
-                       cached: true, type: :money_float
+                      cached: true, type: :money_float
 
   attr_reader :json
 
@@ -17,12 +19,11 @@ class MyParser
   private
 
   def sum(balances)
-    balances.sum if balances
+    balances&.sum
   end
 
-  models = File.expand_path("spec/support/models/my_parser/*.rb")
+  models = File.expand_path('spec/support/models/my_parser/*.rb')
   Dir[models].each do |file|
-    autoload file.gsub(/.*\/(.*)\..*/, '\1').camelize.to_sym, file
+    autoload file.gsub(%r{.*\/(.*)\..*}, '\1').camelize.to_sym, file
   end
 end
-

data/spec/support/models/person.rb

@@ -1,8 +1,14 @@
+# frozen_string_literal: true
+
 class Person
   attr_reader :name
 
   def initialize(name)
     @name = name
   end
-end
 
+  def ==(other)
+    return false unless other.class == self.class
+    other.name == name
+  end
+end

data/spec/support/models/star.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 class Star
   attr_reader :name
 

data/spec/support/models/star_gazer.rb

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 class StarGazer
   include Arstotzka
 
   expose :favorite_star, full_path: 'universe.star',
-         default: { name: 'Sun' }, class: ::Star
+                         default: { name: 'Sun' }, class: ::Star
 
   attr_reader :json
 
@@ -10,4 +12,3 @@ class StarGazer
     @json = json
   end
 end
-

data/spec/support/models/transaction.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class Transaction
+  attr_reader :value, :type
+
+  def initialize(value:, type:)
+    @value = value
+    @type = type
+  end
+
+  def positive?
+    type == 'income'
+  end
+
+  def ==(other)
+    return false unless other.class == self.class
+    other.value == value && other.type == type
+  end
+end