arsi 0.4.0 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: efe5a87bd8303daf7685c2d9e753b30ecdd8efa25f721b68cc5fea2ce1f9e96b
-  data.tar.gz: e631bb40979d5791707bda82e29db2bf7b225c3f1424addd69131ae9b0d23753
+  metadata.gz: aea5ecd2b64166843083b97523f85c66b2c07246d291b2b44f6d4ed814ec6a42
+  data.tar.gz: 7810f158d8850861dfa9eafa974decf092b537503e82850269abbe67b7f415fc
 SHA512:
-  metadata.gz: 75ab18df3d1ee8bc3e04dd51a69fa29e42a7904b8d6bb892341046ca98bc9f86217438ed80fb6d2e7721993a0e132ee601fa3b684e8a35babcb8ebaa9b616c27
-  data.tar.gz: 79660da433f0d3110f05026156634132e6fa295a9f6e8155feec43e7ca8186811d3f2b023ce3ee7dccf024a7a20c083289f3e9b28b6d506453bb7ea1021c73fe
+  metadata.gz: f16b52a751b60ed9d6fe42f8dfe1989bc52b6e48e791c541d6dbfab83d969579507a062e82aa01789e992dd883869dc77c112e9e3f6553c7fd80da56a159eeef
+  data.tar.gz: 6b4f455f599f1ce7e68d5518efb85d6b23bfdd800ab58fbab807573a288f78196ba340016926b4aeab2971e66a88cd2f5c79062b9f58907aaf6f956d3371adc6

data/README.md

@@ -1,6 +1,4 @@
-# ARSI - ActiveRecord SQL Inspector
-
-[![Build Status](https://travis-ci.org/zendesk/arsi.svg?branch=master)](https://travis-ci.org/zendesk/arsi)
+# ARSI - ActiveRecord SQL Inspector [![CI](https://github.com/zendesk/arsi/actions/workflows/actions.yml/badge.svg)](https://github.com/zendesk/arsi/actions/workflows/actions.yml)
 
 Block sql statements that are not scoped by id in `.update_all` and `.delete_all`.
 

data/lib/arsi/arel_tree_manager.rb

@@ -4,23 +4,11 @@ module Arsi
   module ArelTreeManager
     # This is from Arel::SelectManager which inherits from Arel::TreeManager.
     # We need where_sql on both Arel::UpdateManager and Arel::DeleteManager so we add it to the parent class.
-    if ::Arel::VERSION[0].to_i >= 6
-      def where_sql(engine = Arel::Table.engine)
-        return if @ctx.wheres.empty?
+    def where_sql(engine = ::Arel::Table.engine)
+      return if @ctx.wheres.empty?
 
-        viz = if ::Arel::VERSION[0].to_i > 6
-          ::Arel::Visitors::WhereSql.new(engine.connection.visitor, engine.connection)
-        else
-          ::Arel::Visitors::WhereSql.new engine.connection
-        end
-        ::Arel::Nodes::SqlLiteral.new viz.accept(@ctx, ::Arel::Collectors::SQLString.new).value
-      end
-    else
-      def where_sql
-        return if @ctx.wheres.empty?
-        viz = ::Arel::Visitors::WhereSql.new @engine.connection
-        ::Arel::Nodes::SqlLiteral.new viz.accept @ctx
-      end
+      viz = ::Arel::Visitors::WhereSql.new(engine.connection.visitor, engine.connection)
+      ::Arel::Nodes::SqlLiteral.new viz.accept(@ctx, ::Arel::Collectors::SQLString.new).value
     end
   end
 end

data/lib/arsi/relation.rb

@@ -1,6 +1,6 @@
 module Arsi
   module Relation
-    attr_accessor :without_arsi
+    attr_writer  :without_arsi
 
     def without_arsi
       if block_given?
@@ -14,26 +14,26 @@ module Arsi
     end
 
     def without_arsi?
-      @without_arsi || !arsi_scopeable?
+      return @without_arsi if defined?(@without_arsi) && @without_arsi
+      !arsi_scopeable?
+    end
+
+    def _update_record(*)
+      with_relation_in_connection { super }
     end
 
     def delete_all(*)
       with_relation_in_connection { super }
     end
 
-    def self.prepended(base)
-      base.class_eval do
-        alias_method :update_all_without_arsi, :update_all
-        def update_all(*args)
-          with_relation_in_connection { update_all_without_arsi(*args) }
-        end
-      end
+    def update_all(*)
+      with_relation_in_connection { super }
     end
 
     private
 
     def arsi_scopeable?
-      @klass.columns.any? { |c| c.name =~ Arsi::SCOPEABLE_REGEX }
+      @klass.columns.any? { |c| Arsi::SCOPEABLE_REGEX.match?(c.name) }
     end
 
     def with_relation_in_connection

data/lib/arsi/version.rb

@@ -1,3 +1,3 @@
 module Arsi
-  VERSION = '0.4.0'
+  VERSION = '1.0.0'
 end

data/lib/arsi.rb

@@ -6,9 +6,9 @@ require 'active_record/connection_adapters/mysql2_adapter'
 
 module Arsi
   class UnscopedSQL < StandardError; end
-  Arel::TreeManager.send(:include, ArelTreeManager)
-  ActiveRecord::ConnectionAdapters::Mysql2Adapter.send(:prepend, Mysql2Adapter)
-  ActiveRecord::Relation.send(:prepend, Relation)
+  Arel::TreeManager.include(ArelTreeManager)
+  ActiveRecord::ConnectionAdapters::Mysql2Adapter.prepend(Mysql2Adapter)
+  ActiveRecord::Relation.prepend(Relation)
   ActiveRecord::Querying.delegate(:without_arsi, :to => :relation)
 
   @enabled = true
@@ -21,16 +21,15 @@ module Arsi
   end
 
   class << self
+    attr_reader :enabled
     attr_accessor :violation_callback
 
-    def sql_check!(sql, relation)
-      return if !@enabled || relation.try(:without_arsi?)
-      return if sql =~ SQL_MATCHER
-      report_violation(sql, relation)
-    end
-
     def arel_check!(arel, relation)
-      sql = arel.respond_to?(:ast) ? arel.where_sql : arel.to_s
+      return unless @enabled
+      return if relation && relation.without_arsi?
+
+      # ::Arel::TreeManager, String, nil or ... ?
+      sql = arel.respond_to?(:where_sql) ? arel_where_sql(arel, relation) : arel.to_s
       sql_check!(sql, relation)
     end
 
@@ -52,6 +51,18 @@ module Arsi
 
     private
 
+    def arel_where_sql(arel, relation)
+      return arel.where_sql if relation.nil?
+      return arel.where_sql unless relation.model.respond_to?(:arel_engine)
+
+      arel.where_sql(relation.model.arel_engine)
+    end
+
+    def sql_check!(sql, relation)
+      return if SQL_MATCHER.match?(sql)
+      report_violation(sql, relation)
+    end
+
     def run_with_arsi(with_arsi)
       previous, @enabled = @enabled, with_arsi
       yield

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arsi
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 1.0.0
 platform: ruby
 authors:
 - Christopher Kintner
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-12-19 00:00:00.000000000 Z
+date: 2022-03-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: arel
@@ -44,7 +44,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '6.0'
@@ -54,7 +54,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 5.0.0
     - - "<"
       - !ruby/object:Gem::Version
         version: '6.0'
@@ -72,20 +72,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: bundler
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -101,21 +87,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: minitest
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: minitest-rg
+  name: maxitest
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -143,21 +115,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: wwtd
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: byebug
+  name: single_cov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -187,7 +145,7 @@ homepage: https://github.com/zendesk/arsi
 licenses:
 - Apache License Version 2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -195,15 +153,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.4
-signing_key: 
+rubygems_version: 3.3.5
+signing_key:
 specification_version: 4
 summary: ActiveRecord SQL Inspector
 test_files: []