arrthorizer 0.3.1 → 0.3.2

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 99020b8a7d6734b6d583dde7782bf0d5b4a795e1
+  data.tar.gz: 0d287e10df0682a16ab56f937c566971abf11a14
+SHA512:
+  metadata.gz: a83bddadd007007cdd31313d26330c3f97fd663e1ea42fe460e39f9dba86820cfab2dc9138a6093cbeb165559f6aba1c6bf4ed193c4a00b854f2bcf5f61ed5d6
+  data.tar.gz: eb0daf7155fc4acb728ae2cfce174fbd84b88e4f34c53d17f15cd3d636e25110852864cc803ec32c3f1542a8a1fd5451d4bb62fbcf52c1292d895df3dde6029d

data/arrthorizer.gemspec

@@ -20,5 +20,5 @@ Gem::Specification.new do |gem|
   gem.add_dependency             'rails', '>= 3.2.18'
   gem.add_development_dependency 'combustion', '~> 0.5.1'
   gem.add_development_dependency 'sqlite3'
-  gem.add_development_dependency 'rspec-rails'
+  gem.add_development_dependency 'rspec-rails', '>= 3'
 end

data/lib/arrthorizer/rails/controller_concern.rb

@@ -28,8 +28,10 @@ module Arrthorizer
         def arrthorizer_check_role(role, context)
           begin
             role.applies_to_user?(arrthorizer_scope, context)
-          rescue StandardError
-            ::Rails.logger.warn("Error occurred while evaluating #{role} for #{current_user}.")
+          rescue StandardError => error
+            ::Rails.logger.warn("A(n) #{error.class.name} occurred while evaluating #{role} for #{current_user}.")
+            ::Rails.logger.debug(error.message)
+            ::Rails.logger.debug(error.backtrace.join("\n"))
             return false
           end
         end

data/lib/arrthorizer/rspec.rb

@@ -7,9 +7,9 @@ module Arrthorizer
   end
 
   role_spec = {
-      type: :role,
-      example_group: { file_path: %r(spec/roles) }
-    }
+    type: :role,
+    file_path: %r(spec/roles)
+  }
 
   ::RSpec.configure do |config|
     config.include Arrthorizer::RSpec::Matchers::Roles, role_spec

data/lib/arrthorizer/version.rb

@@ -1,3 +1,3 @@
 module Arrthorizer
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/spec/context_spec.rb

@@ -20,7 +20,7 @@ describe Arrthorizer do
 
     context "when an object responding to #to_hash is provided" do
       before :each do
-        arg.stub(:to_hash).and_return({ key => value })
+        allow(arg).to receive(:to_hash).and_return({ key => value })
       end
 
       it "returns an Arrthorizer::Context" do

data/spec/integration/some_controller_spec.rb

@@ -4,12 +4,12 @@ describe SomeController do
   let(:action) { Arrthorizer::Rails::ControllerAction.fetch("some#some_action") }
   let(:other_action) { Arrthorizer::Rails::ControllerAction.fetch("some#other_action") }
 
-  describe :some_action, type: :controller do
+  describe 'some_action', type: :controller do
     let!(:privilege) { action.privilege }
     let!(:current_user) { double("user") }
 
     before do
-      controller.stub(:current_user) { current_user }
+      allow(controller).to receive(:current_user) { current_user }
     end
 
     describe "group roles" do
@@ -124,7 +124,7 @@ describe SomeController do
   private
   def configure_context_role(&block)
     UnnamespacedContextRole.instance.tap do |role|
-      role.stub(:applies_to_user?, &block)
+      allow(role).to receive(:applies_to_user?, &block)
     end
   end
 
@@ -141,6 +141,6 @@ describe SomeController do
   end
 
   def stub_membership_with(user, group, &block)
-    Arrthorizer.membership_service.stub(:is_member_of?).with(user, group, &block)
+    allow(Arrthorizer.membership_service).to receive(:is_member_of?).with(user, group, &block)
   end
 end

data/spec/privilege/accessible_to_spec.rb

@@ -16,7 +16,7 @@ describe Arrthorizer::Privilege do
         let(:arg) { role }
 
         it "returns true" do
-          expect(privilege.accessible_to?(arg)).to be_true
+          expect(privilege.accessible_to?(arg)).to be true
         end
       end
 
@@ -24,7 +24,7 @@ describe Arrthorizer::Privilege do
         let(:arg) { role.name }
 
         it "returns true" do
-          expect(privilege.accessible_to?(arg)).to be_true
+          expect(privilege.accessible_to?(arg)).to be true
         end
       end
     end

data/spec/privilege/make_accessible_to_spec.rb

@@ -16,7 +16,7 @@ describe Arrthorizer::Privilege do
 
       expect {
         privilege.make_accessible_to(role)
-      }.not_to change { privilege.accessible_to?(unrelated_role) }.to(true)
+      }.not_to change { privilege.accessible_to?(unrelated_role) }
     end
   end
 end

data/spec/rails/controller_action/get_current_spec.rb

@@ -5,7 +5,7 @@ describe Arrthorizer::Rails::ControllerAction do
     let(:controller) { double('controller') }
 
     before :each do
-      Arrthorizer::Rails::ControllerAction.stub(:key_for).with(controller).and_return("controller#action")
+      allow(Arrthorizer::Rails::ControllerAction).to receive(:key_for).with(controller).and_return("controller#action")
     end
 
     context "when there is no configuration for the current action" do

data/spec/rails/controller_concern/arrthorizer_context_spec.rb

@@ -11,7 +11,7 @@ describe Arrthorizer::Rails::ControllerConcern do
       end
     end
 
-    controller.stub(:request).and_return(ActionDispatch::TestRequest.new)
+    allow(controller).to receive(:request).and_return(ActionDispatch::TestRequest.new)
   end
 
   describe :arrthorizer_context do

data/spec/rails/controller_concern/authorize_spec.rb

@@ -11,10 +11,10 @@ describe Arrthorizer::Rails::ControllerConcern do
   let(:context){ double("context") }
 
   before do
-    controller.stub(:action_name).and_return(action_name)
-    controller.stub(:current_user).and_return(current_user)
-    controller.stub(:arrthorizer_context).and_return(context)
-    controller.stub(:controller_path).and_return(controller_path)
+    allow(controller).to receive(:action_name).and_return(action_name)
+    allow(controller).to receive(:current_user).and_return(current_user)
+    allow(controller).to receive(:arrthorizer_context).and_return(context)
+    allow(controller).to receive(:controller_path).and_return(controller_path)
   end
 
   describe :authorize do
@@ -31,8 +31,8 @@ describe Arrthorizer::Rails::ControllerConcern do
       let(:permitted_roles){ Arrthorizer::Registry.new }
 
       before do
-        controller_action.stub(:privilege).and_return(privilege)
-        privilege.stub(:permitted_roles).and_return(permitted_roles)
+        allow(controller_action).to receive(:privilege).and_return(privilege)
+        allow(privilege).to receive(:permitted_roles).and_return(permitted_roles)
       end
 
       context "but the privilege has no permitted roles" do
@@ -47,7 +47,7 @@ describe Arrthorizer::Rails::ControllerConcern do
         let(:role){ Arrthorizer::Role.new }
 
         before do
-          role.stub(:name).and_return('some_role')
+          allow(role).to receive(:name).and_return('some_role')
           permitted_roles.add(role)
         end
 
@@ -55,9 +55,9 @@ describe Arrthorizer::Rails::ControllerConcern do
           let(:error) { Class.new(StandardError).new }
 
           before :each do
-            controller.stub(:arrthorizer_context).and_raise(error)
+            allow(controller).to receive(:arrthorizer_context).and_raise(error)
             # for testing purposes. We're testing a filter here, so no request exists, causing #status= to fail
-            controller.stub(:forbidden)
+            allow(controller).to receive(:forbidden)
           end
 
           specify "that error not suppressed" do
@@ -69,7 +69,7 @@ describe Arrthorizer::Rails::ControllerConcern do
 
         context "and the role applies to the user" do
           before do
-            role.stub(:applies_to_user?).with(current_user, context).and_return(true)
+            allow(role).to receive(:applies_to_user?).with(current_user, context).and_return(true)
           end
 
           it "is not forbidden" do
@@ -81,7 +81,7 @@ describe Arrthorizer::Rails::ControllerConcern do
 
         context "and the role does not apply to the user" do
           before do
-            role.stub(:applies_to_user?).with(current_user, context).and_return(false)
+            allow(role).to receive(:applies_to_user?).with(current_user, context).and_return(false)
           end
 
           it "is forbidden" do
@@ -94,13 +94,13 @@ describe Arrthorizer::Rails::ControllerConcern do
             let(:another_role){ Arrthorizer::Role.new }
 
             before do
-              another_role.stub(:name).and_return('another_role')
+              allow(another_role).to receive(:name).and_return('another_role')
               permitted_roles.add(another_role)
             end
 
             context "and the role applies to the user" do
               before do
-                another_role.stub(:applies_to_user?).with(current_user, context).and_return(true)
+                allow(another_role).to receive(:applies_to_user?).with(current_user, context).and_return(true)
               end
 
               it "is not forbidden" do
@@ -112,7 +112,7 @@ describe Arrthorizer::Rails::ControllerConcern do
 
             context "and the role does not apply to the user" do
               before do
-                another_role.stub(:applies_to_user?).with(current_user, context).and_return(false)
+                allow(another_role).to receive(:applies_to_user?).with(current_user, context).and_return(false)
               end
 
               it "is forbidden" do
@@ -126,12 +126,12 @@ describe Arrthorizer::Rails::ControllerConcern do
 
         context "but evaluating the role raises any kind of StandardError" do
           before do
-            role.stub(:applies_to_user?).with(current_user, context).and_raise("Some exception")
+            allow(role).to receive(:applies_to_user?).with(current_user, context).and_raise("Some exception")
           end
 
           specify "a warning is logged" do
             # for testing purposes. We're testing a filter here, so no request exists, causing #status= to fail
-            controller.stub(:forbidden)
+            allow(controller).to receive(:forbidden)
 
             expect(::Rails.logger).to receive(:warn).with(an_instance_of(String))
 
@@ -142,7 +142,7 @@ describe Arrthorizer::Rails::ControllerConcern do
             let(:another_role){ Arrthorizer::Group.new("some other role") }
 
             before :each do
-              another_role.stub(:applies_to_user?).and_return(true)
+              allow(another_role).to receive(:applies_to_user?).and_return(true)
               permitted_roles.add(another_role)
             end
 

data/spec/rails/controller_concern/integration_spec.rb

@@ -30,9 +30,9 @@ describe Arrthorizer::Rails do
         let(:current_action) { 'some_action' }
 
         before :each do
-          controller.stub(:params).and_return injected_params
+          allow(controller).to receive(:params).and_return injected_params
 
-          controller.stub(:action_name).and_return(current_action)
+          allow(controller).to receive(:action_name).and_return(current_action)
         end
 
         context "and there is no specific configuration for the current action" do

metadata

@@ -1,8 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: arrthorizer
 version: !ruby/object:Gem::Version
-  version: 0.3.1
-  prerelease: 
+  version: 0.3.2
 platform: ruby
 authors:
 - René van den Berg
@@ -10,72 +9,64 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-04 00:00:00.000000000 Z
+date: 2015-02-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.18
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 3.2.18
 - !ruby/object:Gem::Dependency
   name: combustion
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.5.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec-rails
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - ! '>='
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3'
 description: Contextual authorization for your Rails (3+) application
 email:
 - rene.vandenberg@ogd.nl
@@ -84,8 +75,8 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .travis.yml
+- ".gitignore"
+- ".travis.yml"
 - LICENSE.txt
 - README.md
 - Rakefile
@@ -188,33 +179,26 @@ files:
 - spec/support/reset.rb
 homepage: https://github.com/BUS-ogd/arrthorizer
 licenses: []
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4363344395387857595
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - ! '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 4363344395387857595
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 2.4.3
 signing_key: 
-specification_version: 3
+specification_version: 4
 summary: Contextual authorization for your Rails (3+) application
 test_files:
 - spec/arrthorizer_exception/inner_spec.rb