arq 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37b1eabfaf83924a5d2c61b390cf9a74043860578c247b851a77bd9b7f8308ce
-  data.tar.gz: e6bafd5efe08658bf7a6065d7026e3aa7dec67e4ead6f4621cf7c94f2df3c464
+  metadata.gz: bf6593b58efb70d3d2ac268f33cb8eae378fe821d13e69975c13216cdfe1ff2f
+  data.tar.gz: fa4401c24cd50c2d8a5b6f7adb69e3224e126d75c166fca994f816ceb27e4523
 SHA512:
-  metadata.gz: 3b900d412628cc1da83c1f9aff8e96a058934cde992f0cbdc1524e34614fbd8c12ad5f0f5b18f25e45b991fa470ebdf0bb01d02d26073d128736aa03c0ad49cc
-  data.tar.gz: b7e55db8850980446f857cd0d89094e95c1983077a748810607a0f8a34e97444d633bbe669ffabffe865b6621cc5ff024ab37c5aeefb125e466989e524eee624
+  metadata.gz: a9feae6ec6e4ff17c37a2af7d99b7df6ec22e1d1fce6af04e42444bdff3e250b44e2c8036d64b333620929cd0d75bd5e0f69058e09d190dc49438ca2e2d456d9
+  data.tar.gz: 297f51c062e329349999b9b370c1f1fc91ba17f90e2b57baf141fc44df6aae3ae97086eef293108204417b94143814ba1e8f512deb9f89d31022c7eb37e5287d

data/lib/arq/action.rb

@@ -1,55 +1,173 @@
 # frozen_string_literal: true
 
 module Arq
-  # Module to extend to create an action. Exposes confing functions #call, #params, and #returns.
+  # Module to extend to create an action.
+  # Class methods are used to configure the action itself.
+  # Instance methods are exposed to the block passed into `run`.
   module Action
-    def call(ctx)
-      ctx = transform_input_context(ctx)
-
-      generate_runnable(ctx).call
-
-      ctx
+    def self.extended(base)
+      base.extend(ClassMethods)
+      base.include(InstanceMethods)
     end
 
-    def params(*keys)
-      params_list.concat(keys).compact
+    def self.included(_base)
+      raise "`Arq::Action` should be `extended`"
     end
 
-    def returns(*keys)
-      returns_list.concat(keys).compact
-    end
+    # Methods and fields exposed to configure the action.
+    module ClassMethods
+      # Runs the stored block with variables from the provided context.
+      def call(ctx = Arq::Context.new)
+        ctx = transform_input_context(ctx)
 
-    def run(&block)
-      @run_block = block
-    end
+        inst = new(ctx)
+        inst.run
 
-    private
-
-    def transform_input_context(ctx)
-      case ctx
-      when Arq::Context
         ctx
-      when Hash
-        Arq::Context.new(ctx)
-      else
-        raise Arq::InvalidContextParameterError
       end
-    end
 
-    def generate_runnable(ctx)
-      Arq::Runnable.new(ctx, params_list, returns_list, &run_block)
-    end
+      def params_list
+        @params_list ||= []
+      end
 
-    def params_list
-      @params_list ||= []
-    end
+      def returns_list
+        @returns_list ||= []
+      end
+
+      def run_block
+        @run_block ||= nil
+      end
+
+      private
 
-    def returns_list
-      @returns_list ||= []
+      # Ensures that a valid context is passed and returned.
+      # Acceptable values are Context or Hash objects.
+      def transform_input_context(ctx)
+        case ctx
+        when Arq::Context
+          ctx
+        when Hash
+          Arq::Context.new(ctx)
+        else
+          raise Arq::InvalidContextParameterError
+        end
+      end
+
+      def params(*keys)
+        params_list.concat(keys).compact
+      end
+
+      def returns(*keys)
+        returns_list.concat(keys).compact
+      end
+
+      def run(&block)
+        return "Block required" unless block_given?
+
+        @run_block = block
+      end
     end
 
-    def run_block
-      @run_block ||= nil
+    # Methods and fields exposed to the run block.
+    module InstanceMethods
+      def initialize(ctx)
+        @_ctx = ctx
+      end
+
+      # This is the entry-point for the action's execution.
+      # rubocop:disable Metrics/MethodLength
+      def run
+        return if @_ctx.failure?
+
+        _validate_required_params
+        _import_context
+
+        # Suppress `FailureError`s since they're used to just exit the action.
+        begin
+          # Instance eval to expose instance variables.
+          instance_eval(&self.class.run_block)
+        rescue Arq::FailureError
+          nil
+        end
+
+        _export_variables
+
+        # Only validate returns if context is successful
+        _validate_required_returns if @_ctx.success?
+
+        nil
+      end
+      # rubocop:enable Metrics/MethodLength
+
+      # Used to call another action using the current action's context.
+      # Because of this, the context is exported and then imported again.
+      def call_other(action)
+        _export_variables
+        action.call(@_ctx)
+        _import_context
+      end
+
+      # Fails the context without exiting the current action.
+      def fail!(message = nil)
+        @_ctx.fail!(message)
+      end
+
+      # Fails the context and exits the current action.
+      def fail_now!(message = nil)
+        @_ctx.fail_now!(message)
+      end
+
+      # Used to easily call other actions via snake-cased modules and dot accessors.
+      # IE `Foo::Bar::Action` can be called via `foo.bar.action`
+      def method_missing(method, *args, &block)
+        obj = Object.const_get(method.to_s.camelize)
+        case obj
+        when Arq::Action
+          call_other(obj)
+        when Module
+          Arq::ModuleHash.new(obj, self)
+        end
+      rescue NameError => _e
+        super
+      end
+
+      def respond_to_missing?(method, include_private: false)
+        Object.const_defined?(method.to_s.camelize) || super
+      end
+
+      private
+
+      # Load parameters of context as instance variables
+      def _import_context
+        @_ctx.each do |key, val|
+          instance_variable_set(:"@#{key}", val)
+        end
+      end
+
+      # Exports instance variables (excluding those prefixed with _) to the context
+      def _export_variables
+        # Filter out vars starting with _
+        vars = instance_variables.filter do |key|
+          !key.start_with?("@_")
+        end
+
+        vars.each do |var|
+          # Strip @ prefix
+          key = var[1..].to_sym
+
+          @_ctx[key] = instance_variable_get(var)
+        end
+      end
+
+      def _validate_required_params
+        missing_params = (self.class.params_list - @_ctx.keys)
+        raise Arq::ParametersNotInContextError, missing_params unless missing_params.empty?
+      end
+
+      def _validate_required_returns
+        missing_returns = (self.class.returns_list - @_ctx.keys)
+        raise Arq::ReturnValuesNotInContextError, missing_returns unless missing_returns.empty?
+      end
     end
   end
 end

data/lib/arq/module_hash.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Arq
+  # Allows for dot-accessing of modules.
+  # Child modules are automatically wrapped and actions are called.
+  class ModuleHash < Hash
+    def initialize(mod, action_inst)
+      super()
+
+      @module = mod
+      @action_inst = action_inst
+    end
+
+    def method_missing(method, *args, &block)
+      wrap(@module.const_get(method.to_s.camelize))
+    rescue NameError => _e
+      super
+    end
+
+    def respond_to_missing?(method, include_private = false)
+      @module.const_defined?(method.to_s.camelize.to_sym) || super
+    end
+
+    private
+
+    # If the value is a Module, it's returned as a ModuleHash.
+    def wrap(value)
+      case value
+      when Arq::Action
+        @action_inst.call_other(value)
+      when Module
+        self.class.new(value, @action_inst)
+      else
+        value
+      end
+    end
+  end
+end

data/lib/arq/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Arq
-  VERSION = "0.2.0"
+  VERSION = "0.3.0"
 end

data/lib/arq.rb

@@ -1,7 +1,9 @@
 # frozen_string_literal: true
 
+require "active_support/core_ext/string"
+
 require_relative "arq/version"
 require_relative "arq/errors"
 require_relative "arq/context"
-require_relative "arq/runnable"
+require_relative "arq/module_hash"
 require_relative "arq/action"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: arq
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - Kavin Phan
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-09-06 00:00:00.000000000 Z
+date: 2022-09-29 00:00:00.000000000 Z
 dependencies: []
 description: A service skeleton framework heavily inspired by LightService with the
   primary goal of being less verbose.
@@ -22,7 +22,7 @@ files:
 - lib/arq/action.rb
 - lib/arq/context.rb
 - lib/arq/errors.rb
-- lib/arq/runnable.rb
+- lib/arq/module_hash.rb
 - lib/arq/version.rb
 homepage: https://github.com/kphan32/arq
 licenses:

data/lib/arq/runnable.rb

@@ -1,90 +0,0 @@
-# frozen_string_literal: true
-
-module Arq
-  # Represents a process to run with a given context, parameters, and returns.
-  # A Runnable is generated from an Action.
-  class Runnable
-    def initialize(ctx, params = [], returns = [], &block)
-      @ctx     = ctx
-      @params  = params
-      @returns = returns
-      @block   = block
-    end
-
-    def call
-      return if @ctx.failure?
-
-      validate_required_params
-
-      import_context
-      val = run_block
-      export_context
-
-      # If the block returned an array, attempt to run
-      run_sequence(val) if val.is_a?(Array)
-
-      # Only validate returns if context is successful
-      validate_required_returns if @ctx.success?
-
-      val
-    end
-
-    def run(&block)
-      Arq::Runnable.new(@ctx, [], [], &block)
-    end
-
-    def fail!(message)
-      @ctx.fail!(message)
-    end
-
-    def fail_now!(message)
-      @ctx.fail_now!(message)
-    end
-
-    private
-
-    def run_block
-      instance_eval(&@block)
-    rescue Arq::FailureError
-      nil
-    end
-
-    def run_sequence(sequence)
-      sequence.each do |e|
-        case e
-        when Arq::Action
-          e.call(@ctx)
-        when Arq::Runnable
-          e.call
-        end
-      end
-    end
-
-    def import_context
-      @ctx.each do |key, val|
-        instance_variable_set(:"@#{key}", val)
-      end
-    end
-
-    def export_context
-      keys = [*@ctx.keys, *@returns]
-
-      keys.each do |key|
-        instance_key = :"@#{key}"
-        # Must check for existence since getting non-existent
-        # instance variables will return nil.
-        @ctx[key] = instance_variable_get(instance_key) if instance_variables.include?(instance_key)
-      end
-    end
-
-    def validate_required_params
-      missing_params = (@params - @ctx.keys)
-      raise Arq::ParametersNotInContextError, missing_params unless missing_params.empty?
-    end
-
-    def validate_required_returns
-      missing_returns = (@returns - @ctx.keys)
-      raise Arq::ReturnValuesNotInContextError, missing_returns unless missing_returns.empty?
-    end
-  end
-end