aroundhome_cops 6.0.0 → 7.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a35fcd55f78d6a4fb19bc2a788ea4823866b8367b3b8223ae5d84390d27e6911
-  data.tar.gz: bc4712d7e3da71cdf98a2d3e83f25129756cb41beec1c63dace41229247aa8ce
+  metadata.gz: e945f7b9bf460da0613d77d0f5a216bb846915fe638bf76e9e1645fa76b4a6b6
+  data.tar.gz: c97a61b1641b38fd7b8de97c9a87ddf3bb95944eb94c7ae4912e675688cb5171
 SHA512:
-  metadata.gz: db604599b4b66e0481ecabb06debc543df1000feb641903b5d8f7b98bb9d403048dcecc023e41f1f9a61cb54db0aef9c569e4766ec994c3ac32721685dd6d800
-  data.tar.gz: dc707c3c258a163f0ece5b506089c4992e3ea941ee0074b3b5628f3054b571867de47119bfabdaefe2f1a2829a65eb07f031db3778f80c307504ad2f0273dc6b
+  metadata.gz: 89cd014f0e01d75a1387ace3b87b37f1ddc85becf64805249311d470aedcf767f83ec2e8fa064f660a91a57ee24145f2ff44ed67c8621ef7241b584838b51b55
+  data.tar.gz: 59b752ad8bdc0ad91c251316984378bb3c635d0c1996093e91b1e8569e4855b9c75f88821663b7183d4eaf3fdabc4e735de9f88885ff84123b8bda7e0608e5a7

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## Version 7.0.0 (2024-06-14)
+
+* No longer suggest rubocop-factory_bot
+* No longer force fixes after updates for older migrations
+* Update underlying rubocop to at least 1.64
+  * Opt into all Rubocop offenses up until 1.64
+* Update underlying rubocop-rspec to at least 2.30
+  * Opt into all Rubocop-Rspec offenses up until 2.30
+* Add rubocop-performance as a dependency, to enforce more performant code
+
+## Version 6.0.1
+
+* Fix deprecation warnings and multiple defined default cops
+
 ## Version 6.0.0
 
 * Update underlying rubocop to at least 1.63

data/aroundhome_cops.gemspec

@@ -20,7 +20,8 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.7.0'
 
-  spec.add_dependency 'rubocop', '~> 1.63'
+  spec.add_dependency 'rubocop', '~> 1.64'
+  spec.add_dependency 'rubocop-performance', '~> 1.21'
   spec.add_dependency 'rubocop-rake', '~> 0.6'
-  spec.add_dependency 'rubocop-rspec', '~> 2.29'
+  spec.add_dependency 'rubocop-rspec', '~> 2.30'
 end

data/default.yml

@@ -1,30 +1,29 @@
 require:
+  - rubocop-performance
   - rubocop-rspec
   - rubocop-rake
 
 AllCops:
   Exclude:
-    - 'bin/**/*'
-    - 'db/schema.rb'
-    - 'doc/**/*'
-    - 'docker_app/**/*'
-    - 'Guardfile'
-    - 'tmp/**/*'
-    - 'vendor/**/*'
-    - 'playground/**/*'
-    - 'public/**/*'
-    - 'node_modules/**/*'
-    - 'db/migrate/200*.rb'
-    - 'db/migrate/2010*.rb'
-    - 'db/migrate/2011*.rb'
-    - 'db/migrate/2012*.rb'
-    - 'db/migrate/2013*.rb'
-    - 'db/migrate/2014*.rb'
-    - 'db/migrate/2015*.rb'
-    - 'db/migrate/2016*.rb'
-    - 'db/migrate/2017*.rb'
+    - "bin/**/*"
+    - "db/schema.rb"
+    - "doc/**/*"
+    - "docker_app/**/*"
+    - "Guardfile"
+    - "tmp/**/*"
+    - "vendor/**/*"
+    - "playground/**/*"
+    - "public/**/*"
+    - "node_modules/**/*"
+    - "db/migrate/200*.rb"
+    - "db/migrate/201*.rb"
+    - "db/migrate/2020*.rb"
+    - "db/migrate/2021*.rb"
+    - "db/migrate/2022*.rb"
+    - "db/migrate/2023*.rb"
   SuggestExtensions:
     rubocop-rails: false
+    rubocop-factory_bot: false
 
 # While we like to write blocks like the following
 # expect { add_special_project }.not_to change { SpecialProject.count }
@@ -33,21 +32,20 @@ AllCops:
 # expect { add_special_project }.not_to(change { SpecialProject.count })
 Lint/AmbiguousBlockAssociation:
   Exclude:
-    - 'spec/**/*'
+    - "spec/**/*"
 
 # Models can have a bunch of attributes which lead to long methods and high
 # complexity values. However, these methods are still very readable because they
 # usually have a lot of repetition.
 Metrics:
   Exclude:
-    - 'db/migrate/*.rb'
+    - "db/migrate/*.rb"
 
 # See above (Metrics). This cop was previously called Metrics/LineLength
 # and therefore disabled as well for migrations.
 Layout/LineLength:
   Exclude:
-    - 'db/migrate/*.rb'
-
+    - "db/migrate/*.rb"
 
 # We need to configure exemptions for blocks that we generally accept to be
 # long, since they are less comparable to methods and more comparable to
@@ -64,10 +62,10 @@ Metrics/BlockLength:
     - xcontext
     - xdescribe
   Exclude:
-    - 'config/environments/*.rb' # instead of excluding all :configure methods
-    - 'config/routes.rb'
-    - 'spec/spec_helper.rb' # instead of excluding all :configure methods
-    - '*.gemspec' # a gemspec could easily have more than the 25 lines limit
+    - "config/environments/*.rb" # instead of excluding all :configure methods
+    - "config/routes.rb"
+    - "spec/spec_helper.rb" # instead of excluding all :configure methods
+    - "*.gemspec" # a gemspec could easily have more than the 25 lines limit
 
 # Increase from rubocops default limit of 10 lines.
 # The idea of increasing the default limit is to reduce the "false alarm rate"
@@ -88,7 +86,7 @@ Style/Documentation:
 Style/Encoding:
   Enabled: true
   Exclude:
-    - '*.gemspec'
+    - "*.gemspec"
 
 # Ruby 2.3 introduced optional automatic freezing of string literals
 # This might become default in future versions.
@@ -134,16 +132,17 @@ Metrics/ParameterLists:
 # People coming from other languages or our junior colleagues will find a single & confusing.
 # Omitting the parameter name is neither more readable or helpful, therefore we prefer to use &block syntax.
 Naming/BlockForwarding:
+  Enabled: true
   EnforcedStyle: explicit
 
 # Adding "and" prefix to list of allowed prefixes to allow for nested contexts
 # that start with "and" as a connector word "when foo is true and bar is false"
 RSpec/ContextWording:
   Prefixes:
-  - when
-  - with
-  - without
-  - and
+    - when
+    - with
+    - without
+    - and
 
 # Complex tests require more flexibility in their length than allowed by default (5).
 RSpec/ExampleLength:
@@ -351,8 +350,6 @@ Lint/UselessRescue: # new in 1.43
   Enabled: true
 Metrics/CollectionLiteralLength: # new in 1.47
   Enabled: true
-Naming/BlockForwarding: # new in 1.24
-  Enabled: true
 Style/ArrayIntersect: # new in 1.40
   Enabled: true
 Style/ComparableClamp: # new in 1.44
@@ -405,13 +402,17 @@ Style/SuperWithArgsParentheses: # new in 1.58
   Enabled: true
 Style/YAMLFileRead: # new in 1.53
   Enabled: true
+Style/SendWithLiteralMethodName: # new in 1.64
+  Enabled: true
+Style/SuperArguments: # new in 1.64
+  Enabled: true
 
 # ----------------- Rubocop-Rspec forced enablements --------------
 RSpec/ExcessiveDocstringSpacing: # (new in 2.5)
   Enabled: true
 RSpec/IdenticalEqualityAssertion: # (new in 2.4)
   Enabled: true
-RSpec/Rails/AvoidSetupHook: # (new in 2.4)
+RSpecRails/AvoidSetupHook: # (new in 2.4)
   Enabled: true
 RSpec/SubjectDeclaration: # (new in 2.5)
   Enabled: true
@@ -423,11 +424,11 @@ RSpec/ChangeByZero: # new in 2.11.0
   Enabled: true
 RSpec/VerifiedDoubleReference: # new in 2.10.0
   Enabled: true
-RSpec/Capybara/SpecificMatcher: # new in 2.12
+Capybara/SpecificMatcher: # new in 2.12
   Enabled: true
-RSpec/FactoryBot/SyntaxMethods: # new in 2.7
+FactoryBot/SyntaxMethods: # new in 2.7
   Enabled: true
-RSpec/Rails/HaveHttpStatus: # new in 2.12
+RSpecRails/HaveHttpStatus: # new in 2.12
   Enabled: true
 RSpec/RedundantPredicateMatcher: # new in 2.26
   Enabled: true
@@ -511,3 +512,45 @@ RSpecRails/NegationBeValid: # new in 2.23
   Enabled: true
 RSpecRails/TravelAround: # new in 2.19
   Enabled: true
+RSpec/ExpectInLet: # new in 2.30
+  Enabled: true
+
+# ----------------- Rubocop-Performance forced enablements --------------
+Performance/AncestorsInclude: # new in 1.7
+  Enabled: true
+Performance/BigDecimalWithNumericArgument: # new in 1.7
+  Enabled: true
+Performance/BlockGivenWithExplicitBlock: # new in 1.9
+  Enabled: true
+Performance/CollectionLiteralInLoop: # new in 1.8
+  Enabled: true
+Performance/ConcurrentMonotonicTime: # new in 1.12
+  Enabled: true
+Performance/ConstantRegexp: # new in 1.9
+  Enabled: true
+Performance/MapCompact: # new in 1.11
+  Enabled: true
+Performance/MapMethodChain: # new in 1.19
+  Enabled: true
+Performance/MethodObjectAsBlock: # new in 1.9
+  Enabled: true
+Performance/RedundantEqualityComparisonBlock: # new in 1.10
+  Enabled: true
+Performance/RedundantSortBlock: # new in 1.7
+  Enabled: true
+Performance/RedundantSplitRegexpArgument: # new in 1.10
+  Enabled: true
+Performance/RedundantStringChars: # new in 1.7
+  Enabled: true
+Performance/ReverseFirst: # new in 1.7
+  Enabled: true
+Performance/SortReverse: # new in 1.7
+  Enabled: true
+Performance/Squeeze: # new in 1.7
+  Enabled: true
+Performance/StringIdentifierArgument: # new in 1.13
+  Enabled: true
+Performance/StringInclude: # new in 1.7
+  Enabled: true
+Performance/Sum: # new in 1.8
+  Enabled: true

data/lib/aroundhome_cops.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AroundhomeCops
-  VERSION = '6.0.0'
+  VERSION = '7.0.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aroundhome_cops
 version: !ruby/object:Gem::Version
-  version: 6.0.0
+  version: 7.0.0
 platform: ruby
 authors:
 - Jan Sandbrink
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-04-15 00:00:00.000000000 Z
+date: 2024-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.63'
+        version: '1.64'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.63'
+        version: '1.64'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.21'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '1.21'
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -44,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.29'
+        version: '2.30'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.29'
+        version: '2.30'
 description:
 email:
 - jan.sandbrink@aroundhome.de
@@ -87,7 +101,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.3
+rubygems_version: 3.5.11
 signing_key:
 specification_version: 4
 summary: Dependency and configuration for rubocop.