aroundhome_cops 5.0.0 → 5.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7b3ed872a0065df50104dab56c15c0ec6112345943e4a87ccea027a956893aad
-  data.tar.gz: 6fb3f2a8f00d60815922347aec18555e06b5155af2610237f2d9223d72279c65
+  metadata.gz: 7c08a92281cf5ab286b30ccdbf4212e1148157b7518352b8369553d6dde0148f
+  data.tar.gz: 510f0776b7ce314f7fb295873129a3646541c1331a39a756252fe28f0e04c683
 SHA512:
-  metadata.gz: f33fcac4d0b2f1e2c2d2ddf599a0564e8e8e6a2a8c48ff2c63f46434380924ded040d93c279028d67eb9f9d490702cce0d4aef5006e0b7c71d1cf10fee5f6d2c
-  data.tar.gz: 25e603de2b851c365356fdaa260a165f3b455212952e48e2510b31bc3e976b9dc884cb90f03b4e1d23190d83bb1e4cdbbc0279360f38694301c4295be5507358
+  metadata.gz: 77ab5d8ac51f8fbcd85e79e002abe0def7d0e5db685e7b78da3ec33e4aecd1d3a1087a080245af829a61331e803c5643a20f69b1ccae460f09625266a5990793
+  data.tar.gz: 51be35b7bcb81d2b0e7574038d1ea57c410d005b01a7eb60744d204ad6c89b333d116cb5baa7658424698ebb892343f51f2dd0fe764691500f328cfb2fd29eba

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## Version 5.0.2
+* use EnforcedStyle: explicit for [BlockForwarding](https://www.rubydoc.info/gems/rubocop/RuboCop/Cop/Naming/BlockForwarding)
+
+## Version 5.0.1
+* [do not expect syntax](https://www.rubydoc.info/gems/rubocop-rspec/1.10.0/RuboCop/Cop/RSpec/MessageSpies) of [message spies](https://relishapp.com/rspec/rspec-mocks/docs/basics/spies) by default
+  
 ## Version 5.0.0
 * Opt into all Rubocop offenses up until 1.35 & rspec 2.12
 * Update minimum rubocop to 1.35

data/default.yml

@@ -131,6 +131,11 @@ Style/FormatStringToken:
 Metrics/ParameterLists:
   CountKeywordArgs: false
 
+# People coming from other languages or our junior colleagues will find a single & confusing.
+# Omitting the parameter name is neither more readable or helpful, therefore we prefer to use &block syntax.
+Naming/BlockForwarding:
+  EnforcedStyle: explicit
+
 # Adding "and" prefix to list of allowed prefixes to allow for nested contexts
 # that start with "and" as a connector word "when foo is true and bar is false"
 RSpec/ContextWording:
@@ -174,6 +179,11 @@ RSpec/NestedGroups:
 RSpec/PredicateMatcher:
   Enabled: false
 
+# Our codebase was consistent across the company before we started to introduce rubocop-rspec
+# lots of our repositories are not using message spies currently
+RSpec/MessageSpies:
+  EnforcedStyle: receive
+
 # While in general 2FA is a good idea, adding 2FA to CI/CD is a difficulty.
 Gemspec/RequireMFA: # new in 1.23
   Enabled: false
@@ -290,8 +300,6 @@ Lint/RequireRangeParentheses: # new in 1.32
   Enabled: true
 Lint/UselessRuby2Keywords: # new in 1.23
   Enabled: true
-Naming/BlockForwarding: # new in 1.24
-  Enabled: true
 Security/CompoundHash: # new in 1.28
   Enabled: true
 Style/EmptyHeredoc: # new in 1.32
@@ -342,3 +350,4 @@ RSpec/FactoryBot/SyntaxMethods: # new in 2.7
   Enabled: true
 RSpec/Rails/HaveHttpStatus: # new in 2.12
   Enabled: true
+

data/lib/aroundhome_cops.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AroundhomeCops
-  VERSION = '5.0.0'
+  VERSION = '5.0.2'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aroundhome_cops
 version: !ruby/object:Gem::Version
-  version: 5.0.0
+  version: 5.0.2
 platform: ruby
 authors:
 - Jan Sandbrink
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-08-19 00:00:00.000000000 Z
+date: 2022-11-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop