aroundhome_cops 3.0.0 → 4.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fee1b743baec2877e677710e69aaad6247e12404931b357086e2da65129e3681
-  data.tar.gz: d0dd262d22f6d447ba79416e94e5c750d255a0bee0cf745c39abf7cef45067e6
+  metadata.gz: 892609c946c6d5b7c856b11c900354e126020bfdc86294456d97ee797b14da1f
+  data.tar.gz: '03096a520b19ce75cb83520668bc24f8c96e738525de3546b319a638ccd3c0e1'
 SHA512:
-  metadata.gz: ef8d267ebbab4c5715d9f7bffe05c59df94bf9e519d077d4e15cdf2792b8ceeb4b6eb36f26c6f1f4cceb9c9413d38ee20d1badf3d70d1ff982fff2dccfd2342b
-  data.tar.gz: e0ec10ec887f77c4a24e9801c23149b6055bc3d5c8b2f9f94e20ecbc59c1dc272109701bed41152f3f4dfda69f6d8aa79babf353a727ebe6d4253fa1c9eb6b93
+  metadata.gz: 2715942fc7d5261183c74623d8536072162dc605e9e9f8e0b02847ee4f66519f14be2a86a0c5f5d44877e5d45203e4d61be54f5f37b9fd52cc87b36684b569aa
+  data.tar.gz: 94bb36c19e518f9ecbf029e473e821b1583f6c916cc15335dfd883680dac97f57a3cea53e7d8e972ddd7cba5a76c5fd9114c6df32a7259bdaba9db99907b3790

data/CHANGELOG.md

@@ -1,3 +1,17 @@
+## Version 4.3.0
+* Disable `RSpec/PredicateMatcher` due to false positives
+
+## Version 4.2.0
+* Add rubocop-rake as a dependency, to enforce better specs
+
+## Version 4.1.0
+* Specify more precise defaults for rspec
+* upgrade rubocop and rubocop-rspec and enable new offenses
+
+## Version 4.0.0
+* Opt into all Rubocop offenses up until 1.18
+* Add rubocop-rspec as a dependency, to enforce better specs
+
 ## Version 3.0.0
 
 * Support Rubocop 1.0 and opt into all offenses up until 1.13

data/aroundhome_cops.gemspec

@@ -20,5 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.required_ruby_version = '>= 2.5.0'
 
-  spec.add_dependency 'rubocop', '~> 1.0'
+  spec.add_dependency 'rubocop', '~> 1.22'
+  spec.add_dependency 'rubocop-rake', '~> 0.6'
+  spec.add_dependency 'rubocop-rspec', '~> 2.5'
 end

data/default.yml

@@ -1,3 +1,7 @@
+require:
+  - rubocop-rspec
+  - rubocop-rake
+
 AllCops:
   Exclude:
     - 'bin/**/*'
@@ -20,7 +24,6 @@ AllCops:
     - 'db/migrate/2016*.rb'
     - 'db/migrate/2017*.rb'
   SuggestExtensions:
-    rubocop-rspec: false
     rubocop-rails: false
 
 # While we like to write blocks like the following
@@ -128,6 +131,49 @@ Style/FormatStringToken:
 Metrics/ParameterLists:
   CountKeywordArgs: false
 
+# Adding "and" prefix to list of allowed prefixes to allow for nested contexts
+# that start with "and" as a connector word "when foo is true and bar is false"
+RSpec/ContextWording:
+  Prefixes:
+  - when
+  - with
+  - without
+  - and
+
+# Complex tests require more flexibility in their length than allowed by default (5).
+RSpec/ExampleLength:
+  Max: 10
+
+# Complex tests often rely on more objects than allowed by default (5).
+RSpec/MultipleMemoizedHelpers:
+  Max: 10
+
+# We rarely use named subjects in our own projects.
+# While it is a good practice in some cases, we do not want to enforce it
+# through Rubocop.
+# https://www.rubydoc.info/gems/rubocop-rspec/1.6.0/RuboCop/Cop/RSpec/NamedSubject
+RSpec/NamedSubject:
+  Enabled: false
+
+# Complex tests often generate more readable output with deeper nesting. The
+# default (3) doesn't provide enough flexibility.
+RSpec/NestedGroups:
+  Max: 7
+
+# While well intentioned at teaching about the existence of be_something matchers
+# in RSpec, this one produces false positives on methods such as
+#
+#     expect(hash.key?('foo')).to be_truthy
+#
+# Where it suggests to change towards:
+#
+#     expect(hash).to be_key('foo')
+#
+# While this works, it is less readable. The hash IS NOT the key, but it HAS the key.
+# Similar mistakes happen for other methods (e.g. File.exist?).
+RSpec/PredicateMatcher:
+  Enabled: false
+
 # ----------------- Rubocop-forced enablements --------------
 
 # Since version 0.80 rubocop wants to cause fewer breaking changes by new cops.
@@ -142,6 +188,10 @@ Layout/SpaceBeforeBrackets: # (new in 1.7)
   Enabled: true
 Lint/AmbiguousAssignment: # (new in 1.7)
   Enabled: true
+Lint/AmbiguousOperatorPrecedence: # (new in 1.21)
+  Enabled: true
+Lint/AmbiguousRange: # (new in 1.19)
+  Enabled: true
 Lint/DeprecatedConstants: # (new in 1.8)
   Enabled: true
 Lint/DuplicateBranch: # (new in 1.3)
@@ -152,6 +202,8 @@ Lint/EmptyBlock: # (new in 1.1)
   Enabled: true
 Lint/EmptyClass: # (new in 1.3)
   Enabled: true
+Lint/IncompatibleIoSelectWithFiberScheduler: # (new in 1.21)
+  Enabled: true
 Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
   Enabled: true
 Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
@@ -162,6 +214,8 @@ Lint/OrAssignmentToConstant: # (new in 1.9)
   Enabled: true
 Lint/RedundantDirGlobSort: # (new in 1.8)
   Enabled: true
+Lint/RequireRelativeSelfPath: # (new in 1.22)
+  Enabled: true
 Lint/SymbolConversion: # (new in 1.9)
   Enabled: true
 Lint/ToEnumArguments: # (new in 1.1)
@@ -172,6 +226,8 @@ Lint/UnexpectedBlockArity: # (new in 1.5)
   Enabled: true
 Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
   Enabled: true
+Security/IoMethods: # (new in 1.22)
+  Enabled: true
 Style/ArgumentsForwarding: # (new in 1.1)
   Enabled: true
 Style/CollectionCompact: # (new in 1.2)
@@ -190,9 +246,39 @@ Style/NegatedIfElseCondition: # (new in 1.2)
   Enabled: true
 Style/NilLambda: # (new in 1.3)
   Enabled: true
+Style/NumberedParameters: # (new in 1.22)
+  Enabled: true
+Style/NumberedParametersLimit: # (new in 1.22)
+  Enabled: true
 Style/RedundantArgument: # (new in 1.4)
   Enabled: true
+Style/RedundantSelfAssignmentBranch: # (new in 1.19)
+  Enabled: true
+Style/SelectByRegexp: # (new in 1.22)
+  Enabled: true
 Style/StringChars: # (new in 1.12)
   Enabled: true
 Style/SwapValues: # (new in 1.1)
   Enabled: true
+Layout/LineEndStringConcatenationIndentation: # (new in 1.18)
+  Enabled: true
+Lint/EmptyInPattern: # (new in 1.16)
+  Enabled: true
+Naming/InclusiveLanguage: # (new in 1.18)
+  Enabled: true
+Style/InPatternThen: # (new in 1.16)
+  Enabled: true
+Style/MultilineInPatternThen: # (new in 1.16)
+  Enabled: true
+Style/QuotedSymbols: # (new in 1.16)
+  Enabled: true
+
+# ----------------- Rubocop-Rspec forced enablements --------------
+RSpec/ExcessiveDocstringSpacing: # (new in 2.5)
+  Enabled: true
+RSpec/IdenticalEqualityAssertion: # (new in 2.4)
+  Enabled: true
+RSpec/Rails/AvoidSetupHook: # (new in 2.4)
+  Enabled: true
+RSpec/SubjectDeclaration: # (new in 2.5)
+  Enabled: true

data/lib/aroundhome_cops.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AroundhomeCops
-  VERSION = '3.0.0'
+  VERSION = '4.3.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aroundhome_cops
 version: !ruby/object:Gem::Version
-  version: 3.0.0
+  version: 4.3.0
 platform: ruby
 authors:
 - Jan Sandbrink
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-05-04 00:00:00.000000000 Z
+date: 2021-10-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,42 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.22'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.0'
+        version: '1.22'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.6'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
 description: 
 email:
 - jan.sandbrink@aroundhome.de
@@ -59,7 +87,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: Dependency and configuration for rubocop.