aroundhome_cops 2.0.0 → 4.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8b9bd51596d52489367945aaa124fd6553037b18c02532108d7257ce32cdc730
-  data.tar.gz: be240ec3e67e0f2d0b6c5df03ec67ec4fbb6430dd0a169e436bf78eab4284b54
+  metadata.gz: 0aa989da6d5148c3fec013805e7cf05eb35e9cc5474e1c8e0b1b9586ff49ad83
+  data.tar.gz: 2599d7b62ac3bb217689b1f5e72bc9ee21e53617a7b0318b551a53e5d60471b5
 SHA512:
-  metadata.gz: 55bf0c984dec9a4618ca6666a3f55eb0bad1fa6e9853c65bcec2f5bf51cd99f883cf558e5f2a37dcd35c3fbdc9e19f03b39170ed63014f5219124cdbedcdae4c
-  data.tar.gz: fbe4d180f3285f76b38dd1371004d265d22c9efbd212b8073541d3efa6e128a5dfcf126687931f0fc6d55b5a5b7ccd1973cdd5f3fb367ebe677c39e2a2f0b47b
+  metadata.gz: 77d867c3da27835acc6533928c487f2f7825ed8552ecf7cd167a05b97030345c5cac11abd8e1d3d35cc7f52f8363aa9977b9206251759f9ec66d44e16601b413
+  data.tar.gz: 304234f4fd850d263bfcfb8ccd72fdf77aab3a60fb94ff476b8be7d4bed18e8a3b4829ac0dcf49370372dc4df6ec208eaa42f69a2fc7c7c1f32ea379815f0c47

data/.ruby-version

@@ -0,0 +1 @@
+2.5.8

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+## Version 4.1.0
+* Specify more precise defaults for rspec
+* upgrade rubocop and rubocop-rspec and enable new offenses
+
+## Version 4.0.0
+* Opt into all Rubocop offenses up until 1.18
+* Add rubocop-rspec as a dependency, to enforce better specs
+
+## Version 3.0.0
+
+* Support Rubocop 1.0 and opt into all offenses up until 1.13
+
+## Version 2.1.0
+
+* Allow ambiguous blocks in specs
+
 ## Version 2.0.0
 
 * Rename to `aroundhome_cops` (our company name changed a while ago)

data/aroundhome_cops.gemspec

@@ -18,5 +18,8 @@ Gem::Specification.new do |spec|
                                         .reject { |f| f.match(%r{^spec/}) }
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'rubocop', '~> 0.86'
+  spec.required_ruby_version = '>= 2.5.0'
+
+  spec.add_dependency 'rubocop', '~> 1.22'
+  spec.add_dependency 'rubocop-rspec', '~> 2.5'
 end

data/default.yml

@@ -1,3 +1,6 @@
+require:
+  - rubocop-rspec
+
 AllCops:
   Exclude:
     - 'bin/**/*'
@@ -19,6 +22,17 @@ AllCops:
     - 'db/migrate/2015*.rb'
     - 'db/migrate/2016*.rb'
     - 'db/migrate/2017*.rb'
+  SuggestExtensions:
+    rubocop-rails: false
+
+# While we like to write blocks like the following
+# expect { add_special_project }.not_to change { SpecialProject.count }
+# Rubocop doesn't like that and prefers either of the following options for clarity
+# expect { add_special_project }.not_to change(SpecialProject, :count)
+# expect { add_special_project }.not_to(change { SpecialProject.count })
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - 'spec/**/*'
 
 # Models can have a bunch of attributes which lead to long methods and high
 # complexity values. However, these methods are still very readable because they
@@ -38,7 +52,7 @@ Layout/LineLength:
 # long, since they are less comparable to methods and more comparable to
 # modules/classes.
 Metrics/BlockLength:
-  ExcludedMethods:
+  IgnoredMethods:
     - context
     - describe
     - namespace
@@ -116,6 +130,35 @@ Style/FormatStringToken:
 Metrics/ParameterLists:
   CountKeywordArgs: false
 
+# Adding "and" prefix to list of allowed prefixes to allow for nested contexts
+# that start with "and" as a connector word "when foo is true and bar is false"
+RSpec/ContextWording:
+  Prefixes:
+  - when
+  - with
+  - without
+  - and
+
+# Complex tests require more flexibility in their length than allowed by default (5).
+RSpec/ExampleLength:
+  Max: 10
+
+# Complex tests often rely on more objects than allowed by default (5).
+RSpec/MultipleMemoizedHelpers:
+  Max: 10
+
+# We rarely use named subjects in our own projects.
+# While it is a good practice in some cases, we do not want to enforce it
+# through Rubocop.
+# https://www.rubydoc.info/gems/rubocop-rspec/1.6.0/RuboCop/Cop/RSpec/NamedSubject
+RSpec/NamedSubject:
+  Enabled: false
+
+# Complex tests often generate more readable output with deeper nesting. The
+# default (3) doesn't provide enough flexibility.
+RSpec/NestedGroups:
+  Max: 7
+
 # ----------------- Rubocop-forced enablements --------------
 
 # Since version 0.80 rubocop wants to cause fewer breaking changes by new cops.
@@ -124,44 +167,103 @@ Metrics/ParameterLists:
 # them below.
 # Disabled cops will appear above with a comment explaining disablement.
 
-Layout/SpaceAroundMethodCallOperator:
+Gemspec/DateAssignment: # (new in 1.10)
   Enabled: true
-
-Lint/RaiseException:
+Layout/SpaceBeforeBrackets: # (new in 1.7)
   Enabled: true
-
-Lint/StructNewOverride:
+Lint/AmbiguousAssignment: # (new in 1.7)
   Enabled: true
-
-Style/ExponentialNotation:
+Lint/AmbiguousOperatorPrecedence: # (new in 1.21)
   Enabled: true
-
-Style/HashEachMethods:
+Lint/AmbiguousRange: # (new in 1.19)
   Enabled: true
-
-Style/HashTransformKeys:
+Lint/DeprecatedConstants: # (new in 1.8)
   Enabled: true
-
-Style/HashTransformValues:
+Lint/DuplicateBranch: # (new in 1.3)
   Enabled: true
-
-Layout/EmptyLinesAroundAttributeAccessor:
+Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
   Enabled: true
-
-Lint/DeprecatedOpenSSLConstant:
+Lint/EmptyBlock: # (new in 1.1)
   Enabled: true
-
-Lint/MixedRegexpCaptureTypes:
+Lint/EmptyClass: # (new in 1.3)
   Enabled: true
-
-Style/RedundantFetchBlock:
+Lint/IncompatibleIoSelectWithFiberScheduler: # (new in 1.21)
   Enabled: true
-
-Style/RedundantRegexpCharacterClass:
+Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
   Enabled: true
-
-Style/RedundantRegexpEscape:
+Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
+  Enabled: true
+Lint/NumberedParameterAssignment: # (new in 1.9)
+  Enabled: true
+Lint/OrAssignmentToConstant: # (new in 1.9)
+  Enabled: true
+Lint/RedundantDirGlobSort: # (new in 1.8)
+  Enabled: true
+Lint/RequireRelativeSelfPath: # (new in 1.22)
+  Enabled: true
+Lint/SymbolConversion: # (new in 1.9)
+  Enabled: true
+Lint/ToEnumArguments: # (new in 1.1)
+  Enabled: true
+Lint/TripleQuotes: # (new in 1.9)
+  Enabled: true
+Lint/UnexpectedBlockArity: # (new in 1.5)
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+  Enabled: true
+Security/IoMethods: # (new in 1.22)
+  Enabled: true
+Style/ArgumentsForwarding: # (new in 1.1)
+  Enabled: true
+Style/CollectionCompact: # (new in 1.2)
+  Enabled: true
+Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+  Enabled: true
+Style/EndlessMethod: # (new in 1.8)
+  Enabled: true
+Style/HashConversion: # (new in 1.10)
+  Enabled: true
+Style/HashExcept: # (new in 1.7)
+  Enabled: true
+Style/IfWithBooleanLiteralBranches: # (new in 1.9)
+  Enabled: true
+Style/NegatedIfElseCondition: # (new in 1.2)
+  Enabled: true
+Style/NilLambda: # (new in 1.3)
+  Enabled: true
+Style/NumberedParameters: # (new in 1.22)
+  Enabled: true
+Style/NumberedParametersLimit: # (new in 1.22)
+  Enabled: true
+Style/RedundantArgument: # (new in 1.4)
+  Enabled: true
+Style/RedundantSelfAssignmentBranch: # (new in 1.19)
+  Enabled: true
+Style/SelectByRegexp: # (new in 1.22)
+  Enabled: true
+Style/StringChars: # (new in 1.12)
+  Enabled: true
+Style/SwapValues: # (new in 1.1)
+  Enabled: true
+Layout/LineEndStringConcatenationIndentation: # (new in 1.18)
+  Enabled: true
+Lint/EmptyInPattern: # (new in 1.16)
+  Enabled: true
+Naming/InclusiveLanguage: # (new in 1.18)
+  Enabled: true
+Style/InPatternThen: # (new in 1.16)
+  Enabled: true
+Style/MultilineInPatternThen: # (new in 1.16)
+  Enabled: true
+Style/QuotedSymbols: # (new in 1.16)
   Enabled: true
 
-Style/SlicingWithRange:
+# ----------------- Rubocop-Rspec forced enablements --------------
+RSpec/ExcessiveDocstringSpacing: # (new in 2.5)
+  Enabled: true
+RSpec/IdenticalEqualityAssertion: # (new in 2.4)
+  Enabled: true
+RSpec/Rails/AvoidSetupHook: # (new in 2.4)
+  Enabled: true
+RSpec/SubjectDeclaration: # (new in 2.5)
   Enabled: true

data/lib/aroundhome_cops.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module AroundhomeCops
-  VERSION = '2.0.0'
+  VERSION = '4.1.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: aroundhome_cops
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 4.1.0
 platform: ruby
 authors:
 - Jan Sandbrink
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-16 00:00:00.000000000 Z
+date: 2021-10-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,28 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.86'
+        version: '1.22'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.86'
+        version: '1.22'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.5'
 description: 
 email:
 - jan.sandbrink@aroundhome.de
@@ -34,6 +48,7 @@ files:
 - ".gitignore"
 - ".gitlab-ci.yml"
 - ".rubocop.yml"
+- ".ruby-version"
 - CHANGELOG.md
 - Gemfile
 - README.md
@@ -51,14 +66,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
+rubygems_version: 3.2.22
 signing_key: 
 specification_version: 4
 summary: Dependency and configuration for rubocop.