armitage-rubocop 1.75.7.6 → 1.81.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cf7d978c3d9a9cff626a35855368888fb5afa7fd1411dafe02d268545378390e
-  data.tar.gz: 31d460e820ce199fd7262146679e6c8bd1cb4de9b7bcd71a9afa38b16179c8b4
+  metadata.gz: '0388d6a056a5183052624bafcbfa3501502c2347d85b1711a99a8505a11a225b'
+  data.tar.gz: a36bc43c295d4df53328d423f03ca8f788e2aef22612c5cab74beb27f8c57fc1
 SHA512:
-  metadata.gz: 474a103d52299a6410e590af8e6efdcf9d3ef296438ad70c1dc7127af2417ca98fe1c9288e2e4d018f5c98d0f60caea4853db46db405a15349ad16b87ce9e10e
-  data.tar.gz: 6b204f4e6b4f20a197436b94626b1c483f5abde75dd3e2e83ad2640581f6607290005ab720388ca6156016e1c16686c612a619c8a54d521c7b660bfdb4d25afe
+  metadata.gz: 989722cb55f92dabe07c69eacc44893ded46f9e946f3ae6f7baca9e8a3b37e72154b97a72696121d82629988153008d4c4bfa1adcd4eeac5829d7cf206ef45e1
+  data.tar.gz: 944c7ec310d1df16ecb2b0567047155951dbd0e61e722157d761a550360ac43ca5a0e0902f1e704ccc2c23b7678d0e4ee7d2cbcc5882b131ae74bf333c4ddcc3

data/Gemfile.lock

@@ -1,65 +1,76 @@
 PATH
   remote: .
   specs:
-    armitage-rubocop (1.75.7.6)
-      rubocop (= 1.75.7)
+    armitage-rubocop (1.81.7)
+      rubocop (= 1.81.7)
       rubocop-capybara (= 2.22.1)
-      rubocop-factory_bot (= 2.27.1)
-      rubocop-on-rbs (= 1.7.0)
-      rubocop-performance (= 1.25.0)
-      rubocop-rails (= 2.32.0)
+      rubocop-factory_bot (= 2.28.0)
+      rubocop-on-rbs (= 1.8.0)
+      rubocop-performance (= 1.26.1)
+      rubocop-rails (= 2.33.4)
       rubocop-rake (= 0.7.1)
-      rubocop-rspec (= 3.6.0)
-      rubocop-rspec_rails (= 2.31.0)
+      rubocop-rspec (= 3.8.0)
+      rubocop-rspec_rails (= 2.32.0)
+      rubocop-thread_safety (= 0.7.3)
+    armitage-rubocop (1.81.7.0)
+      rubocop (= 1.81.7)
+      rubocop-capybara (= 2.22.1)
+      rubocop-factory_bot (= 2.28.0)
+      rubocop-on-rbs (= 1.8.0)
+      rubocop-performance (= 1.26.1)
+      rubocop-rails (= 2.33.4)
+      rubocop-rake (= 0.7.1)
+      rubocop-rspec (= 3.8.0)
+      rubocop-rspec_rails (= 2.32.0)
+      rubocop-thread_safety (= 0.7.3)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (8.0.2)
+    activesupport (8.1.1)
       base64
-      benchmark (>= 0.3)
       bigdecimal
       concurrent-ruby (~> 1.0, >= 1.3.1)
       connection_pool (>= 2.2.5)
       drb
       i18n (>= 1.6, < 2)
+      json
       logger (>= 1.4.2)
       minitest (>= 5.1)
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
     ast (2.4.3)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
+    base64 (0.3.0)
+    bigdecimal (3.3.1)
     coderay (1.1.3)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.3)
+    connection_pool (2.5.4)
     drb (2.2.3)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.12.2)
+    json (2.16.0)
     language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
     logger (1.7.0)
     method_source (1.1.0)
-    minitest (5.25.5)
+    minitest (5.26.1)
     parallel (1.27.0)
-    parser (3.3.8.0)
+    parser (3.3.10.0)
       ast (~> 2.4.1)
       racc
-    prism (1.4.0)
+    prism (1.6.0)
     pry (0.15.2)
       coderay (~> 1.1)
       method_source (~> 1.0)
     racc (1.8.1)
-    rack (3.1.15)
+    rack (3.2.4)
     rainbow (3.1.1)
-    rake (13.2.1)
-    rbs (3.9.4)
+    rake (13.3.1)
+    rbs (3.9.5)
       logger
-    regexp_parser (2.10.0)
-    rubocop (1.75.7)
+    regexp_parser (2.11.3)
+    rubocop (1.81.7)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
@@ -67,28 +78,28 @@ GEM
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.44.0, < 2.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.44.1)
+    rubocop-ast (1.48.0)
       parser (>= 3.3.7.2)
       prism (~> 1.4)
     rubocop-capybara (2.22.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-factory_bot (2.27.1)
+    rubocop-factory_bot (2.28.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-on-rbs (1.7.0)
+    rubocop-on-rbs (1.8.0)
       lint_roller (~> 1.1)
       rbs (~> 3.5)
       rubocop (>= 1.72.1, < 2.0)
       zlib
-    rubocop-performance (1.25.0)
+    rubocop-performance (1.26.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.75.0, < 2.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rails (2.32.0)
+      rubocop-ast (>= 1.47.1, < 2.0)
+    rubocop-rails (2.33.4)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
       rack (>= 1.1)
@@ -97,22 +108,26 @@ GEM
     rubocop-rake (0.7.1)
       lint_roller (~> 1.1)
       rubocop (>= 1.72.1)
-    rubocop-rspec (3.6.0)
+    rubocop-rspec (3.8.0)
       lint_roller (~> 1.1)
-      rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rspec_rails (2.31.0)
+      rubocop (~> 1.81)
+    rubocop-rspec_rails (2.32.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
       rubocop-rspec (~> 3.5)
+    rubocop-thread_safety (0.7.3)
+      lint_roller (~> 1.1)
+      rubocop (~> 1.72, >= 1.72.1)
+      rubocop-ast (>= 1.44.0, < 2.0)
     ruby-progressbar (1.13.0)
     securerandom (0.4.1)
     tzinfo (2.0.6)
       concurrent-ruby (~> 1.0)
-    unicode-display_width (3.1.4)
-      unicode-emoji (~> 4.0, >= 4.0.4)
-    unicode-emoji (4.0.4)
-    uri (1.0.3)
-    zlib (3.2.1)
+    unicode-display_width (3.2.0)
+      unicode-emoji (~> 4.1)
+    unicode-emoji (4.1.0)
+    uri (1.1.1)
+    zlib (3.2.2)
 
 PLATFORMS
   arm64-darwin-24
@@ -125,4 +140,4 @@ DEPENDENCIES
   rake (~> 13.1)
 
 BUNDLED WITH
-   2.6.7
+   2.6.9

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2018-2020 Rustam Ibragimov
+Copyright (c) 2018-2025 Rustam Ibragimov
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/README.md

@@ -63,6 +63,13 @@ inherit_gem:
     - lib/rubocop.rspec.yml
     - lib/rubocop.rake.yml
     - lib/rubocop.rbs.yml # NOTE: if you use RBS
+
+# NOTE: (!for RBS file inclusion!)
+#   - add your rbs files location to <AllCops:Include:> directly
+#     cuz `RBS` department has no working `Include` option at the moment :dunno-why:
+AllCops:
+  Include:
+    - "**/*.rbs" # add your path our use this global default
 ```
 
 ```yaml

data/Rakefile

@@ -13,6 +13,7 @@ require 'rubocop-rake'
 require 'rubocop-capybara'
 require 'rubocop-factory_bot'
 require 'rubocop-on-rbs'
+require 'rubocop-thread_safety'
 
 RuboCop::RakeTask.new(:rubocop) do |t|
   config_path = File.expand_path(File.join('.rubocop.yml'), __dir__)
@@ -25,7 +26,8 @@ RuboCop::RakeTask.new(:rubocop) do |t|
     '--plugin', 'rubocop-rake',
     '--plugin', 'rubocop-capybara',
     '--plugin', 'rubocop-factory_bot',
-    '--plugin', 'rubocop-on-rbs'
+    '--plugin', 'rubocop-on-rbs',
+    '--plugin', 'rubocop-thread_safety'
   ]
 end
 

data/armitage-rubocop.gemspec

@@ -6,7 +6,7 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 Gem::Specification.new do |spec|
   spec.required_ruby_version = '>= 3.3'
 
-  spec.version = '1.75.7.6'
+  spec.version = '1.81.7.0'
 
   spec.name = 'armitage-rubocop'
   spec.license = 'MIT'
@@ -24,15 +24,16 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 1.75.7'
-  spec.add_dependency 'rubocop-performance', '= 1.25.0'
-  spec.add_dependency 'rubocop-rails',       '= 2.32.0'
-  spec.add_dependency 'rubocop-rspec',       '= 3.6.0'
-  spec.add_dependency 'rubocop-rspec_rails', '= 2.31.0'
-  spec.add_dependency 'rubocop-rake',        '= 0.7.1'
-  spec.add_dependency 'rubocop-capybara',    '= 2.22.1'
-  spec.add_dependency 'rubocop-factory_bot', '= 2.27.1'
-  spec.add_dependency 'rubocop-on-rbs',      '= 1.7.0'
+  spec.add_dependency 'rubocop',               '= 1.81.7'
+  spec.add_dependency 'rubocop-performance',   '= 1.26.1'
+  spec.add_dependency 'rubocop-rails',         '= 2.33.4'
+  spec.add_dependency 'rubocop-rspec',         '= 3.8.0'
+  spec.add_dependency 'rubocop-rspec_rails',   '= 2.32.0'
+  spec.add_dependency 'rubocop-rake',          '= 0.7.1'
+  spec.add_dependency 'rubocop-capybara',      '= 2.22.1'
+  spec.add_dependency 'rubocop-factory_bot',   '= 2.28.0'
+  spec.add_dependency 'rubocop-on-rbs',        '= 1.8.0'
+  spec.add_dependency 'rubocop-thread_safety', '= 0.7.3'
 
   spec.add_development_dependency 'bundler', '~> 2.3'
   spec.add_development_dependency 'rake',    '~> 13.1'

data/lib/common/gemspec.yml

@@ -1,3 +1,8 @@
+Gemspec/AttributeAssignment:
+  Enabled: true
+  Include:
+    - '**/*.gemspec'
+
 Gemspec/AddRuntimeDependency:
   Enabled: true
 

data/lib/common/layout.yml

@@ -93,6 +93,9 @@ Layout/DotPosition:
 Layout/ElseAlignment:
   Enabled: true
 
+Layout/EmptyLinesAfterModuleInclusion:
+  Enabled: true
+
 Layout/EmptyComment:
   Enabled: true
   AllowBorderComment: true

data/lib/common/lint.yml

@@ -303,6 +303,13 @@ Lint/PercentStringArray:
 Lint/PercentSymbolArray:
   Enabled: true
 
+Lint/UselessOr:
+  Enabled: true
+
+Lint/UselessDefaultValueArgument:
+  Enabled: true
+  AllowedReceivers: ['Rails.cache']
+
 Lint/UselessDefined:
   Enabled: true
 
@@ -341,6 +348,12 @@ Lint/RefinementImportMethods:
 
 Lint/RedundantSafeNavigation:
   Enabled: true
+  InferNonNilReceiver: false
+  AdditionalNilMethods:
+    - present?
+    - blank?
+    - try
+    - try!
   AllowedMethods:
     - instance_of?
     - kind_of?

data/lib/common/naming.yml

@@ -45,7 +45,14 @@ Naming/MethodName:
     - def
     - super
 
-Naming/PredicateName:
+Naming/PredicateMethod:
+  Enabled: true
+  Mode: conservative
+  AllowedMethods: call
+  AllowBangMethods: false
+  AllowedPatterns: []
+
+Naming/PredicatePrefix:
   Enabled: false
 
 Naming/RescuedExceptionsVariableName:

data/lib/common/rails.yml

@@ -157,6 +157,9 @@ Rails/EnvironmentComparison:
 Rails/Exit:
   Enabled: true
 
+Rails/FindByOrAssignmentMemoization:
+  Enabled: false
+
 Rails/FilePath:
   Enabled: true
   EnforcedStyle: arguments
@@ -237,6 +240,9 @@ Rails/NotNullColumn:
 Rails/OrderById:
   Enabled: false
 
+Rails/OrderArguments:
+  Enabled: false
+
 Rails/Output:
   Enabled: true
 

data/lib/common/style.yml

@@ -20,6 +20,9 @@ Style/AndOr:
   Enabled: false
   EnforcedStyle: always
 
+Style/ArrayIntersectWithSingleElement:
+  Enabled: true
+
 Style/ArrayFirstLast:
   Enabled: false
 
@@ -108,6 +111,9 @@ Style/ClassVars:
 Style/ConcatArrayLiterals:
   Enabled: false # NOTE: it is totally unsafe
 
+Style/CollectionQuerying:
+  Enabled: false # TODO: may be set to true
+
 Style/CollectionCompact:
   Enabled: true
 
@@ -218,6 +224,10 @@ Style/EmptyMethod:
   Enabled: true
   EnforcedStyle: compact
 
+Style/EmptyStringInsideInterpolation:
+  Enabled: true
+  EnforcedStyle: trailing_conditional
+
 Style/EndlessMethod:
   Enabled: true
   EnforcedStyle: allow_single_line
@@ -254,6 +264,7 @@ Style/ExplicitBlockArgument:
 
 Style/FetchEnvVar:
   Enabled: true
+  DefaultToNil: true
 
 Style/FileEmpty:
   Enabled: true
@@ -555,11 +566,12 @@ Style/Not:
   Enabled: true
 
 Style/NumberedParameters:
-  Enabled: false
+  Enabled: true
+  EnforcedStyle: allow_single_line
 
 Style/NumberedParametersLimit:
-  Max: 1_000_000
   Enabled: true
+  Max: 1_000_000
 
 Style/NumericLiteralPrefix:
   Enabled: true
@@ -635,6 +647,9 @@ Style/RandomWithOffset:
 Style/ReturnNilInPredicateMethodDefinition:
   Enabled: true
 
+Style/RedundantArrayFlatten:
+  Enabled: true
+
 Style/RedundantInterpolationUnfreeze:
   Enabled: true
 

data/lib/common/thread_safety.yml

@@ -0,0 +1,47 @@
+ThreadSafety/ClassAndModuleAttributes:
+  # NOTE:
+  #   - we should not "block" this behaviour if we have a lot of expirinece with async programming;
+  #   - i write a lot of DSL and architecture frameworks;
+  #   - so i manage this vua blocking privitives;
+  Enabled: false
+  ActiveSupportClassAttributeAllowed: false
+
+ThreadSafety/ClassInstanceVariable:
+  # NOTE:
+  #   - we should not "block" this behaviour if we have a lot of expirinece with async programming;
+  #   - i write a lot of DSL and architecture frameworks;
+  #   - so i manage this vua blocking privitives;
+  Enabled: false
+
+ThreadSafety/DirChdir:
+  # NOTE:
+  #   - we should not "block" this behaviour if we have a lot of expirinece with async programming;
+  #   - i write a lot of DSL and architecture frameworks;
+  #   - so i manage this vua blocking privitives;
+  Enabled: false
+  AllowCallWithBlock: true
+
+ThreadSafety/MutableClassInstanceVariable:
+  # NOTE:
+  #   - we should not "block" this behaviour if we have a lot of expirinece with async programming;
+  #   - i write a lot of DSL and architecture frameworks;
+  #   - so i manage this vua blocking privitives;
+  Enabled: false
+  EnforcedStyle: literals
+
+# NOTE: wat?
+ThreadSafety/NewThread:
+  Enabled: false
+
+ThreadSafety/RackMiddlewareInstanceVariable:
+  # NOTE:
+  #   - we should not "block" this behaviour if we have a lot of expirinece with async programming;
+  #   - i write a lot of DSL and architecture frameworks;
+  #   - so i manage this vua blocking privitives;
+  Enabled: false
+  Include:
+    - app/middleware/**/*.rb
+    - lib/middleware/**/*.rb
+    - app/middlewares/**/*.rb
+    - lib/middlewares/**/*.rb
+  AllowedIdentifiers: []

data/lib/rbs/lint.yml

@@ -7,6 +7,12 @@ RBS/Lint/AmbiguousOperatorPrecedence:
 RBS/Lint/DuplicateOverload:
   Enabled: true
 
+RBS/Lint/DuplicateAnnotation:
+  Enabled: true
+
+RBS/Lint/ImplicitlyReturnsNil:
+  Enabled: true
+
 RBS/Lint/LiteralIntersection:
   Enabled: true
 

data/lib/rspec/rails.yml

@@ -7,6 +7,9 @@ RSpecRails/AvoidSetupHook:
 RSpecRails/HaveHttpStatus:
   Enabled: false
 
+RSpecRails/HttpStatusNameConsistency:
+  Enabled: true
+
 RSpecRails/InferredSpecType:
   Enabled: false
 

data/lib/rspec/rspec.yml

@@ -184,6 +184,9 @@ RSpec/LeadingSubject:
 RSpec/LeakyConstantDeclaration:
   Enabled: true
 
+RSpec/LeakyLocalVariable:
+  Enabled: true
+
 RSpec/LetBeforeExamples:
   Enabled: true
 

data/lib/rubocop.general.yml

@@ -1,4 +1,6 @@
-plugins: rubocop-performance
+plugins:
+  - rubocop-performance
+  - rubocop-thread_safety
 
 inherit_from:
   - ./common/bundler.yml
@@ -11,6 +13,7 @@ inherit_from:
   - ./common/security.yml
   - ./common/style.yml
   - ./common/migration.yml
+  - ./common/thread_safety.yml
 
 AllCops:
   DefaultFormatter: progress

data/lib/rubocop.rbs.yml

@@ -8,5 +8,6 @@ inherit_from:
 
 RBS:
   Enabled: true
+  # NOTE: include option does not work at the moment but we have prepared in advance;
   Include:
     - "**/*.rbs"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.75.7.6
+  version: 1.81.7.0
 platform: ruby
 authors:
 - Rustam Ibragimov
@@ -15,70 +15,70 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.75.7
+        version: 1.81.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.75.7
+        version: 1.81.7
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.25.0
+        version: 1.26.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.25.0
+        version: 1.26.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.32.0
+        version: 2.33.4
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.32.0
+        version: 2.33.4
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.6.0
+        version: 3.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.6.0
+        version: 3.8.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.31.0
+        version: 2.32.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.31.0
+        version: 2.32.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -113,28 +113,42 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.27.1
+        version: 2.28.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.27.1
+        version: 2.28.0
 - !ruby/object:Gem::Dependency
   name: rubocop-on-rbs
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.8.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.8.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-thread_safety
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.7.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 0.7.3
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -208,6 +222,7 @@ files:
 - lib/common/rake.yml
 - lib/common/security.yml
 - lib/common/style.yml
+- lib/common/thread_safety.yml
 - lib/rbs/layout.yml
 - lib/rbs/lint.yml
 - lib/rbs/style.yml
@@ -238,7 +253,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A set of rubocop settings
 test_files: []