armitage-rubocop 1.23.0 → 1.26.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 55bed071bbf70dccdff35074b5a97ab60a3cf71d639def4d9db4f8c13130f508
-  data.tar.gz: 6ca102e44ec17a96852e1ec8d65a325d9f5a502c0b0c1239706e246e17f4f5fa
+  metadata.gz: c85fdaa3e491845353e14bb772c02c5b0aa4eb4aeca60059be9cec94175884ea
+  data.tar.gz: 6586ec4070318fb4da748321e0be3e9efc1254b7241398ab9addab33461b8d23
 SHA512:
-  metadata.gz: 7bb7405b53235b06fedc9685094b9468b45eb7d2b7d9b08e42ca81e7f846e5fd349ee6e648189abdb4a35df08b8accfff1d8b6253efe09b51518d68d382adda8
-  data.tar.gz: 7a00d9eb867fa8cb747997d38c547bed288a694735cc34d7779af1476c13baf992856d41cb98b8a809608a1bf866e1abaa9c40d040bf6734b3b0f4f3eb56ed50
+  metadata.gz: e3f90b27fca2d902da00b86cf83eb8eed9f53f20ff7fdfb3f0211e197df7fbae148fbeb0ef0d24f533939794663134c8f392bf7a174ce56902d62c31592bb7b8
+  data.tar.gz: 0a714cea6fd4cec5a91cf992f30ea2fd5be9534d5164d11bc7846b57cdee8ac61c6c92186bb4070fdd97bf4f7dcee97249d27a73fa7e2fd76873724441ee3547

data/Gemfile.lock

@@ -1,76 +1,74 @@
 PATH
   remote: .
   specs:
-    armitage-rubocop (1.23.0)
-      rubocop (= 1.23.0)
-      rubocop-performance (= 1.12.0)
-      rubocop-rails (= 2.12.4)
+    armitage-rubocop (1.26.1.1)
+      rubocop (= 1.26.1)
+      rubocop-performance (= 1.13.3)
+      rubocop-rails (= 2.14.2)
       rubocop-rake (= 0.6.0)
-      rubocop-rspec (= 2.6.0)
+      rubocop-rspec (= 2.9.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.4.1)
+    activesupport (7.0.2.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
     ast (2.4.2)
     coderay (1.1.3)
-    concurrent-ruby (1.1.9)
-    i18n (1.8.11)
+    concurrent-ruby (1.1.10)
+    i18n (1.10.0)
       concurrent-ruby (~> 1.0)
     method_source (1.0.0)
-    minitest (5.14.4)
-    parallel (1.21.0)
-    parser (3.0.3.1)
+    minitest (5.15.0)
+    parallel (1.22.1)
+    parser (3.1.1.0)
       ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
     rack (2.2.3)
-    rainbow (3.0.0)
+    rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.1.1)
+    regexp_parser (2.2.1)
     rexml (3.2.5)
-    rubocop (1.23.0)
+    rubocop (1.26.1)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
       rexml
-      rubocop-ast (>= 1.12.0, < 2.0)
+      rubocop-ast (>= 1.16.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.13.0)
-      parser (>= 3.0.1.1)
-    rubocop-performance (1.12.0)
+    rubocop-ast (1.16.0)
+      parser (>= 3.1.1.0)
+    rubocop-performance (1.13.3)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.12.4)
+    rubocop-rails (2.14.2)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.7.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.6.0)
+    rubocop-rspec (2.9.0)
       rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.1.0)
-    zeitwerk (2.5.1)
 
 PLATFORMS
-  x86_64-darwin-21
+  arm64-darwin-21
 
 DEPENDENCIES
   armitage-rubocop!
-  bundler (~> 2.2)
+  bundler (~> 2.3)
   pry (~> 0.14)
   rake (~> 13.0)
 
 BUNDLED WITH
-   2.2.31
+   2.3.10

data/Rakefile

@@ -22,7 +22,6 @@ end
 ARMITAGE_RUBOCOP_PATH = Pathname.new(__FILE__).join('../.rubocop.yml')
 NON_CHECKABLE_COPS = %w[Rails].freeze # NOTE: Global "Rails" cop has only `Enabled` option
 
-# rubocop:disable Rails/RakeEnvironment
 namespace :armitage_rubocop do
   desc 'Full armitage-rubocop build (code style, cops validation, yaml validation)'
   task :build do
@@ -93,6 +92,4 @@ namespace :armitage_rubocop do
     end
   end
 end
-# rubocop:enable Rails/RakeEnvironment
-
 task default: :rubocop

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '1.23.0'
+  spec.version     = '1.26.1.1'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,13 +22,13 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 1.23.0'
-  spec.add_dependency 'rubocop-performance', '= 1.12.0'
-  spec.add_dependency 'rubocop-rails',       '= 2.12.4'
-  spec.add_dependency 'rubocop-rspec',       '= 2.6.0'
+  spec.add_dependency 'rubocop',             '= 1.26.1'
+  spec.add_dependency 'rubocop-performance', '= 1.13.3'
+  spec.add_dependency 'rubocop-rails',       '= 2.14.2'
+  spec.add_dependency 'rubocop-rspec',       '= 2.9.0'
   spec.add_dependency 'rubocop-rake',        '= 0.6.0'
 
-  spec.add_development_dependency 'bundler', '~> 2.2'
+  spec.add_development_dependency 'bundler', '~> 2.3'
   spec.add_development_dependency 'rake',    '~> 13.0'
   spec.add_development_dependency 'pry',     '~> 0.14'
 end

data/lib/common/layout.yml

@@ -35,7 +35,7 @@ Lint/RequireRelativeSelfPath:
 
 Layout/RedundantLineBreak:
   InspectBlocks: false
-  Enabled: true
+  Enabled: false
 
 Layout/BlockAlignment:
   Enabled: true
@@ -74,6 +74,7 @@ Layout/ClosingParenthesisIndentation:
 
 Layout/CommentIndentation:
   Enabled: true
+  AllowForAlignment: true
 
 Layout/ConditionPosition:
   Enabled: true

data/lib/common/naming.yml

@@ -47,6 +47,11 @@ Naming/RescuedExceptionsVariableName:
   Enabled: true
   PreferredName: error
 
+Naming/BlockForwarding:
+  Enabled: true
+  EnforcedStyle: explicit
+  BlockForwardingName: block
+
 Naming/BlockParameterName:
   Enabled: true
   MinNameLength: 1

data/lib/common/performance.yml

@@ -135,6 +135,9 @@ Performance/StartWith:
   Enabled: true
   AutoCorrect: false
 
+Performance/StringIdentifierArgument:
+  Enabled: true
+
 Performance/StringInclude:
   Enabled: true
 
@@ -144,6 +147,7 @@ Performance/StringReplacement:
 Performance/Sum:
   Enabled: true
   AutoCorrect: true
+  OnlySumOrWithInitialValue: false
 
 Performance/TimesMap:
   Enabled: true

data/lib/common/rails.yml

@@ -1,6 +1,9 @@
 Rails/AddColumnIndex:
   Enabled: false # NOTE: cop works incorrectly with `Sequel` (sequel supports :index in add_column)
 
+Rails/ActionControllerTestCase:
+  Enabled: true
+
 Rails/ActionFilter:
   Enabled: true
   EnforcedStyle: action
@@ -78,9 +81,24 @@ Rails/BulkChangeTable:
 Rails/CreateTableWithTimestamps:
   Enabled: false
 
+Rails/CompactBlank:
+  Enabled: false
+
 Rails/ContentTag:
   Enabled: true
 
+Rails/DuplicateAssociation:
+  Enabled: true
+
+Rails/DuplicateScope:
+  Enabled: true
+
+Rails/DurationArithmetic:
+  Enabled: false
+
+Rails/DeprecatedActiveModelErrorsMethods:
+  Enabled: true
+
 Rails/Date:
   Enabled: true
   EnforcedStyle: flexible
@@ -149,6 +167,15 @@ Rails/HttpPositionalArguments:
 Rails/HttpStatus:
   Enabled: false
 
+Rails/I18nLocaleTexts:
+  Enabled: false
+
+Rails/I18nLazyLookup:
+  Enabled: false
+
+Rails/MigrationClassName:
+  Enabled: true
+
 Rails/I18nLocaleAssignment:
   Enabled: false
 
@@ -217,6 +244,9 @@ Rails/Presence:
 Rails/Present:
   Enabled: true
 
+Rails/RootJoinChain:
+  Enabled: true
+
 Rails/ReadWriteAttribute:
   Enabled: true
 
@@ -225,6 +255,9 @@ Rails/RedundantAllowNil:
   Include:
     - app/models/**/*.rb
 
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Enabled: true
+
 Rails/RedundantForeignKey:
   Enabled: false
 
@@ -243,7 +276,6 @@ Rails/RefuteMethods:
 
 Rails/RelativeDateConstant:
   Enabled: true
-  AutoCorrect: false
 
 Rails/RenderInline:
   Enabled: false
@@ -272,6 +304,9 @@ Rails/SaveBang:
 Rails/ScopeArgs:
   Enabled: true
 
+Rails/SchemaComment:
+  Enabled: false
+
 Rails/ShortI18n:
   Enabled: true
   EnforcedStyle: conservative
@@ -285,6 +320,9 @@ Rails/SquishedSQLHeredocs:
 Rails/RedundantTravelBack:
   Enabled: false # NOTE: can affect the readability
 
+Rails/TableNameAssignment:
+  Enabled: false
+
 Rails/TimeZone:
   Enabled: true
   EnforcedStyle: flexible
@@ -292,6 +330,9 @@ Rails/TimeZone:
 Rails/TimeZoneAssignment:
   Enabled: false
 
+Rails/TransactionExitStatement:
+  Enabled: true
+
 Rails/UniqBeforePluck:
   Enabled: true
   EnforcedStyle: conservative

data/lib/common/style.yml

@@ -206,6 +206,12 @@ Style/ExponentialNotation:
 Style/ExplicitBlockArgument:
   Enabled: true
 
+Style/FileRead:
+  Enabled: false
+
+Style/FileWrite:
+  Enabled: false
+
 Style/FloatDivision:
   Enabled: false
 
@@ -263,6 +269,7 @@ Style/HashSyntax:
   EnforcedStyle: ruby19
   UseHashRocketsWithSymbolValues: false
   PreferHashRocketsForNonAlnumEndingSymbols: false
+  EnforcedShorthandSyntax: either
 
 Style/HashTransformKeys:
   Enabled: false
@@ -320,6 +327,9 @@ Style/LambdaCall:
 Style/LineEndConcatenation:
   Enabled: true
 
+Style/MapToHash:
+  Enabled: true
+
 Style/MethodCallWithArgsParentheses:
   Enabled: false # NOTE: experimental!
   EnforcedStyle: require_parentheses
@@ -405,6 +415,9 @@ Style/NegatedUnless:
 Style/NegatedWhile:
   Enabled: true
 
+Style/NestedFileDirname:
+  Enabled: false # NOTE: switch to "true" if you work with Ruby 3.1 or higher
+
 Style/NestedModifier:
   Enabled: true
 
@@ -446,7 +459,9 @@ Style/NumericLiteralPrefix:
   EnforcedOctalStyle: zero_with_o
 
 Style/NumericLiterals:
-  Enabled: false
+  Enabled: true
+  Strict: false
+  AllowedNumbers: []
 
 Style/NumericPredicate:
   Enabled: false # strongly situative cop

data/lib/rspec/factory_bot.yml

@@ -7,3 +7,6 @@ RSpec/FactoryBot/CreateList:
 
 RSpec/FactoryBot/FactoryClassName:
   Enabled: true
+
+RSpec/FactoryBot/SyntaxMethods:
+  Enabled: true

data/lib/rspec/rspec.yml

@@ -13,9 +13,15 @@ RSpec/AroundBlock:
 RSpec/Be:
   Enabled: true
 
+RSpec/BeNil:
+  Enabled: true
+
 RSpec/BeEql:
   Enabled: true
 
+RSpec/BeEq:
+  Enabled: true
+
 RSpec/BeforeAfterAll:
   Enabled: false
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.23.0
+  version: 1.26.1.1
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-01 00:00:00.000000000 Z
+date: 2022-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.23.0
+        version: 1.26.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.23.0
+        version: 1.26.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 1.13.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 1.13.3
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.12.4
+        version: 2.14.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.12.4
+        version: 2.14.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.9.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -180,7 +180,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.10
 signing_key:
 specification_version: 4
 summary: A set of rubocop settings