armitage-rubocop 1.23.0.1 → 1.30.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e96e705fd52bc3f648c1f2d683b0dbb01bd2b34051e44d582f71e188102a7021
-  data.tar.gz: 9cec62a001403537f39ce80c6bc8bbee399c5a7ad388841ae05d726d3b6be94f
+  metadata.gz: 39013c8a88384352b39977d079478943d9c065285c4b1c07d00d2af445376af9
+  data.tar.gz: cdb905adefa131cc4a39ba937e054b1cd7c061869035c62b99054ff91b2f998f
 SHA512:
-  metadata.gz: 89ceeffd263db2383a930bc5d3682cb5fbc9aabb7d1c08fe667e5bd2ff9e3772acc13bb9b8191467971457c4a950a41f6bf587afae1982c26dadbdc7c330aa14
-  data.tar.gz: d6edb6d59f3223f06b9cacf5065c903a805376272f8a906ed660c13523f3fe31f74d163dc93fbbf718f03b75c20842d9b084db8c03a31f4a791daf3b03b3f16e
+  metadata.gz: '083bbf5e7157666e2968222aa058ea9fa39a5bbf73ba9df7334057602e9a6c88dd43f659a1d8486e463779399c09165ef71837cd2fc026859782936007746b3c'
+  data.tar.gz: ae1000b825e11b7b631ecc30fe8ac4fe61329494ddd66017cadfc02c0f58e7f4f8d3dbe2c1c1c29a03c5379f64a85c55c44423fde9f71815ffd3441891680dde

data/Gemfile.lock

@@ -1,76 +1,74 @@
 PATH
   remote: .
   specs:
-    armitage-rubocop (1.23.0)
-      rubocop (= 1.23.0)
-      rubocop-performance (= 1.12.0)
-      rubocop-rails (= 2.12.4)
+    armitage-rubocop (1.26.1.1)
+      rubocop (= 1.30.1)
+      rubocop-performance (= 1.14.2)
+      rubocop-rails (= 2.15.0)
       rubocop-rake (= 0.6.0)
-      rubocop-rspec (= 2.6.0)
+      rubocop-rspec (= 2.11.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    activesupport (6.1.4.1)
+    activesupport (7.0.3)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       i18n (>= 1.6, < 2)
       minitest (>= 5.1)
       tzinfo (~> 2.0)
-      zeitwerk (~> 2.3)
     ast (2.4.2)
     coderay (1.1.3)
-    concurrent-ruby (1.1.9)
-    i18n (1.8.11)
+    concurrent-ruby (1.1.10)
+    i18n (1.10.0)
       concurrent-ruby (~> 1.0)
     method_source (1.0.0)
-    minitest (5.14.4)
-    parallel (1.21.0)
-    parser (3.0.3.1)
+    minitest (5.16.0)
+    parallel (1.22.1)
+    parser (3.1.2.0)
       ast (~> 2.4.1)
     pry (0.14.1)
       coderay (~> 1.1)
       method_source (~> 1.0)
-    rack (2.2.3)
-    rainbow (3.0.0)
+    rack (2.2.3.1)
+    rainbow (3.1.1)
     rake (13.0.6)
-    regexp_parser (2.1.1)
+    regexp_parser (2.5.0)
     rexml (3.2.5)
-    rubocop (1.23.0)
+    rubocop (1.30.1)
       parallel (~> 1.10)
-      parser (>= 3.0.0.0)
+      parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 1.8, < 3.0)
-      rexml
-      rubocop-ast (>= 1.12.0, < 2.0)
+      rexml (>= 3.2.5, < 4.0)
+      rubocop-ast (>= 1.18.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 1.4.0, < 3.0)
-    rubocop-ast (1.13.0)
-      parser (>= 3.0.1.1)
-    rubocop-performance (1.12.0)
+    rubocop-ast (1.18.0)
+      parser (>= 3.1.1.0)
+    rubocop-performance (1.14.2)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
-    rubocop-rails (2.12.4)
+    rubocop-rails (2.15.0)
       activesupport (>= 4.2.0)
       rack (>= 1.1)
       rubocop (>= 1.7.0, < 2.0)
     rubocop-rake (0.6.0)
       rubocop (~> 1.0)
-    rubocop-rspec (2.6.0)
+    rubocop-rspec (2.11.0)
       rubocop (~> 1.19)
     ruby-progressbar (1.11.0)
     tzinfo (2.0.4)
       concurrent-ruby (~> 1.0)
     unicode-display_width (2.1.0)
-    zeitwerk (2.5.1)
 
 PLATFORMS
-  x86_64-darwin-21
+  arm64-darwin-21
 
 DEPENDENCIES
   armitage-rubocop!
-  bundler (~> 2.2)
+  bundler (~> 2.3)
   pry (~> 0.14)
   rake (~> 13.0)
 
 BUNDLED WITH
-   2.2.31
+   2.3.15

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '1.23.0.1'
+  spec.version     = '1.30.1'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,13 +22,13 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 1.23.0'
-  spec.add_dependency 'rubocop-performance', '= 1.12.0'
-  spec.add_dependency 'rubocop-rails',       '= 2.12.4'
-  spec.add_dependency 'rubocop-rspec',       '= 2.6.0'
+  spec.add_dependency 'rubocop',             '= 1.30.1'
+  spec.add_dependency 'rubocop-performance', '= 1.14.2'
+  spec.add_dependency 'rubocop-rails',       '= 2.15.0'
+  spec.add_dependency 'rubocop-rspec',       '= 2.11.0'
   spec.add_dependency 'rubocop-rake',        '= 0.6.0'
 
-  spec.add_development_dependency 'bundler', '~> 2.2'
+  spec.add_development_dependency 'bundler', '~> 2.3'
   spec.add_development_dependency 'rake',    '~> 13.0'
   spec.add_development_dependency 'pry',     '~> 0.14'
 end

data/lib/common/gemspec.yml

@@ -1,3 +1,15 @@
+Gemspec/DeprecatedAttributeAssignment:
+  Enabled: true
+  Include:
+    - '**/*.gemspec'
+
+Gemspec/DependencyVersion:
+  Enabled: true
+  EnforcedStyle: required
+  Include:
+    - '**/*.gemspec'
+  AllowedGems: []
+
 Gemspec/DateAssignment:
   Enabled: true
   Include:

data/lib/common/layout.yml

@@ -74,6 +74,7 @@ Layout/ClosingParenthesisIndentation:
 
 Layout/CommentIndentation:
   Enabled: true
+  AllowForAlignment: true
 
 Layout/ConditionPosition:
   Enabled: true
@@ -219,7 +220,7 @@ Layout/IndentationConsistency:
 Layout/IndentationWidth:
   Enabled: true
   Width: 2
-  IgnoredPatterns: []
+  AllowedPatterns: []
 
 Layout/InitialIndentation:
   Enabled: true
@@ -242,7 +243,7 @@ Layout/LineLength:
     - http
     - https
   IgnoreCopDirectives: false
-  IgnoredPatterns: []
+  AllowedPatterns: []
   Exclude:
     - Gemfile
 

data/lib/common/lint.yml

@@ -79,6 +79,7 @@ Lint/DuplicateElsifCondition:
 
 Lint/DuplicateRequire:
   Enabled: true
+  AutoCorrect: true
 
 Lint/DuplicateRegexpCharacterClassElement:
   Enabled: true
@@ -271,6 +272,9 @@ Lint/RandOne:
 Lint/RedundantDirGlobSort:
   Enabled: true
 
+Lint/RefinementImportMethods:
+  Enabled: true
+
 Lint/RedundantSafeNavigation:
   Enabled: true
   AllowedMethods:
@@ -410,12 +414,8 @@ Lint/UselessAccessModifier:
 Lint/UselessAssignment:
   Enabled: true
 
-Lint/UselessElseWithoutRescue:
-  Enabled: true
-
 Lint/UselessMethodDefinition:
   Enabled: true
-  AllowComments: true
 
 Lint/UselessSetterCall:
   Enabled: true

data/lib/common/naming.yml

@@ -47,6 +47,11 @@ Naming/RescuedExceptionsVariableName:
   Enabled: true
   PreferredName: error
 
+Naming/BlockForwarding:
+  Enabled: true
+  EnforcedStyle: explicit
+  BlockForwardingName: block
+
 Naming/BlockParameterName:
   Enabled: true
   MinNameLength: 1
@@ -78,7 +83,7 @@ Naming/VariableName:
 
 Naming/VariableNumber:
   Enabled: true
-  EnforcedStyle: snake_case
+  EnforcedStyle: normalcase
   CheckMethodNames: true
   CheckSymbols: true
   AllowedIdentifiers: []

data/lib/common/performance.yml

@@ -135,6 +135,9 @@ Performance/StartWith:
   Enabled: true
   AutoCorrect: false
 
+Performance/StringIdentifierArgument:
+  Enabled: true
+
 Performance/StringInclude:
   Enabled: true
 
@@ -144,6 +147,7 @@ Performance/StringReplacement:
 Performance/Sum:
   Enabled: true
   AutoCorrect: true
+  OnlySumOrWithInitialValue: false
 
 Performance/TimesMap:
   Enabled: true

data/lib/common/rails.yml

@@ -1,6 +1,9 @@
 Rails/AddColumnIndex:
   Enabled: false # NOTE: cop works incorrectly with `Sequel` (sequel supports :index in add_column)
 
+Rails/ActionControllerTestCase:
+  Enabled: true
+
 Rails/ActionFilter:
   Enabled: true
   EnforcedStyle: action
@@ -78,9 +81,28 @@ Rails/BulkChangeTable:
 Rails/CreateTableWithTimestamps:
   Enabled: false
 
+Rails/CompactBlank:
+  Enabled: false
+
 Rails/ContentTag:
   Enabled: true
 
+Rails/DotSeparatedKeys:
+  Enabled: true
+
+Rails/DuplicateAssociation:
+  Enabled: true
+
+Rails/DuplicateScope:
+  Enabled: true
+
+Rails/DurationArithmetic:
+  Enabled: false
+
+Rails/DeprecatedActiveModelErrorsMethods:
+  Enabled: true
+  AutoCorrect: true
+
 Rails/Date:
   Enabled: true
   EnforcedStyle: flexible
@@ -149,6 +171,15 @@ Rails/HttpPositionalArguments:
 Rails/HttpStatus:
   Enabled: false
 
+Rails/I18nLocaleTexts:
+  Enabled: false
+
+Rails/I18nLazyLookup:
+  Enabled: false
+
+Rails/MigrationClassName:
+  Enabled: true
+
 Rails/I18nLocaleAssignment:
   Enabled: false
 
@@ -217,6 +248,12 @@ Rails/Presence:
 Rails/Present:
   Enabled: true
 
+Rails/RootPublicPath:
+  Enabled: true
+
+Rails/RootJoinChain:
+  Enabled: true
+
 Rails/ReadWriteAttribute:
   Enabled: true
 
@@ -225,6 +262,9 @@ Rails/RedundantAllowNil:
   Include:
     - app/models/**/*.rb
 
+Rails/RedundantPresenceValidationOnBelongsTo:
+  Enabled: true
+
 Rails/RedundantForeignKey:
   Enabled: false
 
@@ -243,7 +283,6 @@ Rails/RefuteMethods:
 
 Rails/RelativeDateConstant:
   Enabled: true
-  AutoCorrect: false
 
 Rails/RenderInline:
   Enabled: false
@@ -272,6 +311,9 @@ Rails/SaveBang:
 Rails/ScopeArgs:
   Enabled: true
 
+Rails/SchemaComment:
+  Enabled: false
+
 Rails/ShortI18n:
   Enabled: true
   EnforcedStyle: conservative
@@ -282,9 +324,15 @@ Rails/SkipsModelValidations:
 Rails/SquishedSQLHeredocs:
   Enabled: true
 
+Rails/StripHeredoc:
+  Enabled: true
+
 Rails/RedundantTravelBack:
   Enabled: false # NOTE: can affect the readability
 
+Rails/TableNameAssignment:
+  Enabled: false
+
 Rails/TimeZone:
   Enabled: true
   EnforcedStyle: flexible
@@ -292,6 +340,12 @@ Rails/TimeZone:
 Rails/TimeZoneAssignment:
   Enabled: false
 
+Rails/ToFormattedS:
+  Enabled: true
+
+Rails/TransactionExitStatement:
+  Enabled: true
+
 Rails/UniqBeforePluck:
   Enabled: true
   EnforcedStyle: conservative

data/lib/common/security.yml

@@ -1,3 +1,6 @@
+Security/CompoundHash:
+  Enabled: false
+
 Security/Eval:
   Enabled: false
 

data/lib/common/style.yml

@@ -189,6 +189,9 @@ Style/EndBlock:
   Enabled: true
   AutoCorrect: true
 
+Style/EnvHome:
+  Enabled: true
+
 Style/EvalWithLocation:
   Enabled: true
   AutoCorrect: true
@@ -206,6 +209,15 @@ Style/ExponentialNotation:
 Style/ExplicitBlockArgument:
   Enabled: true
 
+Style/FetchEnvVar:
+  Enabled: false
+
+Style/FileRead:
+  Enabled: false
+
+Style/FileWrite:
+  Enabled: false
+
 Style/FloatDivision:
   Enabled: false
 
@@ -238,6 +250,7 @@ Style/GlobalStdStream:
 Style/GuardClause:
   Enabled: false
   MinBodyLength: 1
+  AllowConsecutiveConditionals: false
 
 Style/HashAsLastArrayItem:
   Enabled: true
@@ -263,6 +276,7 @@ Style/HashSyntax:
   EnforcedStyle: ruby19
   UseHashRocketsWithSymbolValues: false
   PreferHashRocketsForNonAlnumEndingSymbols: false
+  EnforcedShorthandSyntax: either
 
 Style/HashTransformKeys:
   Enabled: false
@@ -320,6 +334,12 @@ Style/LambdaCall:
 Style/LineEndConcatenation:
   Enabled: true
 
+Style/MapCompactWithConditionalBlock:
+  Enabled: true
+
+Style/MapToHash:
+  Enabled: true
+
 Style/MethodCallWithArgsParentheses:
   Enabled: false # NOTE: experimental!
   EnforcedStyle: require_parentheses
@@ -405,6 +425,9 @@ Style/NegatedUnless:
 Style/NegatedWhile:
   Enabled: true
 
+Style/NestedFileDirname:
+  Enabled: false # NOTE: switch to "true" if you work with Ruby 3.1 or higher
+
 Style/NestedModifier:
   Enabled: true
 
@@ -446,7 +469,9 @@ Style/NumericLiteralPrefix:
   EnforcedOctalStyle: zero_with_o
 
 Style/NumericLiterals:
-  Enabled: false
+  Enabled: true
+  Strict: false
+  AllowedNumbers: []
 
 Style/NumericPredicate:
   Enabled: false # strongly situative cop
@@ -454,6 +479,10 @@ Style/NumericPredicate:
   AutoCorrect: true
   IgnoredMethods: []
 
+Style/ObjectThen:
+  Enabled: true
+  EnforcedStyle: then
+
 Style/OneLineConditional:
   Enabled: true
 
@@ -521,6 +550,10 @@ Style/RedundantFetchBlock:
   Enabled: true
   SafeForConstants: true
 
+Style/RedundantInitialize:
+  Enabled: true
+  AllowComments: true
+
 Style/RedundantRegexpCharacterClass:
   Enabled: true
 
@@ -567,6 +600,7 @@ Style/RedundantSelfAssignmentBranch:
 Style/SafeNavigation:
   Enabled: true
   ConvertCodeThatCanStartToReturnNil: false
+  MaxChainLength: 3
 
 Style/Sample:
   Enabled: true
@@ -605,6 +639,8 @@ Style/SlicingWithRange:
 
 Style/SpecialGlobalVars:
   Enabled: true
+  RequireEnglish: true
+  EnforcedStyle: use_english_names
 
 Style/StaticClass:
   Enabled: true
@@ -653,11 +689,12 @@ Style/SymbolLiteral:
   Enabled: true
 
 Style/SymbolProc:
+  Enabled: true
   AllowMethodsWithArguments: true
+  AllowComments: false
   IgnoredMethods:
     - respond_to
     - define_method
-  Enabled: true
 
 Style/SwapValues:
   Enabled: true

data/lib/rspec/factory_bot.yml

@@ -7,3 +7,6 @@ RSpec/FactoryBot/CreateList:
 
 RSpec/FactoryBot/FactoryClassName:
   Enabled: true
+
+RSpec/FactoryBot/SyntaxMethods:
+  Enabled: true

data/lib/rspec/rspec.yml

@@ -13,8 +13,12 @@ RSpec/AroundBlock:
 RSpec/Be:
   Enabled: true
 
+RSpec/BeNil:
+  Enabled: false
+  EnforcedStyle: be
+
 RSpec/BeEql:
-  Enabled: true
+  Enabled: false
 
 RSpec/BeforeAfterAll:
   Enabled: false
@@ -263,6 +267,10 @@ RSpec/VerifiedDoubles:
   IgnoreNameless: true
   IgnoreSymbolicNames: false
 
+RSpec/VerifiedDoubleReference:
+  Enabled: true
+  EnforcedStyle: constant
+
 RSpec/VoidExpect:
   Enabled: true
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.23.0.1
+  version: 1.30.1
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-01 00:00:00.000000000 Z
+date: 2022-06-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.23.0
+        version: 1.30.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.23.0
+        version: 1.30.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 1.14.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.12.0
+        version: 1.14.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.12.4
+        version: 2.15.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.12.4
+        version: 2.15.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.11.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.11.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -86,14 +86,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '2.3'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: '2.3'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -180,7 +180,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.22
+rubygems_version: 3.3.11
 signing_key:
 specification_version: 4
 summary: A set of rubocop settings