armitage-rubocop 0.91.0 → 1.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 723ccba176c674a8509ad111fa3c094874c8b934665716cd0580c7d687548055
-  data.tar.gz: ce5930d7bc8bee0567d54a1a04663ba07f67efd9b35ce0620bd7a73ca79d7ccc
+  metadata.gz: fea71e911b6cc9479c86d2437befcf1e73c435da8faac6925aea6fd42bea49a0
+  data.tar.gz: b3668511d94edc22244f8103914722cc960ebf0a1e8d7af1358d3639aa32dbba
 SHA512:
-  metadata.gz: 2c20f74575db7185331158a3b796744131879b00ffc73ee4599a7f9768cc9fc4d82ca27122b39f8b54779ee8ecbb873f03f9dc4a96b618e67d1de119b82dc363
-  data.tar.gz: 61a3b2973c1518fb8a38e07814cc7bbbff4ec942e6fccda5cf262ae1694c4b2c1cd08addc9aa38f272dabe4a7bd65ea47cf222ee2899c53116625a7d0149da47
+  metadata.gz: e1c96bcac6f1bb54b0a040a6639c1577b2cf3409b099fa1c459fb70121906cef3ae9bb864eafb1ad5f621079f6229baffc415746921ace1765f776b1d2749cd1
+  data.tar.gz: e1114919a49bb3da37243776be9d65120d55597c9def152a25cb1da8d593282ec20d9bb3f0e807b51d0a1c5ce14fb4ab9945bb97d72c3f53cd08b24898375a70

data/Rakefile

@@ -5,9 +5,9 @@ require 'rubocop/rake_task'
 require 'open3'
 require 'yaml'
 require 'rubocop'
+require 'rubocop-rspec'
 require 'rubocop-rails'
 require 'rubocop-performance'
-require 'rubocop-rspec'
 require 'rubocop-rake'
 
 RuboCop::RakeTask.new(:rubocop) do |t|

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '0.91.0'
+  spec.version     = '1.3.1'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,10 +22,10 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 0.91.0'
-  spec.add_dependency 'rubocop-performance', '= 1.8.1'
+  spec.add_dependency 'rubocop',             '= 1.3.1'
+  spec.add_dependency 'rubocop-performance', '= 1.9.0'
   spec.add_dependency 'rubocop-rails',       '= 2.8.1'
-  spec.add_dependency 'rubocop-rspec',       '= 1.43.2'
+  spec.add_dependency 'rubocop-rspec',       '= 2.0.0'
   spec.add_dependency 'rubocop-rake',        '= 0.5.1'
 
   spec.add_development_dependency 'bundler'

data/lib/common/lint.yml

@@ -25,6 +25,8 @@ Lint/CircularArgumentReference:
 
 Lint/ConstantDefinitionInBlock:
   Enabled: false
+  AllowedMethods:
+    - enums
 
 Lint/ConstantResolution:
   Enabled: false
@@ -44,6 +46,9 @@ Lint/DisjunctiveAssignmentInConstructor:
   Enabled: true
   AutoCorrect: false
 
+Lint/DuplicateBranch:
+  Enabled: true
+
 Lint/DuplicateCaseCondition:
   Enabled: true
 
@@ -59,6 +64,9 @@ Lint/DuplicateElsifCondition:
 Lint/DuplicateRequire:
   Enabled: true
 
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Enabled: true
 
@@ -67,6 +75,15 @@ Lint/DuplicateRescueException:
 
 Lint/ElseLayout:
   Enabled: true
+  AutoCorrect: true
+
+Lint/EmptyBlock:
+  Enabled: true
+  AllowComments: true
+
+Lint/EmptyClass:
+  Enabled: false
+  AllowComments: true
 
 Lint/EmptyConditionalBody:
   Enabled: true
@@ -118,6 +135,9 @@ Lint/StructNewOverride:
 Lint/SuppressedException:
   Enabled: false
 
+Lint/HashCompareByIdentity:
+  Enabled: false
+
 Lint/HeredocMethodCallPosition:
   Enabled: true
 
@@ -160,6 +180,7 @@ Lint/MissingSuper:
 
 Lint/MultipleComparison:
   Enabled: true
+  AllowMethodComparison: true
 
 Lint/NestedMethodDefinition:
   Enabled: true
@@ -204,6 +225,16 @@ Lint/RaiseException:
 Lint/RandOne:
   Enabled: true
 
+Lint/RedundantSafeNavigation:
+  Enabled: true
+  AllowedMethods:
+    - instance_of?
+    - kind_of?
+    - is_a?
+    - eql?
+    - respond_to?
+    - equal?
+
 Lint/RedundantWithIndex:
   Enabled: true
 
@@ -258,6 +289,9 @@ Lint/RedundantStringCoercion:
 Lint/Syntax:
   Enabled: true
 
+Lint/ToEnumArguments:
+  Enabled: false
+
 Lint/ToJSON:
   Enabled: true
 
@@ -270,6 +304,9 @@ Lint/TrailingCommaInAttributeDeclaration:
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
 
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
+
 Lint/UnifiedInteger:
   Enabled: true
 
@@ -329,6 +366,7 @@ Lint/UselessMethodDefinition:
 
 Lint/UselessSetterCall:
   Enabled: true
+  AutoCorrect: true
 
 Lint/UselessTimes:
   Enabled: true

data/lib/common/naming.yml

@@ -7,6 +7,7 @@ Naming/AsciiIdentifiers:
 
 Naming/BinaryOperatorParameterName:
   Enabled: false
+  AutoCorrect: true
 
 Naming/ClassAndModuleCamelCase:
   Enabled: true
@@ -24,6 +25,7 @@ Naming/FileName:
 Naming/HeredocDelimiterCase:
   Enabled: true
   EnforcedStyle: uppercase
+  AutoCorrect: true
 
 Naming/HeredocDelimiterNaming:
   Enabled: false
@@ -73,3 +75,6 @@ Naming/VariableName:
 Naming/VariableNumber:
   Enabled: true
   EnforcedStyle: snake_case
+  CheckMethodNames: true
+  CheckSymbols: true
+  AllowedIdentifiers: []

data/lib/common/performance.yml

@@ -1,3 +1,6 @@
+Performance/ArraySemiInfiniteRangeSlice:
+  Enabled: true
+
 Performance/AncestorsInclude:
   Enabled: true
 
@@ -7,8 +10,13 @@ Performance/BindCall:
 Performance/BigDecimalWithNumericArgument:
   Enabled: true
 
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: false
+  AutoCorrect: true
+
 Performance/Caller:
   Enabled: true
+  AutoCorrect: true
 
 Performance/CaseWhenSplat:
   Enabled: true
@@ -27,6 +35,9 @@ Performance/CollectionLiteralInLoop:
   Enabled: true
   MinSize: 1
 
+Performance/ConstantRegexp:
+  Enabled: true
+
 Performance/Count:
   Enabled: true
   SafeAutoCorrect: false
@@ -62,6 +73,9 @@ Performance/InefficientHashSearch:
 Performance/IoReadlines:
   Enabled: true
 
+Performance/MethodObjectAsBlock:
+  Enabled: true
+
 Performance/OpenStruct:
   Enabled: true
 
@@ -114,6 +128,7 @@ Performance/StringReplacement:
 
 Performance/Sum:
   Enabled: true
+  AutoCorrect: true
 
 Performance/TimesMap:
   Enabled: true
@@ -121,6 +136,7 @@ Performance/TimesMap:
 
 Performance/UnfreezeString:
   Enabled: true
+  AutoCorrect: true
 
 Performance/UriDefaultParser:
   Enabled: true

data/lib/common/style.yml

@@ -11,12 +11,16 @@ Style/Alias:
   Enabled: true
   EnforcedStyle: prefer_alias_method
 
+Style/AndOr:
+  Enabled: false
+  EnforcedStyle: always
+
 Style/ArrayCoercion:
   Enabled: true
 
-Style/AndOr:
+Style/ArgumentsForwarding:
   Enabled: false
-  EnforcedStyle: always
+  AllowOnlyRestArgument: true
 
 Style/ArrayJoin:
   Enabled: true
@@ -69,16 +73,26 @@ Style/ClassCheck:
   Enabled: true
   EnforcedStyle: is_a?
 
+Style/ClassEqualityComparison:
+  Enabled: true
+  IgnoredMethods:
+    - ==
+    - equal?
+    - eql?
+
 Style/ClassMethods:
   Enabled: true
 
 Style/ClassMethodsDefinitions:
-  Enabled: true
+  Enabled: false
   EnforcedStyle: self_class
 
 Style/ClassVars:
   Enabled: true
 
+Style/CollectionCompact:
+  Enabled: true
+
 Style/CollectionMethods:
   Enabled: false
 
@@ -112,6 +126,7 @@ Style/Copyright:
 Style/DateTime:
   Enabled: false
   AllowCoercion: false
+  AutoCorrect: false
 
 Style/DefWithParentheses:
   Enabled: true
@@ -122,6 +137,9 @@ Style/Dir:
 Style/DisableCopsWithinSourceCodeDirective:
   Enabled: false
 
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
+
 Style/Documentation:
   Enabled: false
 
@@ -130,6 +148,7 @@ Style/DocumentationMethod:
 
 Style/DoubleNegation:
   Enabled: false
+  AutoCorrect: true
   EnforcedStyle: allowed_in_returns
 
 Style/EachForSimpleLoop:
@@ -195,6 +214,7 @@ Style/FormatString:
 
 Style/FormatStringToken:
   Enabled: true
+  MaxUnannotatedPlaceholdersAllowed: 1
   EnforcedStyle: annotated
 
 Style/FrozenStringLiteralComment:
@@ -242,6 +262,7 @@ Style/IdenticalConditionalBranches:
 Style/IfInsideElse:
   Enabled: true
   AllowIfModifier: true
+  AutoCorrect: true
 
 Style/IfUnlessModifier:
   Enabled: false
@@ -339,7 +360,7 @@ Style/MultilineWhenThen:
   Enabled: true
 
 Style/MultipleComparison:
-  Enabled: true
+  Enabled: false
 
 Style/MutableConstant:
   Enabled: true
@@ -348,6 +369,9 @@ Style/NegatedIf:
   Enabled: true
   EnforcedStyle: both
 
+Style/NegatedIfElseCondition:
+  Enabled: false
+
 Style/NegatedUnless:
   Enabled: false
   EnforcedStyle: both
@@ -374,6 +398,9 @@ Style/NilComparison:
   Enabled: true
   EnforcedStyle: comparison
 
+Style/NilLambda:
+  Enabled: false
+
 Style/NonNilCheck:
   Enabled: true
   IncludeSemanticChanges: false
@@ -405,6 +432,8 @@ Style/OptionalArguments:
 
 Style/OptionalBooleanParameter:
   Enabled: false
+  AllowedMethods:
+    - respond_to_missing?
 
 Style/ParallelAssignment:
   Enabled: false
@@ -432,6 +461,7 @@ Style/Proc:
 Style/RaiseArgs:
   Enabled: true
   EnforcedStyle: exploded
+  AllowedCompactTypes: []
 
 Style/RandomWithOffset:
   Enabled: true
@@ -531,6 +561,9 @@ Style/SlicingWithRange:
 Style/SpecialGlobalVars:
   Enabled: true
 
+Style/StaticClass:
+  Enabled: true
+
 Style/StabbyLambdaParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses
@@ -573,6 +606,9 @@ Style/SymbolLiteral:
 Style/SymbolProc:
   Enabled: true
 
+Style/SwapValues:
+  Enabled: true
+
 Style/TernaryParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses_when_complex

data/lib/rspec/capybara.yml

@@ -1,8 +1,8 @@
-Capybara/CurrentPathExpectation:
+RSpec/Capybara/CurrentPathExpectation:
   Enabled: true
 
-Capybara/FeatureMethods:
+RSpec/Capybara/FeatureMethods:
   Enabled: false
 
-Capybara/VisibilityMatcher:
+RSpec/Capybara/VisibilityMatcher:
   Enabled: true

data/lib/rspec/factory_bot.yml

@@ -1,9 +1,9 @@
-FactoryBot/AttributeDefinedStatically:
+RSpec/FactoryBot/AttributeDefinedStatically:
   Enabled: false
 
-FactoryBot/CreateList:
+RSpec/FactoryBot/CreateList:
   Enabled: true
   EnforcedStyle: create_list
 
-FactoryBot/FactoryClassName:
+RSpec/FactoryBot/FactoryClassName:
   Enabled: true

data/lib/rspec/rails.yml

@@ -1,2 +1,2 @@
-Rails/HttpStatus:
+RSpec/Rails/HttpStatus:
   Enabled: false

data/lib/rspec/rspec.yml

@@ -120,9 +120,6 @@ RSpec/InstanceVariable:
   Enabled: true
   AssignmentOnly: false
 
-RSpec/InvalidPredicateMatcher:
-  Enabled: true
-
 RSpec/ItBehavesLike:
   Enabled: true
   EnforcedStyle: it_behaves_like
@@ -211,6 +208,9 @@ RSpec/RepeatedExampleGroupBody:
 RSpec/RepeatedExampleGroupDescription:
   Enabled: true
 
+RSpec/RepeatedIncludeExample:
+  Enabled: true
+
 RSpec/ReturnFromStub:
   Enabled: true
   EnforcedStyle: and_return
@@ -233,6 +233,9 @@ RSpec/SingleArgumentMessageChain:
 RSpec/SubjectStub:
   Enabled: true
 
+RSpec/StubbedMock:
+  Enabled: true
+
 RSpec/UnspecifiedException:
   Enabled: true
 

data/lib/rubocop.rspec.yml

@@ -6,16 +6,16 @@ inherit_from:
   - ./rspec/rails.yml
   - ./rspec/rspec.yml
 
-AllCops:
-  RSpec:
-    Patterns:
-      - _spec.rb
-      - "(?:^|/)spec/"
-  RSpec/FactoryBot:
-    Patterns:
-      - spec/factories.rb
-      - spec/factories/**/*.rb
-      - spec/support/factories.rb
-      - spec/support/factories/**/*.rb
-      - features/support/factires.rb
-      - features/support/factories/**/*.rb
+RSpec:
+  Include:
+    - _spec.rb
+    - "(?:^|/)spec/"
+  
+RSpec/FactoryBot:
+  Include:
+    - spec/factories.rb
+    - spec/factories/**/*.rb
+    - spec/support/factories.rb
+    - spec/support/factories/**/*.rb
+    - features/support/factires.rb
+    - features/support/factories/**/*.rb

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.91.0
+  version: 1.3.1
 platform: ruby
 authors:
 - Rustam Ibragimov
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-09-21 00:00:00.000000000 Z
+date: 2020-11-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,28 +16,28 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.91.0
+        version: 1.3.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.91.0
+        version: 1.3.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.8.1
+        version: 1.9.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.43.2
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.43.2
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -164,7 +164,7 @@ homepage: https://github.com/0exp/armitage
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -179,8 +179,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.2
-signing_key: 
+rubygems_version: 3.2.0.rc.1
+signing_key:
 specification_version: 4
 summary: A set of rubocop settings
 test_files: []