armitage-rubocop 0.89.1 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c28154435f7b4b3dce611b7eedca8497f6e5d6e53360459b7e9a9c8ac140bb99
-  data.tar.gz: e0080568e776946dc84708b57ca704bdfbeb1fcde5d7a5d7777a41b701ed491e
+  metadata.gz: f224eff3263b19fd9dd64b5783d656806e0def874f3c708376baa3ea44ea9b73
+  data.tar.gz: 4e20193c21cb9f90e9e87569b6db63592ead287053c23468a3cd7a20c8a7554e
 SHA512:
-  metadata.gz: 4bff4699b1f8920f5d72db839673d0b5e167d5607f929a782e6d9945182fe18f3b557bb6beb4136afff858bb10d181bab9006be715fe1c21e6bd7f38fbebafc3
-  data.tar.gz: 4772b4ee3cf65a8f3abe93bd33dda81bb00f4ffddefc8f4bc281f0826c5d194d4132646b865a721792f16783dd08ef09e39dd728721ce867bd9ba68048b0b8d3
+  metadata.gz: e2c1e6486619014452d5150e85e4c2924bd245536309bb7a33235c8f3ac847c9a0c4509eb0e86ada8a16ddd91df56283fb10214bd2a23d15425e12e31084d6b9
+  data.tar.gz: b5f736c62c0f55de2841628ab21489e01b2938f68de3b25722ebc442f6c43983497f95fd5ce1bc8121ac4a232112d0619f086b4cb117ead908300217dd42810f

data/Rakefile

@@ -5,9 +5,9 @@ require 'rubocop/rake_task'
 require 'open3'
 require 'yaml'
 require 'rubocop'
+require 'rubocop-rspec'
 require 'rubocop-rails'
 require 'rubocop-performance'
-require 'rubocop-rspec'
 require 'rubocop-rake'
 
 RuboCop::RakeTask.new(:rubocop) do |t|

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '0.89.1'
+  spec.version     = '1.2.0'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,10 +22,10 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 0.89.1'
-  spec.add_dependency 'rubocop-performance', '= 1.7.1'
-  spec.add_dependency 'rubocop-rails',       '= 2.7.1'
-  spec.add_dependency 'rubocop-rspec',       '= 1.43.2'
+  spec.add_dependency 'rubocop',             '= 1.2.0'
+  spec.add_dependency 'rubocop-performance', '= 1.8.1'
+  spec.add_dependency 'rubocop-rails',       '= 2.8.1'
+  spec.add_dependency 'rubocop-rspec',       '= 2.0.0'
   spec.add_dependency 'rubocop-rake',        '= 0.5.1'
 
   spec.add_development_dependency 'bundler'

data/lib/common/layout.yml

@@ -24,6 +24,11 @@ Layout/ParameterAlignment:
   EnforcedStyle: with_first_parameter
   IndentationWidth: ~
 
+Layout/BeginEndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: start_of_line
+  Severity: warning
+
 Layout/BlockAlignment:
   Enabled: true
   EnforcedStyleAlignWith: either
@@ -90,6 +95,9 @@ Layout/EmptyLineAfterGuardClause:
 Layout/EmptyLineAfterMagicComment:
   Enabled: true
 
+Layout/EmptyLineAfterMultilineCondition:
+  Enabled: false
+
 Layout/EmptyLinesAroundAttributeAccessor:
   Enabled: true
   AllowAliasSyntax: true

data/lib/common/lint.yml

@@ -23,6 +23,9 @@ Lint/BooleanSymbol:
 Lint/CircularArgumentReference:
   Enabled: true
 
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
 Lint/ConstantResolution:
   Enabled: false
   Only: []
@@ -53,6 +56,12 @@ Lint/DuplicateHashKey:
 Lint/DuplicateElsifCondition:
   Enabled: true
 
+Lint/DuplicateRequire:
+  Enabled: true
+
+Lint/DuplicateRegexpCharacterClassElement:
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Enabled: true
 
@@ -61,6 +70,11 @@ Lint/DuplicateRescueException:
 
 Lint/ElseLayout:
   Enabled: true
+  AutoCorrect: true
+
+Lint/EmptyBlock:
+  Enabled: true
+  AllowComments: true
 
 Lint/EmptyConditionalBody:
   Enabled: true
@@ -73,6 +87,10 @@ Lint/EmptyEnsure:
 Lint/EmptyExpression:
   Enabled: true
 
+Lint/EmptyFile:
+  Enabled: true
+  AllowComments: true
+
 Lint/EmptyInterpolation:
   Enabled: true
 
@@ -108,9 +126,15 @@ Lint/StructNewOverride:
 Lint/SuppressedException:
   Enabled: false
 
+Lint/HashCompareByIdentity:
+  Enabled: false
+
 Lint/HeredocMethodCallPosition:
   Enabled: true
 
+Lint/IdentityComparison:
+  Enabled: false
+
 Lint/ImplicitStringConcatenation:
   Enabled: true
 
@@ -147,6 +171,7 @@ Lint/MissingSuper:
 
 Lint/MultipleComparison:
   Enabled: true
+  AllowMethodComparison: true
 
 Lint/NestedMethodDefinition:
   Enabled: true
@@ -191,6 +216,16 @@ Lint/RaiseException:
 Lint/RandOne:
   Enabled: true
 
+Lint/RedundantSafeNavigation:
+  Enabled: true
+  AllowedMethods:
+    - instance_of?
+    - kind_of?
+    - is_a?
+    - eql?
+    - respond_to?
+    - equal?
+
 Lint/RedundantWithIndex:
   Enabled: true
 
@@ -245,15 +280,24 @@ Lint/RedundantStringCoercion:
 Lint/Syntax:
   Enabled: true
 
+Lint/ToEnumArguments:
+  Enabled: false
+
 Lint/ToJSON:
   Enabled: true
 
 Lint/TopLevelReturnWithArgument:
   Enabled: true
 
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: true
+
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
 
+Lint/UnmodifiedReduceAccumulator:
+  Enabled: true
+
 Lint/UnifiedInteger:
   Enabled: true
 
@@ -307,8 +351,16 @@ Lint/UselessAssignment:
 Lint/UselessElseWithoutRescue:
   Enabled: true
 
+Lint/UselessMethodDefinition:
+  Enabled: true
+  AllowComments: true
+
 Lint/UselessSetterCall:
   Enabled: true
+  AutoCorrect: true
+
+Lint/UselessTimes:
+  Enabled: true
 
 Lint/Void:
   Enabled: true

data/lib/common/naming.yml

@@ -7,6 +7,7 @@ Naming/AsciiIdentifiers:
 
 Naming/BinaryOperatorParameterName:
   Enabled: false
+  AutoCorrect: true
 
 Naming/ClassAndModuleCamelCase:
   Enabled: true
@@ -24,6 +25,7 @@ Naming/FileName:
 Naming/HeredocDelimiterCase:
   Enabled: true
   EnforcedStyle: uppercase
+  AutoCorrect: true
 
 Naming/HeredocDelimiterNaming:
   Enabled: false

data/lib/common/performance.yml

@@ -23,6 +23,10 @@ Performance/ChainArrayAllocation:
 Performance/CompareWithBlock:
   Enabled: true
 
+Performance/CollectionLiteralInLoop:
+  Enabled: true
+  MinSize: 1
+
 Performance/Count:
   Enabled: true
   SafeAutoCorrect: false
@@ -108,6 +112,9 @@ Performance/StringInclude:
 Performance/StringReplacement:
   Enabled: true
 
+Performance/Sum:
+  Enabled: true
+
 Performance/TimesMap:
   Enabled: true
   AutoCorrect: false

data/lib/common/rails.yml

@@ -18,6 +18,9 @@ Rails/ActiveRecordOverride:
 Rails/ActiveSupportAliases:
   Enabled: true
 
+Rails/AfterCommitOverride:
+  Enabled: true
+
 Rails/ApplicationJob:
   Enabled: true
 
@@ -148,6 +151,9 @@ Rails/NegateInclude:
 Rails/NotNullColumn:
   Enabled: true
 
+Rails/OrderById:
+  Enabled: false
+
 Rails/Output:
   Enabled: true
 
@@ -165,6 +171,7 @@ Rails/PluckId:
 
 Rails/PluckInWhere:
   Enabled: true
+  EnforcedStyle: conservative
 
 Rails/PluralizationGrammar:
   Enabled: true
@@ -237,6 +244,9 @@ Rails/ShortI18n:
 Rails/SkipsModelValidations:
   Enabled: false
 
+Rails/SquishedSQLHeredocs:
+  Enabled: true
+
 Rails/TimeZone:
   Enabled: true
   EnforcedStyle: flexible
@@ -263,3 +273,7 @@ Rails/Validation:
 
 Rails/WhereExists:
   Enabled: false
+  EnforcedStyle: exists
+
+Rails/WhereNot:
+  Enabled: false

data/lib/common/style.yml

@@ -11,12 +11,16 @@ Style/Alias:
   Enabled: true
   EnforcedStyle: prefer_alias_method
 
+Style/AndOr:
+  Enabled: false
+  EnforcedStyle: always
+
 Style/ArrayCoercion:
   Enabled: true
 
-Style/AndOr:
+Style/ArgumentsForwarding:
   Enabled: false
-  EnforcedStyle: always
+  AllowOnlyRestArgument: true
 
 Style/ArrayJoin:
   Enabled: true
@@ -69,12 +73,26 @@ Style/ClassCheck:
   Enabled: true
   EnforcedStyle: is_a?
 
+Style/ClassEqualityComparison:
+  Enabled: true
+  IgnoredMethods:
+    - ==
+    - equal?
+    - eql?
+
 Style/ClassMethods:
   Enabled: true
 
+Style/ClassMethodsDefinitions:
+  Enabled: false
+  EnforcedStyle: self_class
+
 Style/ClassVars:
   Enabled: true
 
+Style/CollectionCompact:
+  Enabled: true
+
 Style/CollectionMethods:
   Enabled: false
 
@@ -84,6 +102,9 @@ Style/ColonMethodCall:
 Style/ColonMethodDefinition:
   Enabled: true
 
+Style/CombinableLoops:
+  Enabled: false
+
 Style/CommandLiteral:
   Enabled: false
 
@@ -105,6 +126,7 @@ Style/Copyright:
 Style/DateTime:
   Enabled: false
   AllowCoercion: false
+  AutoCorrect: false
 
 Style/DefWithParentheses:
   Enabled: true
@@ -115,6 +137,9 @@ Style/Dir:
 Style/DisableCopsWithinSourceCodeDirective:
   Enabled: false
 
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
+
 Style/Documentation:
   Enabled: false
 
@@ -123,6 +148,7 @@ Style/DocumentationMethod:
 
 Style/DoubleNegation:
   Enabled: false
+  AutoCorrect: true
   EnforcedStyle: allowed_in_returns
 
 Style/EachForSimpleLoop:
@@ -188,6 +214,7 @@ Style/FormatString:
 
 Style/FormatStringToken:
   Enabled: true
+  MaxUnannotatedPlaceholdersAllowed: 1
   EnforcedStyle: annotated
 
 Style/FrozenStringLiteralComment:
@@ -262,6 +289,9 @@ Style/InverseMethods:
 Style/IpAddresses:
   Enabled: false
 
+Style/KeywordParametersOrder:
+  Enabled: false
+
 Style/Lambda:
   Enabled: true
   EnforcedStyle: line_count_dependent
@@ -329,7 +359,7 @@ Style/MultilineWhenThen:
   Enabled: true
 
 Style/MultipleComparison:
-  Enabled: true
+  Enabled: false
 
 Style/MutableConstant:
   Enabled: true
@@ -338,6 +368,9 @@ Style/NegatedIf:
   Enabled: true
   EnforcedStyle: both
 
+Style/NegatedIfElseCondition:
+  Enabled: false
+
 Style/NegatedUnless:
   Enabled: false
   EnforcedStyle: both
@@ -395,6 +428,8 @@ Style/OptionalArguments:
 
 Style/OptionalBooleanParameter:
   Enabled: false
+  AllowedMethods:
+    - respond_to_missing?
 
 Style/ParallelAssignment:
   Enabled: false
@@ -422,6 +457,7 @@ Style/Proc:
 Style/RaiseArgs:
   Enabled: true
   EnforcedStyle: exploded
+  AllowedCompactTypes: []
 
 Style/RandomWithOffset:
   Enabled: true
@@ -464,6 +500,9 @@ Style/RedundantReturn:
 Style/RedundantSelf:
   Enabled: true
 
+Style/RedundantSelfAssignment:
+  Enabled: false
+
 Style/RedundantSortBy:
   Enabled: true
 
@@ -560,6 +599,9 @@ Style/SymbolLiteral:
 Style/SymbolProc:
   Enabled: true
 
+Style/SwapValues:
+  Enabled: true
+
 Style/TernaryParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses_when_complex
@@ -618,6 +660,10 @@ Style/RedundantPercentQ:
 Style/RedundantSort:
   Enabled: true
 
+Style/SoleNestedConditional:
+  Enabled: true
+  AllowModifier: true
+
 Style/UnpackFirst:
   Enabled: true
 

data/lib/rspec/capybara.yml

@@ -1,8 +1,8 @@
-Capybara/CurrentPathExpectation:
+RSpec/Capybara/CurrentPathExpectation:
   Enabled: true
 
-Capybara/FeatureMethods:
+RSpec/Capybara/FeatureMethods:
   Enabled: false
 
-Capybara/VisibilityMatcher:
+RSpec/Capybara/VisibilityMatcher:
   Enabled: true

data/lib/rspec/factory_bot.yml

@@ -1,9 +1,9 @@
-FactoryBot/AttributeDefinedStatically:
+RSpec/FactoryBot/AttributeDefinedStatically:
   Enabled: false
 
-FactoryBot/CreateList:
+RSpec/FactoryBot/CreateList:
   Enabled: true
   EnforcedStyle: create_list
 
-FactoryBot/FactoryClassName:
+RSpec/FactoryBot/FactoryClassName:
   Enabled: true

data/lib/rspec/rails.yml

@@ -1,2 +1,2 @@
-Rails/HttpStatus:
+RSpec/Rails/HttpStatus:
   Enabled: false

data/lib/rspec/rspec.yml

@@ -120,9 +120,6 @@ RSpec/InstanceVariable:
   Enabled: true
   AssignmentOnly: false
 
-RSpec/InvalidPredicateMatcher:
-  Enabled: true
-
 RSpec/ItBehavesLike:
   Enabled: true
   EnforcedStyle: it_behaves_like
@@ -211,6 +208,9 @@ RSpec/RepeatedExampleGroupBody:
 RSpec/RepeatedExampleGroupDescription:
   Enabled: true
 
+RSpec/RepeatedIncludeExample:
+  Enabled: true
+
 RSpec/ReturnFromStub:
   Enabled: true
   EnforcedStyle: and_return
@@ -233,6 +233,9 @@ RSpec/SingleArgumentMessageChain:
 RSpec/SubjectStub:
   Enabled: true
 
+RSpec/StubbedMock:
+  Enabled: true
+
 RSpec/UnspecifiedException:
   Enabled: true
 

data/lib/rubocop.rspec.yml

@@ -6,16 +6,16 @@ inherit_from:
   - ./rspec/rails.yml
   - ./rspec/rspec.yml
 
-AllCops:
-  RSpec:
-    Patterns:
-      - _spec.rb
-      - "(?:^|/)spec/"
-  RSpec/FactoryBot:
-    Patterns:
-      - spec/factories.rb
-      - spec/factories/**/*.rb
-      - spec/support/factories.rb
-      - spec/support/factories/**/*.rb
-      - features/support/factires.rb
-      - features/support/factories/**/*.rb
+RSpec:
+  Include:
+    - _spec.rb
+    - "(?:^|/)spec/"
+  
+RSpec/FactoryBot:
+  Include:
+    - spec/factories.rb
+    - spec/factories/**/*.rb
+    - spec/support/factories.rb
+    - spec/support/factories/**/*.rb
+    - features/support/factires.rb
+    - features/support/factories/**/*.rb

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.89.1
+  version: 1.2.0
 platform: ruby
 authors:
 - Rustam Ibragimov
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-08-25 00:00:00.000000000 Z
+date: 2020-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.89.1
+        version: 1.2.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.89.1
+        version: 1.2.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.1
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.1
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: 2.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.7.1
+        version: 2.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.43.2
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.43.2
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -164,7 +164,7 @@ homepage: https://github.com/0exp/armitage
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -180,7 +180,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.1.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: A set of rubocop settings
 test_files: []