armitage-rubocop 0.88.0 → 0.93.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 140748b670a47306e4446b79a9c61665e5dcef9f9264af29e3d353d6acdbb0a3
-  data.tar.gz: 3f4d1be7db4045eef7b5315ffbe33666be78226d65b3a88f847b54aa3c6e7f2c
+  metadata.gz: 78e11ada119f145b98a39b8d45bd500f817ba503ffc7f30d6389b727742a476a
+  data.tar.gz: 5d7ea304c8de4e190a2acaa9c11a5974251da4a21525fb19dc3f5d4c4a5744c0
 SHA512:
-  metadata.gz: 25f30f612097f816d8e3c47fee8fc6d28bd59c9cd07255d4294582a7b86328ea28b0e2e3520b0587469bbe55cef357de12393ad0139931736e5d50e3f4b6fcad
-  data.tar.gz: c241318e983d388bbe248be699b8968ffd1cbe487d637074ce93e4be3fdc3688a057be58ce8f4671eb5dea6d9ec45d507bf0aafebda4699d6d4178d3bfaa7037
+  metadata.gz: 02bd62021abbde7aa28af11c8aecfb1eed5fe6e46db86c04bf832755335c2fcf4d13df6fa6511e5e14c296cfa0f83190fce614eaf61cf7caf19c9de44e3e7582
+  data.tar.gz: 5824ad439f1f9a2ebfacef4448d5dae006c3baa3a10cbda59e44b590de39af11befcfef28d93551db3c306b9e6dab9baa3f32eb6a2c6d16900d4825c553b1602

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '0.88.0'
+  spec.version     = '0.93.1'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,10 +22,10 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 0.88.0'
-  spec.add_dependency 'rubocop-performance', '= 1.7.1'
-  spec.add_dependency 'rubocop-rails',       '= 2.6.0'
-  spec.add_dependency 'rubocop-rspec',       '= 1.42.0'
+  spec.add_dependency 'rubocop',             '= 0.93.1'
+  spec.add_dependency 'rubocop-performance', '= 1.8.1'
+  spec.add_dependency 'rubocop-rails',       '= 2.8.1'
+  spec.add_dependency 'rubocop-rspec',       '= 1.43.2'
   spec.add_dependency 'rubocop-rake',        '= 0.5.1'
 
   spec.add_development_dependency 'bundler'

data/lib/common/layout.yml

@@ -24,6 +24,11 @@ Layout/ParameterAlignment:
   EnforcedStyle: with_first_parameter
   IndentationWidth: ~
 
+Layout/BeginEndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: start_of_line
+  Severity: warning
+
 Layout/BlockAlignment:
   Enabled: true
   EnforcedStyleAlignWith: either
@@ -90,6 +95,9 @@ Layout/EmptyLineAfterGuardClause:
 Layout/EmptyLineAfterMagicComment:
   Enabled: true
 
+Layout/EmptyLineAfterMultilineCondition:
+  Enabled: false
+
 Layout/EmptyLinesAroundAttributeAccessor:
   Enabled: true
   AllowAliasSyntax: true
@@ -367,6 +375,9 @@ Layout/IndentationStyle:
   EnforcedStyle: spaces
   IndentationWidth: 2
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 Layout/TrailingEmptyLines:
   Enabled: true
   EnforcedStyle: final_newline

data/lib/common/lint.yml

@@ -14,12 +14,18 @@ Lint/AssignmentInCondition:
 Lint/BigDecimalNew:
   Enabled: true
 
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
 Lint/BooleanSymbol:
   Enabled: false
 
 Lint/CircularArgumentReference:
   Enabled: true
 
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
 Lint/ConstantResolution:
   Enabled: false
   Only: []
@@ -50,12 +56,22 @@ Lint/DuplicateHashKey:
 Lint/DuplicateElsifCondition:
   Enabled: true
 
+Lint/DuplicateRequire:
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Enabled: true
 
+Lint/DuplicateRescueException:
+  Enabled: true
+
 Lint/ElseLayout:
   Enabled: true
 
+Lint/EmptyConditionalBody:
+  Enabled: true
+  AllowComments: true
+
 Lint/EmptyEnsure:
   Enabled: true
   AutoCorrect: true
@@ -63,6 +79,10 @@ Lint/EmptyEnsure:
 Lint/EmptyExpression:
   Enabled: true
 
+Lint/EmptyFile:
+  Enabled: true
+  AllowComments: true
+
 Lint/EmptyInterpolation:
   Enabled: true
 
@@ -72,7 +92,6 @@ Lint/EmptyWhen:
 
 Lint/EnsureReturn:
   Enabled: true
-  AutoCorrect: false
 
 Lint/ErbNewArguments:
   Enabled: true
@@ -84,10 +103,13 @@ Lint/FlipFlop:
 Lint/FloatOutOfRange:
   Enabled: true
 
+Lint/FloatComparison:
+  Enabled: false
+
 Lint/FormatParameterMismatch:
   Enabled: true
 
-Layout/SpaceAroundMethodCallOperator:
+Lint/SelfAssignment:
   Enabled: true
 
 Lint/StructNewOverride:
@@ -96,9 +118,15 @@ Lint/StructNewOverride:
 Lint/SuppressedException:
   Enabled: false
 
+Lint/HashCompareByIdentity:
+  Enabled: false
+
 Lint/HeredocMethodCallPosition:
   Enabled: true
 
+Lint/IdentityComparison:
+  Enabled: false
+
 Lint/ImplicitStringConcatenation:
   Enabled: true
 
@@ -121,6 +149,7 @@ Lint/LiteralInInterpolation:
 
 Lint/Loop:
   Enabled: true
+  AutoCorrect: true
 
 Lint/MissingCopEnableDirective:
   Enabled: true
@@ -129,6 +158,9 @@ Lint/MixedRegexpCaptureTypes:
   Enabled: true
   # NOTE: if you use named captures - numbered captures will be ignored. it is bad. validate it.
 
+Lint/MissingSuper:
+  Enabled: false
+
 Lint/MultipleComparison:
   Enabled: true
 
@@ -153,6 +185,9 @@ Lint/NumberConversion:
 Lint/OrderedMagicComments:
   Enabled: true
 
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
 Lint/ParenthesesAsGroupedExpression:
   Enabled: true
   AutoCorrect: true
@@ -172,6 +207,16 @@ Lint/RaiseException:
 Lint/RandOne:
   Enabled: true
 
+Lint/RedundantSafeNavigation:
+  Enabled: true
+  AllowedMethods:
+    - instance_of?
+    - kind_of?
+    - is_a?
+    - eql?
+    - respond_to?
+    - equal?
+
 Lint/RedundantWithIndex:
   Enabled: true
 
@@ -229,12 +274,21 @@ Lint/Syntax:
 Lint/ToJSON:
   Enabled: true
 
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: true
+
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
 
 Lint/UnifiedInteger:
   Enabled: true
 
+Lint/UnreachableLoop:
+  Enabled: true
+
 Lint/RedundantCopDisableDirective:
   Enabled: true
 
@@ -279,15 +333,19 @@ Lint/UselessAccessModifier:
 Lint/UselessAssignment:
   Enabled: true
 
-Lint/UselessComparison:
+Lint/UselessElseWithoutRescue:
   Enabled: true
 
-Lint/UselessElseWithoutRescue:
+Lint/UselessMethodDefinition:
   Enabled: true
+  AllowComments: true
 
 Lint/UselessSetterCall:
   Enabled: true
 
+Lint/UselessTimes:
+  Enabled: true
+
 Lint/Void:
   Enabled: true
   CheckForMethodsWithNoSideEffects: false

data/lib/common/performance.yml

@@ -23,6 +23,10 @@ Performance/ChainArrayAllocation:
 Performance/CompareWithBlock:
   Enabled: true
 
+Performance/CollectionLiteralInLoop:
+  Enabled: true
+  MinSize: 1
+
 Performance/Count:
   Enabled: true
   SafeAutoCorrect: false
@@ -108,6 +112,9 @@ Performance/StringInclude:
 Performance/StringReplacement:
   Enabled: true
 
+Performance/Sum:
+  Enabled: true
+
 Performance/TimesMap:
   Enabled: true
   AutoCorrect: false

data/lib/common/rails.yml

@@ -5,6 +5,11 @@ Rails/ActionFilter:
 Rails/ActiveRecordAliases:
   Enabled: true
 
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
 Rails/ActiveRecordOverride:
   Enabled: true
   Include:
@@ -13,6 +18,9 @@ Rails/ActiveRecordOverride:
 Rails/ActiveSupportAliases:
   Enabled: true
 
+Rails/AfterCommitOverride:
+  Enabled: true
+
 Rails/ApplicationJob:
   Enabled: true
 
@@ -52,6 +60,9 @@ Rails/Date:
   Enabled: true
   EnforcedStyle: flexible
 
+Rails/DefaultScope:
+  Enabled: false
+
 Rails/Delegate:
   Enabled: false
 
@@ -88,6 +99,9 @@ Rails/FilePath:
 Rails/FindBy:
   Enabled: true
 
+Rails/FindById:
+  Enabled: true
+
 Rails/FindEach:
   Enabled: true
 
@@ -112,6 +126,9 @@ Rails/IndexBy:
 Rails/IndexWith:
   Enabled: true
 
+Rails/Inquiry:
+  Enabled: false
+
 Rails/InverseOf:
   Enabled: true
 
@@ -121,9 +138,22 @@ Rails/LexicallyScopedActionFilter:
 Rails/LinkToBlank:
   Enabled: true
 
+Rails/MailerName:
+  Enabled: true
+  # mailer views are mapped to the mailer class with Mailer postfix in the name of a class
+
+Rails/MatchRoute:
+  Enabled: true
+
+Rails/NegateInclude:
+  Enabled: true
+
 Rails/NotNullColumn:
   Enabled: true
 
+Rails/OrderById:
+  Enabled: false
+
 Rails/Output:
   Enabled: true
 
@@ -133,6 +163,16 @@ Rails/OutputSafety:
 Rails/Pick:
   Enabled: true
 
+Rails/Pluck:
+  Enabled: true
+
+Rails/PluckId:
+  Enabled: false
+
+Rails/PluckInWhere:
+  Enabled: true
+  EnforcedStyle: conservative
+
 Rails/PluralizationGrammar:
   Enabled: true
 
@@ -170,6 +210,13 @@ Rails/RelativeDateConstant:
   Enabled: true
   AutoCorrect: false
 
+Rails/RenderInline:
+  Enabled: false
+
+Rails/RenderPlainText:
+  Enabled: true
+  ContentTypeCompatibility: true
+
 Rails/RequestReferer:
   Enabled: true
   EnforcedStyle: referer
@@ -190,9 +237,16 @@ Rails/SaveBang:
 Rails/ScopeArgs:
   Enabled: true
 
+Rails/ShortI18n:
+  Enabled: true
+  EnforcedStyle: conservative
+
 Rails/SkipsModelValidations:
   Enabled: false
 
+Rails/SquishedSQLHeredocs:
+  Enabled: true
+
 Rails/TimeZone:
   Enabled: true
   EnforcedStyle: flexible
@@ -216,3 +270,10 @@ Rails/UnknownEnv:
 
 Rails/Validation:
   Enabled: true
+
+Rails/WhereExists:
+  Enabled: false
+  EnforcedStyle: exists
+
+Rails/WhereNot:
+  Enabled: false

data/lib/common/style.yml

@@ -52,6 +52,8 @@ Style/BlockDelimiters:
 
 Style/CaseEquality:
   Enabled: true
+  AllowOnConstant: false
+  AutoCorrect: true
 
 Style/CaseLikeIf:
   Enabled: true
@@ -67,9 +69,20 @@ Style/ClassCheck:
   Enabled: true
   EnforcedStyle: is_a?
 
+Style/ClassEqualityComparison:
+  Enabled: true
+  IgnoredMethods:
+    - ==
+    - equal?
+    - eql?
+
 Style/ClassMethods:
   Enabled: true
 
+Style/ClassMethodsDefinitions:
+  Enabled: false
+  EnforcedStyle: self_class
+
 Style/ClassVars:
   Enabled: true
 
@@ -82,6 +95,9 @@ Style/ColonMethodCall:
 Style/ColonMethodDefinition:
   Enabled: true
 
+Style/CombinableLoops:
+  Enabled: false
+
 Style/CommandLiteral:
   Enabled: false
 
@@ -103,6 +119,7 @@ Style/Copyright:
 Style/DateTime:
   Enabled: false
   AllowCoercion: false
+  AutoCorrect: false
 
 Style/DefWithParentheses:
   Enabled: true
@@ -169,6 +186,9 @@ Style/ExponentialNotation:
   Enabled: true
   EnforcedStyle: scientific
 
+Style/ExplicitBlockArgument:
+  Enabled: true
+
 Style/FloatDivision:
   Enabled: false
 
@@ -193,6 +213,9 @@ Style/GlobalVars:
   Enabled: true
   AllowedVariables: []
 
+Style/GlobalStdStream:
+  Enabled: false
+
 Style/GuardClause:
   Enabled: false
   MinBodyLength: 1
@@ -254,6 +277,9 @@ Style/InverseMethods:
 Style/IpAddresses:
   Enabled: false
 
+Style/KeywordParametersOrder:
+  Enabled: false
+
 Style/Lambda:
   Enabled: true
   EnforcedStyle: line_count_dependent
@@ -278,9 +304,6 @@ Style/MethodDefParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses
 
-Style/MethodMissingSuper:
-  Enabled: false
-
 Style/MinMax:
   Enabled: true
 
@@ -357,7 +380,7 @@ Style/Next:
 
 Style/NilComparison:
   Enabled: true
-  EnforcedStyle: predicate
+  EnforcedStyle: comparison
 
 Style/NonNilCheck:
   Enabled: true
@@ -374,9 +397,9 @@ Style/NumericLiterals:
   Enabled: false
 
 Style/NumericPredicate:
-  Enabled: true
-  EnforcedStyle: predicate
-  AutoCorrect: false
+  Enabled: false # strongly situative cop
+  EnforcedStyle: comparison
+  AutoCorrect: true
   IgnoredMethods: []
 
 Style/OneLineConditional:
@@ -388,6 +411,11 @@ Style/OptionHash:
 Style/OptionalArguments:
   Enabled: true
 
+Style/OptionalBooleanParameter:
+  Enabled: false
+  AllowedMethods:
+    - respond_to_missing?
+
 Style/ParallelAssignment:
   Enabled: false
 
@@ -456,6 +484,9 @@ Style/RedundantReturn:
 Style/RedundantSelf:
   Enabled: true
 
+Style/RedundantSelfAssignment:
+  Enabled: false
+
 Style/RedundantSortBy:
   Enabled: true
 
@@ -492,6 +523,9 @@ Style/SignalException:
   Enabled: true
   EnforcedStyle: only_raise
 
+Style/SingleArgumentDig:
+  Enabled: true
+
 Style/SingleLineBlockParams:
   Enabled: false
 
@@ -514,6 +548,9 @@ Style/StabbyLambdaParentheses:
 Style/StderrPuts:
   Enabled: true
 
+Style/StringConcatenation:
+  Enabled: true
+
 Style/StringHashKeys:
   Enabled: false
 
@@ -604,6 +641,10 @@ Style/RedundantPercentQ:
 Style/RedundantSort:
   Enabled: true
 
+Style/SoleNestedConditional:
+  Enabled: true
+  AllowModifier: true
+
 Style/UnpackFirst:
   Enabled: true
 

data/lib/rspec/rspec.yml

@@ -160,6 +160,9 @@ RSpec/MultipleDescribes:
 RSpec/MultipleExpectations:
   Enabled: false
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/MultipleSubjects:
   Enabled: true
 
@@ -240,6 +243,7 @@ RSpec/VariableDefinition:
 RSpec/VariableName:
   Enabled: true
   EnforcedStyle: snake_case
+  IgnoredPatterns: []
 
 RSpec/VerifiedDoubles:
   Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.88.0
+  version: 0.93.1
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-19 00:00:00.000000000 Z
+date: 2020-10-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.88.0
+        version: 0.93.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.88.0
+        version: 0.93.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.1
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.1
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.42.0
+        version: 1.43.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.42.0
+        version: 1.43.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement