armitage-rubocop 0.87.1.1 → 0.91.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0124364ffad7baa8a75839b31eca3253e7054da646219f4f43830a51dca92bbe
-  data.tar.gz: 89982b21525d864f6d8081014c1e6e58db8d4a807e3d272178c5574a3b3698a9
+  metadata.gz: 6b759312f8268f9832a1638da553d0f4e2b5e519463628c18a65ff6b32279f37
+  data.tar.gz: 431102ea68c615df5dfa95bca31d6c69f831d2a2e582f934c312b3711d720fed
 SHA512:
-  metadata.gz: 922d615affcfab24a22b3b0f8f2c8bd29f4673248812981a10dedb485b1938acbd48ec26aedd1de39bcf0577a8266ac81c886af44bce4cbd0bae46d6c5aaa253
-  data.tar.gz: 1f44cbb9457c11c8a3807e34cb5f6e48225fe94f17a0abcfbcb3f46c9f002d27086637fba72ea7365de34b497439cc2482b6e19411f7f1a0fc44c8fe3477573e
+  metadata.gz: a077efb974e8a51eec7f28407c870b93d3d9774a72476569f0969a27e5ee8ced525a1fe916d4553a206bb8432b846ddcbc0bba3c77a286d120dc0a9261955063
+  data.tar.gz: f7a90c55586de8dc921d571467c668c8302545160aa4c321909e8674b788b400f74f01979ba339dac668324fc60ce563f48ca82fa8c262e69e56111bb0cdc2c7

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '0.87.1.1'
+  spec.version     = '0.91.0.1'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,10 +22,10 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 0.87.1'
-  spec.add_dependency 'rubocop-performance', '= 1.7.0'
-  spec.add_dependency 'rubocop-rails',       '= 2.6.0'
-  spec.add_dependency 'rubocop-rspec',       '= 1.41.0'
+  spec.add_dependency 'rubocop',             '= 0.91.0'
+  spec.add_dependency 'rubocop-performance', '= 1.8.1'
+  spec.add_dependency 'rubocop-rails',       '= 2.8.1'
+  spec.add_dependency 'rubocop-rspec',       '= 1.43.2'
   spec.add_dependency 'rubocop-rake',        '= 0.5.1'
 
   spec.add_development_dependency 'bundler'

data/lib/common/layout.yml

@@ -24,6 +24,11 @@ Layout/ParameterAlignment:
   EnforcedStyle: with_first_parameter
   IndentationWidth: ~
 
+Layout/BeginEndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: start_of_line
+  Severity: warning
+
 Layout/BlockAlignment:
   Enabled: true
   EnforcedStyleAlignWith: either
@@ -90,6 +95,9 @@ Layout/EmptyLineAfterGuardClause:
 Layout/EmptyLineAfterMagicComment:
   Enabled: true
 
+Layout/EmptyLineAfterMultilineCondition:
+  Enabled: false
+
 Layout/EmptyLinesAroundAttributeAccessor:
   Enabled: true
   AllowAliasSyntax: true
@@ -367,6 +375,9 @@ Layout/IndentationStyle:
   EnforcedStyle: spaces
   IndentationWidth: 2
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 Layout/TrailingEmptyLines:
   Enabled: true
   EnforcedStyle: final_newline

data/lib/common/lint.yml

@@ -14,12 +14,18 @@ Lint/AssignmentInCondition:
 Lint/BigDecimalNew:
   Enabled: true
 
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
 Lint/BooleanSymbol:
   Enabled: false
 
 Lint/CircularArgumentReference:
   Enabled: true
 
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
 Lint/ConstantResolution:
   Enabled: false
   Only: []
@@ -34,6 +40,10 @@ Lint/DeprecatedClassMethods:
 Lint/DeprecatedOpenSSLConstant:
   Enabled: true
 
+Lint/DisjunctiveAssignmentInConstructor:
+  Enabled: true
+  AutoCorrect: false
+
 Lint/DuplicateCaseCondition:
   Enabled: true
 
@@ -43,12 +53,25 @@ Lint/DuplicateMethods:
 Lint/DuplicateHashKey:
   Enabled: true
 
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
+Lint/DuplicateRequire:
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Enabled: true
 
+Lint/DuplicateRescueException:
+  Enabled: true
+
 Lint/ElseLayout:
   Enabled: true
 
+Lint/EmptyConditionalBody:
+  Enabled: true
+  AllowComments: true
+
 Lint/EmptyEnsure:
   Enabled: true
   AutoCorrect: true
@@ -56,6 +79,10 @@ Lint/EmptyEnsure:
 Lint/EmptyExpression:
   Enabled: true
 
+Lint/EmptyFile:
+  Enabled: true
+  AllowComments: true
+
 Lint/EmptyInterpolation:
   Enabled: true
 
@@ -65,7 +92,6 @@ Lint/EmptyWhen:
 
 Lint/EnsureReturn:
   Enabled: true
-  AutoCorrect: false
 
 Lint/ErbNewArguments:
   Enabled: true
@@ -77,10 +103,13 @@ Lint/FlipFlop:
 Lint/FloatOutOfRange:
   Enabled: true
 
+Lint/FloatComparison:
+  Enabled: false
+
 Lint/FormatParameterMismatch:
   Enabled: true
 
-Layout/SpaceAroundMethodCallOperator:
+Lint/SelfAssignment:
   Enabled: true
 
 Lint/StructNewOverride:
@@ -92,6 +121,9 @@ Lint/SuppressedException:
 Lint/HeredocMethodCallPosition:
   Enabled: true
 
+Lint/IdentityComparison:
+  Enabled: false
+
 Lint/ImplicitStringConcatenation:
   Enabled: true
 
@@ -114,6 +146,7 @@ Lint/LiteralInInterpolation:
 
 Lint/Loop:
   Enabled: true
+  AutoCorrect: true
 
 Lint/MissingCopEnableDirective:
   Enabled: true
@@ -122,6 +155,9 @@ Lint/MixedRegexpCaptureTypes:
   Enabled: true
   # NOTE: if you use named captures - numbered captures will be ignored. it is bad. validate it.
 
+Lint/MissingSuper:
+  Enabled: false
+
 Lint/MultipleComparison:
   Enabled: true
 
@@ -146,6 +182,9 @@ Lint/NumberConversion:
 Lint/OrderedMagicComments:
   Enabled: true
 
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
 Lint/ParenthesesAsGroupedExpression:
   Enabled: true
   AutoCorrect: true
@@ -222,12 +261,21 @@ Lint/Syntax:
 Lint/ToJSON:
   Enabled: true
 
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
+Lint/TrailingCommaInAttributeDeclaration:
+  Enabled: true
+
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
 
 Lint/UnifiedInteger:
   Enabled: true
 
+Lint/UnreachableLoop:
+  Enabled: true
+
 Lint/RedundantCopDisableDirective:
   Enabled: true
 
@@ -272,15 +320,19 @@ Lint/UselessAccessModifier:
 Lint/UselessAssignment:
   Enabled: true
 
-Lint/UselessComparison:
+Lint/UselessElseWithoutRescue:
   Enabled: true
 
-Lint/UselessElseWithoutRescue:
+Lint/UselessMethodDefinition:
   Enabled: true
+  AllowComments: true
 
 Lint/UselessSetterCall:
   Enabled: true
 
+Lint/UselessTimes:
+  Enabled: true
+
 Lint/Void:
   Enabled: true
   CheckForMethodsWithNoSideEffects: false

data/lib/common/performance.yml

@@ -23,6 +23,10 @@ Performance/ChainArrayAllocation:
 Performance/CompareWithBlock:
   Enabled: true
 
+Performance/CollectionLiteralInLoop:
+  Enabled: true
+  MinSize: 1
+
 Performance/Count:
   Enabled: true
   SafeAutoCorrect: false
@@ -108,6 +112,9 @@ Performance/StringInclude:
 Performance/StringReplacement:
   Enabled: true
 
+Performance/Sum:
+  Enabled: true
+
 Performance/TimesMap:
   Enabled: true
   AutoCorrect: false

data/lib/common/rails.yml

@@ -5,6 +5,11 @@ Rails/ActionFilter:
 Rails/ActiveRecordAliases:
   Enabled: true
 
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
 Rails/ActiveRecordOverride:
   Enabled: true
   Include:
@@ -13,6 +18,9 @@ Rails/ActiveRecordOverride:
 Rails/ActiveSupportAliases:
   Enabled: true
 
+Rails/AfterCommitOverride:
+  Enabled: true
+
 Rails/ApplicationJob:
   Enabled: true
 
@@ -52,6 +60,9 @@ Rails/Date:
   Enabled: true
   EnforcedStyle: flexible
 
+Rails/DefaultScope:
+  Enabled: false
+
 Rails/Delegate:
   Enabled: false
 
@@ -88,6 +99,9 @@ Rails/FilePath:
 Rails/FindBy:
   Enabled: true
 
+Rails/FindById:
+  Enabled: true
+
 Rails/FindEach:
   Enabled: true
 
@@ -112,6 +126,9 @@ Rails/IndexBy:
 Rails/IndexWith:
   Enabled: true
 
+Rails/Inquiry:
+  Enabled: false
+
 Rails/InverseOf:
   Enabled: true
 
@@ -121,9 +138,22 @@ Rails/LexicallyScopedActionFilter:
 Rails/LinkToBlank:
   Enabled: true
 
+Rails/MailerName:
+  Enabled: true
+  # mailer views are mapped to the mailer class with Mailer postfix in the name of a class
+
+Rails/MatchRoute:
+  Enabled: true
+
+Rails/NegateInclude:
+  Enabled: true
+
 Rails/NotNullColumn:
   Enabled: true
 
+Rails/OrderById:
+  Enabled: false
+
 Rails/Output:
   Enabled: true
 
@@ -133,6 +163,16 @@ Rails/OutputSafety:
 Rails/Pick:
   Enabled: true
 
+Rails/Pluck:
+  Enabled: true
+
+Rails/PluckId:
+  Enabled: false
+
+Rails/PluckInWhere:
+  Enabled: true
+  EnforcedStyle: conservative
+
 Rails/PluralizationGrammar:
   Enabled: true
 
@@ -170,6 +210,13 @@ Rails/RelativeDateConstant:
   Enabled: true
   AutoCorrect: false
 
+Rails/RenderInline:
+  Enabled: false
+
+Rails/RenderPlainText:
+  Enabled: true
+  ContentTypeCompatibility: true
+
 Rails/RequestReferer:
   Enabled: true
   EnforcedStyle: referer
@@ -190,9 +237,16 @@ Rails/SaveBang:
 Rails/ScopeArgs:
   Enabled: true
 
+Rails/ShortI18n:
+  Enabled: true
+  EnforcedStyle: conservative
+
 Rails/SkipsModelValidations:
   Enabled: false
 
+Rails/SquishedSQLHeredocs:
+  Enabled: true
+
 Rails/TimeZone:
   Enabled: true
   EnforcedStyle: flexible
@@ -216,3 +270,10 @@ Rails/UnknownEnv:
 
 Rails/Validation:
   Enabled: true
+
+Rails/WhereExists:
+  Enabled: false
+  EnforcedStyle: exists
+
+Rails/WhereNot:
+  Enabled: false

data/lib/common/style.yml

@@ -11,6 +11,9 @@ Style/Alias:
   Enabled: true
   EnforcedStyle: prefer_alias_method
 
+Style/ArrayCoercion:
+  Enabled: true
+
 Style/AndOr:
   Enabled: false
   EnforcedStyle: always
@@ -49,6 +52,12 @@ Style/BlockDelimiters:
 
 Style/CaseEquality:
   Enabled: true
+  AllowOnConstant: false
+  AutoCorrect: true
+
+Style/CaseLikeIf:
+  Enabled: true
+  AutoCorrect: true
 
 Style/CharacterLiteral:
   Enabled: true
@@ -63,6 +72,10 @@ Style/ClassCheck:
 Style/ClassMethods:
   Enabled: true
 
+Style/ClassMethodsDefinitions:
+  Enabled: false
+  EnforcedStyle: self_class
+
 Style/ClassVars:
   Enabled: true
 
@@ -75,6 +88,9 @@ Style/ColonMethodCall:
 Style/ColonMethodDefinition:
   Enabled: true
 
+Style/CombinableLoops:
+  Enabled: false
+
 Style/CommandLiteral:
   Enabled: false
 
@@ -162,6 +178,9 @@ Style/ExponentialNotation:
   Enabled: true
   EnforcedStyle: scientific
 
+Style/ExplicitBlockArgument:
+  Enabled: true
+
 Style/FloatDivision:
   Enabled: false
 
@@ -186,10 +205,22 @@ Style/GlobalVars:
   Enabled: true
   AllowedVariables: []
 
+Style/GlobalStdStream:
+  Enabled: false
+
 Style/GuardClause:
   Enabled: false
   MinBodyLength: 1
 
+Style/HashAsLastArrayItem:
+  Enabled: true
+  EnforcedStyle: braces
+  AutoCorrect: true
+
+Style/HashLikeCase:
+  Enabled: false
+  MinBranchesCount: 4
+
 Style/HashEachMethods:
   Enabled: true
 
@@ -238,6 +269,9 @@ Style/InverseMethods:
 Style/IpAddresses:
   Enabled: false
 
+Style/KeywordParametersOrder:
+  Enabled: false
+
 Style/Lambda:
   Enabled: true
   EnforcedStyle: line_count_dependent
@@ -262,9 +296,6 @@ Style/MethodDefParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses
 
-Style/MethodMissingSuper:
-  Enabled: false
-
 Style/MinMax:
   Enabled: true
 
@@ -341,7 +372,7 @@ Style/Next:
 
 Style/NilComparison:
   Enabled: true
-  EnforcedStyle: predicate
+  EnforcedStyle: comparison
 
 Style/NonNilCheck:
   Enabled: true
@@ -358,9 +389,9 @@ Style/NumericLiterals:
   Enabled: false
 
 Style/NumericPredicate:
-  Enabled: true
-  EnforcedStyle: predicate
-  AutoCorrect: false
+  Enabled: false # strongly situative cop
+  EnforcedStyle: comparison
+  AutoCorrect: true
   IgnoredMethods: []
 
 Style/OneLineConditional:
@@ -372,6 +403,9 @@ Style/OptionHash:
 Style/OptionalArguments:
   Enabled: true
 
+Style/OptionalBooleanParameter:
+  Enabled: false
+
 Style/ParallelAssignment:
   Enabled: false
 
@@ -411,6 +445,9 @@ Style/RedundantBegin:
 Style/RedundantConditional:
   Enabled: true
 
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
 Style/RedundantFetchBlock:
   Enabled: true
   SafeForConstants: true
@@ -437,6 +474,9 @@ Style/RedundantReturn:
 Style/RedundantSelf:
   Enabled: true
 
+Style/RedundantSelfAssignment:
+  Enabled: false
+
 Style/RedundantSortBy:
   Enabled: true
 
@@ -473,6 +513,9 @@ Style/SignalException:
   Enabled: true
   EnforcedStyle: only_raise
 
+Style/SingleArgumentDig:
+  Enabled: true
+
 Style/SingleLineBlockParams:
   Enabled: false
 
@@ -495,6 +538,9 @@ Style/StabbyLambdaParentheses:
 Style/StderrPuts:
   Enabled: true
 
+Style/StringConcatenation:
+  Enabled: true
+
 Style/StringHashKeys:
   Enabled: false
 
@@ -555,6 +601,7 @@ Style/TrailingCommaInBlockArgs:
 Style/TrailingCommaInHashLiteral:
   Enabled: true
   EnforcedStyleForMultiline: no_comma
+  AutoCorrect: true
 
 Style/TrailingMethodEndStatement:
   Enabled: true
@@ -584,6 +631,10 @@ Style/RedundantPercentQ:
 Style/RedundantSort:
   Enabled: true
 
+Style/SoleNestedConditional:
+  Enabled: true
+  AllowModifier: true
+
 Style/UnpackFirst:
   Enabled: true
 

data/lib/rspec/rspec.yml

@@ -160,6 +160,9 @@ RSpec/MultipleDescribes:
 RSpec/MultipleExpectations:
   Enabled: false
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/MultipleSubjects:
   Enabled: true
 
@@ -240,6 +243,7 @@ RSpec/VariableDefinition:
 RSpec/VariableName:
   Enabled: true
   EnforcedStyle: snake_case
+  IgnoredPatterns: []
 
 RSpec/VerifiedDoubles:
   Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.87.1.1
+  version: 0.91.0.1
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-07-09 00:00:00.000000000 Z
+date: 2020-09-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 0.91.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.87.1
+        version: 0.91.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.7.0
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.41.0
+        version: 1.43.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.41.0
+        version: 1.43.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement