armitage-rubocop 0.85.1 → 0.89.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 801ba79bcde3092cf474495c6193f0741ecf7255aa6823e03bd040c6ee99416b
-  data.tar.gz: 30d05d1f766efdebb0358b5ef85b515722bb218c47bfd031eb5a14997a09286f
+  metadata.gz: c28154435f7b4b3dce611b7eedca8497f6e5d6e53360459b7e9a9c8ac140bb99
+  data.tar.gz: e0080568e776946dc84708b57ca704bdfbeb1fcde5d7a5d7777a41b701ed491e
 SHA512:
-  metadata.gz: 7a2c4f90aeec589490828b9548a14647c8d418e0e8ba3f124337bd6927b3a4128471b54221b90221d72acbd270859c8ee6ffae0cb0171d35cc5f40253a0e221b
-  data.tar.gz: a6386d38de5ad307b23b5aa24e98b7afb120822914d623d84bb5827e6d04b62990458d47c2639935438b5b85fbeb99e0341aa53b0dfcf2597a82a9d3acddcb3f
+  metadata.gz: 4bff4699b1f8920f5d72db839673d0b5e167d5607f929a782e6d9945182fe18f3b557bb6beb4136afff858bb10d181bab9006be715fe1c21e6bd7f38fbebafc3
+  data.tar.gz: 4772b4ee3cf65a8f3abe93bd33dda81bb00f4ffddefc8f4bc281f0826c5d194d4132646b865a721792f16783dd08ef09e39dd728721ce867bd9ba68048b0b8d3

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '0.85.1'
+  spec.version     = '0.89.1'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,10 +22,10 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 0.85.1'
-  spec.add_dependency 'rubocop-performance', '= 1.6.1'
-  spec.add_dependency 'rubocop-rails',       '= 2.6.0'
-  spec.add_dependency 'rubocop-rspec',       '= 1.40.0'
+  spec.add_dependency 'rubocop',             '= 0.89.1'
+  spec.add_dependency 'rubocop-performance', '= 1.7.1'
+  spec.add_dependency 'rubocop-rails',       '= 2.7.1'
+  spec.add_dependency 'rubocop-rspec',       '= 1.43.2'
   spec.add_dependency 'rubocop-rake',        '= 0.5.1'
 
   spec.add_development_dependency 'bundler'

data/lib/common/layout.yml

@@ -367,6 +367,9 @@ Layout/IndentationStyle:
   EnforcedStyle: spaces
   IndentationWidth: 2
 
+Layout/SpaceAroundMethodCallOperator:
+  Enabled: true
+
 Layout/TrailingEmptyLines:
   Enabled: true
   EnforcedStyle: final_newline

data/lib/common/lint.yml

@@ -14,12 +14,20 @@ Lint/AssignmentInCondition:
 Lint/BigDecimalNew:
   Enabled: true
 
+Lint/BinaryOperatorWithIdenticalOperands:
+  Enabled: true
+
 Lint/BooleanSymbol:
   Enabled: false
 
 Lint/CircularArgumentReference:
   Enabled: true
 
+Lint/ConstantResolution:
+  Enabled: false
+  Only: []
+  Ignore: []
+
 Lint/Debugger:
   Enabled: true
 
@@ -29,6 +37,10 @@ Lint/DeprecatedClassMethods:
 Lint/DeprecatedOpenSSLConstant:
   Enabled: true
 
+Lint/DisjunctiveAssignmentInConstructor:
+  Enabled: true
+  AutoCorrect: false
+
 Lint/DuplicateCaseCondition:
   Enabled: true
 
@@ -38,12 +50,22 @@ Lint/DuplicateMethods:
 Lint/DuplicateHashKey:
   Enabled: true
 
+Lint/DuplicateElsifCondition:
+  Enabled: true
+
 Lint/EachWithObjectArgument:
   Enabled: true
 
+Lint/DuplicateRescueException:
+  Enabled: true
+
 Lint/ElseLayout:
   Enabled: true
 
+Lint/EmptyConditionalBody:
+  Enabled: true
+  AllowComments: true
+
 Lint/EmptyEnsure:
   Enabled: true
   AutoCorrect: true
@@ -60,7 +82,6 @@ Lint/EmptyWhen:
 
 Lint/EnsureReturn:
   Enabled: true
-  AutoCorrect: false
 
 Lint/ErbNewArguments:
   Enabled: true
@@ -72,10 +93,13 @@ Lint/FlipFlop:
 Lint/FloatOutOfRange:
   Enabled: true
 
+Lint/FloatComparison:
+  Enabled: false
+
 Lint/FormatParameterMismatch:
   Enabled: true
 
-Layout/SpaceAroundMethodCallOperator:
+Lint/SelfAssignment:
   Enabled: true
 
 Lint/StructNewOverride:
@@ -99,6 +123,7 @@ Lint/InheritException:
 
 Lint/InterpolationCheck:
   Enabled: true
+  AutoCorrect: true
 
 Lint/LiteralAsCondition:
   Enabled: true
@@ -108,6 +133,7 @@ Lint/LiteralInInterpolation:
 
 Lint/Loop:
   Enabled: true
+  AutoCorrect: true
 
 Lint/MissingCopEnableDirective:
   Enabled: true
@@ -116,6 +142,9 @@ Lint/MixedRegexpCaptureTypes:
   Enabled: true
   # NOTE: if you use named captures - numbered captures will be ignored. it is bad. validate it.
 
+Lint/MissingSuper:
+  Enabled: false
+
 Lint/MultipleComparison:
   Enabled: true
 
@@ -140,6 +169,9 @@ Lint/NumberConversion:
 Lint/OrderedMagicComments:
   Enabled: true
 
+Lint/OutOfRangeRegexpRef:
+  Enabled: true
+
 Lint/ParenthesesAsGroupedExpression:
   Enabled: true
   AutoCorrect: true
@@ -152,6 +184,9 @@ Lint/PercentSymbolArray:
 
 Lint/RaiseException:
   Enabled: true
+  AutoCorrect: false
+  AllowedImplicitNamespaces:
+    - Gem
 
 Lint/RandOne:
   Enabled: true
@@ -164,6 +199,7 @@ Lint/RedundantWithObject:
 
 Lint/RegexpAsCondition:
   Enabled: true
+  AutoCorrect: true
 
 Lint/RequireParentheses:
   Enabled: true
@@ -185,6 +221,7 @@ Lint/SafeNavigationConsistency:
 
 Lint/SafeNavigationWithEmpty:
   Enabled: true
+  AutoCorrect: true
 
 Lint/ScriptPermission:
   Enabled: true
@@ -211,12 +248,18 @@ Lint/Syntax:
 Lint/ToJSON:
   Enabled: true
 
+Lint/TopLevelReturnWithArgument:
+  Enabled: true
+
 Lint/UnderscorePrefixedVariableName:
   Enabled: false
 
 Lint/UnifiedInteger:
   Enabled: true
 
+Lint/UnreachableLoop:
+  Enabled: true
+
 Lint/RedundantCopDisableDirective:
   Enabled: true
 
@@ -261,9 +304,6 @@ Lint/UselessAccessModifier:
 Lint/UselessAssignment:
   Enabled: true
 
-Lint/UselessComparison:
-  Enabled: true
-
 Lint/UselessElseWithoutRescue:
   Enabled: true
 

data/lib/common/naming.yml

@@ -3,6 +3,7 @@ Naming/AccessorMethodName:
 
 Naming/AsciiIdentifiers:
   Enabled: true
+  AsciiConstants: true
 
 Naming/BinaryOperatorParameterName:
   Enabled: false

data/lib/common/performance.yml

@@ -1,6 +1,12 @@
+Performance/AncestorsInclude:
+  Enabled: true
+
 Performance/BindCall:
   Enabled: true
 
+Performance/BigDecimalWithNumericArgument:
+  Enabled: true
+
 Performance/Caller:
   Enabled: true
 
@@ -49,15 +55,24 @@ Performance/FlatMap:
 Performance/InefficientHashSearch:
   Enabled: true
 
+Performance/IoReadlines:
+  Enabled: true
+
 Performance/OpenStruct:
   Enabled: true
 
 Performance/RangeInclude:
   Enabled: true
 
+Performance/RedundantSortBlock:
+  Enabled: true
+
 Performance/RedundantBlockCall:
   Enabled: true
 
+Performance/RedundantStringChars:
+  Enabled: true
+
 Performance/RedundantMatch:
   Enabled: true
 
@@ -71,13 +86,25 @@ Performance/RegexpMatch:
 Performance/ReverseEach:
   Enabled: true
 
+Performance/ReverseFirst:
+  Enabled: true
+
 Performance/Size:
   Enabled: true
 
+Performance/SortReverse:
+  Enabled: true
+
+Performance/Squeeze:
+  Enabled: true
+
 Performance/StartWith:
   Enabled: true
   AutoCorrect: false
 
+Performance/StringInclude:
+  Enabled: true
+
 Performance/StringReplacement:
   Enabled: true
 

data/lib/common/rails.yml

@@ -5,6 +5,11 @@ Rails/ActionFilter:
 Rails/ActiveRecordAliases:
   Enabled: true
 
+Rails/ActiveRecordCallbacksOrder:
+  Enabled: true
+  Include:
+    - app/models/**/*.rb
+
 Rails/ActiveRecordOverride:
   Enabled: true
   Include:
@@ -52,6 +57,9 @@ Rails/Date:
   Enabled: true
   EnforcedStyle: flexible
 
+Rails/DefaultScope:
+  Enabled: false
+
 Rails/Delegate:
   Enabled: false
 
@@ -88,6 +96,9 @@ Rails/FilePath:
 Rails/FindBy:
   Enabled: true
 
+Rails/FindById:
+  Enabled: true
+
 Rails/FindEach:
   Enabled: true
 
@@ -112,6 +123,9 @@ Rails/IndexBy:
 Rails/IndexWith:
   Enabled: true
 
+Rails/Inquiry:
+  Enabled: false
+
 Rails/InverseOf:
   Enabled: true
 
@@ -121,6 +135,16 @@ Rails/LexicallyScopedActionFilter:
 Rails/LinkToBlank:
   Enabled: true
 
+Rails/MailerName:
+  Enabled: true
+  # mailer views are mapped to the mailer class with Mailer postfix in the name of a class
+
+Rails/MatchRoute:
+  Enabled: true
+
+Rails/NegateInclude:
+  Enabled: true
+
 Rails/NotNullColumn:
   Enabled: true
 
@@ -133,6 +157,15 @@ Rails/OutputSafety:
 Rails/Pick:
   Enabled: true
 
+Rails/Pluck:
+  Enabled: true
+
+Rails/PluckId:
+  Enabled: false
+
+Rails/PluckInWhere:
+  Enabled: true
+
 Rails/PluralizationGrammar:
   Enabled: true
 
@@ -170,6 +203,13 @@ Rails/RelativeDateConstant:
   Enabled: true
   AutoCorrect: false
 
+Rails/RenderInline:
+  Enabled: false
+
+Rails/RenderPlainText:
+  Enabled: true
+  ContentTypeCompatibility: true
+
 Rails/RequestReferer:
   Enabled: true
   EnforcedStyle: referer
@@ -190,6 +230,10 @@ Rails/SaveBang:
 Rails/ScopeArgs:
   Enabled: true
 
+Rails/ShortI18n:
+  Enabled: true
+  EnforcedStyle: conservative
+
 Rails/SkipsModelValidations:
   Enabled: false
 
@@ -216,3 +260,6 @@ Rails/UnknownEnv:
 
 Rails/Validation:
   Enabled: true
+
+Rails/WhereExists:
+  Enabled: false

data/lib/common/style.yml

@@ -1,3 +1,7 @@
+Style/AccessorGrouping:
+  Enabled: true
+  EnforcedStyle: separated
+
 Style/AccessModifierDeclarations:
   Enabled: true
   EnforcedStyle: group
@@ -7,6 +11,9 @@ Style/Alias:
   Enabled: true
   EnforcedStyle: prefer_alias_method
 
+Style/ArrayCoercion:
+  Enabled: true
+
 Style/AndOr:
   Enabled: false
   EnforcedStyle: always
@@ -31,6 +38,9 @@ Style/BarePercentLiterals:
 Style/BeginBlock:
   Enabled: true
 
+Style/BisectedAttrAccessor:
+  Enabled: true
+
 Style/BlockComments:
   Enabled: true
 
@@ -42,6 +52,12 @@ Style/BlockDelimiters:
 
 Style/CaseEquality:
   Enabled: true
+  AllowOnConstant: false
+  AutoCorrect: true
+
+Style/CaseLikeIf:
+  Enabled: true
+  AutoCorrect: true
 
 Style/CharacterLiteral:
   Enabled: true
@@ -155,6 +171,9 @@ Style/ExponentialNotation:
   Enabled: true
   EnforcedStyle: scientific
 
+Style/ExplicitBlockArgument:
+  Enabled: true
+
 Style/FloatDivision:
   Enabled: false
 
@@ -179,10 +198,22 @@ Style/GlobalVars:
   Enabled: true
   AllowedVariables: []
 
+Style/GlobalStdStream:
+  Enabled: false
+
 Style/GuardClause:
   Enabled: false
   MinBodyLength: 1
 
+Style/HashAsLastArrayItem:
+  Enabled: true
+  EnforcedStyle: braces
+  AutoCorrect: true
+
+Style/HashLikeCase:
+  Enabled: false
+  MinBranchesCount: 4
+
 Style/HashEachMethods:
   Enabled: true
 
@@ -210,6 +241,7 @@ Style/IfUnlessModifier:
 
 Style/IfUnlessModifierOfIfUnless:
   Enabled: true
+  AutoCorrect: true
 
 Style/IfWithSemicolon:
   Enabled: true
@@ -254,9 +286,6 @@ Style/MethodDefParentheses:
   Enabled: true
   EnforcedStyle: require_parentheses
 
-Style/MethodMissingSuper:
-  Enabled: false
-
 Style/MinMax:
   Enabled: true
 
@@ -294,6 +323,7 @@ Style/MultilineMethodSignature:
 
 Style/MultilineTernaryOperator:
   Enabled: false
+  AutoCorrect: true
 
 Style/MultilineWhenThen:
   Enabled: true
@@ -323,6 +353,7 @@ Style/NestedParenthesizedCalls:
 
 Style/NestedTernaryOperator:
   Enabled: true
+  AutoCorrect: true
 
 Style/Next:
   Enabled: true
@@ -331,7 +362,7 @@ Style/Next:
 
 Style/NilComparison:
   Enabled: true
-  EnforcedStyle: predicate
+  EnforcedStyle: comparison
 
 Style/NonNilCheck:
   Enabled: true
@@ -348,9 +379,9 @@ Style/NumericLiterals:
   Enabled: false
 
 Style/NumericPredicate:
-  Enabled: true
-  EnforcedStyle: predicate
-  AutoCorrect: false
+  Enabled: false # strongly situative cop
+  EnforcedStyle: comparison
+  AutoCorrect: true
   IgnoredMethods: []
 
 Style/OneLineConditional:
@@ -362,6 +393,9 @@ Style/OptionHash:
 Style/OptionalArguments:
   Enabled: true
 
+Style/OptionalBooleanParameter:
+  Enabled: false
+
 Style/ParallelAssignment:
   Enabled: false
 
@@ -392,12 +426,22 @@ Style/RaiseArgs:
 Style/RandomWithOffset:
   Enabled: true
 
+Style/RedundantAssignment:
+  Enabled: true
+
 Style/RedundantBegin:
   Enabled: true
 
 Style/RedundantConditional:
   Enabled: true
 
+Style/RedundantFileExtensionInRequire:
+  Enabled: true
+
+Style/RedundantFetchBlock:
+  Enabled: true
+  SafeForConstants: true
+
 Style/RedundantRegexpCharacterClass:
   Enabled: true
 
@@ -456,6 +500,9 @@ Style/SignalException:
   Enabled: true
   EnforcedStyle: only_raise
 
+Style/SingleArgumentDig:
+  Enabled: true
+
 Style/SingleLineBlockParams:
   Enabled: false
 
@@ -478,6 +525,9 @@ Style/StabbyLambdaParentheses:
 Style/StderrPuts:
   Enabled: true
 
+Style/StringConcatenation:
+  Enabled: true
+
 Style/StringHashKeys:
   Enabled: false
 
@@ -498,6 +548,7 @@ Style/Strip:
 
 Style/StructInheritance:
   Enabled: true
+  AutoCorrect: true
 
 Style/SymbolArray:
   Enabled: true
@@ -537,6 +588,7 @@ Style/TrailingCommaInBlockArgs:
 Style/TrailingCommaInHashLiteral:
   Enabled: true
   EnforcedStyleForMultiline: no_comma
+  AutoCorrect: true
 
 Style/TrailingMethodEndStatement:
   Enabled: true

data/lib/rspec/rspec.yml

@@ -160,6 +160,9 @@ RSpec/MultipleDescribes:
 RSpec/MultipleExpectations:
   Enabled: false
 
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
 RSpec/MultipleSubjects:
   Enabled: true
 
@@ -240,6 +243,7 @@ RSpec/VariableDefinition:
 RSpec/VariableName:
   Enabled: true
   EnforcedStyle: snake_case
+  IgnoredPatterns: []
 
 RSpec/VerifiedDoubles:
   Enabled: false

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.85.1
+  version: 0.89.1
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-06-20 00:00:00.000000000 Z
+date: 2020-08-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.85.1
+        version: 0.89.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.85.1
+        version: 0.89.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: 1.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.6.1
+        version: 1.7.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.6.0
+        version: 2.7.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.40.0
+        version: 1.43.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.40.0
+        version: 1.43.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement