armitage-rubocop 0.83.0 → 0.87.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '079a5cd3b52832506fb37b97fe3f548e8d5e993502c30936d06e9c9c9d50cb8b'
-  data.tar.gz: 27377dcf4675b9b611ef0834c284843d946e5d260595b381fe79c0a98fad193d
+  metadata.gz: 493f5291c89baad7d9a9026748facfaf3ed2c55d5647b48dba493cf96faddc07
+  data.tar.gz: b8eac86e6a5aa70299828d5830c2f17bda6950441186419290c8c86924b4aa0e
 SHA512:
-  metadata.gz: 966d1e9845d6065260ab3e6f425a8b38b12f57104b10ce71bd661eb3857bd51e57b815850903f9f27a68b2f873130b341b126cbb9beda4622f78b42bcc672fce
-  data.tar.gz: 13ac3c3269bd87875f11f7cf97b0fb356ddaa6c30a79e87506f056abcbb8719a303345112c12e64567b3ebe393a13a0dddd338725ca31ece093faa898d2a07d7
+  metadata.gz: 0dac5e57caa33ac60acdee5b9c8bb2d9fe9b1058d31e60feb6eb9193793f71ea331550eb6f6bee4a778b1fb114a54b1daa3100278f5b77039615c151253d61aa
+  data.tar.gz: e93d8c930f8fa0a9596155190e30713635b60d6dfc78dccb55bc2e7b518f3749c1e184008cb18d31a1b7778ad2bc75a277025d9482104784f98241f6c0d0aa70

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '0.83.0'
+  spec.version     = '0.87.1'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,10 +22,10 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 0.83.0'
-  spec.add_dependency 'rubocop-performance', '= 1.5.2'
-  spec.add_dependency 'rubocop-rails',       '= 2.5.2'
-  spec.add_dependency 'rubocop-rspec',       '= 1.39.0'
+  spec.add_dependency 'rubocop',             '= 0.87.1'
+  spec.add_dependency 'rubocop-performance', '= 1.7.0'
+  spec.add_dependency 'rubocop-rails',       '= 2.6.0'
+  spec.add_dependency 'rubocop-rspec',       '= 1.41.0'
   spec.add_dependency 'rubocop-rake',        '= 0.5.1'
 
   spec.add_development_dependency 'bundler'

data/lib/common/layout.yml

@@ -90,9 +90,14 @@ Layout/EmptyLineAfterGuardClause:
 Layout/EmptyLineAfterMagicComment:
   Enabled: true
 
-# NOTE: coming soon
-# Layout/EmptyLineAroundAttributeAccessor:
-#   Enabled: true
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+  AllowAliasSyntax: true
+  AllowedMethods:
+    - alias_method
+    - public
+    - protected
+    - private
 
 Layout/EmptyLineBetweenDefs:
   Enabled: true
@@ -187,7 +192,6 @@ Layout/FirstHashElementIndentation:
 
 Layout/HeredocIndentation:
   Enabled: true
-  EnforcedStyle: squiggly
 
 Layout/IndentationConsistency:
   Enabled: true

data/lib/common/lint.yml

@@ -20,12 +20,20 @@ Lint/BooleanSymbol:
 Lint/CircularArgumentReference:
   Enabled: true
 
+Lint/ConstantResolution:
+  Enabled: false
+  Only: []
+  Ignore: []
+
 Lint/Debugger:
   Enabled: true
 
 Lint/DeprecatedClassMethods:
   Enabled: true
 
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
 Lint/DuplicateCaseCondition:
   Enabled: true
 
@@ -96,6 +104,7 @@ Lint/InheritException:
 
 Lint/InterpolationCheck:
   Enabled: true
+  AutoCorrect: true
 
 Lint/LiteralAsCondition:
   Enabled: true
@@ -109,6 +118,10 @@ Lint/Loop:
 Lint/MissingCopEnableDirective:
   Enabled: true
 
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+  # NOTE: if you use named captures - numbered captures will be ignored. it is bad. validate it.
+
 Lint/MultipleComparison:
   Enabled: true
 
@@ -145,6 +158,9 @@ Lint/PercentSymbolArray:
 
 Lint/RaiseException:
   Enabled: true
+  AutoCorrect: false
+  AllowedImplicitNamespaces:
+    - Gem
 
 Lint/RandOne:
   Enabled: true
@@ -157,6 +173,7 @@ Lint/RedundantWithObject:
 
 Lint/RegexpAsCondition:
   Enabled: true
+  AutoCorrect: true
 
 Lint/RequireParentheses:
   Enabled: true
@@ -178,6 +195,7 @@ Lint/SafeNavigationConsistency:
 
 Lint/SafeNavigationWithEmpty:
   Enabled: true
+  AutoCorrect: true
 
 Lint/ScriptPermission:
   Enabled: true

data/lib/common/naming.yml

@@ -3,12 +3,14 @@ Naming/AccessorMethodName:
 
 Naming/AsciiIdentifiers:
   Enabled: true
+  AsciiConstants: true
 
 Naming/BinaryOperatorParameterName:
   Enabled: false
 
 Naming/ClassAndModuleCamelCase:
   Enabled: true
+  AllowedNames: []
 
 Naming/ConstantName:
   Enabled: true
@@ -17,6 +19,7 @@ Naming/FileName:
   Enabled: true
   ExpectMatchingDefinition: false
   IgnoreExecutableScripts: true
+  CheckDefinitionPathHierarchy: false
 
 Naming/HeredocDelimiterCase:
   Enabled: true

data/lib/common/performance.yml

@@ -1,3 +1,9 @@
+Performance/AncestorsInclude:
+  Enabled: true
+
+Performance/BindCall:
+  Enabled: true
+
 Performance/Caller:
   Enabled: true
 
@@ -18,6 +24,12 @@ Performance/Count:
   Enabled: true
   SafeAutoCorrect: false
 
+Performance/DeletePrefix:
+  Enabled: true
+
+Performance/DeleteSuffix:
+  Enabled: true
+
 Performance/Detect:
   Enabled: true
   SafeAutoCorrect: false
@@ -40,15 +52,24 @@ Performance/FlatMap:
 Performance/InefficientHashSearch:
   Enabled: true
 
+Performance/IoReadlines:
+  Enabled: true
+
 Performance/OpenStruct:
   Enabled: true
 
 Performance/RangeInclude:
   Enabled: true
 
+Performance/RedundantSortBlock:
+  Enabled: true
+
 Performance/RedundantBlockCall:
   Enabled: true
 
+Performance/RedundantStringChars:
+  Enabled: true
+
 Performance/RedundantMatch:
   Enabled: true
 
@@ -62,13 +83,25 @@ Performance/RegexpMatch:
 Performance/ReverseEach:
   Enabled: true
 
+Performance/ReverseFirst:
+  Enabled: true
+
 Performance/Size:
   Enabled: true
 
+Performance/SortReverse:
+  Enabled: true
+
+Performance/Squeeze:
+  Enabled: true
+
 Performance/StartWith:
   Enabled: true
   AutoCorrect: false
 
+Performance/StringInclude:
+  Enabled: true
+
 Performance/StringReplacement:
   Enabled: true
 

data/lib/common/rails.yml

@@ -27,6 +27,7 @@ Rails/ApplicationMailer:
 
 Rails/RakeEnvironment:
   Enabled: true
+  AutoCorrect: true
 
 Rails/AssertNot:
   Enabled: true
@@ -44,6 +45,9 @@ Rails/BulkChangeTable:
 Rails/CreateTableWithTimestamps:
   Enabled: false
 
+Rails/ContentTag:
+  Enabled: true
+
 Rails/Date:
   Enabled: true
   EnforcedStyle: flexible
@@ -56,6 +60,12 @@ Rails/DelegateAllowBlank:
 
 Rails/DynamicFindBy:
   Enabled: true
+  Whitelist:
+    - find_by_sql
+  AllowedMethods:
+    - find_by_sql
+  AllowedReceivers:
+    - Gem::Specification
 
 Rails/EnumHash:
   Enabled: true
@@ -120,6 +130,9 @@ Rails/Output:
 Rails/OutputSafety:
   Enabled: false
 
+Rails/Pick:
+  Enabled: true
+
 Rails/PluralizationGrammar:
   Enabled: true
 
@@ -137,6 +150,9 @@ Rails/RedundantAllowNil:
   Include:
     - app/models/**/*.rb
 
+Rails/RedundantForeignKey:
+  Enabled: false
+
 Rails/RedundantReceiverInWithOptions:
   Enabled: true
 

data/lib/common/style.yml

@@ -1,3 +1,7 @@
+Style/AccessorGrouping:
+  Enabled: true
+  EnforcedStyle: separated
+
 Style/AccessModifierDeclarations:
   Enabled: true
   EnforcedStyle: group
@@ -31,6 +35,9 @@ Style/BarePercentLiterals:
 Style/BeginBlock:
   Enabled: true
 
+Style/BisectedAttrAccessor:
+  Enabled: true
+
 Style/BlockComments:
   Enabled: true
 
@@ -107,6 +114,7 @@ Style/DocumentationMethod:
 
 Style/DoubleNegation:
   Enabled: false
+  EnforcedStyle: allowed_in_returns
 
 Style/EachForSimpleLoop:
   Enabled: false
@@ -209,6 +217,7 @@ Style/IfUnlessModifier:
 
 Style/IfUnlessModifierOfIfUnless:
   Enabled: true
+  AutoCorrect: true
 
 Style/IfWithSemicolon:
   Enabled: true
@@ -293,6 +302,7 @@ Style/MultilineMethodSignature:
 
 Style/MultilineTernaryOperator:
   Enabled: false
+  AutoCorrect: true
 
 Style/MultilineWhenThen:
   Enabled: true
@@ -322,6 +332,7 @@ Style/NestedParenthesizedCalls:
 
 Style/NestedTernaryOperator:
   Enabled: true
+  AutoCorrect: true
 
 Style/Next:
   Enabled: true
@@ -391,12 +402,25 @@ Style/RaiseArgs:
 Style/RandomWithOffset:
   Enabled: true
 
+Style/RedundantAssignment:
+  Enabled: true
+
 Style/RedundantBegin:
   Enabled: true
 
 Style/RedundantConditional:
   Enabled: true
 
+Style/RedundantFetchBlock:
+  Enabled: true
+  SafeForConstants: true
+
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
 Style/RedundantException:
   Enabled: false
 
@@ -491,6 +515,7 @@ Style/Strip:
 
 Style/StructInheritance:
   Enabled: true
+  AutoCorrect: true
 
 Style/SymbolArray:
   Enabled: true

data/lib/rspec/rspec.yml

@@ -233,6 +233,14 @@ RSpec/SubjectStub:
 RSpec/UnspecifiedException:
   Enabled: true
 
+RSpec/VariableDefinition:
+  Enabled: true
+  EnforcedStyle: symbols
+
+RSpec/VariableName:
+  Enabled: true
+  EnforcedStyle: snake_case
+
 RSpec/VerifiedDoubles:
   Enabled: false
   IgnoreNameless: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.83.0
+  version: 0.87.1
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-16 00:00:00.000000000 Z
+date: 2020-07-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.83.0
+        version: 0.87.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.83.0
+        version: 0.87.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.7.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.7.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.5.2
+        version: 2.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.5.2
+        version: 2.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.39.0
+        version: 1.41.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.39.0
+        version: 1.41.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement