armitage-rubocop 0.82.0.2 → 0.85.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d4b2be69a4b5346c363d8012a6346a71bcba42fffeed0d690fa59a0ebe4e607f
-  data.tar.gz: 27344328c3a216ca6542dcbcc6d4ed8b31b3b41622e4f88dec61605766f7215b
+  metadata.gz: 801ba79bcde3092cf474495c6193f0741ecf7255aa6823e03bd040c6ee99416b
+  data.tar.gz: 30d05d1f766efdebb0358b5ef85b515722bb218c47bfd031eb5a14997a09286f
 SHA512:
-  metadata.gz: fa6777ec47fa937285cdd5aff37ab510df136da1afda3d6235804b8e180cb94d4ea63a2ac9e25ce90b6ee5364a605ca275726f1a59a12eb6706f3e785e68bcbf
-  data.tar.gz: 8b9822eb1b66832220a92e43c3a230d36f15d0de117eb3fad6a7dca47a7e35a2ed754f1d98692312a7f9fe521f1517ff214e58838bcb61d1e57908c5263ffa40
+  metadata.gz: 7a2c4f90aeec589490828b9548a14647c8d418e0e8ba3f124337bd6927b3a4128471b54221b90221d72acbd270859c8ee6ffae0cb0171d35cc5f40253a0e221b
+  data.tar.gz: a6386d38de5ad307b23b5aa24e98b7afb120822914d623d84bb5827e6d04b62990458d47c2639935438b5b85fbeb99e0341aa53b0dfcf2597a82a9d3acddcb3f

data/armitage-rubocop.gemspec

@@ -4,7 +4,7 @@ lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  spec.version     = '0.82.0.2'
+  spec.version     = '0.85.1'
 
   spec.name        = 'armitage-rubocop'
   spec.license     = 'MIT'
@@ -22,10 +22,10 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 0.82.0'
-  spec.add_dependency 'rubocop-performance', '= 1.5.2'
-  spec.add_dependency 'rubocop-rails',       '= 2.5.2'
-  spec.add_dependency 'rubocop-rspec',       '= 1.39.0'
+  spec.add_dependency 'rubocop',             '= 0.85.1'
+  spec.add_dependency 'rubocop-performance', '= 1.6.1'
+  spec.add_dependency 'rubocop-rails',       '= 2.6.0'
+  spec.add_dependency 'rubocop-rspec',       '= 1.40.0'
   spec.add_dependency 'rubocop-rake',        '= 0.5.1'
 
   spec.add_development_dependency 'bundler'

data/lib/common/layout.yml

@@ -64,6 +64,7 @@ Layout/CommentIndentation:
 
 Layout/ConditionPosition:
   Enabled: true
+  AutoCorrect: true
 
 Layout/DefEndAlignment:
   Enabled: true
@@ -89,6 +90,15 @@ Layout/EmptyLineAfterGuardClause:
 Layout/EmptyLineAfterMagicComment:
   Enabled: true
 
+Layout/EmptyLinesAroundAttributeAccessor:
+  Enabled: true
+  AllowAliasSyntax: true
+  AllowedMethods:
+    - alias_method
+    - public
+    - protected
+    - private
+
 Layout/EmptyLineBetweenDefs:
   Enabled: true
   NumberOfEmptyLines: 1
@@ -182,7 +192,6 @@ Layout/FirstHashElementIndentation:
 
 Layout/HeredocIndentation:
   Enabled: true
-  EnforcedStyle: squiggly
 
 Layout/IndentationConsistency:
   Enabled: true

data/lib/common/lint.yml

@@ -26,6 +26,9 @@ Lint/Debugger:
 Lint/DeprecatedClassMethods:
   Enabled: true
 
+Lint/DeprecatedOpenSSLConstant:
+  Enabled: true
+
 Lint/DuplicateCaseCondition:
   Enabled: true
 
@@ -53,9 +56,11 @@ Lint/EmptyInterpolation:
 
 Lint/EmptyWhen:
   Enabled: false
+  AllowComments: true
 
 Lint/EnsureReturn:
   Enabled: true
+  AutoCorrect: false
 
 Lint/ErbNewArguments:
   Enabled: true
@@ -107,6 +112,10 @@ Lint/Loop:
 Lint/MissingCopEnableDirective:
   Enabled: true
 
+Lint/MixedRegexpCaptureTypes:
+  Enabled: true
+  # NOTE: if you use named captures - numbered captures will be ignored. it is bad. validate it.
+
 Lint/MultipleComparison:
   Enabled: true
 
@@ -131,10 +140,9 @@ Lint/NumberConversion:
 Lint/OrderedMagicComments:
   Enabled: true
 
-# WARNING!!!
 Lint/ParenthesesAsGroupedExpression:
-  Enabled: false
-# WARNING!!!
+  Enabled: true
+  AutoCorrect: true
 
 Lint/PercentStringArray:
   Enabled: true
@@ -243,6 +251,12 @@ Lint/UriRegexp:
 
 Lint/UselessAccessModifier:
   Enabled: true
+  ContextCreatingMethods: []
+  MethodCreatingMethods:
+    - delegate
+    - def_delegator
+    - def_delegators
+  AutoCorrect: true
 
 Lint/UselessAssignment:
   Enabled: true

data/lib/common/naming.yml

@@ -9,6 +9,7 @@ Naming/BinaryOperatorParameterName:
 
 Naming/ClassAndModuleCamelCase:
   Enabled: true
+  AllowedNames: []
 
 Naming/ConstantName:
   Enabled: true
@@ -17,6 +18,7 @@ Naming/FileName:
   Enabled: true
   ExpectMatchingDefinition: false
   IgnoreExecutableScripts: true
+  CheckDefinitionPathHierarchy: false
 
 Naming/HeredocDelimiterCase:
   Enabled: true

data/lib/common/performance.yml

@@ -1,3 +1,6 @@
+Performance/BindCall:
+  Enabled: true
+
 Performance/Caller:
   Enabled: true
 
@@ -18,6 +21,12 @@ Performance/Count:
   Enabled: true
   SafeAutoCorrect: false
 
+Performance/DeletePrefix:
+  Enabled: true
+
+Performance/DeleteSuffix:
+  Enabled: true
+
 Performance/Detect:
   Enabled: true
   SafeAutoCorrect: false

data/lib/common/rails.yml

@@ -27,6 +27,7 @@ Rails/ApplicationMailer:
 
 Rails/RakeEnvironment:
   Enabled: true
+  AutoCorrect: true
 
 Rails/AssertNot:
   Enabled: true
@@ -44,6 +45,9 @@ Rails/BulkChangeTable:
 Rails/CreateTableWithTimestamps:
   Enabled: false
 
+Rails/ContentTag:
+  Enabled: true
+
 Rails/Date:
   Enabled: true
   EnforcedStyle: flexible
@@ -56,6 +60,12 @@ Rails/DelegateAllowBlank:
 
 Rails/DynamicFindBy:
   Enabled: true
+  Whitelist:
+    - find_by_sql
+  AllowedMethods:
+    - find_by_sql
+  AllowedReceivers:
+    - Gem::Specification
 
 Rails/EnumHash:
   Enabled: true
@@ -120,6 +130,9 @@ Rails/Output:
 Rails/OutputSafety:
   Enabled: false
 
+Rails/Pick:
+  Enabled: true
+
 Rails/PluralizationGrammar:
   Enabled: true
 
@@ -137,6 +150,9 @@ Rails/RedundantAllowNil:
   Include:
     - app/models/**/*.rb
 
+Rails/RedundantForeignKey:
+  Enabled: false
+
 Rails/RedundantReceiverInWithOptions:
   Enabled: true
 

data/lib/common/style.yml

@@ -107,6 +107,7 @@ Style/DocumentationMethod:
 
 Style/DoubleNegation:
   Enabled: false
+  EnforcedStyle: allowed_in_returns
 
 Style/EachForSimpleLoop:
   Enabled: false
@@ -212,6 +213,7 @@ Style/IfUnlessModifierOfIfUnless:
 
 Style/IfWithSemicolon:
   Enabled: true
+  AutoCorrect: true
 
 Style/ImplicitRuntimeError:
   Enabled: false
@@ -396,6 +398,12 @@ Style/RedundantBegin:
 Style/RedundantConditional:
   Enabled: true
 
+Style/RedundantRegexpCharacterClass:
+  Enabled: true
+
+Style/RedundantRegexpEscape:
+  Enabled: true
+
 Style/RedundantException:
   Enabled: false
 
@@ -457,6 +465,9 @@ Style/SingleLineMethods:
   Exclude:
     - spec/**/*
 
+Style/SlicingWithRange:
+  Enabled: true
+
 Style/SpecialGlobalVars:
   Enabled: true
 

data/lib/rspec/rspec.yml

@@ -233,6 +233,14 @@ RSpec/SubjectStub:
 RSpec/UnspecifiedException:
   Enabled: true
 
+RSpec/VariableDefinition:
+  Enabled: true
+  EnforcedStyle: symbols
+
+RSpec/VariableName:
+  Enabled: true
+  EnforcedStyle: snake_case
+
 RSpec/VerifiedDoubles:
   Enabled: false
   IgnoreNameless: true

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.82.0.2
+  version: 0.85.1
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-05-01 00:00:00.000000000 Z
+date: 2020-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,56 +16,56 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.85.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.82.0
+        version: 0.85.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.6.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.5.2
+        version: 1.6.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.5.2
+        version: 2.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.5.2
+        version: 2.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.39.0
+        version: 1.40.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.39.0
+        version: 1.40.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement