armitage-rubocop 0.72.0 → 0.73.0.117

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 057ca83ae6e4b2e7c20139d602a0ff431b9f37c98af7f0b551002bcc48ae0a97
-  data.tar.gz: f45fda7d7ff502bc5a56b027d0a4cca88f95c0d71457c78709ef8d0c90f6d760
+  metadata.gz: 83d1c608fb4c6aab4f54f7dfce2a9cc6a945e3a48f3b1ad1e36ec796ca18a43b
+  data.tar.gz: f92f270fdb073e2b3992935b0c54470181f6f78dcfbd0d04b68bca8ab9b88da6
 SHA512:
-  metadata.gz: 23fed537ab129efd2aa9ceb1672466011ab37d01ffd869340c7aa2ca87f9a8246ec1ee943a612bbdd778045a6c86707d15b12e08c630457ba1d00c5d0eee05e8
-  data.tar.gz: c708cbeee868a592e974b05a810921232c52ca0deaceefe6f2b17383d4e26f435d3156ba0b3f9e6498496de28bbbf0b8d26cdbf55bd0524c3de91545ce2af1d1
+  metadata.gz: 3bf7c0369bb088a458ca506cbceeff1033708a6240b344604d53f5cfb0df13be32c971b8decea1475dad901c0355e3e1abc9b050fe81805c2cc57affdfeb5642
+  data.tar.gz: b004650ed1011264431d6db9c11931d1287cedeb2d93f1f2a588ea8e81fc04568343ae14e1a4de3a0682cfeb20918786839edcaabb89be566107121202c372e0

data/.rubocop.yml

@@ -0,0 +1 @@
+inherit_from: ./lib/rubocop.general.yml

data/LICENSE.txt

@@ -1,6 +1,6 @@
 The MIT License (MIT)
 
-Copyright (c) 2018 Rustam Ibragimov
+Copyright (c) 2018-2019 Rustam Ibragimov
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

data/Rakefile

@@ -5,6 +5,7 @@ require 'rubocop/rake_task'
 require 'open3'
 require 'yaml'
 require 'rubocop'
+require 'rubocop-rails'
 require 'rubocop-performance'
 require 'rubocop-rspec'
 
@@ -15,6 +16,8 @@ RuboCop::RakeTask.new(:rubocop) do |t|
   t.requires << 'rubocop-rails'
 end
 
+NON_CHECKABLE_COPS = %w[Rails].freeze # NOTE: Global Rails cop has only `Enabled` option
+
 namespace :armitage_rubocop do
   task :build do
     build_processes = {
@@ -56,7 +59,11 @@ namespace :armitage_rubocop do
 
       # NOTE: try to load without Psych exceptions
       invalid_yamls = yamls.each_with_object([]) do |file_name, invalid_files|
-        YAML.load(File.read(file_name)) rescue (invalid_files << "- \e[33m#{file_name}\e[0m")
+        begin
+          YAML.safe_load(File.read(file_name))
+        rescue StandardError
+          (invalid_files << "- \e[33m#{file_name}\e[0m")
+        end
       end
 
       if invalid_yamls.empty?
@@ -88,21 +95,26 @@ namespace :armitage_rubocop do
           next if RuboCop::ConfigLoader.default_configuration.key?(cop)
           next if RuboCop::Cop::Cop.registry.contains_cop_matching?([cop])
           next if cop == 'inherit_mode'
+
           invalid_cops[cop] = "\e[31mBAD COP\e[0m"
         end
 
         # NOTE: validate cop params
         rubocop_config.keys.each do |cop|
           next if invalid_cops.key?(cop)
+
           invalid_params = Set.new
 
           rubocop_config[cop].each_key do |cop_param|
             next if RuboCop::Config::COMMON_PARAMS.include?(cop_param)
+            next if NON_CHECKABLE_COPS.include?(cop)
             next if RuboCop::ConfigLoader.default_configuration[cop].key?(cop_param)
+
             invalid_params << "\e[35m#{cop_param}\e[0m"
           end
 
           next if invalid_params.empty?
+
           invalid_cops[cop] = "\e[31mBAD PARAMS\e[0m: #{invalid_params.to_a.join(', ')}"
         end
       end

data/armitage-rubocop.gemspec

@@ -1,11 +1,10 @@
-# coding: utf-8
 # frozen_string_literal: true
 
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 
 Gem::Specification.new do |spec|
-  gem_version = '0.72.0'
+  gem_version = '0.73.0'
   release_version = ENV['TRAVIS'] ? "#{gem_version}.#{ENV['TRAVIS_BUILD_NUMBER']}" : gem_version
 
   spec.name        = 'armitage-rubocop'
@@ -24,10 +23,10 @@ Gem::Specification.new do |spec|
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
 
-  spec.add_dependency 'rubocop',             '= 0.72.0'
+  spec.add_dependency 'rubocop',             '= 0.73.0'
   spec.add_dependency 'rubocop-performance', '= 1.4.0'
+  spec.add_dependency 'rubocop-rails',       '= 2.2.1'
   spec.add_dependency 'rubocop-rspec',       '= 1.33.0'
-  spec.add_dependency 'rubocop-rails',       '= 2.1.0'
 
   spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'rake'

data/lib/common/layout.yml

@@ -199,6 +199,7 @@ Layout/LeadingBlankLines:
 
 Layout/LeadingCommentSpace:
   Enabled: true
+  AllowDoxygenCommentStyle: false
 
 Layout/MultilineArrayBraceLayout:
   Enabled: true

data/lib/common/style.yml

@@ -277,6 +277,9 @@ Style/MultilineMethodSignature:
 Style/MultilineTernaryOperator:
   Enabled: false
 
+Style/MultilineWhenThen:
+  Enabled: true
+
 Style/MultipleComparison:
   Enabled: true
 
@@ -410,6 +413,7 @@ Style/ReturnNil:
 
 Style/SafeNavigation:
   Enabled: true
+  ConvertCodeThatCanStartToReturnNil: false
 
 Style/Sample:
   Enabled: true

data/lib/rspec/rspec.yml

@@ -22,10 +22,6 @@ RSpec/BeforeAfterAll:
 RSpec/ContextWording:
   Enabled: false
 
-RSpec/Dialect:
-  Enabled: true
-  PreferredMethods: {}
-
 RSpec/DescribeClass:
   Enabled: false
 
@@ -40,6 +36,10 @@ RSpec/DescribedClass:
   SkipBlocks: false
   EnforcedStyle: described_class
 
+RSpec/Dialect:
+  Enabled: true
+  PreferredMethods: {}
+
 RSpec/EmptyExampleGroup:
   Enabled: true
 
@@ -118,6 +118,10 @@ RSpec/IteratedExpectation:
 RSpec/LeadingSubject:
   Enabled: true
 
+# NOTE: will be introduced in next release
+# RSpec/LeakyConstantDeclaration:
+#   Enabled: true
+
 RSpec/LetBeforeExamples:
   Enabled: true
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: armitage-rubocop
 version: !ruby/object:Gem::Version
-  version: 0.72.0
+  version: 0.73.0.117
 platform: ruby
 authors:
 - Rustam Ibragimov
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-06-28 00:00:00.000000000 Z
+date: 2019-07-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -16,14 +16,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.72.0
+        version: 0.73.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.72.0
+        version: 0.73.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
@@ -39,33 +39,33 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 1.4.0
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.33.0
+        version: 2.2.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.33.0
+        version: 2.2.1
 - !ruby/object:Gem::Dependency
-  name: rubocop-rails
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 1.33.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: 1.33.0
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -103,6 +103,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rubocop.yml"
 - CODE_OF_CONDUCT.md
 - Gemfile
 - LICENSE.txt
@@ -146,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.4
 signing_key: 
 specification_version: 4
 summary: A set of rubocop settings